* [U-Boot] [PATCH 1/1] yaffs2: remove redundant condition
@ 2017-04-15 11:28 Heinrich Schuchardt
2017-04-15 16:11 ` Tom Rini
2017-04-19 13:03 ` [U-Boot] [U-Boot,1/1] " Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2017-04-15 11:28 UTC (permalink / raw)
To: u-boot
If !parent, the changed line is not reached.
So there is no need to check the value again.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
fs/yaffs2/yaffsfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/yaffs2/yaffsfs.c b/fs/yaffs2/yaffsfs.c
index 41e5f0108c..ba76a5ccdb 100644
--- a/fs/yaffs2/yaffsfs.c
+++ b/fs/yaffs2/yaffsfs.c
@@ -3018,7 +3018,7 @@ int yaffs_symlink(const YCHAR *oldpath, const YCHAR *newpath)
yaffsfs_SetError(-ENFILE);
else if (parent->my_dev->read_only)
yaffsfs_SetError(-EROFS);
- else if (parent) {
+ else {
obj = yaffs_create_symlink(parent, name, mode, 0, 0, oldpath);
if (obj)
retVal = 0;
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH 1/1] yaffs2: remove redundant condition
2017-04-15 11:28 [U-Boot] [PATCH 1/1] yaffs2: remove redundant condition Heinrich Schuchardt
@ 2017-04-15 16:11 ` Tom Rini
2017-04-19 13:03 ` [U-Boot] [U-Boot,1/1] " Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2017-04-15 16:11 UTC (permalink / raw)
To: u-boot
On Sat, Apr 15, 2017 at 01:28:13PM +0200, Heinrich Schuchardt wrote:
> If !parent, the changed line is not reached.
> So there is no need to check the value again.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170415/98009b7e/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [U-Boot,1/1] yaffs2: remove redundant condition
2017-04-15 11:28 [U-Boot] [PATCH 1/1] yaffs2: remove redundant condition Heinrich Schuchardt
2017-04-15 16:11 ` Tom Rini
@ 2017-04-19 13:03 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2017-04-19 13:03 UTC (permalink / raw)
To: u-boot
On Sat, Apr 15, 2017 at 01:28:13PM +0200, xypron.glpk at gmx.de wrote:
> If !parent, the changed line is not reached.
> So there is no need to check the value again.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Tom Rini <trini@konsulko.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170419/fe55653f/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-19 13:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-15 11:28 [U-Boot] [PATCH 1/1] yaffs2: remove redundant condition Heinrich Schuchardt
2017-04-15 16:11 ` Tom Rini
2017-04-19 13:03 ` [U-Boot] [U-Boot,1/1] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.