* [U-Boot] [PATCH 1/1] musb: properly detect failed initialization of controller
@ 2017-04-15 11:46 Heinrich Schuchardt
2017-04-16 16:11 ` Marek Vasut
0 siblings, 1 reply; 2+ messages in thread
From: Heinrich Schuchardt @ 2017-04-15 11:46 UTC (permalink / raw)
To: u-boot
We want to check the result of musb_init_controller
and not the address were the result is stored.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
drivers/usb/musb-new/musb_uboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/musb-new/musb_uboot.c b/drivers/usb/musb-new/musb_uboot.c
index ea71f75947..8662c0ff70 100644
--- a/drivers/usb/musb-new/musb_uboot.c
+++ b/drivers/usb/musb-new/musb_uboot.c
@@ -446,7 +446,7 @@ int musb_register(struct musb_hdrc_platform_data *plat, void *bdata,
}
*musbp = musb_init_controller(plat, (struct device *)bdata, ctl_regs);
- if (!musbp) {
+ if (!*musbp) {
printf("Failed to init the controller\n");
return -EIO;
}
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH 1/1] musb: properly detect failed initialization of controller
2017-04-15 11:46 [U-Boot] [PATCH 1/1] musb: properly detect failed initialization of controller Heinrich Schuchardt
@ 2017-04-16 16:11 ` Marek Vasut
0 siblings, 0 replies; 2+ messages in thread
From: Marek Vasut @ 2017-04-16 16:11 UTC (permalink / raw)
To: u-boot
On 04/15/2017 01:46 PM, Heinrich Schuchardt wrote:
> We want to check the result of musb_init_controller
> and not the address were the result is stored.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Applied, thanks!
> ---
> drivers/usb/musb-new/musb_uboot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/musb-new/musb_uboot.c b/drivers/usb/musb-new/musb_uboot.c
> index ea71f75947..8662c0ff70 100644
> --- a/drivers/usb/musb-new/musb_uboot.c
> +++ b/drivers/usb/musb-new/musb_uboot.c
> @@ -446,7 +446,7 @@ int musb_register(struct musb_hdrc_platform_data *plat, void *bdata,
> }
>
> *musbp = musb_init_controller(plat, (struct device *)bdata, ctl_regs);
> - if (!musbp) {
> + if (!*musbp) {
> printf("Failed to init the controller\n");
> return -EIO;
> }
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-16 16:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-15 11:46 [U-Boot] [PATCH 1/1] musb: properly detect failed initialization of controller Heinrich Schuchardt
2017-04-16 16:11 ` Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.