* Re: [Patch v2 1/2] lustre: Parantheses added for Macro argument to avoid precedence issues
[not found] ` <VI1PR0901MB1616DC70D6D5F1A84A43C5D9A4040@VI1PR0901MB1616.eurprd09.prod.outlook.com>
@ 2017-04-15 11:48 ` greg at kroah.com
0 siblings, 0 replies; 2+ messages in thread
From: greg @ 2017-04-15 11:48 UTC (permalink / raw)
To: Rishiraj Manwatkar
Cc: lustre-devel, devel, linux-kernel, andreas.dilger, oleg.drokin
On Sat, Apr 15, 2017 at 11:25:00AM +0000, Rishiraj Manwatkar wrote:
> From: RishirajAM <manwatkar@outlook.com>
>
> Parantheses are added for Macro argument, to avoid precedence issues.
>
> Signed-off-by: Rishiraj Manwatkar <manwatkar@outlook.com>
> ---
> drivers/staging/lustre/lustre/obdclass/cl_io.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
What changed from v1? Always put that below the --- line.
And your From: line doesn't match your signed-off-by name, that's not
ok.
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_io.c b/drivers/staging/lustre/lustre/obdclass/cl_io.c
> index ee7d677..0997254 100755
> --- a/drivers/staging/lustre/lustre/obdclass/cl_io.c
> +++ b/drivers/staging/lustre/lustre/obdclass/cl_io.c
> @@ -52,9 +52,9 @@
> */
>
> #define cl_io_for_each(slice, io) \
> - list_for_each_entry((slice), &io->ci_layers, cis_linkage)
> + list_for_each_entry((slice), &(io)->ci_layers, cis_linkage)
What 'precidence' issue is this fixing? How could that ever be
incorrect?
Really, this macro just needs to go away and be used "as is" anyway...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
* [lustre-devel] [Patch v2 1/2] lustre: Parantheses added for Macro argument to avoid precedence issues
@ 2017-04-15 11:48 ` greg at kroah.com
0 siblings, 0 replies; 2+ messages in thread
From: greg at kroah.com @ 2017-04-15 11:48 UTC (permalink / raw)
To: Rishiraj Manwatkar
Cc: lustre-devel, devel, linux-kernel, andreas.dilger, oleg.drokin
On Sat, Apr 15, 2017 at 11:25:00AM +0000, Rishiraj Manwatkar wrote:
> From: RishirajAM <manwatkar@outlook.com>
>
> Parantheses are added for Macro argument, to avoid precedence issues.
>
> Signed-off-by: Rishiraj Manwatkar <manwatkar@outlook.com>
> ---
> drivers/staging/lustre/lustre/obdclass/cl_io.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
What changed from v1? Always put that below the --- line.
And your From: line doesn't match your signed-off-by name, that's not
ok.
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_io.c b/drivers/staging/lustre/lustre/obdclass/cl_io.c
> index ee7d677..0997254 100755
> --- a/drivers/staging/lustre/lustre/obdclass/cl_io.c
> +++ b/drivers/staging/lustre/lustre/obdclass/cl_io.c
> @@ -52,9 +52,9 @@
> */
>
> #define cl_io_for_each(slice, io) \
> - list_for_each_entry((slice), &io->ci_layers, cis_linkage)
> + list_for_each_entry((slice), &(io)->ci_layers, cis_linkage)
What 'precidence' issue is this fixing? How could that ever be
incorrect?
Really, this macro just needs to go away and be used "as is" anyway...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-15 11:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <a2e734ab4562ded68cb7e7b8d55f51f757189fcd.1492252523>
[not found] ` <VI1PR0901MB1616DC70D6D5F1A84A43C5D9A4040@VI1PR0901MB1616.eurprd09.prod.outlook.com>
2017-04-15 11:48 ` [Patch v2 1/2] lustre: Parantheses added for Macro argument to avoid precedence issues greg
2017-04-15 11:48 ` [lustre-devel] " greg at kroah.com
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.