* [PATCH 0/3] ARM: sun8i: a83t: device tree cleanup @ 2017-04-18 4:22 ` Chen-Yu Tsai 0 siblings, 0 replies; 33+ messages in thread From: Chen-Yu Tsai @ 2017-04-18 4:22 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi Hi Maxime, Here are a few patches cleaning up sun8i-a83t.dtsi. These get rid of known warnings and deprecated features. I'm sending these now before I send patches that add new stuff. Regards ChenYu Chen-Yu Tsai (3): ARM: sun8i: a83t: Drop skeleton.dtsi ARM: sun8i: a83t: Drop leading zeroes from device node addresses ARM: sun8i: a83t: Rename pinmux setting names .../boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts | 2 +- arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts | 2 +- arch/arm/boot/dts/sun8i-a83t.dtsi | 36 ++++++++++++++-------- 3 files changed, 25 insertions(+), 15 deletions(-) -- 2.11.0 ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 0/3] ARM: sun8i: a83t: device tree cleanup @ 2017-04-18 4:22 ` Chen-Yu Tsai 0 siblings, 0 replies; 33+ messages in thread From: Chen-Yu Tsai @ 2017-04-18 4:22 UTC (permalink / raw) To: linux-arm-kernel Hi Maxime, Here are a few patches cleaning up sun8i-a83t.dtsi. These get rid of known warnings and deprecated features. I'm sending these now before I send patches that add new stuff. Regards ChenYu Chen-Yu Tsai (3): ARM: sun8i: a83t: Drop skeleton.dtsi ARM: sun8i: a83t: Drop leading zeroes from device node addresses ARM: sun8i: a83t: Rename pinmux setting names .../boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts | 2 +- arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts | 2 +- arch/arm/boot/dts/sun8i-a83t.dtsi | 36 ++++++++++++++-------- 3 files changed, 25 insertions(+), 15 deletions(-) -- 2.11.0 ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 0/3] ARM: sun8i: a83t: device tree cleanup @ 2017-04-18 4:22 ` Chen-Yu Tsai 0 siblings, 0 replies; 33+ messages in thread From: Chen-Yu Tsai @ 2017-04-18 4:22 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw Hi Maxime, Here are a few patches cleaning up sun8i-a83t.dtsi. These get rid of known warnings and deprecated features. I'm sending these now before I send patches that add new stuff. Regards ChenYu Chen-Yu Tsai (3): ARM: sun8i: a83t: Drop skeleton.dtsi ARM: sun8i: a83t: Drop leading zeroes from device node addresses ARM: sun8i: a83t: Rename pinmux setting names .../boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts | 2 +- arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts | 2 +- arch/arm/boot/dts/sun8i-a83t.dtsi | 36 ++++++++++++++-------- 3 files changed, 25 insertions(+), 15 deletions(-) -- 2.11.0 ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 1/3] ARM: sun8i: a83t: Drop skeleton.dtsi @ 2017-04-18 4:22 ` Chen-Yu Tsai 0 siblings, 0 replies; 33+ messages in thread From: Chen-Yu Tsai @ 2017-04-18 4:22 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi skeleton.dtsi is deprecated. Remove it from sun8i-a83t.dtsi and add the needed device nodes directly. Also drop an extra, non-style-conforming line in the copyright license header. Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- arch/arm/boot/dts/sun8i-a83t.dtsi | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index 0ec143773ee9..913aacafe8d5 100644 --- a/arch/arm/boot/dts/sun8i-a83t.dtsi +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi @@ -40,15 +40,20 @@ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR * OTHER DEALINGS IN THE SOFTWARE. - */ -#include "skeleton.dtsi" - #include <dt-bindings/interrupt-controller/arm-gic.h> / { interrupt-parent = <&gic>; + #address-cells = <1>; + #size-cells = <1>; + + aliases { + }; + + chosen { + }; cpus { #address-cells = <1>; @@ -146,6 +151,11 @@ }; }; + memory { + reg = <0x40000000 0x80000000>; + device_type = "memory"; + }; + soc { compatible = "simple-bus"; #address-cells = <1>; -- 2.11.0 ^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 1/3] ARM: sun8i: a83t: Drop skeleton.dtsi @ 2017-04-18 4:22 ` Chen-Yu Tsai 0 siblings, 0 replies; 33+ messages in thread From: Chen-Yu Tsai @ 2017-04-18 4:22 UTC (permalink / raw) To: linux-arm-kernel skeleton.dtsi is deprecated. Remove it from sun8i-a83t.dtsi and add the needed device nodes directly. Also drop an extra, non-style-conforming line in the copyright license header. Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- arch/arm/boot/dts/sun8i-a83t.dtsi | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index 0ec143773ee9..913aacafe8d5 100644 --- a/arch/arm/boot/dts/sun8i-a83t.dtsi +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi @@ -40,15 +40,20 @@ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR * OTHER DEALINGS IN THE SOFTWARE. - */ -#include "skeleton.dtsi" - #include <dt-bindings/interrupt-controller/arm-gic.h> / { interrupt-parent = <&gic>; + #address-cells = <1>; + #size-cells = <1>; + + aliases { + }; + + chosen { + }; cpus { #address-cells = <1>; @@ -146,6 +151,11 @@ }; }; + memory { + reg = <0x40000000 0x80000000>; + device_type = "memory"; + }; + soc { compatible = "simple-bus"; #address-cells = <1>; -- 2.11.0 ^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 1/3] ARM: sun8i: a83t: Drop skeleton.dtsi @ 2017-04-18 4:22 ` Chen-Yu Tsai 0 siblings, 0 replies; 33+ messages in thread From: Chen-Yu Tsai @ 2017-04-18 4:22 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw skeleton.dtsi is deprecated. Remove it from sun8i-a83t.dtsi and add the needed device nodes directly. Also drop an extra, non-style-conforming line in the copyright license header. Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> --- arch/arm/boot/dts/sun8i-a83t.dtsi | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index 0ec143773ee9..913aacafe8d5 100644 --- a/arch/arm/boot/dts/sun8i-a83t.dtsi +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi @@ -40,15 +40,20 @@ * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR * OTHER DEALINGS IN THE SOFTWARE. - */ -#include "skeleton.dtsi" - #include <dt-bindings/interrupt-controller/arm-gic.h> / { interrupt-parent = <&gic>; + #address-cells = <1>; + #size-cells = <1>; + + aliases { + }; + + chosen { + }; cpus { #address-cells = <1>; @@ -146,6 +151,11 @@ }; }; + memory { + reg = <0x40000000 0x80000000>; + device_type = "memory"; + }; + soc { compatible = "simple-bus"; #address-cells = <1>; -- 2.11.0 ^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 2/3] ARM: sun8i: a83t: Drop leading zeroes from device node addresses @ 2017-04-18 4:22 ` Chen-Yu Tsai 0 siblings, 0 replies; 33+ messages in thread From: Chen-Yu Tsai @ 2017-04-18 4:22 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi Kbuild now complains about leading zeroes in the address portion of device node names. Get rid of them. Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- arch/arm/boot/dts/sun8i-a83t.dtsi | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index 913aacafe8d5..82cb87f21b96 100644 --- a/arch/arm/boot/dts/sun8i-a83t.dtsi +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi @@ -162,7 +162,7 @@ #size-cells = <1>; ranges; - pio: pinctrl@01c20800 { + pio: pinctrl@1c20800 { compatible = "allwinner,sun8i-a83t-pinctrl"; interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>, @@ -193,7 +193,7 @@ }; }; - timer@01c20c00 { + timer@1c20c00 { compatible = "allwinner,sun4i-a10-timer"; reg = <0x01c20c00 0xa0>; interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>, @@ -201,14 +201,14 @@ clocks = <&osc24M>; }; - watchdog@01c20ca0 { + watchdog@1c20ca0 { compatible = "allwinner,sun6i-a31-wdt"; reg = <0x01c20ca0 0x20>; interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>; clocks = <&osc24M>; }; - uart0: serial@01c28000 { + uart0: serial@1c28000 { compatible = "snps,dw-apb-uart"; reg = <0x01c28000 0x400>; interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>; @@ -218,7 +218,7 @@ status = "disabled"; }; - gic: interrupt-controller@01c81000 { + gic: interrupt-controller@1c81000 { compatible = "arm,cortex-a7-gic", "arm,cortex-a15-gic"; reg = <0x01c81000 0x1000>, <0x01c82000 0x2000>, -- 2.11.0 ^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 2/3] ARM: sun8i: a83t: Drop leading zeroes from device node addresses @ 2017-04-18 4:22 ` Chen-Yu Tsai 0 siblings, 0 replies; 33+ messages in thread From: Chen-Yu Tsai @ 2017-04-18 4:22 UTC (permalink / raw) To: linux-arm-kernel Kbuild now complains about leading zeroes in the address portion of device node names. Get rid of them. Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- arch/arm/boot/dts/sun8i-a83t.dtsi | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index 913aacafe8d5..82cb87f21b96 100644 --- a/arch/arm/boot/dts/sun8i-a83t.dtsi +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi @@ -162,7 +162,7 @@ #size-cells = <1>; ranges; - pio: pinctrl at 01c20800 { + pio: pinctrl at 1c20800 { compatible = "allwinner,sun8i-a83t-pinctrl"; interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>, @@ -193,7 +193,7 @@ }; }; - timer at 01c20c00 { + timer at 1c20c00 { compatible = "allwinner,sun4i-a10-timer"; reg = <0x01c20c00 0xa0>; interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>, @@ -201,14 +201,14 @@ clocks = <&osc24M>; }; - watchdog at 01c20ca0 { + watchdog at 1c20ca0 { compatible = "allwinner,sun6i-a31-wdt"; reg = <0x01c20ca0 0x20>; interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>; clocks = <&osc24M>; }; - uart0: serial at 01c28000 { + uart0: serial at 1c28000 { compatible = "snps,dw-apb-uart"; reg = <0x01c28000 0x400>; interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>; @@ -218,7 +218,7 @@ status = "disabled"; }; - gic: interrupt-controller at 01c81000 { + gic: interrupt-controller at 1c81000 { compatible = "arm,cortex-a7-gic", "arm,cortex-a15-gic"; reg = <0x01c81000 0x1000>, <0x01c82000 0x2000>, -- 2.11.0 ^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 2/3] ARM: sun8i: a83t: Drop leading zeroes from device node addresses @ 2017-04-18 4:22 ` Chen-Yu Tsai 0 siblings, 0 replies; 33+ messages in thread From: Chen-Yu Tsai @ 2017-04-18 4:22 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw Kbuild now complains about leading zeroes in the address portion of device node names. Get rid of them. Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> --- arch/arm/boot/dts/sun8i-a83t.dtsi | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index 913aacafe8d5..82cb87f21b96 100644 --- a/arch/arm/boot/dts/sun8i-a83t.dtsi +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi @@ -162,7 +162,7 @@ #size-cells = <1>; ranges; - pio: pinctrl@01c20800 { + pio: pinctrl@1c20800 { compatible = "allwinner,sun8i-a83t-pinctrl"; interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>, @@ -193,7 +193,7 @@ }; }; - timer@01c20c00 { + timer@1c20c00 { compatible = "allwinner,sun4i-a10-timer"; reg = <0x01c20c00 0xa0>; interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>, @@ -201,14 +201,14 @@ clocks = <&osc24M>; }; - watchdog@01c20ca0 { + watchdog@1c20ca0 { compatible = "allwinner,sun6i-a31-wdt"; reg = <0x01c20ca0 0x20>; interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>; clocks = <&osc24M>; }; - uart0: serial@01c28000 { + uart0: serial@1c28000 { compatible = "snps,dw-apb-uart"; reg = <0x01c28000 0x400>; interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>; @@ -218,7 +218,7 @@ status = "disabled"; }; - gic: interrupt-controller@01c81000 { + gic: interrupt-controller@1c81000 { compatible = "arm,cortex-a7-gic", "arm,cortex-a15-gic"; reg = <0x01c81000 0x1000>, <0x01c82000 0x2000>, -- 2.11.0 ^ permalink raw reply related [flat|nested] 33+ messages in thread
* Re: [PATCH 2/3] ARM: sun8i: a83t: Drop leading zeroes from device node addresses @ 2017-04-18 9:03 ` Maxime Ripard 0 siblings, 0 replies; 33+ messages in thread From: Maxime Ripard @ 2017-04-18 9:03 UTC (permalink / raw) To: Chen-Yu Tsai; +Cc: devicetree, linux-arm-kernel, linux-kernel, linux-sunxi [-- Attachment #1: Type: text/plain, Size: 876 bytes --] On Tue, Apr 18, 2017 at 12:22:04PM +0800, Chen-Yu Tsai wrote: > Kbuild now complains about leading zeroes in the address portion of > device node names. > > Get rid of them. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- > arch/arm/boot/dts/sun8i-a83t.dtsi | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > index 913aacafe8d5..82cb87f21b96 100644 > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > @@ -162,7 +162,7 @@ > #size-cells = <1>; > ranges; > > - pio: pinctrl@01c20800 { > + pio: pinctrl@1c20800 { As far as I know this breaks Uboot's auto-addition of stdout-path Maxime > -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 801 bytes --] ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 2/3] ARM: sun8i: a83t: Drop leading zeroes from device node addresses @ 2017-04-18 9:03 ` Maxime Ripard 0 siblings, 0 replies; 33+ messages in thread From: Maxime Ripard @ 2017-04-18 9:03 UTC (permalink / raw) To: linux-arm-kernel On Tue, Apr 18, 2017 at 12:22:04PM +0800, Chen-Yu Tsai wrote: > Kbuild now complains about leading zeroes in the address portion of > device node names. > > Get rid of them. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- > arch/arm/boot/dts/sun8i-a83t.dtsi | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > index 913aacafe8d5..82cb87f21b96 100644 > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > @@ -162,7 +162,7 @@ > #size-cells = <1>; > ranges; > > - pio: pinctrl at 01c20800 { > + pio: pinctrl at 1c20800 { As far as I know this breaks Uboot's auto-addition of stdout-path Maxime > -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170418/8e60df3b/attachment.sig> ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 2/3] ARM: sun8i: a83t: Drop leading zeroes from device node addresses @ 2017-04-18 9:03 ` Maxime Ripard 0 siblings, 0 replies; 33+ messages in thread From: Maxime Ripard @ 2017-04-18 9:03 UTC (permalink / raw) To: Chen-Yu Tsai Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw [-- Attachment #1: Type: text/plain, Size: 864 bytes --] On Tue, Apr 18, 2017 at 12:22:04PM +0800, Chen-Yu Tsai wrote: > Kbuild now complains about leading zeroes in the address portion of > device node names. > > Get rid of them. > > Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> > --- > arch/arm/boot/dts/sun8i-a83t.dtsi | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > index 913aacafe8d5..82cb87f21b96 100644 > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > @@ -162,7 +162,7 @@ > #size-cells = <1>; > ranges; > > - pio: pinctrl@01c20800 { > + pio: pinctrl@1c20800 { As far as I know this breaks Uboot's auto-addition of stdout-path Maxime > -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 2/3] ARM: sun8i: a83t: Drop leading zeroes from device node addresses 2017-04-18 9:03 ` Maxime Ripard (?) @ 2017-04-18 9:22 ` Chen-Yu Tsai -1 siblings, 0 replies; 33+ messages in thread From: Chen-Yu Tsai @ 2017-04-18 9:22 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi On Tue, Apr 18, 2017 at 5:03 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Tue, Apr 18, 2017 at 12:22:04PM +0800, Chen-Yu Tsai wrote: >> Kbuild now complains about leading zeroes in the address portion of >> device node names. >> >> Get rid of them. >> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> >> --- >> arch/arm/boot/dts/sun8i-a83t.dtsi | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi >> index 913aacafe8d5..82cb87f21b96 100644 >> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi >> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi >> @@ -162,7 +162,7 @@ >> #size-cells = <1>; >> ranges; >> >> - pio: pinctrl@01c20800 { >> + pio: pinctrl@1c20800 { > > As far as I know this breaks Uboot's auto-addition of stdout-path You're right. It breaks as Uboot has the path to the uarts hard-coded. That sucks. And from what I can tell, it's not easily solvable by just switching to serial alias based references. CONS_INDEX won't line up on the A23/A33 Q8 tablets. Maybe we can just keep the uart device node the same for now, but fix all the other ones. We can come back and fix the uart later once we figure out how to fix Uboot. Regards ChenYu ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 2/3] ARM: sun8i: a83t: Drop leading zeroes from device node addresses @ 2017-04-18 9:22 ` Chen-Yu Tsai 0 siblings, 0 replies; 33+ messages in thread From: Chen-Yu Tsai @ 2017-04-18 9:22 UTC (permalink / raw) To: linux-arm-kernel On Tue, Apr 18, 2017 at 5:03 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Tue, Apr 18, 2017 at 12:22:04PM +0800, Chen-Yu Tsai wrote: >> Kbuild now complains about leading zeroes in the address portion of >> device node names. >> >> Get rid of them. >> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> >> --- >> arch/arm/boot/dts/sun8i-a83t.dtsi | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi >> index 913aacafe8d5..82cb87f21b96 100644 >> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi >> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi >> @@ -162,7 +162,7 @@ >> #size-cells = <1>; >> ranges; >> >> - pio: pinctrl at 01c20800 { >> + pio: pinctrl at 1c20800 { > > As far as I know this breaks Uboot's auto-addition of stdout-path You're right. It breaks as Uboot has the path to the uarts hard-coded. That sucks. And from what I can tell, it's not easily solvable by just switching to serial alias based references. CONS_INDEX won't line up on the A23/A33 Q8 tablets. Maybe we can just keep the uart device node the same for now, but fix all the other ones. We can come back and fix the uart later once we figure out how to fix Uboot. Regards ChenYu ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 2/3] ARM: sun8i: a83t: Drop leading zeroes from device node addresses @ 2017-04-18 9:22 ` Chen-Yu Tsai 0 siblings, 0 replies; 33+ messages in thread From: Chen-Yu Tsai @ 2017-04-18 9:22 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi On Tue, Apr 18, 2017 at 5:03 PM, Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > On Tue, Apr 18, 2017 at 12:22:04PM +0800, Chen-Yu Tsai wrote: >> Kbuild now complains about leading zeroes in the address portion of >> device node names. >> >> Get rid of them. >> >> Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> >> --- >> arch/arm/boot/dts/sun8i-a83t.dtsi | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi >> index 913aacafe8d5..82cb87f21b96 100644 >> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi >> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi >> @@ -162,7 +162,7 @@ >> #size-cells = <1>; >> ranges; >> >> - pio: pinctrl@01c20800 { >> + pio: pinctrl@1c20800 { > > As far as I know this breaks Uboot's auto-addition of stdout-path You're right. It breaks as Uboot has the path to the uarts hard-coded. That sucks. And from what I can tell, it's not easily solvable by just switching to serial alias based references. CONS_INDEX won't line up on the A23/A33 Q8 tablets. Maybe we can just keep the uart device node the same for now, but fix all the other ones. We can come back and fix the uart later once we figure out how to fix Uboot. Regards ChenYu ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 2/3] ARM: sun8i: a83t: Drop leading zeroes from device node addresses @ 2017-04-19 6:53 ` Maxime Ripard 0 siblings, 0 replies; 33+ messages in thread From: Maxime Ripard @ 2017-04-19 6:53 UTC (permalink / raw) To: Chen-Yu Tsai; +Cc: devicetree, linux-arm-kernel, linux-kernel, linux-sunxi [-- Attachment #1: Type: text/plain, Size: 1849 bytes --] On Tue, Apr 18, 2017 at 05:22:02PM +0800, Chen-Yu Tsai wrote: > On Tue, Apr 18, 2017 at 5:03 PM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > On Tue, Apr 18, 2017 at 12:22:04PM +0800, Chen-Yu Tsai wrote: > >> Kbuild now complains about leading zeroes in the address portion of > >> device node names. > >> > >> Get rid of them. > >> > >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> > >> --- > >> arch/arm/boot/dts/sun8i-a83t.dtsi | 10 +++++----- > >> 1 file changed, 5 insertions(+), 5 deletions(-) > >> > >> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > >> index 913aacafe8d5..82cb87f21b96 100644 > >> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > >> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > >> @@ -162,7 +162,7 @@ > >> #size-cells = <1>; > >> ranges; > >> > >> - pio: pinctrl@01c20800 { > >> + pio: pinctrl@1c20800 { > > > > As far as I know this breaks Uboot's auto-addition of stdout-path > > You're right. It breaks as Uboot has the path to the uarts hard-coded. > That sucks. And from what I can tell, it's not easily solvable by just > switching to serial alias based references. CONS_INDEX won't line up > on the A23/A33 Q8 tablets. > > Maybe we can just keep the uart device node the same for now, but fix > all the other ones. We can come back and fix the uart later once we > figure out how to fix Uboot. Thinking more about this, I don't really know why we have that in U-Boot actually. All our DTs for a very long time have had stdout-path properly set (and if it's improperly set, this should be fixed). I'd say we can simply remove that from U-Boot and be done with it. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 801 bytes --] ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 2/3] ARM: sun8i: a83t: Drop leading zeroes from device node addresses @ 2017-04-19 6:53 ` Maxime Ripard 0 siblings, 0 replies; 33+ messages in thread From: Maxime Ripard @ 2017-04-19 6:53 UTC (permalink / raw) To: linux-arm-kernel On Tue, Apr 18, 2017 at 05:22:02PM +0800, Chen-Yu Tsai wrote: > On Tue, Apr 18, 2017 at 5:03 PM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > On Tue, Apr 18, 2017 at 12:22:04PM +0800, Chen-Yu Tsai wrote: > >> Kbuild now complains about leading zeroes in the address portion of > >> device node names. > >> > >> Get rid of them. > >> > >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> > >> --- > >> arch/arm/boot/dts/sun8i-a83t.dtsi | 10 +++++----- > >> 1 file changed, 5 insertions(+), 5 deletions(-) > >> > >> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > >> index 913aacafe8d5..82cb87f21b96 100644 > >> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > >> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > >> @@ -162,7 +162,7 @@ > >> #size-cells = <1>; > >> ranges; > >> > >> - pio: pinctrl at 01c20800 { > >> + pio: pinctrl at 1c20800 { > > > > As far as I know this breaks Uboot's auto-addition of stdout-path > > You're right. It breaks as Uboot has the path to the uarts hard-coded. > That sucks. And from what I can tell, it's not easily solvable by just > switching to serial alias based references. CONS_INDEX won't line up > on the A23/A33 Q8 tablets. > > Maybe we can just keep the uart device node the same for now, but fix > all the other ones. We can come back and fix the uart later once we > figure out how to fix Uboot. Thinking more about this, I don't really know why we have that in U-Boot actually. All our DTs for a very long time have had stdout-path properly set (and if it's improperly set, this should be fixed). I'd say we can simply remove that from U-Boot and be done with it. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170419/38858818/attachment.sig> ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 2/3] ARM: sun8i: a83t: Drop leading zeroes from device node addresses @ 2017-04-19 6:53 ` Maxime Ripard 0 siblings, 0 replies; 33+ messages in thread From: Maxime Ripard @ 2017-04-19 6:53 UTC (permalink / raw) To: Chen-Yu Tsai; +Cc: devicetree, linux-arm-kernel, linux-kernel, linux-sunxi [-- Attachment #1: Type: text/plain, Size: 1852 bytes --] On Tue, Apr 18, 2017 at 05:22:02PM +0800, Chen-Yu Tsai wrote: > On Tue, Apr 18, 2017 at 5:03 PM, Maxime Ripard > <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > > On Tue, Apr 18, 2017 at 12:22:04PM +0800, Chen-Yu Tsai wrote: > >> Kbuild now complains about leading zeroes in the address portion of > >> device node names. > >> > >> Get rid of them. > >> > >> Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> > >> --- > >> arch/arm/boot/dts/sun8i-a83t.dtsi | 10 +++++----- > >> 1 file changed, 5 insertions(+), 5 deletions(-) > >> > >> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > >> index 913aacafe8d5..82cb87f21b96 100644 > >> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > >> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > >> @@ -162,7 +162,7 @@ > >> #size-cells = <1>; > >> ranges; > >> > >> - pio: pinctrl@01c20800 { > >> + pio: pinctrl@1c20800 { > > > > As far as I know this breaks Uboot's auto-addition of stdout-path > > You're right. It breaks as Uboot has the path to the uarts hard-coded. > That sucks. And from what I can tell, it's not easily solvable by just > switching to serial alias based references. CONS_INDEX won't line up > on the A23/A33 Q8 tablets. > > Maybe we can just keep the uart device node the same for now, but fix > all the other ones. We can come back and fix the uart later once we > figure out how to fix Uboot. Thinking more about this, I don't really know why we have that in U-Boot actually. All our DTs for a very long time have had stdout-path properly set (and if it's improperly set, this should be fixed). I'd say we can simply remove that from U-Boot and be done with it. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names @ 2017-04-18 4:22 ` Chen-Yu Tsai 0 siblings, 0 replies; 33+ messages in thread From: Chen-Yu Tsai @ 2017-04-18 4:22 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi The pinmux setting nodes all have an address element in their node names, however the pinctrl node does not have #address-cells. Rename the existing pinmux setting nodes and labels in sun8i-a83t.dtsi, dropping identifiers for functions that only have one possible setting, and using the pingroup name if the function is identically available on different pingroups. Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- arch/arm/boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts | 2 +- arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts | 2 +- arch/arm/boot/dts/sun8i-a83t.dtsi | 10 +++++----- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/arm/boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts b/arch/arm/boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts index 342e1d33fa1c..aecdeeb368ed 100644 --- a/arch/arm/boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts +++ b/arch/arm/boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts @@ -59,6 +59,6 @@ &uart0 { pinctrl-names = "default"; - pinctrl-0 = <&uart0_pins_b>; + pinctrl-0 = <&uart0_pb_pins>; status = "okay"; }; diff --git a/arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts b/arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts index 88b1e0970b8d..d2614f101ecc 100644 --- a/arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts +++ b/arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts @@ -60,6 +60,6 @@ &uart0 { pinctrl-names = "default"; - pinctrl-0 = <&uart0_pins_b>; + pinctrl-0 = <&uart0_pb_pins>; status = "okay"; }; diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index 82cb87f21b96..87b99338716b 100644 --- a/arch/arm/boot/dts/sun8i-a83t.dtsi +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi @@ -174,7 +174,7 @@ #interrupt-cells = <3>; #gpio-cells = <3>; - mmc0_pins_a: mmc0@0 { + mmc0_pins: mmc0_pins { pins = "PF0", "PF1", "PF2", "PF3", "PF4", "PF5"; function = "mmc0"; @@ -182,13 +182,13 @@ bias-pull-up; }; - uart0_pins_a: uart0@0 { - pins = "PF2", "PF4"; + uart0_pb_pins: uart0_pb_pins { + pins = "PB9", "PB10"; function = "uart0"; }; - uart0_pins_b: uart0@1 { - pins = "PB9", "PB10"; + uart0_pf_pins: uart0_pf_pins { + pins = "PF2", "PF4"; function = "uart0"; }; }; -- 2.11.0 ^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names @ 2017-04-18 4:22 ` Chen-Yu Tsai 0 siblings, 0 replies; 33+ messages in thread From: Chen-Yu Tsai @ 2017-04-18 4:22 UTC (permalink / raw) To: linux-arm-kernel The pinmux setting nodes all have an address element in their node names, however the pinctrl node does not have #address-cells. Rename the existing pinmux setting nodes and labels in sun8i-a83t.dtsi, dropping identifiers for functions that only have one possible setting, and using the pingroup name if the function is identically available on different pingroups. Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- arch/arm/boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts | 2 +- arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts | 2 +- arch/arm/boot/dts/sun8i-a83t.dtsi | 10 +++++----- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/arm/boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts b/arch/arm/boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts index 342e1d33fa1c..aecdeeb368ed 100644 --- a/arch/arm/boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts +++ b/arch/arm/boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts @@ -59,6 +59,6 @@ &uart0 { pinctrl-names = "default"; - pinctrl-0 = <&uart0_pins_b>; + pinctrl-0 = <&uart0_pb_pins>; status = "okay"; }; diff --git a/arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts b/arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts index 88b1e0970b8d..d2614f101ecc 100644 --- a/arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts +++ b/arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts @@ -60,6 +60,6 @@ &uart0 { pinctrl-names = "default"; - pinctrl-0 = <&uart0_pins_b>; + pinctrl-0 = <&uart0_pb_pins>; status = "okay"; }; diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index 82cb87f21b96..87b99338716b 100644 --- a/arch/arm/boot/dts/sun8i-a83t.dtsi +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi @@ -174,7 +174,7 @@ #interrupt-cells = <3>; #gpio-cells = <3>; - mmc0_pins_a: mmc0 at 0 { + mmc0_pins: mmc0_pins { pins = "PF0", "PF1", "PF2", "PF3", "PF4", "PF5"; function = "mmc0"; @@ -182,13 +182,13 @@ bias-pull-up; }; - uart0_pins_a: uart0 at 0 { - pins = "PF2", "PF4"; + uart0_pb_pins: uart0_pb_pins { + pins = "PB9", "PB10"; function = "uart0"; }; - uart0_pins_b: uart0 at 1 { - pins = "PB9", "PB10"; + uart0_pf_pins: uart0_pf_pins { + pins = "PF2", "PF4"; function = "uart0"; }; }; -- 2.11.0 ^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names @ 2017-04-18 4:22 ` Chen-Yu Tsai 0 siblings, 0 replies; 33+ messages in thread From: Chen-Yu Tsai @ 2017-04-18 4:22 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw The pinmux setting nodes all have an address element in their node names, however the pinctrl node does not have #address-cells. Rename the existing pinmux setting nodes and labels in sun8i-a83t.dtsi, dropping identifiers for functions that only have one possible setting, and using the pingroup name if the function is identically available on different pingroups. Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> --- arch/arm/boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts | 2 +- arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts | 2 +- arch/arm/boot/dts/sun8i-a83t.dtsi | 10 +++++----- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/arm/boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts b/arch/arm/boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts index 342e1d33fa1c..aecdeeb368ed 100644 --- a/arch/arm/boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts +++ b/arch/arm/boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts @@ -59,6 +59,6 @@ &uart0 { pinctrl-names = "default"; - pinctrl-0 = <&uart0_pins_b>; + pinctrl-0 = <&uart0_pb_pins>; status = "okay"; }; diff --git a/arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts b/arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts index 88b1e0970b8d..d2614f101ecc 100644 --- a/arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts +++ b/arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts @@ -60,6 +60,6 @@ &uart0 { pinctrl-names = "default"; - pinctrl-0 = <&uart0_pins_b>; + pinctrl-0 = <&uart0_pb_pins>; status = "okay"; }; diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index 82cb87f21b96..87b99338716b 100644 --- a/arch/arm/boot/dts/sun8i-a83t.dtsi +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi @@ -174,7 +174,7 @@ #interrupt-cells = <3>; #gpio-cells = <3>; - mmc0_pins_a: mmc0@0 { + mmc0_pins: mmc0_pins { pins = "PF0", "PF1", "PF2", "PF3", "PF4", "PF5"; function = "mmc0"; @@ -182,13 +182,13 @@ bias-pull-up; }; - uart0_pins_a: uart0@0 { - pins = "PF2", "PF4"; + uart0_pb_pins: uart0_pb_pins { + pins = "PB9", "PB10"; function = "uart0"; }; - uart0_pins_b: uart0@1 { - pins = "PB9", "PB10"; + uart0_pf_pins: uart0_pf_pins { + pins = "PF2", "PF4"; function = "uart0"; }; }; -- 2.11.0 ^ permalink raw reply related [flat|nested] 33+ messages in thread
* Re: [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names @ 2017-04-18 9:04 ` Maxime Ripard 0 siblings, 0 replies; 33+ messages in thread From: Maxime Ripard @ 2017-04-18 9:04 UTC (permalink / raw) To: Chen-Yu Tsai; +Cc: devicetree, linux-arm-kernel, linux-kernel, linux-sunxi [-- Attachment #1: Type: text/plain, Size: 706 bytes --] On Tue, Apr 18, 2017 at 12:22:05PM +0800, Chen-Yu Tsai wrote: > The pinmux setting nodes all have an address element in their node > names, however the pinctrl node does not have #address-cells. > > Rename the existing pinmux setting nodes and labels in sun8i-a83t.dtsi, > dropping identifiers for functions that only have one possible setting, > and using the pingroup name if the function is identically available on > different pingroups. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> Applied, and I really like the new names. Would you make the same patch for everyone? Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 801 bytes --] ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names @ 2017-04-18 9:04 ` Maxime Ripard 0 siblings, 0 replies; 33+ messages in thread From: Maxime Ripard @ 2017-04-18 9:04 UTC (permalink / raw) To: linux-arm-kernel On Tue, Apr 18, 2017 at 12:22:05PM +0800, Chen-Yu Tsai wrote: > The pinmux setting nodes all have an address element in their node > names, however the pinctrl node does not have #address-cells. > > Rename the existing pinmux setting nodes and labels in sun8i-a83t.dtsi, > dropping identifiers for functions that only have one possible setting, > and using the pingroup name if the function is identically available on > different pingroups. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> Applied, and I really like the new names. Would you make the same patch for everyone? Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170418/4f2ee0ac/attachment.sig> ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names @ 2017-04-18 9:04 ` Maxime Ripard 0 siblings, 0 replies; 33+ messages in thread From: Maxime Ripard @ 2017-04-18 9:04 UTC (permalink / raw) To: Chen-Yu Tsai Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw [-- Attachment #1: Type: text/plain, Size: 705 bytes --] On Tue, Apr 18, 2017 at 12:22:05PM +0800, Chen-Yu Tsai wrote: > The pinmux setting nodes all have an address element in their node > names, however the pinctrl node does not have #address-cells. > > Rename the existing pinmux setting nodes and labels in sun8i-a83t.dtsi, > dropping identifiers for functions that only have one possible setting, > and using the pingroup name if the function is identically available on > different pingroups. > > Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> Applied, and I really like the new names. Would you make the same patch for everyone? Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names 2017-04-18 9:04 ` Maxime Ripard (?) @ 2017-04-18 9:16 ` Chen-Yu Tsai -1 siblings, 0 replies; 33+ messages in thread From: Chen-Yu Tsai @ 2017-04-18 9:16 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi On Tue, Apr 18, 2017 at 5:04 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Tue, Apr 18, 2017 at 12:22:05PM +0800, Chen-Yu Tsai wrote: >> The pinmux setting nodes all have an address element in their node >> names, however the pinctrl node does not have #address-cells. >> >> Rename the existing pinmux setting nodes and labels in sun8i-a83t.dtsi, >> dropping identifiers for functions that only have one possible setting, >> and using the pingroup name if the function is identically available on >> different pingroups. >> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> > > Applied, and I really like the new names. > > Would you make the same patch for everyone? I can. No guarantees on the schedule though. ChenYu ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names @ 2017-04-18 9:16 ` Chen-Yu Tsai 0 siblings, 0 replies; 33+ messages in thread From: Chen-Yu Tsai @ 2017-04-18 9:16 UTC (permalink / raw) To: linux-arm-kernel On Tue, Apr 18, 2017 at 5:04 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Tue, Apr 18, 2017 at 12:22:05PM +0800, Chen-Yu Tsai wrote: >> The pinmux setting nodes all have an address element in their node >> names, however the pinctrl node does not have #address-cells. >> >> Rename the existing pinmux setting nodes and labels in sun8i-a83t.dtsi, >> dropping identifiers for functions that only have one possible setting, >> and using the pingroup name if the function is identically available on >> different pingroups. >> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> > > Applied, and I really like the new names. > > Would you make the same patch for everyone? I can. No guarantees on the schedule though. ChenYu ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names @ 2017-04-18 9:16 ` Chen-Yu Tsai 0 siblings, 0 replies; 33+ messages in thread From: Chen-Yu Tsai @ 2017-04-18 9:16 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi On Tue, Apr 18, 2017 at 5:04 PM, Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > On Tue, Apr 18, 2017 at 12:22:05PM +0800, Chen-Yu Tsai wrote: >> The pinmux setting nodes all have an address element in their node >> names, however the pinctrl node does not have #address-cells. >> >> Rename the existing pinmux setting nodes and labels in sun8i-a83t.dtsi, >> dropping identifiers for functions that only have one possible setting, >> and using the pingroup name if the function is identically available on >> different pingroups. >> >> Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> > > Applied, and I really like the new names. > > Would you make the same patch for everyone? I can. No guarantees on the schedule though. ChenYu ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names @ 2017-04-19 6:52 ` Maxime Ripard 0 siblings, 0 replies; 33+ messages in thread From: Maxime Ripard @ 2017-04-19 6:52 UTC (permalink / raw) To: Chen-Yu Tsai; +Cc: devicetree, linux-arm-kernel, linux-kernel, linux-sunxi [-- Attachment #1: Type: text/plain, Size: 1050 bytes --] On Tue, Apr 18, 2017 at 05:16:53PM +0800, Chen-Yu Tsai wrote: > On Tue, Apr 18, 2017 at 5:04 PM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > On Tue, Apr 18, 2017 at 12:22:05PM +0800, Chen-Yu Tsai wrote: > >> The pinmux setting nodes all have an address element in their node > >> names, however the pinctrl node does not have #address-cells. > >> > >> Rename the existing pinmux setting nodes and labels in sun8i-a83t.dtsi, > >> dropping identifiers for functions that only have one possible setting, > >> and using the pingroup name if the function is identically available on > >> different pingroups. > >> > >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> > > > > Applied, and I really like the new names. > > > > Would you make the same patch for everyone? > > I can. No guarantees on the schedule though. Sure, I know this isn't really the most entertaining and fulfilling patch to make ;) Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 801 bytes --] ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names @ 2017-04-19 6:52 ` Maxime Ripard 0 siblings, 0 replies; 33+ messages in thread From: Maxime Ripard @ 2017-04-19 6:52 UTC (permalink / raw) To: linux-arm-kernel On Tue, Apr 18, 2017 at 05:16:53PM +0800, Chen-Yu Tsai wrote: > On Tue, Apr 18, 2017 at 5:04 PM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > On Tue, Apr 18, 2017 at 12:22:05PM +0800, Chen-Yu Tsai wrote: > >> The pinmux setting nodes all have an address element in their node > >> names, however the pinctrl node does not have #address-cells. > >> > >> Rename the existing pinmux setting nodes and labels in sun8i-a83t.dtsi, > >> dropping identifiers for functions that only have one possible setting, > >> and using the pingroup name if the function is identically available on > >> different pingroups. > >> > >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> > > > > Applied, and I really like the new names. > > > > Would you make the same patch for everyone? > > I can. No guarantees on the schedule though. Sure, I know this isn't really the most entertaining and fulfilling patch to make ;) Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170419/274bb57d/attachment.sig> ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names @ 2017-04-19 6:52 ` Maxime Ripard 0 siblings, 0 replies; 33+ messages in thread From: Maxime Ripard @ 2017-04-19 6:52 UTC (permalink / raw) To: Chen-Yu Tsai; +Cc: devicetree, linux-arm-kernel, linux-kernel, linux-sunxi [-- Attachment #1: Type: text/plain, Size: 1071 bytes --] On Tue, Apr 18, 2017 at 05:16:53PM +0800, Chen-Yu Tsai wrote: > On Tue, Apr 18, 2017 at 5:04 PM, Maxime Ripard > <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > > On Tue, Apr 18, 2017 at 12:22:05PM +0800, Chen-Yu Tsai wrote: > >> The pinmux setting nodes all have an address element in their node > >> names, however the pinctrl node does not have #address-cells. > >> > >> Rename the existing pinmux setting nodes and labels in sun8i-a83t.dtsi, > >> dropping identifiers for functions that only have one possible setting, > >> and using the pingroup name if the function is identically available on > >> different pingroups. > >> > >> Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> > > > > Applied, and I really like the new names. > > > > Would you make the same patch for everyone? > > I can. No guarantees on the schedule though. Sure, I know this isn't really the most entertaining and fulfilling patch to make ;) Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names @ 2017-04-21 3:30 ` Chen-Yu Tsai 0 siblings, 0 replies; 33+ messages in thread From: Chen-Yu Tsai @ 2017-04-21 3:30 UTC (permalink / raw) To: Chen-Yu Tsai Cc: Maxime Ripard, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi On Tue, Apr 18, 2017 at 12:22 PM, Chen-Yu Tsai <wens@csie.org> wrote: > The pinmux setting nodes all have an address element in their node > names, however the pinctrl node does not have #address-cells. > > Rename the existing pinmux setting nodes and labels in sun8i-a83t.dtsi, > dropping identifiers for functions that only have one possible setting, > and using the pingroup name if the function is identically available on > different pingroups. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- > arch/arm/boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts | 2 +- > arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts | 2 +- > arch/arm/boot/dts/sun8i-a83t.dtsi | 10 +++++----- > 3 files changed, 7 insertions(+), 7 deletions(-) > [...] > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > index 82cb87f21b96..87b99338716b 100644 > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > @@ -174,7 +174,7 @@ > #interrupt-cells = <3>; > #gpio-cells = <3>; > > - mmc0_pins_a: mmc0@0 { > + mmc0_pins: mmc0_pins { > pins = "PF0", "PF1", "PF2", > "PF3", "PF4", "PF5"; > function = "mmc0"; > @@ -182,13 +182,13 @@ > bias-pull-up; > }; > > - uart0_pins_a: uart0@0 { > - pins = "PF2", "PF4"; > + uart0_pb_pins: uart0_pb_pins { Duh... Forgot to use hyphens instead of underscores in the node names. I'll send a patch for you to squash in. ChenYu > + pins = "PB9", "PB10"; > function = "uart0"; > }; > > - uart0_pins_b: uart0@1 { > - pins = "PB9", "PB10"; > + uart0_pf_pins: uart0_pf_pins { > + pins = "PF2", "PF4"; > function = "uart0"; > }; > }; > -- > 2.11.0 > ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names @ 2017-04-21 3:30 ` Chen-Yu Tsai 0 siblings, 0 replies; 33+ messages in thread From: Chen-Yu Tsai @ 2017-04-21 3:30 UTC (permalink / raw) To: linux-arm-kernel On Tue, Apr 18, 2017 at 12:22 PM, Chen-Yu Tsai <wens@csie.org> wrote: > The pinmux setting nodes all have an address element in their node > names, however the pinctrl node does not have #address-cells. > > Rename the existing pinmux setting nodes and labels in sun8i-a83t.dtsi, > dropping identifiers for functions that only have one possible setting, > and using the pingroup name if the function is identically available on > different pingroups. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- > arch/arm/boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts | 2 +- > arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts | 2 +- > arch/arm/boot/dts/sun8i-a83t.dtsi | 10 +++++----- > 3 files changed, 7 insertions(+), 7 deletions(-) > [...] > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > index 82cb87f21b96..87b99338716b 100644 > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > @@ -174,7 +174,7 @@ > #interrupt-cells = <3>; > #gpio-cells = <3>; > > - mmc0_pins_a: mmc0 at 0 { > + mmc0_pins: mmc0_pins { > pins = "PF0", "PF1", "PF2", > "PF3", "PF4", "PF5"; > function = "mmc0"; > @@ -182,13 +182,13 @@ > bias-pull-up; > }; > > - uart0_pins_a: uart0 at 0 { > - pins = "PF2", "PF4"; > + uart0_pb_pins: uart0_pb_pins { Duh... Forgot to use hyphens instead of underscores in the node names. I'll send a patch for you to squash in. ChenYu > + pins = "PB9", "PB10"; > function = "uart0"; > }; > > - uart0_pins_b: uart0 at 1 { > - pins = "PB9", "PB10"; > + uart0_pf_pins: uart0_pf_pins { > + pins = "PF2", "PF4"; > function = "uart0"; > }; > }; > -- > 2.11.0 > ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names @ 2017-04-21 3:30 ` Chen-Yu Tsai 0 siblings, 0 replies; 33+ messages in thread From: Chen-Yu Tsai @ 2017-04-21 3:30 UTC (permalink / raw) To: Chen-Yu Tsai Cc: Maxime Ripard, devicetree, linux-arm-kernel, linux-kernel, linux-sunxi On Tue, Apr 18, 2017 at 12:22 PM, Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> wrote: > The pinmux setting nodes all have an address element in their node > names, however the pinctrl node does not have #address-cells. > > Rename the existing pinmux setting nodes and labels in sun8i-a83t.dtsi, > dropping identifiers for functions that only have one possible setting, > and using the pingroup name if the function is identically available on > different pingroups. > > Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> > --- > arch/arm/boot/dts/sun8i-a83t-allwinner-h8homlet-v2.dts | 2 +- > arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts | 2 +- > arch/arm/boot/dts/sun8i-a83t.dtsi | 10 +++++----- > 3 files changed, 7 insertions(+), 7 deletions(-) > [...] > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > index 82cb87f21b96..87b99338716b 100644 > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > @@ -174,7 +174,7 @@ > #interrupt-cells = <3>; > #gpio-cells = <3>; > > - mmc0_pins_a: mmc0@0 { > + mmc0_pins: mmc0_pins { > pins = "PF0", "PF1", "PF2", > "PF3", "PF4", "PF5"; > function = "mmc0"; > @@ -182,13 +182,13 @@ > bias-pull-up; > }; > > - uart0_pins_a: uart0@0 { > - pins = "PF2", "PF4"; > + uart0_pb_pins: uart0_pb_pins { Duh... Forgot to use hyphens instead of underscores in the node names. I'll send a patch for you to squash in. ChenYu > + pins = "PB9", "PB10"; > function = "uart0"; > }; > > - uart0_pins_b: uart0@1 { > - pins = "PB9", "PB10"; > + uart0_pf_pins: uart0_pf_pins { > + pins = "PF2", "PF4"; > function = "uart0"; > }; > }; > -- > 2.11.0 > ^ permalink raw reply [flat|nested] 33+ messages in thread
end of thread, other threads:[~2017-04-21 3:30 UTC | newest] Thread overview: 33+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-04-18 4:22 [PATCH 0/3] ARM: sun8i: a83t: device tree cleanup Chen-Yu Tsai 2017-04-18 4:22 ` Chen-Yu Tsai 2017-04-18 4:22 ` Chen-Yu Tsai 2017-04-18 4:22 ` [PATCH 1/3] ARM: sun8i: a83t: Drop skeleton.dtsi Chen-Yu Tsai 2017-04-18 4:22 ` Chen-Yu Tsai 2017-04-18 4:22 ` Chen-Yu Tsai 2017-04-18 4:22 ` [PATCH 2/3] ARM: sun8i: a83t: Drop leading zeroes from device node addresses Chen-Yu Tsai 2017-04-18 4:22 ` Chen-Yu Tsai 2017-04-18 4:22 ` Chen-Yu Tsai 2017-04-18 9:03 ` Maxime Ripard 2017-04-18 9:03 ` Maxime Ripard 2017-04-18 9:03 ` Maxime Ripard 2017-04-18 9:22 ` Chen-Yu Tsai 2017-04-18 9:22 ` Chen-Yu Tsai 2017-04-18 9:22 ` Chen-Yu Tsai 2017-04-19 6:53 ` Maxime Ripard 2017-04-19 6:53 ` Maxime Ripard 2017-04-19 6:53 ` Maxime Ripard 2017-04-18 4:22 ` [PATCH 3/3] ARM: sun8i: a83t: Rename pinmux setting names Chen-Yu Tsai 2017-04-18 4:22 ` Chen-Yu Tsai 2017-04-18 4:22 ` Chen-Yu Tsai 2017-04-18 9:04 ` Maxime Ripard 2017-04-18 9:04 ` Maxime Ripard 2017-04-18 9:04 ` Maxime Ripard 2017-04-18 9:16 ` Chen-Yu Tsai 2017-04-18 9:16 ` Chen-Yu Tsai 2017-04-18 9:16 ` Chen-Yu Tsai 2017-04-19 6:52 ` Maxime Ripard 2017-04-19 6:52 ` Maxime Ripard 2017-04-19 6:52 ` Maxime Ripard 2017-04-21 3:30 ` Chen-Yu Tsai 2017-04-21 3:30 ` Chen-Yu Tsai 2017-04-21 3:30 ` Chen-Yu Tsai
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.