From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH] i2c: designware: do not show SDA hold time warning when not needed
Date: Tue, 18 Apr 2017 09:59:39 +0200 [thread overview]
Message-ID: <20170418095939.68788787@free-electrons.com> (raw)
In-Reply-To: <1492502087.24567.47.camel@linux.intel.com>
Hello,
On Tue, 18 Apr 2017 10:54:47 +0300, Andy Shevchenko wrote:
> On Fri, 2017-04-14 at 22:53 +0200, Thomas Petazzoni wrote:
> > When the I2C controller IP block has a revision too old to be able to
> > configure the SDA hold time, the driver currently displays a
> > warning. However, it does so unconditionally, even if no SDA hold time
> > has been configured through the Device Tree. This causes useless
> > warnings when running the system, so only show the warning if a SDA
> > hold time was specified.
>
> As far as I understand the warning it would be better to keep it in
> either way, though you may shift it to debug level.
>
> Wolfram, Jarkko, thoughts?
Why show a message when the user has not requested a custom SDA hold
time? Getting a warning about something you haven't requested seems
really odd.
I think it makes a lot more sense to keep it at the warning level
(because it's important to get this message if you configure a custom
SDA hold time), but only show it when appropriate.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: designware: do not show SDA hold time warning when not needed
Date: Tue, 18 Apr 2017 09:59:39 +0200 [thread overview]
Message-ID: <20170418095939.68788787@free-electrons.com> (raw)
In-Reply-To: <1492502087.24567.47.camel@linux.intel.com>
Hello,
On Tue, 18 Apr 2017 10:54:47 +0300, Andy Shevchenko wrote:
> On Fri, 2017-04-14 at 22:53 +0200, Thomas Petazzoni wrote:
> > When the I2C controller IP block has a revision too old to be able to
> > configure the SDA hold time, the driver currently displays a
> > warning. However, it does so unconditionally, even if no SDA hold time
> > has been configured through the Device Tree. This causes useless
> > warnings when running the system, so only show the warning if a SDA
> > hold time was specified.
>
> As far as I understand the warning it would be better to keep it in
> either way, though you may shift it to debug level.
>
> Wolfram, Jarkko, thoughts?
Why show a message when the user has not requested a custom SDA hold
time? Getting a warning about something you haven't requested seems
really odd.
I think it makes a lot more sense to keep it at the warning level
(because it's important to get this message if you configure a custom
SDA hold time), but only show it when appropriate.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-04-18 7:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 20:53 [PATCH] i2c: designware: do not show SDA hold time warning when not needed Thomas Petazzoni
2017-04-14 20:53 ` Thomas Petazzoni
2017-04-18 7:54 ` Andy Shevchenko
2017-04-18 7:54 ` Andy Shevchenko
2017-04-18 7:59 ` Thomas Petazzoni [this message]
2017-04-18 7:59 ` Thomas Petazzoni
2017-04-18 10:23 ` Jarkko Nikula
2017-04-18 10:23 ` Jarkko Nikula
2017-06-02 20:15 ` Wolfram Sang
2017-06-02 20:15 ` Wolfram Sang
2017-06-03 13:18 ` Thomas Petazzoni
2017-06-03 13:18 ` Thomas Petazzoni
2017-06-03 21:25 ` Wolfram Sang
2017-06-03 21:25 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170418095939.68788787@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.