* [PATCH] mmc: sdhci-esdhc-imx: increase the pad I/O drive strength for DDR50 card
@ 2017-04-17 11:10 ` Haibo Chen
0 siblings, 0 replies; 5+ messages in thread
From: Haibo Chen @ 2017-04-17 11:10 UTC (permalink / raw)
To: adrian.hunter, ulf.hansson, aisheng.dong; +Cc: tharvey, stable, linux-mmc
Currently for DDR50 card, it need tuning in default. We meet tuning fail
issue for DDR50 card and some data CRC error when DDR50 sd card works.
This is because the default pad I/O drive strength can't make sure DDR50
card work stable. So increase the pad I/O drive strength for DDR50 card,
and use pins_100mhz.
Tested-and-reported-by: Tim Harvey <tharvey@gateworks.com>
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
Cc: stable@vger.kernel.org # v4.4+
---
drivers/mmc/host/sdhci-esdhc-imx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
index cf666a0..abad67a 100644
--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c
@@ -830,6 +830,7 @@ static int esdhc_change_pinstate(struct sdhci_host *host,
switch (uhs) {
case MMC_TIMING_UHS_SDR50:
+ case MMC_TIMING_UHS_DDR50:
pinctrl = imx_data->pins_100mhz;
break;
case MMC_TIMING_UHS_SDR104:
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] mmc: sdhci-esdhc-imx: increase the pad I/O drive strength for DDR50 card
@ 2017-04-17 11:10 ` Haibo Chen
0 siblings, 0 replies; 5+ messages in thread
From: Haibo Chen @ 2017-04-17 11:10 UTC (permalink / raw)
To: adrian.hunter, ulf.hansson, aisheng.dong; +Cc: tharvey, stable, linux-mmc
Currently for DDR50 card, it need tuning in default. We meet tuning fail
issue for DDR50 card and some data CRC error when DDR50 sd card works.
This is because the default pad I/O drive strength can't make sure DDR50
card work stable. So increase the pad I/O drive strength for DDR50 card,
and use pins_100mhz.
Tested-and-reported-by: Tim Harvey <tharvey@gateworks.com>
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
Cc: stable@vger.kernel.org # v4.4+
---
drivers/mmc/host/sdhci-esdhc-imx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
index cf666a0..abad67a 100644
--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c
@@ -830,6 +830,7 @@ static int esdhc_change_pinstate(struct sdhci_host *host,
switch (uhs) {
case MMC_TIMING_UHS_SDR50:
+ case MMC_TIMING_UHS_DDR50:
pinctrl = imx_data->pins_100mhz;
break;
case MMC_TIMING_UHS_SDR104:
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: sdhci-esdhc-imx: increase the pad I/O drive strength for DDR50 card
2017-04-17 11:10 ` Haibo Chen
(?)
@ 2017-04-18 7:01 ` Adrian Hunter
-1 siblings, 0 replies; 5+ messages in thread
From: Adrian Hunter @ 2017-04-18 7:01 UTC (permalink / raw)
To: Haibo Chen, ulf.hansson, aisheng.dong; +Cc: tharvey, stable, linux-mmc
On 17/04/17 14:10, Haibo Chen wrote:
> Currently for DDR50 card, it need tuning in default. We meet tuning fail
> issue for DDR50 card and some data CRC error when DDR50 sd card works.
>
> This is because the default pad I/O drive strength can't make sure DDR50
> card work stable. So increase the pad I/O drive strength for DDR50 card,
> and use pins_100mhz.
>
> Tested-and-reported-by: Tim Harvey <tharvey@gateworks.com>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> Cc: stable@vger.kernel.org # v4.4+
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-esdhc-imx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index cf666a0..abad67a 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -830,6 +830,7 @@ static int esdhc_change_pinstate(struct sdhci_host *host,
>
> switch (uhs) {
> case MMC_TIMING_UHS_SDR50:
> + case MMC_TIMING_UHS_DDR50:
> pinctrl = imx_data->pins_100mhz;
> break;
> case MMC_TIMING_UHS_SDR104:
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: sdhci-esdhc-imx: increase the pad I/O drive strength for DDR50 card
2017-04-17 11:10 ` Haibo Chen
(?)
(?)
@ 2017-04-18 10:23 ` Dong Aisheng
-1 siblings, 0 replies; 5+ messages in thread
From: Dong Aisheng @ 2017-04-18 10:23 UTC (permalink / raw)
To: Haibo Chen
Cc: adrian.hunter, ulf.hansson, aisheng.dong, tharvey, stable, linux-mmc
On Mon, Apr 17, 2017 at 07:10:02PM +0800, Haibo Chen wrote:
> Currently for DDR50 card, it need tuning in default. We meet tuning fail
> issue for DDR50 card and some data CRC error when DDR50 sd card works.
>
> This is because the default pad I/O drive strength can't make sure DDR50
> card work stable. So increase the pad I/O drive strength for DDR50 card,
> and use pins_100mhz.
>
> Tested-and-reported-by: Tim Harvey <tharvey@gateworks.com>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> Cc: stable@vger.kernel.org # v4.4+
Acked-by: Dong Aisheng <aisheng.dong@nxp.com>
Regards
Dong Aisheng
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: sdhci-esdhc-imx: increase the pad I/O drive strength for DDR50 card
2017-04-17 11:10 ` Haibo Chen
` (2 preceding siblings ...)
(?)
@ 2017-04-18 14:33 ` Tim Harvey
-1 siblings, 0 replies; 5+ messages in thread
From: Tim Harvey @ 2017-04-18 14:33 UTC (permalink / raw)
To: Haibo Chen
Cc: Adrian Hunter, Ulf Hansson, aisheng.dong, stable, Linux MMC List
On Mon, Apr 17, 2017 at 4:10 AM, Haibo Chen <haibo.chen@nxp.com> wrote:
> Currently for DDR50 card, it need tuning in default. We meet tuning fail
> issue for DDR50 card and some data CRC error when DDR50 sd card works.
>
> This is because the default pad I/O drive strength can't make sure DDR50
> card work stable. So increase the pad I/O drive strength for DDR50 card,
> and use pins_100mhz.
>
> Tested-and-reported-by: Tim Harvey <tharvey@gateworks.com>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> Cc: stable@vger.kernel.org # v4.4+
Haibo,
I believe for stable to know how far back this needs to be applied (to
4.4) you need to add something like the following in your commit log:
This fixes DDR50 card support for IMX since DDR50 tuning was enabled
from commit 9faac7b95ea4 (mmc: sdhci: enable tuning for DDR50)
Regards,
Tim
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-04-18 14:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-17 11:10 [PATCH] mmc: sdhci-esdhc-imx: increase the pad I/O drive strength for DDR50 card Haibo Chen
2017-04-17 11:10 ` Haibo Chen
2017-04-18 7:01 ` Adrian Hunter
2017-04-18 10:23 ` Dong Aisheng
2017-04-18 14:33 ` Tim Harvey
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.