[Devel] [PATCH][V2] Remove redundant assignment to ObjectType

[Devel] [PATCH][V2] Remove redundant assignment to ObjectType

[Colin King]

[-- Attachment #1: Type: text/plain, Size: 1679 bytes --]

From: Colin Ian King <colin.king(a)canonical.com>

There are several occurrances of ObjectType being assigned
twice successively and the first assignment is clearly
unncessary and can hence be removed.  Remove the redundant
assignments and also a no longer needed OpInfo.

Signed-off-by: Colin Ian King <colin.king(a)canonical.com>
---
 source/common/adwalk.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/source/common/adwalk.c b/source/common/adwalk.c
index 22fbfe416..73533027e 100644
--- a/source/common/adwalk.c
+++ b/source/common/adwalk.c
@@ -747,7 +747,6 @@ AcpiDmLoadDescendingOp (
 
     WalkState = Info->WalkState;
     OpInfo = AcpiPsGetOpcodeInfo (Op->Common.AmlOpcode);
-    ObjectType = OpInfo->ObjectType;
     ObjectType = AslMapNamedOpcodeToDataType (Op->Asl.AmlOpcode);
 
     /* Only interested in operators that create new names */
@@ -885,7 +884,6 @@ AcpiDmXrefDescendingOp (
 
     WalkState = Info->WalkState;
     OpInfo = AcpiPsGetOpcodeInfo (Op->Common.AmlOpcode);
-    ObjectType = OpInfo->ObjectType;
     ObjectType = AslMapNamedOpcodeToDataType (Op->Asl.AmlOpcode);
 
     if ((!(OpInfo->Flags & AML_NAMED)) &&
@@ -1182,14 +1180,11 @@ AcpiDmCommonAscendingOp (
     void                    *Context)
 {
     ACPI_OP_WALK_INFO       *Info = Context;
-    const ACPI_OPCODE_INFO  *OpInfo;
     ACPI_OBJECT_TYPE        ObjectType;
 
 
     /* Close scope if necessary */
 
-    OpInfo = AcpiPsGetOpcodeInfo (Op->Common.AmlOpcode);
-    ObjectType = OpInfo->ObjectType;
     ObjectType = AslMapNamedOpcodeToDataType (Op->Asl.AmlOpcode);
 
     if (AcpiNsOpensScope (ObjectType))
-- 
2.11.0

Re: [Devel] [PATCH][V2] Remove redundant assignment to ObjectType

[Colin Ian King]

[-- Attachment #1: Type: text/plain, Size: 1837 bytes --]

On 18/04/17 22:30, Colin King wrote:
> From: Colin Ian King <colin.king(a)canonical.com>
> 
> There are several occurrances of ObjectType being assigned
> twice successively and the first assignment is clearly
> unncessary and can hence be removed.  Remove the redundant
> assignments and also a no longer needed OpInfo.
> 
> Signed-off-by: Colin Ian King <colin.king(a)canonical.com>
> ---
>  source/common/adwalk.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/source/common/adwalk.c b/source/common/adwalk.c
> index 22fbfe416..73533027e 100644
> --- a/source/common/adwalk.c
> +++ b/source/common/adwalk.c
> @@ -747,7 +747,6 @@ AcpiDmLoadDescendingOp (
>  
>      WalkState = Info->WalkState;
>      OpInfo = AcpiPsGetOpcodeInfo (Op->Common.AmlOpcode);
> -    ObjectType = OpInfo->ObjectType;
>      ObjectType = AslMapNamedOpcodeToDataType (Op->Asl.AmlOpcode);
>  
>      /* Only interested in operators that create new names */
> @@ -885,7 +884,6 @@ AcpiDmXrefDescendingOp (
>  
>      WalkState = Info->WalkState;
>      OpInfo = AcpiPsGetOpcodeInfo (Op->Common.AmlOpcode);
> -    ObjectType = OpInfo->ObjectType;
>      ObjectType = AslMapNamedOpcodeToDataType (Op->Asl.AmlOpcode);
>  
>      if ((!(OpInfo->Flags & AML_NAMED)) &&
> @@ -1182,14 +1180,11 @@ AcpiDmCommonAscendingOp (
>      void                    *Context)
>  {
>      ACPI_OP_WALK_INFO       *Info = Context;
> -    const ACPI_OPCODE_INFO  *OpInfo;
>      ACPI_OBJECT_TYPE        ObjectType;
>  
>  
>      /* Close scope if necessary */
>  
> -    OpInfo = AcpiPsGetOpcodeInfo (Op->Common.AmlOpcode);
> -    ObjectType = OpInfo->ObjectType;
>      ObjectType = AslMapNamedOpcodeToDataType (Op->Asl.AmlOpcode);
>  
>      if (AcpiNsOpensScope (ObjectType))
> 

Any chance this will be reviewed?