* [PATCH 1/2] drm/amd/amdgpu: Change comp GFXv6 ring name to remove space
@ 2017-04-19 13:10 Tom St Denis
[not found] ` <20170419131056.16369-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Tom St Denis @ 2017-04-19 13:10 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Tom St Denis
umr expects the ring name to be a complete word. This also
makes it consistent with GFXv7/8.
Signed-off-by: Tom St Denis <tom.stdenis@amd.com>
---
drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c
index 625dbfc4f826..f7579dedc577 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c
@@ -3292,7 +3292,7 @@ static int gfx_v6_0_sw_init(void *handle)
ring->me = 1;
ring->pipe = i;
ring->queue = i;
- sprintf(ring->name, "comp %d.%d.%d", ring->me, ring->pipe, ring->queue);
+ sprintf(ring->name, "comp_%d.%d.%d", ring->me, ring->pipe, ring->queue);
irq_type = AMDGPU_CP_IRQ_COMPUTE_MEC1_PIPE0_EOP + ring->pipe;
r = amdgpu_ring_init(adev, ring, 1024,
&adev->gfx.eop_irq, irq_type);
--
2.12.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <20170419131056.16369-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org>]
* [PATCH 2/2] drm/amd/amdgpu: Change comp GFXv9 ring name to remove space [not found] ` <20170419131056.16369-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org> @ 2017-04-19 13:10 ` Tom St Denis [not found] ` <20170419131056.16369-2-tom.stdenis-5C7GfCeVMHo@public.gmane.org> 2017-04-19 13:30 ` [PATCH 1/2] drm/amd/amdgpu: Change comp GFXv6 " Christian König 1 sibling, 1 reply; 4+ messages in thread From: Tom St Denis @ 2017-04-19 13:10 UTC (permalink / raw) To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Tom St Denis umr expects the ring name to be a complete word. This also makes it consistent with GFXv7/8. Signed-off-by: Tom St Denis <tom.stdenis@amd.com> --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c index 898bc5c3a42b..42cfd3b45390 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c @@ -1094,7 +1094,7 @@ static int gfx_v9_0_sw_init(void *handle) ring->pipe = i / 8; ring->queue = i % 8; ring->eop_gpu_addr = adev->gfx.mec.hpd_eop_gpu_addr + (i * MEC_HPD_SIZE); - sprintf(ring->name, "comp %d.%d.%d", ring->me, ring->pipe, ring->queue); + sprintf(ring->name, "comp_%d.%d.%d", ring->me, ring->pipe, ring->queue); irq_type = AMDGPU_CP_IRQ_COMPUTE_MEC1_PIPE0_EOP + ring->pipe; /* type-2 packets are deprecated on MEC, use type-3 instead */ r = amdgpu_ring_init(adev, ring, 1024, -- 2.12.0 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 4+ messages in thread
[parent not found: <20170419131056.16369-2-tom.stdenis-5C7GfCeVMHo@public.gmane.org>]
* RE: [PATCH 2/2] drm/amd/amdgpu: Change comp GFXv9 ring name to remove space [not found] ` <20170419131056.16369-2-tom.stdenis-5C7GfCeVMHo@public.gmane.org> @ 2017-04-19 16:19 ` Deucher, Alexander 0 siblings, 0 replies; 4+ messages in thread From: Deucher, Alexander @ 2017-04-19 16:19 UTC (permalink / raw) To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: StDenis, Tom > -----Original Message----- > From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf > Of Tom St Denis > Sent: Wednesday, April 19, 2017 9:11 AM > To: amd-gfx@lists.freedesktop.org > Cc: StDenis, Tom > Subject: [PATCH 2/2] drm/amd/amdgpu: Change comp GFXv9 ring name to > remove space > > umr expects the ring name to be a complete word. This also > makes it consistent with GFXv7/8. > > Signed-off-by: Tom St Denis <tom.stdenis@amd.com> Series is: Reviewed-by: Alex Deucher <alexander.deucher@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c > b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c > index 898bc5c3a42b..42cfd3b45390 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c > @@ -1094,7 +1094,7 @@ static int gfx_v9_0_sw_init(void *handle) > ring->pipe = i / 8; > ring->queue = i % 8; > ring->eop_gpu_addr = adev->gfx.mec.hpd_eop_gpu_addr + > (i * MEC_HPD_SIZE); > - sprintf(ring->name, "comp %d.%d.%d", ring->me, ring->pipe, > ring->queue); > + sprintf(ring->name, "comp_%d.%d.%d", ring->me, ring- > >pipe, ring->queue); > irq_type = AMDGPU_CP_IRQ_COMPUTE_MEC1_PIPE0_EOP > + ring->pipe; > /* type-2 packets are deprecated on MEC, use type-3 instead > */ > r = amdgpu_ring_init(adev, ring, 1024, > -- > 2.12.0 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] drm/amd/amdgpu: Change comp GFXv6 ring name to remove space [not found] ` <20170419131056.16369-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org> 2017-04-19 13:10 ` [PATCH 2/2] drm/amd/amdgpu: Change comp GFXv9 " Tom St Denis @ 2017-04-19 13:30 ` Christian König 1 sibling, 0 replies; 4+ messages in thread From: Christian König @ 2017-04-19 13:30 UTC (permalink / raw) To: Tom St Denis, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Am 19.04.2017 um 15:10 schrieb Tom St Denis: > umr expects the ring name to be a complete word. This also > makes it consistent with GFXv7/8. > > Signed-off-by: Tom St Denis <tom.stdenis@amd.com> Reviewed-by: Christian König <christian.koenig@amd.com> for both. > --- > drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c > index 625dbfc4f826..f7579dedc577 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c > @@ -3292,7 +3292,7 @@ static int gfx_v6_0_sw_init(void *handle) > ring->me = 1; > ring->pipe = i; > ring->queue = i; > - sprintf(ring->name, "comp %d.%d.%d", ring->me, ring->pipe, ring->queue); > + sprintf(ring->name, "comp_%d.%d.%d", ring->me, ring->pipe, ring->queue); > irq_type = AMDGPU_CP_IRQ_COMPUTE_MEC1_PIPE0_EOP + ring->pipe; > r = amdgpu_ring_init(adev, ring, 1024, > &adev->gfx.eop_irq, irq_type); _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-19 16:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-19 13:10 [PATCH 1/2] drm/amd/amdgpu: Change comp GFXv6 ring name to remove space Tom St Denis
[not found] ` <20170419131056.16369-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org>
2017-04-19 13:10 ` [PATCH 2/2] drm/amd/amdgpu: Change comp GFXv9 " Tom St Denis
[not found] ` <20170419131056.16369-2-tom.stdenis-5C7GfCeVMHo@public.gmane.org>
2017-04-19 16:19 ` Deucher, Alexander
2017-04-19 13:30 ` [PATCH 1/2] drm/amd/amdgpu: Change comp GFXv6 " Christian König
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.