All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alice Michael <alice.michael@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH S71 04/10] i40e: remove unnecessary msleep() delay in i40e_free_vfs
Date: Wed, 19 Apr 2017 09:25:53 -0400	[thread overview]
Message-ID: <20170419132559.20459-4-alice.michael@intel.com> (raw)
In-Reply-To: <20170419132559.20459-1-alice.michael@intel.com>

From: Jacob Keller <jacob.e.keller@intel.com>

The delay was added because of a desire to ensure that the VF driver can
finish up removing. However, pci_disable_sriov already has its own
ssleep() call that will sleep for an entire second, so there is no
reason to add extra delay on top of this by using msleep here. In
practice, an msleep() won't have a huge impact on timing but there is no
real value in keeping it, so lets just simplify the code and remove it.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_main.c        | 2 +-
 drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 2 --
 drivers/net/ethernet/intel/i40evf/i40evf_main.c    | 2 +-
 3 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index f44affc..20850a6 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -47,7 +47,7 @@ static const char i40e_driver_string[] =
 
 #define DRV_VERSION_MAJOR 2
 #define DRV_VERSION_MINOR 1
-#define DRV_VERSION_BUILD 7
+#define DRV_VERSION_BUILD 14
 #define DRV_VERSION __stringify(DRV_VERSION_MAJOR) "." \
 	     __stringify(DRV_VERSION_MINOR) "." \
 	     __stringify(DRV_VERSION_BUILD)    DRV_KERN
diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
index 2a47a64..29f53f0 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
@@ -1219,8 +1219,6 @@ void i40e_free_vfs(struct i40e_pf *pf)
 	else
 		dev_warn(&pf->pdev->dev, "VFs are assigned - not disabling SR-IOV\n");
 
-	msleep(20); /* let any messages in transit get finished up */
-
 	/* free up VF resources */
 	tmp = pf->num_alloc_vfs;
 	pf->num_alloc_vfs = 0;
diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
index 5915273..3ea81bd 100644
--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
@@ -46,7 +46,7 @@ static const char i40evf_driver_string[] =
 
 #define DRV_VERSION_MAJOR 2
 #define DRV_VERSION_MINOR 1
-#define DRV_VERSION_BUILD 7
+#define DRV_VERSION_BUILD 14
 #define DRV_VERSION __stringify(DRV_VERSION_MAJOR) "." \
 	     __stringify(DRV_VERSION_MINOR) "." \
 	     __stringify(DRV_VERSION_BUILD) \
-- 
2.9.3


  parent reply	other threads:[~2017-04-19 13:25 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-19 13:25 [Intel-wired-lan] [next PATCH S71 01/10] i40e: rename index to port to avoid confusion Alice Michael
2017-04-19 13:25 ` [Intel-wired-lan] [next PATCH S71 02/10] i40e: Reprogram port offloads after reset Alice Michael
2017-04-21 16:04   ` Bowers, AndrewX
2017-04-19 13:25 ` [Intel-wired-lan] [next PATCH S71 03/10] i40e: amortize wait time when disabling lots of VFs Alice Michael
2017-04-21 18:07   ` Bowers, AndrewX
2017-04-19 13:25 ` Alice Michael [this message]
2017-04-19 22:03   ` [Intel-wired-lan] [next PATCH S71 04/10] i40e: remove unnecessary msleep() delay in i40e_free_vfs Shannon Nelson
2017-04-21 18:08   ` Bowers, AndrewX
2017-04-19 13:25 ` [Intel-wired-lan] [next PATCH S71 05/10] i40e: separate PF and VSI state flags Alice Michael
2017-04-20 23:01   ` Bowers, AndrewX
2017-04-21 20:15     ` Keller, Jacob E
2017-04-19 13:25 ` [Intel-wired-lan] [next PATCH S71 06/10] i40e: use DECLARE_BITMAP for state fields Alice Michael
2017-04-21 18:09   ` Bowers, AndrewX
2017-04-19 13:25 ` [Intel-wired-lan] [next PATCH S71 07/10] i40evf: remove needless min_t() on num_online_cpus()*2 Alice Michael
2017-04-20 23:02   ` Bowers, AndrewX
2017-04-19 13:25 ` [Intel-wired-lan] [next PATCH S71 08/10] i40e: remove hw_disabled_flags in favor of using separate flag bits Alice Michael
2017-04-19 13:25 ` [Intel-wired-lan] [next PATCH S71 09/10] i40evf: remove I40E_FLAG_FDIR_ATR_ENABLED Alice Michael
2017-04-20 23:03   ` Bowers, AndrewX
2017-04-19 13:25 ` [Intel-wired-lan] [next PATCH S71 10/10] i40evf: allocate queues before we setup the interrupts and q_vectors Alice Michael
2017-04-21 18:13   ` Bowers, AndrewX
2017-04-20 23:00 ` [Intel-wired-lan] [next PATCH S71 01/10] i40e: rename index to port to avoid confusion Bowers, AndrewX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170419132559.20459-4-alice.michael@intel.com \
    --to=alice.michael@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.