All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alice Michael <alice.michael@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH S71 09/10] i40evf: remove I40E_FLAG_FDIR_ATR_ENABLED
Date: Wed, 19 Apr 2017 09:25:58 -0400	[thread overview]
Message-ID: <20170419132559.20459-9-alice.michael@intel.com> (raw)
In-Reply-To: <20170419132559.20459-1-alice.michael@intel.com>

From: Jacob Keller <jacob.e.keller@intel.com>

The flag used by the common code and PF code is I40E_FLAG_FD_ATR_ENABLED,
not *FDIR*. It turns out none of the txrx code actually shared with the
VF driver actually checks the ATR flag. This is made even more obvious
by the typo in the VF header file.

Let's just remove the flag from the VF driver since it's not needed.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
---
 drivers/net/ethernet/intel/i40evf/i40evf.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/i40evf/i40evf.h b/drivers/net/ethernet/intel/i40evf/i40evf.h
index 4681c63..b8ada6d 100644
--- a/drivers/net/ethernet/intel/i40evf/i40evf.h
+++ b/drivers/net/ethernet/intel/i40evf/i40evf.h
@@ -223,7 +223,6 @@ struct i40evf_adapter {
 #define I40EVF_FLAG_ALLMULTI_ON			BIT(19)
 #define I40EVF_FLAG_LEGACY_RX			BIT(20)
 /* duplicates for common code */
-#define I40E_FLAG_FDIR_ATR_ENABLED		0
 #define I40E_FLAG_DCB_ENABLED			0
 #define I40E_FLAG_RX_CSUM_ENABLED		I40EVF_FLAG_RX_CSUM_ENABLED
 #define I40E_FLAG_WB_ON_ITR_CAPABLE		I40EVF_FLAG_WB_ON_ITR_CAPABLE
-- 
2.9.3


  parent reply	other threads:[~2017-04-19 13:25 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-19 13:25 [Intel-wired-lan] [next PATCH S71 01/10] i40e: rename index to port to avoid confusion Alice Michael
2017-04-19 13:25 ` [Intel-wired-lan] [next PATCH S71 02/10] i40e: Reprogram port offloads after reset Alice Michael
2017-04-21 16:04   ` Bowers, AndrewX
2017-04-19 13:25 ` [Intel-wired-lan] [next PATCH S71 03/10] i40e: amortize wait time when disabling lots of VFs Alice Michael
2017-04-21 18:07   ` Bowers, AndrewX
2017-04-19 13:25 ` [Intel-wired-lan] [next PATCH S71 04/10] i40e: remove unnecessary msleep() delay in i40e_free_vfs Alice Michael
2017-04-19 22:03   ` Shannon Nelson
2017-04-21 18:08   ` Bowers, AndrewX
2017-04-19 13:25 ` [Intel-wired-lan] [next PATCH S71 05/10] i40e: separate PF and VSI state flags Alice Michael
2017-04-20 23:01   ` Bowers, AndrewX
2017-04-21 20:15     ` Keller, Jacob E
2017-04-19 13:25 ` [Intel-wired-lan] [next PATCH S71 06/10] i40e: use DECLARE_BITMAP for state fields Alice Michael
2017-04-21 18:09   ` Bowers, AndrewX
2017-04-19 13:25 ` [Intel-wired-lan] [next PATCH S71 07/10] i40evf: remove needless min_t() on num_online_cpus()*2 Alice Michael
2017-04-20 23:02   ` Bowers, AndrewX
2017-04-19 13:25 ` [Intel-wired-lan] [next PATCH S71 08/10] i40e: remove hw_disabled_flags in favor of using separate flag bits Alice Michael
2017-04-19 13:25 ` Alice Michael [this message]
2017-04-20 23:03   ` [Intel-wired-lan] [next PATCH S71 09/10] i40evf: remove I40E_FLAG_FDIR_ATR_ENABLED Bowers, AndrewX
2017-04-19 13:25 ` [Intel-wired-lan] [next PATCH S71 10/10] i40evf: allocate queues before we setup the interrupts and q_vectors Alice Michael
2017-04-21 18:13   ` Bowers, AndrewX
2017-04-20 23:00 ` [Intel-wired-lan] [next PATCH S71 01/10] i40e: rename index to port to avoid confusion Bowers, AndrewX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170419132559.20459-9-alice.michael@intel.com \
    --to=alice.michael@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.