All of lore.kernel.org
 help / color / mirror / Atom feed
From: "hch@lst.de" <hch@lst.de>
To: Bart Van Assche <Bart.VanAssche@sandisk.com>
Cc: "hch@bombadil.infradead.org" <hch@bombadil.infradead.org>,
	"axboe@kernel.dk" <axboe@kernel.dk>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"hch@lst.de" <hch@lst.de>,
	"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
	"roger.pau@citrix.com" <roger.pau@citrix.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"jbacik@fb.com" <jbacik@fb.com>,
	"james.smart@broadcom.com" <james.smart@broadcom.com>,
	"dm-devel@redhat.com" <dm-devel@redhat.com>
Subject: Re: blk-mq: remove the error argument to blk_mq_complete_request
Date: Wed, 19 Apr 2017 19:54:07 +0200	[thread overview]
Message-ID: <20170419175407.GB25761@lst.de> (raw)
In-Reply-To: <1492555816.2689.20.camel@sandisk.com>

On Tue, Apr 18, 2017 at 10:50:18PM +0000, Bart Van Assche wrote:
> On Tue, 2017-04-18 at 08:52 -0700, Christoph Hellwig wrote:
> > Now that we always have a ->complete callback we can remove the direct
> > call to blk_mq_end_request, as well as the error argument to
> > blk_mq_complete_request.
> 
> Hello Christoph,
> 
> Please add a runtime check that issues a warning early if a .complete
> callback function is missing.
> 
> Are you sure that all blk-mq drivers have a .complete callback? In the
> request-errors branch of your block git tree I found the following:

I think the problem is that my above changelog was wrong - we only
require the complete_rq method if the driver calls the
blk_mq_complete_request function.  Both rbd and ubiblock don't in
the tree.  They probably should, but that's work for a separate
series.

WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (hch@lst.de)
Subject: blk-mq: remove the error argument to blk_mq_complete_request
Date: Wed, 19 Apr 2017 19:54:07 +0200	[thread overview]
Message-ID: <20170419175407.GB25761@lst.de> (raw)
In-Reply-To: <1492555816.2689.20.camel@sandisk.com>

On Tue, Apr 18, 2017@10:50:18PM +0000, Bart Van Assche wrote:
> On Tue, 2017-04-18@08:52 -0700, Christoph Hellwig wrote:
> > Now that we always have a ->complete callback we can remove the direct
> > call to blk_mq_end_request, as well as the error argument to
> > blk_mq_complete_request.
> 
> Hello Christoph,
> 
> Please add a runtime check that issues a warning early if a .complete
> callback function is missing.
> 
> Are you sure that all blk-mq drivers have a .complete callback? In the
> request-errors branch of your block git tree I found the following:

I think the problem is that my above changelog was wrong - we only
require the complete_rq method if the driver calls the
blk_mq_complete_request function.  Both rbd and ubiblock don't in
the tree.  They probably should, but that's work for a separate
series.

  reply	other threads:[~2017-04-19 17:54 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-18 15:52 kill req->errors V2 Christoph Hellwig
2017-04-18 15:52 ` Christoph Hellwig
2017-04-18 15:52 ` block: remove the blk_execute_rq return value Christoph Hellwig
2017-04-18 15:52   ` Christoph Hellwig
2017-04-18 22:24   ` Bart Van Assche
2017-04-18 22:24     ` Bart Van Assche
2017-04-18 22:24     ` Bart Van Assche
2017-04-19  6:13     ` hch
2017-04-19  6:13       ` hch
2017-04-18 15:52 ` nvme-fc: fix status code handling in nvme_fc_fcpio_done Christoph Hellwig
2017-04-18 15:52   ` Christoph Hellwig
2017-04-18 21:08   ` James Smart
2017-04-18 21:08     ` James Smart
2017-04-18 15:52 ` nvme: split nvme status from block req->errors Christoph Hellwig
2017-04-18 15:52   ` Christoph Hellwig
2017-04-18 15:52 ` nvme: make nvme_error_status private Christoph Hellwig
2017-04-18 15:52   ` Christoph Hellwig
2017-04-18 15:52 ` virtio: fix spelling of virtblk_scsi_request_done Christoph Hellwig
2017-04-18 15:52   ` Christoph Hellwig
2017-04-18 15:52 ` virtio_blk: don't use req->errors Christoph Hellwig
2017-04-18 15:52   ` Christoph Hellwig
2017-04-18 15:52 ` scsi: introduce a new result field in struct scsi_request Christoph Hellwig
2017-04-18 15:52   ` Christoph Hellwig
2017-04-18 22:34   ` Bart Van Assche
2017-04-18 22:34     ` Bart Van Assche
2017-04-18 22:34     ` Bart Van Assche
2017-04-19  6:14     ` hch
2017-04-19  6:14       ` hch
2017-04-18 15:52 ` loop: zero-fill bio on the submitting cpu Christoph Hellwig
2017-04-18 15:52   ` Christoph Hellwig
2017-04-18 15:52 ` null_blk: don't pass always-0 req->errors to blk_mq_complete_request Christoph Hellwig
2017-04-18 15:52   ` Christoph Hellwig
2017-04-18 15:52 ` dm rq: don't pass irrelevant error code " Christoph Hellwig
2017-04-18 15:52   ` Christoph Hellwig
2017-04-18 15:52 ` dm mpath: don't check for req->errors Christoph Hellwig
2017-04-18 15:52   ` Christoph Hellwig
2017-04-18 15:52 ` nbd: don't use req->errors Christoph Hellwig
2017-04-18 15:52   ` Christoph Hellwig
2017-04-18 15:52 ` mtip32xx: add a status field to struct mtip_cmd Christoph Hellwig
2017-04-18 15:52   ` Christoph Hellwig
2017-04-18 15:52 ` xen-blkfront: don't use req->errors Christoph Hellwig
2017-04-18 15:52   ` Christoph Hellwig
2017-04-18 15:52 ` blk-mq: remove the error argument to blk_mq_complete_request Christoph Hellwig
2017-04-18 15:52   ` Christoph Hellwig
2017-04-18 22:50   ` Bart Van Assche
2017-04-18 22:50     ` Bart Van Assche
2017-04-18 22:50     ` Bart Van Assche
2017-04-19 17:54     ` hch [this message]
2017-04-19 17:54       ` hch
2017-04-18 15:52 ` blk-mq: simplify __blk_mq_complete_request Christoph Hellwig
2017-04-18 15:52   ` Christoph Hellwig
2017-04-18 15:52 ` block: add a error_count field to struct request Christoph Hellwig
2017-04-18 15:52   ` Christoph Hellwig
2017-04-18 22:57   ` Bart Van Assche
2017-04-18 22:57     ` Bart Van Assche
2017-04-18 22:57     ` Bart Van Assche
2017-04-19  6:15     ` hch
2017-04-19  6:15       ` hch
2017-04-18 15:52 ` floppy: switch from req->errors to req->error_count Christoph Hellwig
2017-04-18 15:52   ` Christoph Hellwig
2017-04-18 15:52 ` ataflop: " Christoph Hellwig
2017-04-18 15:52   ` Christoph Hellwig
2017-04-18 15:52 ` swim3: remove (commented out) printing of req->errors Christoph Hellwig
2017-04-18 15:52   ` Christoph Hellwig
2017-04-18 15:52 ` pd: remove bogus check for req->errors Christoph Hellwig
2017-04-18 15:52   ` Christoph Hellwig
2017-04-18 22:59   ` Bart Van Assche
2017-04-18 22:59     ` Bart Van Assche
2017-04-18 22:59     ` Bart Van Assche
2017-04-18 15:52 ` blktrace: remove the unused block_rq_abort tracepoint Christoph Hellwig
2017-04-18 15:52   ` Christoph Hellwig
2017-04-18 15:52 ` block: remove the errors field from struct request Christoph Hellwig
2017-04-18 15:52   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170419175407.GB25761@lst.de \
    --to=hch@lst.de \
    --cc=Bart.VanAssche@sandisk.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=hch@bombadil.infradead.org \
    --cc=james.smart@broadcom.com \
    --cc=jbacik@fb.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=roger.pau@citrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.