All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] nvmet_fc: Change traddr field separator to a colon
@ 2017-04-12 22:15 jsmart2021
  2017-04-19 19:33 ` Christoph Hellwig
  2017-04-20 11:32 ` Sagi Grimberg
  0 siblings, 2 replies; 3+ messages in thread
From: jsmart2021 @ 2017-04-12 22:15 UTC (permalink / raw)


From: James Smart <jsmart2021@gmail.com>

The FC-NVME spec revised syntax to avoid comma separators.
Sync with the change in the parser for traddr on port attachments.

Signed-off-by: James Smart <james.smart at broadcom.com>
---
 drivers/nvme/target/fc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c
index 9a8b846..e6243bb 100644
--- a/drivers/nvme/target/fc.c
+++ b/drivers/nvme/target/fc.c
@@ -2326,7 +2326,7 @@ nvmet_fc_parse_traddr(struct nvmet_fc_traddr *traddr, char *buf)
 	if (!options)
 		return -ENOMEM;
 
-	while ((p = strsep(&o, ",\n")) != NULL) {
+	while ((p = strsep(&o, ":\n")) != NULL) {
 		if (!*p)
 			continue;
 
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] nvmet_fc: Change traddr field separator to a colon
  2017-04-12 22:15 [PATCH] nvmet_fc: Change traddr field separator to a colon jsmart2021
@ 2017-04-19 19:33 ` Christoph Hellwig
  2017-04-20 11:32 ` Sagi Grimberg
  1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2017-04-19 19:33 UTC (permalink / raw)


On Wed, Apr 12, 2017@03:15:18PM -0700, jsmart2021@gmail.com wrote:
> From: James Smart <jsmart2021 at gmail.com>
> 
> The FC-NVME spec revised syntax to avoid comma separators.
> Sync with the change in the parser for traddr on port attachments.

Looks fine,

Reviewed-by: Christoph Hellwig <hch at lst.de>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] nvmet_fc: Change traddr field separator to a colon
  2017-04-12 22:15 [PATCH] nvmet_fc: Change traddr field separator to a colon jsmart2021
  2017-04-19 19:33 ` Christoph Hellwig
@ 2017-04-20 11:32 ` Sagi Grimberg
  1 sibling, 0 replies; 3+ messages in thread
From: Sagi Grimberg @ 2017-04-20 11:32 UTC (permalink / raw)


Looks good,

Reviewed-by: Sagi Grimberg <sagi at grimber.me>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-04-20 11:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-12 22:15 [PATCH] nvmet_fc: Change traddr field separator to a colon jsmart2021
2017-04-19 19:33 ` Christoph Hellwig
2017-04-20 11:32 ` Sagi Grimberg

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.