[Qemu-devel] 答复: Re: [PATCH] qemu-ga: addguest-network-get-interface-stat command

[Qemu-devel] 答复: Re: [PATCH] qemu-ga: addguest-network-get-interface-stat command

[lu.zhipeng]

[-- Attachment #1: Type: text/plain, Size: 2514 bytes --]

in some cases， nic statistics from guest is different from  QEMU backend device,when guest network drops packets.

 We can know the real reason by monitor guest network statistics in the case.







为了让您的VPlat虚拟化故障得到高效的处理，请上报故障到: $VPlat技术支持。


芦志朋 luzhipeng






IT开发工程师 IT Development
Engineer
操作系统产品部/中心研究院/系统产品 OS Product Dept./Central R＆D Institute/System Product









深圳市南山区科技南路55号中兴通讯研发大楼33楼 
33/F, R&D Building, ZTE
Corporation Hi-tech Road South, 
Hi-tech
Industrial Park Nanshan District, Shenzhen, P.R.China, 518057 
T: +86 755 xxxxxxxx F:+86 755 xxxxxxxx 
M: +86 xxxxxxxxxxx 
E: lu.zhipeng@zte.com.cn 
www.zte.com.cn






原始邮件



发件人： ＜berrange@redhat.com＞
收件人：芦志朋10108272
抄送人： ＜mdroth@linux.vnet.ibm.com＞ ＜qemu-devel@nongnu.org＞
日 期 ：2017年04月19日 17:22
主 题 ：Re: [Qemu-devel] [PATCH] qemu-ga: addguest-network-get-interface-stat command





On Thu, Apr 20, 2017 at 12:57:08AM +0800, ZhiPeng Lu wrote:
＞ we can get the  network card statistics inside  a virtual machine by
＞ guest-network-get-interface-stat command.
＞ it is very userful for us to monitor and analyze network traff.

In most cases you can already monitor guest network traffic from the
statistics on the QEMU backend device (ie tap device). The exception
is when doing PCI device assignment. Is the latter the reason why you
need to add this functionality instead of just quuerying the host
backend ?

There have been a lot of proposals for new QEMU geust agent commands in
the past few weeks

 - NIC statistics
 - Logged in users
 - Timezone offset
 - Hostname
 - OS version / product

This makes me wonder what our intended scope is for the guest agent ? Are we
happy to add arbitrary functionality to the guest agent, allowing it grow in
size & complexity without bound. Or is it better to restrict it to tasks which
are needed in order to coordinate management of the host virtualization layer
and leave general purpose guest OS management to another app.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

[-- Attachment #2: 24242e5637af428891c4db731e7765ad.jpg --]
[-- Type: image/jpeg, Size: 2064 bytes --]

[-- Attachment #3: 9ae3e214c17d49ed935d87c674ba3ee2.jpg --]
[-- Type: image/jpeg, Size: 6015 bytes --]

Re: [Qemu-devel] 答复: Re: [PATCH] qemu-ga: addguest-network-get-interface-stat command

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

On 04/19/2017 08:14 AM, lu.zhipeng@zte.com.cn wrote:
> ok,i agreed. i will do it
> 

Can you please fix your mailer to respect threading?  Your mails are
missing 'In-Reply-To' and 'References' headers, so they are showing up
as new top-level threads instead of being properly threaded.

Also, on technical lists, it is customary to avoid top-posting, but to
instead reply underneath the text you are responding to.


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

[Qemu-devel] 答复: Re: [PATCH] qemu-ga: addguest-network-get-interface-stat command

[lu.zhipeng]

[-- Attachment #1: Type: text/plain, Size: 3952 bytes --]

ok,i agreed. i will do it
















为了让您的VPlat虚拟化故障得到高效的处理，请上报故障到: $VPlat技术支持。


芦志朋 luzhipeng






IT开发工程师 IT Development
Engineer
操作系统产品部/中心研究院/系统产品 OS Product Dept./Central R＆D Institute/System Product









深圳市南山区科技南路55号中兴通讯研发大楼33楼 
33/F, R&D Building, ZTE
Corporation Hi-tech Road South, 
Hi-tech
Industrial Park Nanshan District, Shenzhen, P.R.China, 518057 
T: +86 755 xxxxxxxx F:+86 755 xxxxxxxx 
M: +86 xxxxxxxxxxx 
E: lu.zhipeng@zte.com.cn 
www.zte.com.cn








原始邮件



发件人： ＜cornelia.huck@de.ibm.com＞
收件人： ＜berrange@redhat.com＞
抄送人：芦志朋10108272 ＜mdroth@linux.vnet.ibm.com＞ ＜qemu-devel@nongnu.org＞
日 期 ：2017年04月19日 19:58
主 题 ：Re: [Qemu-devel] [PATCH] qemu-ga: addguest-network-get-interface-stat command





On Wed, 19 Apr 2017 12:50:36 +0100
"Daniel P. Berrange" ＜berrange@redhat.com＞ wrote:

＞ On Wed, Apr 19, 2017 at 01:41:47PM +0200, Cornelia Huck wrote:
＞ ＞ On Thu, 20 Apr 2017 00:57:08 +0800
＞ ＞ ZhiPeng Lu ＜lu.zhipeng@zte.com.cn＞ wrote:
＞ ＞ 
＞ ＞ ＞ diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
＞ ＞ ＞ index a02dbf2..60111dc 100644
＞ ＞ ＞ --- a/qga/qapi-schema.json
＞ ＞ ＞ +++ b/qga/qapi-schema.json
＞ ＞ ＞ @@ -1042,3 +1042,37 @@
＞ ＞ ＞    'data':    { 'path': 'str', '*arg': ['str'], '*env': ['str'],
＞ ＞ ＞                 '*input-data': 'str', '*capture-output': 'bool' },
＞ ＞ ＞    'returns': 'GuestExec' }
＞ ＞ ＞ +##
＞ ＞ ＞ +# @GuestNetworkInterfaceStat:
＞ ＞ ＞ +#
＞ ＞ ＞ +# @rx_bytes: received bytes of interface
＞ ＞ ＞ +#
＞ ＞ ＞ +# @rx_packets: received packets of interface
＞ ＞ ＞ +#
＞ ＞ ＞ +# @rx_errs: received error packets of interface
＞ ＞ ＞ +# @rx_drop: received drop packets of interface
＞ ＞ ＞ +#
＞ ＞ ＞ +# Since: 2.10
＞ ＞ ＞ +##
＞ ＞ ＞ +{ 'struct': 'GuestNetworkInterfaceStat',
＞ ＞ ＞ +  'data': {'rx_bytes': 'uint64',
＞ ＞ ＞ +            'rx_packets': 'uint64',
＞ ＞ ＞ +            'rx_errs': 'uint64',
＞ ＞ ＞ +            'rx_drop': 'uint64',
＞ ＞ ＞ +            'tx_bytes': 'uint64',
＞ ＞ ＞ +            'tx_packets': 'uint64',
＞ ＞ ＞ +            'tx_errs': 'uint64',
＞ ＞ ＞ +            'tx_drop': 'uint64'
＞ ＞ ＞ +           } }
＞ ＞ ＞ +##
＞ ＞ ＞ +# @guest-network-get-interface-stat:
＞ ＞ ＞ +#
＞ ＞ ＞ +# Get list of interface stat
＞ ＞ ＞ +#
＞ ＞ ＞ +# Returns: List of GuestNetworkInterfaceStat on success.
＞ ＞ ＞ +#
＞ ＞ ＞ +# Since: 2.10
＞ ＞ ＞ +##
＞ ＞ ＞ +{ 'command': 'guest-network-get-interface-stat',
＞ ＞ ＞ +  'data':    {'bus': 'int64', 'slot': 'int64', 'function': 'int64','netname':'str'},
＞ ＞ ＞ +  'returns': ['GuestNetworkInterfaceStat'] }
＞ ＞ 
＞ ＞ Disregarding the question whether this command should be added to the
＞ ＞ guest agent (I'll leave that to others to discuss), I don't think it's
＞ ＞ a good idea to enshrine pci identifiers here, as it means that we would
＞ ＞ need to add a new interface for every non-pci network device.
＞ ＞ 
＞ ＞ Can you use a more general device identifier interface? It's fine to
＞ ＞ only support pci for now (as that is likely your use case anyway), but
＞ ＞ there should be a way to extend this in the future.
＞ 
＞ It would be better to match the identification approach uses for the
＞ existing guest-network-get-interfaces command, which is based on MAC
＞ address. Arguably the stats data could just be added to this existnig
＞ command instead of adding a new command.

Agreed, that sounds like a better choice.

[-- Attachment #2: 24242e5637af428891c4db731e7765ad.jpg --]
[-- Type: image/jpeg, Size: 2064 bytes --]

[-- Attachment #3: 9ae3e214c17d49ed935d87c674ba3ee2.jpg --]
[-- Type: image/jpeg, Size: 6015 bytes --]