* [meta-raspberrypi][PATCH 1/3] raspberrypi2.conf: Make SERIAL_CONSOLE overwritable
@ 2017-04-20 17:18 Andrei Gherzan
2017-04-20 17:18 ` [meta-raspberrypi][PATCH 2/3] raspberrypi3-64.conf: " Andrei Gherzan
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Andrei Gherzan @ 2017-04-20 17:18 UTC (permalink / raw)
To: yocto
Signed-off-by: Andrei Gherzan <andrei@gherzan.ro>
---
conf/machine/raspberrypi2.conf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/conf/machine/raspberrypi2.conf b/conf/machine/raspberrypi2.conf
index 9b4c02a..a17289c 100644
--- a/conf/machine/raspberrypi2.conf
+++ b/conf/machine/raspberrypi2.conf
@@ -7,7 +7,7 @@ DEFAULTTUNE ?= "cortexa7thf-neon-vfpv4"
require conf/machine/include/tune-cortexa7.inc
include conf/machine/include/rpi-base.inc
-SERIAL_CONSOLE = "115200 ttyAMA0"
+SERIAL_CONSOLE ?= "115200 ttyAMA0"
UBOOT_MACHINE = "rpi_2_config"
VC4_CMA_SIZE ?= "cma-256"
--
2.12.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [meta-raspberrypi][PATCH 2/3] raspberrypi3-64.conf: Make SERIAL_CONSOLE overwritable
2017-04-20 17:18 [meta-raspberrypi][PATCH 1/3] raspberrypi2.conf: Make SERIAL_CONSOLE overwritable Andrei Gherzan
@ 2017-04-20 17:18 ` Andrei Gherzan
2017-04-20 17:18 ` [meta-raspberrypi][PATCH 3/3] raspberrypi3.conf: Use a stand alone machine configuration Andrei Gherzan
2017-04-21 16:03 ` [meta-raspberrypi][PATCH 1/3] raspberrypi2.conf: Make SERIAL_CONSOLE overwritable Andrei Gherzan
2 siblings, 0 replies; 6+ messages in thread
From: Andrei Gherzan @ 2017-04-20 17:18 UTC (permalink / raw)
To: yocto
Signed-off-by: Andrei Gherzan <andrei@gherzan.ro>
---
conf/machine/raspberrypi3-64.conf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/conf/machine/raspberrypi3-64.conf b/conf/machine/raspberrypi3-64.conf
index 7e99da1..5e2b80c 100644
--- a/conf/machine/raspberrypi3-64.conf
+++ b/conf/machine/raspberrypi3-64.conf
@@ -35,7 +35,7 @@ KERNEL_DEVICETREE = " \
overlays/vc4-kms-v3d.dtbo \
"
-SERIAL_CONSOLE = "115200 ttyS0"
+SERIAL_CONSOLE ?= "115200 ttyS0"
VC4_CMA_SIZE ?= "cma-256"
UBOOT_MACHINE = "rpi_3_config"
--
2.12.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [meta-raspberrypi][PATCH 3/3] raspberrypi3.conf: Use a stand alone machine configuration
2017-04-20 17:18 [meta-raspberrypi][PATCH 1/3] raspberrypi2.conf: Make SERIAL_CONSOLE overwritable Andrei Gherzan
2017-04-20 17:18 ` [meta-raspberrypi][PATCH 2/3] raspberrypi3-64.conf: " Andrei Gherzan
@ 2017-04-20 17:18 ` Andrei Gherzan
2017-04-21 16:03 ` [meta-raspberrypi][PATCH 1/3] raspberrypi2.conf: Make SERIAL_CONSOLE overwritable Andrei Gherzan
2 siblings, 0 replies; 6+ messages in thread
From: Andrei Gherzan @ 2017-04-20 17:18 UTC (permalink / raw)
To: yocto
As well make all the variables assigned in a way that they can be
overwritten so we can give maximum flexibility to distros.
Signed-off-by: Andrei Gherzan <andrei@gherzan.ro>
---
conf/machine/raspberrypi3.conf | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/conf/machine/raspberrypi3.conf b/conf/machine/raspberrypi3.conf
index 1ac5928..884d875 100644
--- a/conf/machine/raspberrypi3.conf
+++ b/conf/machine/raspberrypi3.conf
@@ -2,10 +2,14 @@
#@NAME: RaspberryPi 3 Development Board
#@DESCRIPTION: Machine configuration for the RaspberryPi 3
-MACHINEOVERRIDES = "raspberrypi2:${MACHINE}"
-include conf/machine/raspberrypi2.conf
+DEFAULTTUNE ?= "cortexa7thf-neon-vfpv4"
+require conf/machine/include/tune-cortexa7.inc
+include conf/machine/include/rpi-base.inc
MACHINE_EXTRA_RRECOMMENDS += "linux-firmware-bcm43430"
-SERIAL_CONSOLE = "115200 ttyS0"
+SDIMG_KERNELIMAGE ?= "kernel7.img"
+KERNEL_DEFCONFIG ?= "bcm2709_defconfig"
+UBOOT_MACHINE ?= "rpi_2_config"
+SERIAL_CONSOLE ?= "115200 ttyS0"
VC4_CMA_SIZE ?= "cma-256"
--
2.12.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [meta-raspberrypi][PATCH 1/3] raspberrypi2.conf: Make SERIAL_CONSOLE overwritable
2017-04-20 17:18 [meta-raspberrypi][PATCH 1/3] raspberrypi2.conf: Make SERIAL_CONSOLE overwritable Andrei Gherzan
2017-04-20 17:18 ` [meta-raspberrypi][PATCH 2/3] raspberrypi3-64.conf: " Andrei Gherzan
2017-04-20 17:18 ` [meta-raspberrypi][PATCH 3/3] raspberrypi3.conf: Use a stand alone machine configuration Andrei Gherzan
@ 2017-04-21 16:03 ` Andrei Gherzan
2017-04-21 17:37 ` Paul Barker
2 siblings, 1 reply; 6+ messages in thread
From: Andrei Gherzan @ 2017-04-21 16:03 UTC (permalink / raw)
To: yocto
[-- Attachment #1: Type: text/plain, Size: 852 bytes --]
On Thu, Apr 20, 2017 at 06:18:14PM +0100, Andrei Gherzan wrote:
> Signed-off-by: Andrei Gherzan <andrei@gherzan.ro>
> ---
> conf/machine/raspberrypi2.conf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/conf/machine/raspberrypi2.conf b/conf/machine/raspberrypi2.conf
> index 9b4c02a..a17289c 100644
> --- a/conf/machine/raspberrypi2.conf
> +++ b/conf/machine/raspberrypi2.conf
> @@ -7,7 +7,7 @@ DEFAULTTUNE ?= "cortexa7thf-neon-vfpv4"
> require conf/machine/include/tune-cortexa7.inc
> include conf/machine/include/rpi-base.inc
>
> -SERIAL_CONSOLE = "115200 ttyAMA0"
> +SERIAL_CONSOLE ?= "115200 ttyAMA0"
>
> UBOOT_MACHINE = "rpi_2_config"
> VC4_CMA_SIZE ?= "cma-256"
> --
> 2.12.2
>
Entire patch set merged to master and morty.
--
Andrei Gherzan
gpg: rsa4096/D4D94F67AD0E9640 | t: @agherzan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 849 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-raspberrypi][PATCH 1/3] raspberrypi2.conf: Make SERIAL_CONSOLE overwritable
2017-04-21 16:03 ` [meta-raspberrypi][PATCH 1/3] raspberrypi2.conf: Make SERIAL_CONSOLE overwritable Andrei Gherzan
@ 2017-04-21 17:37 ` Paul Barker
2017-04-21 20:09 ` Mirza Krak
0 siblings, 1 reply; 6+ messages in thread
From: Paul Barker @ 2017-04-21 17:37 UTC (permalink / raw)
To: Andrei Gherzan; +Cc: yocto
On Fri, Apr 21, 2017 at 5:03 PM, Andrei Gherzan <andrei@gherzan.ro> wrote:
> On Thu, Apr 20, 2017 at 06:18:14PM +0100, Andrei Gherzan wrote:
>> Signed-off-by: Andrei Gherzan <andrei@gherzan.ro>
>> ---
>> conf/machine/raspberrypi2.conf | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/conf/machine/raspberrypi2.conf b/conf/machine/raspberrypi2.conf
>> index 9b4c02a..a17289c 100644
>> --- a/conf/machine/raspberrypi2.conf
>> +++ b/conf/machine/raspberrypi2.conf
>> @@ -7,7 +7,7 @@ DEFAULTTUNE ?= "cortexa7thf-neon-vfpv4"
>> require conf/machine/include/tune-cortexa7.inc
>> include conf/machine/include/rpi-base.inc
>>
>> -SERIAL_CONSOLE = "115200 ttyAMA0"
>> +SERIAL_CONSOLE ?= "115200 ttyAMA0"
>>
>> UBOOT_MACHINE = "rpi_2_config"
>> VC4_CMA_SIZE ?= "cma-256"
>> --
>> 2.12.2
>>
>
> Entire patch set merged to master and morty.
>
This is the sort of thing I'm not keen on applying to stable branches
as it may change recipe behaviour. For comparison, the stable branch
policy for oe-core is very strict
(https://wiki.yoctoproject.org/wiki/Stable_branch_maintenance#Policies).
In my mind, avoiding potential breakage on a stable branch is more
important than making improvements. I'm even weary of updating the
raspberrypi firmware as I don't know how careful they are about
backwards compatibility. For kernel updates I do have an expectation
of backwards compatibility and an understanding that new stable
releases often fix security issues so I'm ok with those on stable
branches.
For example of where I'm concerned, a "raspberrypi2" override was
previously applied to both raspberrypi2 and raspberrypi3 machines.
After the third patch in this series it only applies to the
raspberrypi2 machine. Also, UBOOT_MACHINE is now set differently for
raspberrypi3 ('=' vs '?='). These changes may affect the value of some
variables when building for raspberrypi3 if downstream users haven't
explicitly handled both raspberrypi2 and raspberrypi3 overrides. I
don't mind these sorts of changes on the master branch but I worry
about applying them to a stable branch.
What do other meta-raspberrypi stable branch users think? Should we be
pedantic here or should we keep things open so that improvements can
be applied to stable branches?
Cheers,
Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-raspberrypi][PATCH 1/3] raspberrypi2.conf: Make SERIAL_CONSOLE overwritable
2017-04-21 17:37 ` Paul Barker
@ 2017-04-21 20:09 ` Mirza Krak
0 siblings, 0 replies; 6+ messages in thread
From: Mirza Krak @ 2017-04-21 20:09 UTC (permalink / raw)
To: Paul Barker; +Cc: yocto
2017-04-21 19:37 GMT+02:00 Paul Barker <pbarker@toganlabs.com>:
> On Fri, Apr 21, 2017 at 5:03 PM, Andrei Gherzan <andrei@gherzan.ro> wrote:
>> On Thu, Apr 20, 2017 at 06:18:14PM +0100, Andrei Gherzan wrote:
>>> Signed-off-by: Andrei Gherzan <andrei@gherzan.ro>
>>> ---
>>> conf/machine/raspberrypi2.conf | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/conf/machine/raspberrypi2.conf b/conf/machine/raspberrypi2.conf
>>> index 9b4c02a..a17289c 100644
>>> --- a/conf/machine/raspberrypi2.conf
>>> +++ b/conf/machine/raspberrypi2.conf
>>> @@ -7,7 +7,7 @@ DEFAULTTUNE ?= "cortexa7thf-neon-vfpv4"
>>> require conf/machine/include/tune-cortexa7.inc
>>> include conf/machine/include/rpi-base.inc
>>>
>>> -SERIAL_CONSOLE = "115200 ttyAMA0"
>>> +SERIAL_CONSOLE ?= "115200 ttyAMA0"
>>>
>>> UBOOT_MACHINE = "rpi_2_config"
>>> VC4_CMA_SIZE ?= "cma-256"
>>> --
>>> 2.12.2
>>>
>>
>> Entire patch set merged to master and morty.
>>
>
> This is the sort of thing I'm not keen on applying to stable branches
> as it may change recipe behaviour. For comparison, the stable branch
> policy for oe-core is very strict
> (https://wiki.yoctoproject.org/wiki/Stable_branch_maintenance#Policies).
>
> In my mind, avoiding potential breakage on a stable branch is more
> important than making improvements. I'm even weary of updating the
> raspberrypi firmware as I don't know how careful they are about
> backwards compatibility. For kernel updates I do have an expectation
> of backwards compatibility and an understanding that new stable
> releases often fix security issues so I'm ok with those on stable
> branches.
>
> For example of where I'm concerned, a "raspberrypi2" override was
> previously applied to both raspberrypi2 and raspberrypi3 machines.
> After the third patch in this series it only applies to the
> raspberrypi2 machine. Also, UBOOT_MACHINE is now set differently for
> raspberrypi3 ('=' vs '?='). These changes may affect the value of some
> variables when building for raspberrypi3 if downstream users haven't
> explicitly handled both raspberrypi2 and raspberrypi3 overrides. I
> don't mind these sorts of changes on the master branch but I worry
> about applying them to a stable branch.
>
> What do other meta-raspberrypi stable branch users think? Should we be
> pedantic here or should we keep things open so that improvements can
> be applied to stable branches?
I would have to agree with Paul here since you asked :).
I would apply a more strict policy working with stable branches, and
be be more in line with the Yocto policy. That is only bug fixes,
security updates and make sure that build is stable on supported
distributions. Everything else can wait until the next "release" and
reside in master.
My 2 cents.
Best Regards
Mirza
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-04-21 20:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-20 17:18 [meta-raspberrypi][PATCH 1/3] raspberrypi2.conf: Make SERIAL_CONSOLE overwritable Andrei Gherzan
2017-04-20 17:18 ` [meta-raspberrypi][PATCH 2/3] raspberrypi3-64.conf: " Andrei Gherzan
2017-04-20 17:18 ` [meta-raspberrypi][PATCH 3/3] raspberrypi3.conf: Use a stand alone machine configuration Andrei Gherzan
2017-04-21 16:03 ` [meta-raspberrypi][PATCH 1/3] raspberrypi2.conf: Make SERIAL_CONSOLE overwritable Andrei Gherzan
2017-04-21 17:37 ` Paul Barker
2017-04-21 20:09 ` Mirza Krak
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.