All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/5] boost: Upgrade to 1.64.0
@ 2017-04-20 18:20 Khem Raj
  2017-04-20 18:20 ` [PATCH 2/5] valgrind: Fix arm build with gcc7 Khem Raj
                   ` (3 more replies)
  0 siblings, 4 replies; 12+ messages in thread
From: Khem Raj @ 2017-04-20 18:20 UTC (permalink / raw)
  To: openembedded-core

drop upstreamed patches

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 ...bjam-native_1.63.0.bb => bjam-native_1.64.0.bb} |   0
 .../boost/{boost-1.63.0.inc => boost-1.64.0.inc}   |   7 +-
 ...soft-float-on-ARM-we-should-not-expect-th.patch |  29 ---
 ...by-default-when-BOOST_NO_CXX11_HDR_ATOMIC.patch |  59 -----
 meta/recipes-support/boost/boost/py3.patch         | 269 ---------------------
 .../boost/{boost_1.63.0.bb => boost_1.64.0.bb}     |   3 -
 6 files changed, 2 insertions(+), 365 deletions(-)
 rename meta/recipes-support/boost/{bjam-native_1.63.0.bb => bjam-native_1.64.0.bb} (100%)
 rename meta/recipes-support/boost/{boost-1.63.0.inc => boost-1.64.0.inc} (83%)
 delete mode 100644 meta/recipes-support/boost/boost/0001-When-using-soft-float-on-ARM-we-should-not-expect-th.patch
 delete mode 100644 meta/recipes-support/boost/boost/0004-Use-atomic-by-default-when-BOOST_NO_CXX11_HDR_ATOMIC.patch
 delete mode 100644 meta/recipes-support/boost/boost/py3.patch
 rename meta/recipes-support/boost/{boost_1.63.0.bb => boost_1.64.0.bb} (72%)

diff --git a/meta/recipes-support/boost/bjam-native_1.63.0.bb b/meta/recipes-support/boost/bjam-native_1.64.0.bb
similarity index 100%
rename from meta/recipes-support/boost/bjam-native_1.63.0.bb
rename to meta/recipes-support/boost/bjam-native_1.64.0.bb
diff --git a/meta/recipes-support/boost/boost-1.63.0.inc b/meta/recipes-support/boost/boost-1.64.0.inc
similarity index 83%
rename from meta/recipes-support/boost/boost-1.63.0.inc
rename to meta/recipes-support/boost/boost-1.64.0.inc
index 1c1563050c3..2fa63dca6c7 100644
--- a/meta/recipes-support/boost/boost-1.63.0.inc
+++ b/meta/recipes-support/boost/boost-1.64.0.inc
@@ -12,12 +12,9 @@ BOOST_MAJ = "${@"_".join(d.getVar("PV").split(".")[0:2])}"
 BOOST_P = "boost_${BOOST_VER}"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/project/boost/boost/${PV}/${BOOST_P}.tar.bz2"
-
-SRC_URI[md5sum] = "1c837ecd990bb022d07e7aab32b09847"
-SRC_URI[sha256sum] = "beae2529f759f6b3bf3f4969a19c2e9d6f0c503edcb2de4a61d1428519fcb3b0"
+SRC_URI[md5sum] = "93eecce2abed9d2442c9676914709349"
+SRC_URI[sha256sum] = "7bcc5caace97baa948931d712ea5f37038dbb1c5d89b43ad4def4ed7cb683332"
 
 UPSTREAM_CHECK_URI = "https://sourceforge.net/projects/boost/files/"
 
-PR = "r1"
-
 S = "${WORKDIR}/${BOOST_P}"
diff --git a/meta/recipes-support/boost/boost/0001-When-using-soft-float-on-ARM-we-should-not-expect-th.patch b/meta/recipes-support/boost/boost/0001-When-using-soft-float-on-ARM-we-should-not-expect-th.patch
deleted file mode 100644
index bafd5ce001e..00000000000
--- a/meta/recipes-support/boost/boost/0001-When-using-soft-float-on-ARM-we-should-not-expect-th.patch
+++ /dev/null
@@ -1,29 +0,0 @@
-From 9ab0914207e6d0e6b75ce12147c54b96478feb64 Mon Sep 17 00:00:00 2001
-From: Alexander Kanavin <alex.kanavin@gmail.com>
-Date: Tue, 21 Feb 2017 12:50:35 +0200
-Subject: [PATCH] When using soft-float, on ARM we should not expect the FE_*
- symbols
-
-Upstream-Status: Pending
-Signed-off-by: Khem Raj <raj.khem@gmail.com>
-Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
----
- boost/test/execution_monitor.hpp | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/boost/test/execution_monitor.hpp b/boost/test/execution_monitor.hpp
-index f53348a..86252d7 100644
---- a/boost/test/execution_monitor.hpp
-+++ b/boost/test/execution_monitor.hpp
-@@ -498,7 +498,7 @@ enum masks {
- 
-     BOOST_FPE_ALL       = MCW_EM,
- 
--#elif defined(BOOST_NO_FENV_H) || defined(BOOST_CLANG) /* *** */
-+#elif defined(BOOST_NO_FENV_H) || defined(BOOST_CLANG) || defined(__ARM_PCS) /* *** */
-     BOOST_FPE_ALL       = BOOST_FPE_OFF,
- 
- #else /* *** */
--- 
-2.11.0
-
diff --git a/meta/recipes-support/boost/boost/0004-Use-atomic-by-default-when-BOOST_NO_CXX11_HDR_ATOMIC.patch b/meta/recipes-support/boost/boost/0004-Use-atomic-by-default-when-BOOST_NO_CXX11_HDR_ATOMIC.patch
deleted file mode 100644
index ab7826ba266..00000000000
--- a/meta/recipes-support/boost/boost/0004-Use-atomic-by-default-when-BOOST_NO_CXX11_HDR_ATOMIC.patch
+++ /dev/null
@@ -1,59 +0,0 @@
-From c234cc557f60729e071d6da59747c1a9289555c5 Mon Sep 17 00:00:00 2001
-From: Peter Dimov <pdimov@pdimov.com>
-Date: Sun, 28 Aug 2016 21:28:21 +0300
-Subject: [PATCH 4/4] Use <atomic> by default when BOOST_NO_CXX11_HDR_ATOMIC is
- not defined
-
----
-Upstream-Status: Backport [https://github.com/boostorg/smart_ptr/commit/20fedcff2ca3143503ec4e876d47745ab0ec7b0c]
-Signed-off-by: André Draszik <git@andred.net>
- boost/smart_ptr/detail/atomic_count.hpp    | 3 +++
- boost/smart_ptr/detail/sp_counted_base.hpp | 3 +++
- boost/smart_ptr/detail/spinlock.hpp        | 3 +++
- 3 files changed, 9 insertions(+)
-
-diff --git a/boost/smart_ptr/detail/atomic_count.hpp b/boost/smart_ptr/detail/atomic_count.hpp
-index 8aefd44..6e4f71a 100644
---- a/boost/smart_ptr/detail/atomic_count.hpp
-+++ b/boost/smart_ptr/detail/atomic_count.hpp
-@@ -73,6 +73,9 @@
- #elif defined( BOOST_DISABLE_THREADS ) && !defined( BOOST_SP_ENABLE_THREADS ) && !defined( BOOST_DISABLE_WIN32 )
- # include <boost/smart_ptr/detail/atomic_count_nt.hpp>
- 
-+#elif !defined( BOOST_NO_CXX11_HDR_ATOMIC )
-+# include <boost/smart_ptr/detail/atomic_count_std_atomic.hpp>
-+
- #elif defined( __GNUC__ ) && ( defined( __i386__ ) || defined( __x86_64__ ) ) && !defined( __PATHSCALE__ )
- # include <boost/smart_ptr/detail/atomic_count_gcc_x86.hpp>
- 
-diff --git a/boost/smart_ptr/detail/sp_counted_base.hpp b/boost/smart_ptr/detail/sp_counted_base.hpp
-index 0995ca8..83ede23 100644
---- a/boost/smart_ptr/detail/sp_counted_base.hpp
-+++ b/boost/smart_ptr/detail/sp_counted_base.hpp
-@@ -44,6 +44,9 @@
- #elif defined( BOOST_SP_HAS_CLANG_C11_ATOMICS )
- # include <boost/smart_ptr/detail/sp_counted_base_clang.hpp>
- 
-+#elif !defined( BOOST_NO_CXX11_HDR_ATOMIC )
-+# include <boost/smart_ptr/detail/sp_counted_base_std_atomic.hpp>
-+
- #elif defined( __SNC__ )
- # include <boost/smart_ptr/detail/sp_counted_base_snc_ps3.hpp>
- 
-diff --git a/boost/smart_ptr/detail/spinlock.hpp b/boost/smart_ptr/detail/spinlock.hpp
-index 19f93d7..0b618df 100644
---- a/boost/smart_ptr/detail/spinlock.hpp
-+++ b/boost/smart_ptr/detail/spinlock.hpp
-@@ -43,6 +43,9 @@
- #elif defined( BOOST_SP_USE_PTHREADS )
- #  include <boost/smart_ptr/detail/spinlock_pt.hpp>
- 
-+#elif !defined( BOOST_NO_CXX11_HDR_ATOMIC )
-+#  include <boost/smart_ptr/detail/spinlock_std_atomic.hpp>
-+
- #elif defined(__GNUC__) && defined( __arm__ ) && !defined( __thumb__ )
- #  include <boost/smart_ptr/detail/spinlock_gcc_arm.hpp>
- 
--- 
-2.9.3
-
diff --git a/meta/recipes-support/boost/boost/py3.patch b/meta/recipes-support/boost/boost/py3.patch
deleted file mode 100644
index 2b1ff1865e9..00000000000
--- a/meta/recipes-support/boost/boost/py3.patch
+++ /dev/null
@@ -1,269 +0,0 @@
-Backport fixes from upstream (as of boost super-module commit 0d52b9) to improve
-the building of the Boost Python module with Python 3.
-
-Upstream-Status: Backport
-Signed-off-by: Ross Burton <ross.burton@intel.com>
-
-diff --git a/build/Jamfile b/build/Jamfile
-index 313fdab..f14dc11 100644
---- a/libs/python/build/Jamfile
-+++ b/libs/python/build/Jamfile
-@@ -6,6 +6,7 @@ import os ;
- import indirect ;
- import modules ;
- import feature ;
-+import property ;
- 
- import python ;
- 
-@@ -30,21 +31,8 @@ else
-         ;
- }
- 
--rule find-py3-version
--{
--    local versions = [ feature.values python ] ;
--    local py3ver ;
--    for local v in $(versions)
--    {
--        if $(v) >= 3.0
--        {
--            py3ver = $(v) ;
--        }
--    }
--    return $(py3ver) ;
--}
--
--py3-version = [ find-py3-version ] ;
-+py2-version = [ py-version 2 ] ;
-+py3-version = [ py-version 3 ] ;
- 
- project boost/python
-   : source-location ../src
-@@ -52,11 +40,17 @@ project boost/python
- 
- rule cond ( test ? : yes * : no * ) { if $(test) { return $(yes) ; } else { return $(no) ; } }
- rule unless ( test ? : yes * : no * ) { if ! $(test) { return $(yes) ; } else { return $(no) ; } }
-+local rule eq ( a : b ) { if $(a) = $(b) { return 1 ; } }
- 
--rule lib_boost_python ( is-py3 ? )
--{
-+lib_boost_python(2) = boost_python ;
-+lib_boost_python(3) = boost_python3 ;
- 
--    lib [ cond $(is-py3) : boost_python3 : boost_python ]
-+lib_boost_python($(py2-version)) = $(lib_boost_python(2)) ;
-+lib_boost_python($(py3-version)) = $(lib_boost_python(3)) ;
-+
-+rule lib_boost_python ( version )
-+{
-+    lib $(lib_boost_python($(version)))
-         : # sources
-         numeric.cpp
-         list.cpp
-@@ -112,11 +106,13 @@ rule lib_boost_python ( is-py3 ? )
-             <dependency>config-warning
- 
-             <python-debugging>on:<define>BOOST_DEBUG_PYTHON
--            [ cond $(is-py3) : <python>$(py3-version) ]
-+            <python>$(version)
- 
-             -<tag>@$(BOOST_JAMROOT_MODULE)%$(BOOST_JAMROOT_MODULE).tag
-             <tag>@$(BOOST_JAMROOT_MODULE)%$(BOOST_JAMROOT_MODULE).python-tag
- 
-+            <conditional>@python.require-py
-+
-         :   # default build
-             <link>shared
-         :   # usage requirements
-@@ -125,51 +121,68 @@ rule lib_boost_python ( is-py3 ? )
-         ;
- }
- 
--rule lib_boost_numpy ( is-py3 ? )
-+lib_boost_numpy(2) = boost_numpy ;
-+lib_boost_numpy(3) = boost_numpy3 ;
-+
-+lib_boost_numpy($(py2-version)) = $(lib_boost_python(2)) ;
-+lib_boost_numpy($(py3-version)) = $(lib_boost_python(3)) ;
-+
-+rule lib_boost_numpy ( version )
- {
-     numpy-include = [ python.numpy-include ] ;
--    lib [ cond $(is-py3) : boost_numpy3 : boost_numpy ]
-+    lib $(lib_boost_numpy($(version)))
-         : # sources
-         numpy/dtype.cpp
-         numpy/matrix.cpp
-         numpy/ndarray.cpp
--	numpy/numpy.cpp
--	numpy/scalars.cpp
--	numpy/ufunc.cpp
-+        numpy/numpy.cpp
-+        numpy/scalars.cpp
-+        numpy/ufunc.cpp
-         :   # requirements
-+            <link>static:<define>BOOST_NUMPY_STATIC_LIB 
-+            <define>BOOST_NUMPY_SOURCE
-             [ cond [ python.numpy ] : <library>/python//python_for_extensions ]
-             [ unless [ python.numpy ] : <build>no ]
--	    <include>$(numpy-include)
--	    <library>boost_python
-+            <include>$(numpy-include)
-+            <library>$(lib_boost_python($(version)))
-             <python-debugging>on:<define>BOOST_DEBUG_PYTHON
--            [ cond $(is-py3) : <python>$(py3-version) ]
-+            <python>$(version)
- 
-             -<tag>@$(BOOST_JAMROOT_MODULE)%$(BOOST_JAMROOT_MODULE).tag
-             <tag>@$(BOOST_JAMROOT_MODULE)%$(BOOST_JAMROOT_MODULE).python-tag
- 
-+            <conditional>@python.require-py
-+
-         :   # default build
-             <link>shared
-         :   # usage requirements
-+			<link>static:<define>BOOST_NUMPY_STATIC_LIB
-             <python-debugging>on:<define>BOOST_DEBUG_PYTHON
-         ;
- }
- 
--libraries = boost_python ;
--libraries3 = boost_python3 ;
--if [ python.numpy ]
--{
--    libraries += boost_numpy ;
--    libraries3 += boost_numpy3 ;
--}
--
--lib_boost_python ;
--lib_boost_numpy ;
-+libraries = ;
- 
--if $(py3-version)
-+for local N in 2 3
- {
--    lib_boost_python yes ;
--    lib_boost_numpy yes ;
--    libraries += $(libraries3) ;
-+    if $(py$(N)-version)
-+    {
-+        lib_boost_python $(py$(N)-version) ;
-+        libraries += $(lib_boost_python($(py$(N)-version))) ;
-+    }
-+    else
-+    {
-+        alias $(lib_boost_python($(N))) ;
-+    }
-+    if $(py$(N)-version) && [ python.numpy ]
-+    {
-+        lib_boost_numpy $(py$(N)-version) ;
-+        libraries += $(lib_boost_numpy($(py$(N)-version))) ;
-+    }
-+    else
-+    {
-+        alias $(lib_boost_numpy($(N))) ;
-+    }
- }
- 
- boost-install $(libraries) ;
-diff --git a/src/tools/python.jam b/src/tools/python.jam
-index cc13385..bf300b8 100644
---- a/tools/build/src/tools/python.jam
-+++ b/tools/build/src/tools/python.jam
-@@ -34,6 +34,7 @@ import path ;
- import feature ;
- import set ;
- import builtin ;
-+import property-set ;
- 
- 
- # Make this module a project.
-@@ -60,6 +61,10 @@ lib rt ;
- # installed in the development system's default paths.
- feature.feature pythonpath : : free optional path ;
- 
-+# The best configured version of Python 2 and 3.
-+py2-version = ;
-+py3-version = ;
-+
- # Initializes the Python toolset. Note that all parameters are optional.
- #
- # - version -- the version of Python to use. Should be in Major.Minor format,
-@@ -861,6 +866,11 @@ local rule configure ( version ? : cmd-or-prefix ? : includes * : libraries ? :
-         if ! $(version) in [ feature.values python ]
-         {
-             feature.extend python : $(version) ;
-+            py$(major-minor[1])-version ?= $(version) ;
-+            if $(py$(major-minor[1])-version) < $(version)
-+            {
-+                py$(major-minor[1])-version = $(version) ;
-+            }
-         }
-         target-requirements += <python>$(version:E=default) ;
-     }
-@@ -916,6 +926,9 @@ local rule configure ( version ? : cmd-or-prefix ? : includes * : libraries ? :
-         }
-     }
- 
-+    # In case we added duplicate requirements from what the user specified.
-+    target-requirements = [ sequence.unique $(target-requirements) ] ;
-+
-     # Global, but conditional, requirements to give access to the interpreter
-     # for general utilities, like other toolsets, that run Python scripts.
-     toolset.add-requirements
-@@ -934,19 +947,6 @@ local rule configure ( version ? : cmd-or-prefix ? : includes * : libraries ? :
-         toolset.add-requirements <target-os>$(target-os):<python>$(version:E=default) ;
-     }
- 
--    # We also set a default requirement that assigns the first python configured
--    # for a particular target OS as the default. This makes it so that we can
--    # select a python interpreter with only knowledge of the target OS. And hence
--    # can configure different Pythons based on the target OS only.
--    local toolset-requirements = [ toolset.requirements ] ;
--    local toolset-target-os-requirements
--        = [ property.evaluate-conditionals-in-context
--            [ $(toolset-requirements).raw ] : <target-os>$(target-os) ] ;
--    if ! <python> in $(toolset-target-os-requirements:G)
--    {
--        toolset.add-requirements <target-os>$(target-os):<python>$(version:E=default) ;
--    }
--
-     # Register the right suffix for extensions.
-     register-extension-suffix $(extension-suffix) : $(target-requirements) ;
- 
-@@ -1038,6 +1038,22 @@ local rule configure ( version ? : cmd-or-prefix ? : includes * : libraries ? :
-             : $(usage-requirements)
-             ;
-     }
-+    
-+}
-+
-+# Conditional rule specification that will prevent building of a target
-+# if there is no matching python configuration available with the given
-+# required properties.
-+rule require-py ( properties * )
-+{
-+    local py-ext-target = [ $(.project).find python_for_extensions ] ;
-+    local property-set = [ property-set.create $(properties) ] ;
-+    property-set = [ $(property-set).expand ] ;
-+    local py-ext-alternative = [ $(py-ext-target).select-alternatives $(property-set) ] ;
-+    if ! $(py-ext-alternative)
-+    {
-+        return <build>no ;
-+    }
- }
- 
- 
-@@ -1298,5 +1314,11 @@ rule numpy-test ( name : sources * : requirements * )
-         : $(name) ] ;
- }
- 
-+rule py-version ( n )
-+{
-+    return $(py$(n)-version) ;
-+}
-+
- IMPORT $(__name__) : bpl-test : : bpl-test ;
- IMPORT $(__name__) : numpy-test : : numpy-test ;
-+IMPORT $(__name__) : py-version : : py-version ;
diff --git a/meta/recipes-support/boost/boost_1.63.0.bb b/meta/recipes-support/boost/boost_1.64.0.bb
similarity index 72%
rename from meta/recipes-support/boost/boost_1.63.0.bb
rename to meta/recipes-support/boost/boost_1.64.0.bb
index 1107686bca2..119eb0af452 100644
--- a/meta/recipes-support/boost/boost_1.63.0.bb
+++ b/meta/recipes-support/boost/boost_1.64.0.bb
@@ -3,13 +3,10 @@ require boost.inc
 
 SRC_URI += "\
     file://arm-intrinsics.patch \
-    file://0001-When-using-soft-float-on-ARM-we-should-not-expect-th.patch \
     file://boost-CVE-2012-2677.patch \
     file://0001-boost-asio-detail-socket_types.hpp-fix-poll.h-includ.patch \
-    file://0004-Use-atomic-by-default-when-BOOST_NO_CXX11_HDR_ATOMIC.patch \
     file://boost-math-disable-pch-for-gcc.patch \
     file://0001-Apply-boost-1.62.0-no-forced-flags.patch.patch \
     file://0003-Don-t-set-up-arch-instruction-set-flags-we-do-that-o.patch \
     file://0002-Don-t-set-up-m32-m64-we-do-that-ourselves.patch \
-    file://py3.patch \
 "
-- 
2.12.2



^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 2/5] valgrind: Fix arm build with gcc7
  2017-04-20 18:20 [PATCH 1/5] boost: Upgrade to 1.64.0 Khem Raj
@ 2017-04-20 18:20 ` Khem Raj
  2017-04-21  0:56   ` Andre McCurdy
  2017-04-20 18:20 ` [PATCH 3/5] bitbake.conf: Add pr to list of hosttools Khem Raj
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 12+ messages in thread
From: Khem Raj @ 2017-04-20 18:20 UTC (permalink / raw)
  To: openembedded-core

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 ...rop-setting-mcpu-to-cortex-a8-on-arm-arch.patch | 108 +++++++++++++++++++++
 meta/recipes-devtools/valgrind/valgrind_3.12.0.bb  |   3 +-
 2 files changed, 110 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-devtools/valgrind/valgrind/0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch

diff --git a/meta/recipes-devtools/valgrind/valgrind/0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch b/meta/recipes-devtools/valgrind/valgrind/0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch
new file mode 100644
index 00000000000..9f1da7bac68
--- /dev/null
+++ b/meta/recipes-devtools/valgrind/valgrind/0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch
@@ -0,0 +1,108 @@
+From 715cf122388f3527afa5649cebf9f1522c240693 Mon Sep 17 00:00:00 2001
+From: Khem Raj <raj.khem@gmail.com>
+Date: Thu, 20 Apr 2017 10:11:16 -0700
+Subject: [PATCH] makefiles: Drop setting -mcpu to cortex-a8 on arm
+ architecture
+
+We can not assume that all arches armv7+ are cortex-a8 only
+it fails to build for rpi which is armv7ve based (cortex-a8) cpu
+implementation.
+Fixes
+| cc1: warning: switch -mcpu=cortex-a8 conflicts with -march=armv7ve switch
+
+Upstream-Status: Pending
+
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+---
+ Makefile.all.am            |  6 +++---
+ helgrind/tests/Makefile.am |  6 +++---
+ none/tests/arm/Makefile.am | 18 +++++++++---------
+ 3 files changed, 15 insertions(+), 15 deletions(-)
+
+diff --git a/Makefile.all.am b/Makefile.all.am
+index 02059a3..c7c4700 100644
+--- a/Makefile.all.am
++++ b/Makefile.all.am
+@@ -197,11 +197,11 @@ AM_CCASFLAGS_PPC64LE_LINUX  = @FLAG_M64@ -g
+ 
+ AM_FLAG_M3264_ARM_LINUX   = @FLAG_M32@
+ AM_CFLAGS_ARM_LINUX       = @FLAG_M32@ \
+-			 	$(AM_CFLAGS_BASE) -marm -mcpu=cortex-a8
++			 	$(AM_CFLAGS_BASE) -marm
+ AM_CFLAGS_PSO_ARM_LINUX   = @FLAG_M32@ $(AM_CFLAGS_BASE) \
+-				-marm -mcpu=cortex-a8 $(AM_CFLAGS_PSO_BASE)
++				-marm $(AM_CFLAGS_PSO_BASE)
+ AM_CCASFLAGS_ARM_LINUX    = @FLAG_M32@ \
+-				-marm -mcpu=cortex-a8 -g
++				-marm -g
+ 
+ AM_FLAG_M3264_ARM64_LINUX = @FLAG_M64@
+ AM_CFLAGS_ARM64_LINUX     = @FLAG_M64@ $(AM_CFLAGS_BASE)
+diff --git a/helgrind/tests/Makefile.am b/helgrind/tests/Makefile.am
+index df82169..07eb66a 100644
+--- a/helgrind/tests/Makefile.am
++++ b/helgrind/tests/Makefile.am
+@@ -189,9 +189,9 @@ if ! VGCONF_PLATFORMS_INCLUDE_X86_DARWIN
+ endif
+ 
+ if VGCONF_PLATFORMS_INCLUDE_ARM_LINUX
+-annotate_hbefore_CFLAGS = $(AM_CFLAGS) -mcpu=cortex-a8
+-tc07_hbl1_CFLAGS        = $(AM_CFLAGS) -mcpu=cortex-a8
+-tc08_hbl2_CFLAGS        = $(AM_CFLAGS) -mcpu=cortex-a8
++annotate_hbefore_CFLAGS = $(AM_CFLAGS)
++tc07_hbl1_CFLAGS        = $(AM_CFLAGS)
++tc08_hbl2_CFLAGS        = $(AM_CFLAGS)
+ else
+ annotate_hbefore_CFLAGS = $(AM_CFLAGS)
+ tc07_hbl1_CFLAGS        = $(AM_CFLAGS)
+diff --git a/none/tests/arm/Makefile.am b/none/tests/arm/Makefile.am
+index 024eb6d..ccecb90 100644
+--- a/none/tests/arm/Makefile.am
++++ b/none/tests/arm/Makefile.am
+@@ -52,10 +52,10 @@ allexec_CFLAGS		= $(AM_CFLAGS) @FLAG_W_NO_NONNULL@
+ # need special helping w.r.t -mfpu and -mfloat-abi, though.
+ # Also force -O0 since -O takes hundreds of MB of memory 
+ # for v6intThumb.c.
+-v6intARM_CFLAGS   = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 -marm
+-v6intThumb_CFLAGS = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 -mthumb
++v6intARM_CFLAGS   = $(AM_CFLAGS) -g -O0 -marm
++v6intThumb_CFLAGS = $(AM_CFLAGS) -g -O0 -mthumb
+ 
+-v6media_CFLAGS    = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 -mthumb
++v6media_CFLAGS    = $(AM_CFLAGS) -g -O0 -mthumb
+ 
+ v8crypto_a_CFLAGS = $(AM_CFLAGS) -g -O0 -mfpu=crypto-neon-fp-armv8 -marm
+ v8crypto_t_CFLAGS = $(AM_CFLAGS) -g -O0 -mfpu=crypto-neon-fp-armv8 -mthumb
+@@ -65,23 +65,23 @@ v8memory_a_CFLAGS = $(AM_CFLAGS) -g -O0 \
+ v8memory_t_CFLAGS = $(AM_CFLAGS) -g -O0 \
+ 			-march=armv8-a -mfpu=crypto-neon-fp-armv8 -mthumb
+ 
+-vfp_CFLAGS        = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 \
++vfp_CFLAGS        = $(AM_CFLAGS) -g -O0 \
+ 			-mfpu=neon \
+ 			-mthumb
+ 
+ 
+-neon128_CFLAGS    = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 \
++neon128_CFLAGS    = $(AM_CFLAGS) -g -O0 \
+ 			-mfpu=neon \
+ 			-mthumb
+ 
+-neon64_CFLAGS     = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 \
++neon64_CFLAGS     = $(AM_CFLAGS) -g -O0 \
+ 			-mfpu=neon \
+ 			-mthumb
+ 
+ intdiv_CFLAGS	  = $(AM_CFLAGS) -g -march=armv7ve -mcpu=cortex-a15 -mthumb
+-ldrt_CFLAGS	  = $(AM_CFLAGS) -g -mcpu=cortex-a8 -mthumb
+-ldrt_arm_CFLAGS	  = $(AM_CFLAGS) -g -mcpu=cortex-a8 -marm
++ldrt_CFLAGS	  = $(AM_CFLAGS) -g -mthumb
++ldrt_arm_CFLAGS	  = $(AM_CFLAGS) -g -marm
+ 
+-vcvt_fixed_float_VFP_CFLAGS = $(AM_CFLAGS) -g -mcpu=cortex-a8 -mfpu=vfpv3
++vcvt_fixed_float_VFP_CFLAGS = $(AM_CFLAGS) -g -mfpu=vfpv3
+ 
+ vfpv4_fma_CFLAGS  = $(AM_CFLAGS) -g -O0 -march=armv7ve -mcpu=cortex-a15 -mfpu=vfpv4 -marm
+-- 
+2.12.2
+
diff --git a/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb
index 62a96354cd0..a07c8767ce3 100644
--- a/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb
+++ b/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb
@@ -23,7 +23,8 @@ SRC_URI = "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
            file://use-appropriate-march-mcpu-mfpu-for-ARM-test-apps.patch \
            file://avoid-neon-for-targets-which-don-t-support-it.patch \
            file://valgrind-make-ld-XXX.so-strlen-intercept-optional.patch \
-"
+           file://0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch \
+           "
 SRC_URI_append_libc-musl = "\
            file://0001-fix-build-for-musl-targets.patch \
 "
-- 
2.12.2



^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 3/5] bitbake.conf: Add pr to list of hosttools
  2017-04-20 18:20 [PATCH 1/5] boost: Upgrade to 1.64.0 Khem Raj
  2017-04-20 18:20 ` [PATCH 2/5] valgrind: Fix arm build with gcc7 Khem Raj
@ 2017-04-20 18:20 ` Khem Raj
  2017-04-20 21:30   ` Burton, Ross
  2017-04-20 18:20 ` [PATCH 4/5] gstreamer1.0-libav: Fix build with gcc7 Khem Raj
  2017-04-20 18:20 ` [PATCH 5/5] gnu-efi: " Khem Raj
  3 siblings, 1 reply; 12+ messages in thread
From: Khem Raj @ 2017-04-20 18:20 UTC (permalink / raw)
  To: openembedded-core

pr is used by gstreamer1.0-libav during configure

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/conf/bitbake.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 227babd1b21..16a1fcd9db4 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -458,7 +458,7 @@ HOSTTOOLS += " \
     cpp cut date dd diff diffstat dirname du echo egrep env expand expr false \
     fgrep file find flock g++ gawk gcc getconf getopt git grep gunzip gzip \
     head hostname install ld ldd ln ls make makeinfo md5sum mkdir mknod \
-    mktemp mv nm objcopy objdump od patch perl pod2man printf pwd python \
+    mktemp mv nm objcopy objdump od patch perl pod2man pr printf pwd python \
     python2.7 python3 ranlib readelf readlink rm rmdir rpcgen sed sh sha256sum \
     sleep sort split stat strings strip tail tar tee test touch tr true uname \
     uniq wc wget which xargs \
-- 
2.12.2



^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 4/5] gstreamer1.0-libav: Fix build with gcc7
  2017-04-20 18:20 [PATCH 1/5] boost: Upgrade to 1.64.0 Khem Raj
  2017-04-20 18:20 ` [PATCH 2/5] valgrind: Fix arm build with gcc7 Khem Raj
  2017-04-20 18:20 ` [PATCH 3/5] bitbake.conf: Add pr to list of hosttools Khem Raj
@ 2017-04-20 18:20 ` Khem Raj
  2017-04-20 18:20 ` [PATCH 5/5] gnu-efi: " Khem Raj
  3 siblings, 0 replies; 12+ messages in thread
From: Khem Raj @ 2017-04-20 18:20 UTC (permalink / raw)
  To: openembedded-core

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 .../0001-configure-check-for-armv7ve-variant.patch | 35 ++++++++++++++++++++++
 .../gstreamer/gstreamer1.0-libav_1.10.4.bb         | 12 ++++----
 2 files changed, 41 insertions(+), 6 deletions(-)
 create mode 100644 meta/recipes-multimedia/gstreamer/gstreamer1.0-libav/0001-configure-check-for-armv7ve-variant.patch

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-libav/0001-configure-check-for-armv7ve-variant.patch b/meta/recipes-multimedia/gstreamer/gstreamer1.0-libav/0001-configure-check-for-armv7ve-variant.patch
new file mode 100644
index 00000000000..b80d0739461
--- /dev/null
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-libav/0001-configure-check-for-armv7ve-variant.patch
@@ -0,0 +1,35 @@
+From aac5902d3c9cb35c771e760d0e487622aa2e116a Mon Sep 17 00:00:00 2001
+From: Khem Raj <raj.khem@gmail.com>
+Date: Thu, 20 Apr 2017 10:38:18 -0700
+Subject: [PATCH] configure: check for armv7ve variant
+
+OE passes -mcpu and -march via cmdline and if
+package tries to detect one of it own then it
+should be compatible otherwise, newer gcc7+ will
+error out
+
+Check for relevant preprocessor macro to determine
+armv7ve architecture
+
+Upstream-Status: Pending
+
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+---
+ gst-libs/ext/libav/configure | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/gst-libs/ext/libav/configure b/gst-libs/ext/libav/configure
+index 4a5e477..727818e 100755
+--- a/gst-libs/ext/libav/configure
++++ b/gst-libs/ext/libav/configure
+@@ -4295,6 +4295,7 @@ elif enabled arm; then
+         elif check_arm_arch 6Z;       then echo armv6z
+         elif check_arm_arch 6ZK;      then echo armv6zk
+         elif check_arm_arch 6T2;      then echo armv6t2
++        elif check_arm_arch EXT_IDIV; then echo armv7ve
+         elif check_arm_arch 7;        then echo armv7
+         elif check_arm_arch 7A  7_A;  then echo armv7-a
+         elif check_arm_arch 7S;       then echo armv7-a
+-- 
+2.12.2
+
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-libav_1.10.4.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-libav_1.10.4.bb
index 59d81db03ab..e4bb477c7a0 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-libav_1.10.4.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-libav_1.10.4.bb
@@ -8,12 +8,12 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
                     file://gst-libs/ext/libav/COPYING.LGPLv2.1;md5=bd7a443320af8c812e4c18d1b79df004 \
                     file://gst-libs/ext/libav/COPYING.LGPLv3;md5=e6a600fd5e1d9cbde2d983680233ad02"
 
-SRC_URI = " \
-    http://gstreamer.freedesktop.org/src/gst-libav/gst-libav-${PV}.tar.xz \
-    file://0001-Disable-yasm-for-libav-when-disable-yasm.patch \
-    file://workaround-to-build-gst-libav-for-i586-with-gcc.patch \
-    file://mips64_cpu_detection.patch \
-"
+SRC_URI = "http://gstreamer.freedesktop.org/src/gst-libav/gst-libav-${PV}.tar.xz \
+           file://0001-Disable-yasm-for-libav-when-disable-yasm.patch \
+           file://workaround-to-build-gst-libav-for-i586-with-gcc.patch \
+           file://mips64_cpu_detection.patch \
+           file://0001-configure-check-for-armv7ve-variant.patch \
+           "
 SRC_URI[md5sum] = "e2bdd9fde6ca3ff7efffb93df121f4fd"
 SRC_URI[sha256sum] = "6ca0feca75e3d48315e07f20ec37cf6260ed1e9dde58df355febd5016246268b"
 
-- 
2.12.2



^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 5/5] gnu-efi: Fix build with gcc7
  2017-04-20 18:20 [PATCH 1/5] boost: Upgrade to 1.64.0 Khem Raj
                   ` (2 preceding siblings ...)
  2017-04-20 18:20 ` [PATCH 4/5] gstreamer1.0-libav: Fix build with gcc7 Khem Raj
@ 2017-04-20 18:20 ` Khem Raj
  3 siblings, 0 replies; 12+ messages in thread
From: Khem Raj @ 2017-04-20 18:20 UTC (permalink / raw)
  To: openembedded-core

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 ...plicit-fall-through-so-Wextra-will-work-i.patch | 34 ++++++++++++++++++++++
 meta/recipes-bsp/gnu-efi/gnu-efi_3.0.5.bb          |  3 +-
 2 files changed, 36 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-bsp/gnu-efi/gnu-efi/0001-Mark-our-explicit-fall-through-so-Wextra-will-work-i.patch

diff --git a/meta/recipes-bsp/gnu-efi/gnu-efi/0001-Mark-our-explicit-fall-through-so-Wextra-will-work-i.patch b/meta/recipes-bsp/gnu-efi/gnu-efi/0001-Mark-our-explicit-fall-through-so-Wextra-will-work-i.patch
new file mode 100644
index 00000000000..d0aeb2d560d
--- /dev/null
+++ b/meta/recipes-bsp/gnu-efi/gnu-efi/0001-Mark-our-explicit-fall-through-so-Wextra-will-work-i.patch
@@ -0,0 +1,34 @@
+From 676a8a9001f06808b4dbe0a545d76b5d9a8ebf48 Mon Sep 17 00:00:00 2001
+From: Peter Jones <pjones@redhat.com>
+Date: Thu, 2 Feb 2017 13:51:27 -0500
+Subject: [PATCH] Mark our explicit fall through so -Wextra will work in gcc 7
+
+gcc 7 introduces detection of fall-through behavior in switch/case
+statements, and will warn if -Wimplicit-fallthrough is present and there
+is no comment stating that the fall-through is intentional.  This is
+also triggered by -Wextra, as it enables -Wimplicit-fallthrough=1.
+
+This patch adds the comment in the one place we use fall-through.
+
+Signed-off-by: Peter Jones <pjones@redhat.com>
+---
+Upstream-Status: Pending
+
+ lib/print.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/lib/print.c b/lib/print.c
+index b8a9d38..cb732f0 100644
+--- a/lib/print.c
++++ b/lib/print.c
+@@ -1131,6 +1131,7 @@ Returns:
+             case 'X':
+                 Item.Width = Item.Long ? 16 : 8;
+                 Item.Pad = '0';
++		/* falls through */
+             case 'x':
+                 ValueToHex (
+                     Item.Scratch,
+-- 
+2.12.2
+
diff --git a/meta/recipes-bsp/gnu-efi/gnu-efi_3.0.5.bb b/meta/recipes-bsp/gnu-efi/gnu-efi_3.0.5.bb
index 6f235b7455c..d6f9f536d08 100644
--- a/meta/recipes-bsp/gnu-efi/gnu-efi_3.0.5.bb
+++ b/meta/recipes-bsp/gnu-efi/gnu-efi_3.0.5.bb
@@ -16,7 +16,8 @@ SRC_URI = "${SOURCEFORGE_MIRROR}/${BPN}/${BP}.tar.bz2 \
            file://parallel-make-archives.patch \
            file://lib-Makefile-fix-parallel-issue.patch \
            file://gcc46-compatibility.patch \
-          "
+           file://0001-Mark-our-explicit-fall-through-so-Wextra-will-work-i.patch \
+           "
 
 SRC_URI[md5sum] = "1f719c9c135778aa6b087b89a1cc2423"
 SRC_URI[sha256sum] = "bd8fcd5914f18fc0e4ba948ab03b00013e528504f529c60739b748f6ef130b22"
-- 
2.12.2



^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH 3/5] bitbake.conf: Add pr to list of hosttools
  2017-04-20 18:20 ` [PATCH 3/5] bitbake.conf: Add pr to list of hosttools Khem Raj
@ 2017-04-20 21:30   ` Burton, Ross
  2017-04-20 21:32     ` Khem Raj
  0 siblings, 1 reply; 12+ messages in thread
From: Burton, Ross @ 2017-04-20 21:30 UTC (permalink / raw)
  To: Khem Raj; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

On 20 April 2017 at 19:20, Khem Raj <raj.khem@gmail.com> wrote:

> pr is used by gstreamer1.0-libav during configure
>

So how does this work at the moment, or what's the problem with it failing?

Ross

[-- Attachment #2: Type: text/html, Size: 619 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 3/5] bitbake.conf: Add pr to list of hosttools
  2017-04-20 21:30   ` Burton, Ross
@ 2017-04-20 21:32     ` Khem Raj
  0 siblings, 0 replies; 12+ messages in thread
From: Khem Raj @ 2017-04-20 21:32 UTC (permalink / raw)
  To: Burton, Ross; +Cc: OE-core

On Thu, Apr 20, 2017 at 2:30 PM, Burton, Ross <ross.burton@intel.com> wrote:
>
> On 20 April 2017 at 19:20, Khem Raj <raj.khem@gmail.com> wrote:
>>
>> pr is used by gstreamer1.0-libav during configure
>
>
> So how does this work at the moment, or what's the problem with it failing?
>

I build for rpi3 may be thats why you are not seeing it.

> Ross


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/5] valgrind: Fix arm build with gcc7
  2017-04-20 18:20 ` [PATCH 2/5] valgrind: Fix arm build with gcc7 Khem Raj
@ 2017-04-21  0:56   ` Andre McCurdy
  2017-04-21  1:06     ` Khem Raj
  0 siblings, 1 reply; 12+ messages in thread
From: Andre McCurdy @ 2017-04-21  0:56 UTC (permalink / raw)
  To: Khem Raj; +Cc: OE Core mailing list

On Thu, Apr 20, 2017 at 11:20 AM, Khem Raj <raj.khem@gmail.com> wrote:
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  ...rop-setting-mcpu-to-cortex-a8-on-arm-arch.patch | 108 +++++++++++++++++++++
>  meta/recipes-devtools/valgrind/valgrind_3.12.0.bb  |   3 +-
>  2 files changed, 110 insertions(+), 1 deletion(-)
>  create mode 100644 meta/recipes-devtools/valgrind/valgrind/0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch
>
> diff --git a/meta/recipes-devtools/valgrind/valgrind/0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch b/meta/recipes-devtools/valgrind/valgrind/0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch
> new file mode 100644
> index 00000000000..9f1da7bac68
> --- /dev/null
> +++ b/meta/recipes-devtools/valgrind/valgrind/0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch
> @@ -0,0 +1,108 @@
> +From 715cf122388f3527afa5649cebf9f1522c240693 Mon Sep 17 00:00:00 2001
> +From: Khem Raj <raj.khem@gmail.com>
> +Date: Thu, 20 Apr 2017 10:11:16 -0700
> +Subject: [PATCH] makefiles: Drop setting -mcpu to cortex-a8 on arm
> + architecture
> +
> +We can not assume that all arches armv7+ are cortex-a8 only
> +it fails to build for rpi which is armv7ve based (cortex-a8) cpu
> +implementation.
> +Fixes
> +| cc1: warning: switch -mcpu=cortex-a8 conflicts with -march=armv7ve switch

The valgrind tests are built for fixed CPU targets which are known to
support the instructions being tested (since those instructions may
not be supported by the target CPU which valgrind itself is being
built for).

It may be safer to add -march=armv7a to the -mcpu=cortex-a8 tests (and
ensure that -march=armv7ve doesn't leak through) rather than remove
-mcpu=cortex-a8.

See the comments in:

  http://git.openembedded.org/openembedded-core/commit/?id=3e94af90d90f6db6bab66ae87a47b31f3a0474f6

The change to the toplevel Makefile.all.am looks OK.

> +Upstream-Status: Pending
> +
> +Signed-off-by: Khem Raj <raj.khem@gmail.com>
> +---
> + Makefile.all.am            |  6 +++---
> + helgrind/tests/Makefile.am |  6 +++---
> + none/tests/arm/Makefile.am | 18 +++++++++---------
> + 3 files changed, 15 insertions(+), 15 deletions(-)
> +
> +diff --git a/Makefile.all.am b/Makefile.all.am
> +index 02059a3..c7c4700 100644
> +--- a/Makefile.all.am
> ++++ b/Makefile.all.am
> +@@ -197,11 +197,11 @@ AM_CCASFLAGS_PPC64LE_LINUX  = @FLAG_M64@ -g
> +
> + AM_FLAG_M3264_ARM_LINUX   = @FLAG_M32@
> + AM_CFLAGS_ARM_LINUX       = @FLAG_M32@ \
> +-                              $(AM_CFLAGS_BASE) -marm -mcpu=cortex-a8
> ++                              $(AM_CFLAGS_BASE) -marm
> + AM_CFLAGS_PSO_ARM_LINUX   = @FLAG_M32@ $(AM_CFLAGS_BASE) \
> +-                              -marm -mcpu=cortex-a8 $(AM_CFLAGS_PSO_BASE)
> ++                              -marm $(AM_CFLAGS_PSO_BASE)
> + AM_CCASFLAGS_ARM_LINUX    = @FLAG_M32@ \
> +-                              -marm -mcpu=cortex-a8 -g
> ++                              -marm -g
> +
> + AM_FLAG_M3264_ARM64_LINUX = @FLAG_M64@
> + AM_CFLAGS_ARM64_LINUX     = @FLAG_M64@ $(AM_CFLAGS_BASE)
> +diff --git a/helgrind/tests/Makefile.am b/helgrind/tests/Makefile.am
> +index df82169..07eb66a 100644
> +--- a/helgrind/tests/Makefile.am
> ++++ b/helgrind/tests/Makefile.am
> +@@ -189,9 +189,9 @@ if ! VGCONF_PLATFORMS_INCLUDE_X86_DARWIN
> + endif
> +
> + if VGCONF_PLATFORMS_INCLUDE_ARM_LINUX
> +-annotate_hbefore_CFLAGS = $(AM_CFLAGS) -mcpu=cortex-a8
> +-tc07_hbl1_CFLAGS        = $(AM_CFLAGS) -mcpu=cortex-a8
> +-tc08_hbl2_CFLAGS        = $(AM_CFLAGS) -mcpu=cortex-a8
> ++annotate_hbefore_CFLAGS = $(AM_CFLAGS)
> ++tc07_hbl1_CFLAGS        = $(AM_CFLAGS)
> ++tc08_hbl2_CFLAGS        = $(AM_CFLAGS)
> + else
> + annotate_hbefore_CFLAGS = $(AM_CFLAGS)
> + tc07_hbl1_CFLAGS        = $(AM_CFLAGS)
> +diff --git a/none/tests/arm/Makefile.am b/none/tests/arm/Makefile.am
> +index 024eb6d..ccecb90 100644
> +--- a/none/tests/arm/Makefile.am
> ++++ b/none/tests/arm/Makefile.am
> +@@ -52,10 +52,10 @@ allexec_CFLAGS             = $(AM_CFLAGS) @FLAG_W_NO_NONNULL@
> + # need special helping w.r.t -mfpu and -mfloat-abi, though.
> + # Also force -O0 since -O takes hundreds of MB of memory
> + # for v6intThumb.c.
> +-v6intARM_CFLAGS   = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 -marm
> +-v6intThumb_CFLAGS = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 -mthumb
> ++v6intARM_CFLAGS   = $(AM_CFLAGS) -g -O0 -marm
> ++v6intThumb_CFLAGS = $(AM_CFLAGS) -g -O0 -mthumb
> +
> +-v6media_CFLAGS    = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 -mthumb
> ++v6media_CFLAGS    = $(AM_CFLAGS) -g -O0 -mthumb
> +
> + v8crypto_a_CFLAGS = $(AM_CFLAGS) -g -O0 -mfpu=crypto-neon-fp-armv8 -marm
> + v8crypto_t_CFLAGS = $(AM_CFLAGS) -g -O0 -mfpu=crypto-neon-fp-armv8 -mthumb
> +@@ -65,23 +65,23 @@ v8memory_a_CFLAGS = $(AM_CFLAGS) -g -O0 \
> + v8memory_t_CFLAGS = $(AM_CFLAGS) -g -O0 \
> +                       -march=armv8-a -mfpu=crypto-neon-fp-armv8 -mthumb
> +
> +-vfp_CFLAGS        = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 \
> ++vfp_CFLAGS        = $(AM_CFLAGS) -g -O0 \
> +                       -mfpu=neon \
> +                       -mthumb
> +
> +
> +-neon128_CFLAGS    = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 \
> ++neon128_CFLAGS    = $(AM_CFLAGS) -g -O0 \
> +                       -mfpu=neon \
> +                       -mthumb
> +
> +-neon64_CFLAGS     = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 \
> ++neon64_CFLAGS     = $(AM_CFLAGS) -g -O0 \
> +                       -mfpu=neon \
> +                       -mthumb
> +
> + intdiv_CFLAGS   = $(AM_CFLAGS) -g -march=armv7ve -mcpu=cortex-a15 -mthumb
> +-ldrt_CFLAGS     = $(AM_CFLAGS) -g -mcpu=cortex-a8 -mthumb
> +-ldrt_arm_CFLAGS         = $(AM_CFLAGS) -g -mcpu=cortex-a8 -marm
> ++ldrt_CFLAGS     = $(AM_CFLAGS) -g -mthumb
> ++ldrt_arm_CFLAGS         = $(AM_CFLAGS) -g -marm
> +
> +-vcvt_fixed_float_VFP_CFLAGS = $(AM_CFLAGS) -g -mcpu=cortex-a8 -mfpu=vfpv3
> ++vcvt_fixed_float_VFP_CFLAGS = $(AM_CFLAGS) -g -mfpu=vfpv3
> +
> + vfpv4_fma_CFLAGS  = $(AM_CFLAGS) -g -O0 -march=armv7ve -mcpu=cortex-a15 -mfpu=vfpv4 -marm
> +--
> +2.12.2
> +
> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb
> index 62a96354cd0..a07c8767ce3 100644
> --- a/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb
> +++ b/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb
> @@ -23,7 +23,8 @@ SRC_URI = "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
>             file://use-appropriate-march-mcpu-mfpu-for-ARM-test-apps.patch \
>             file://avoid-neon-for-targets-which-don-t-support-it.patch \
>             file://valgrind-make-ld-XXX.so-strlen-intercept-optional.patch \
> -"
> +           file://0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch \
> +           "
>  SRC_URI_append_libc-musl = "\
>             file://0001-fix-build-for-musl-targets.patch \
>  "
> --
> 2.12.2
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/5] valgrind: Fix arm build with gcc7
  2017-04-21  0:56   ` Andre McCurdy
@ 2017-04-21  1:06     ` Khem Raj
  2017-04-21  1:29       ` Andre McCurdy
  0 siblings, 1 reply; 12+ messages in thread
From: Khem Raj @ 2017-04-21  1:06 UTC (permalink / raw)
  To: Andre McCurdy; +Cc: OE Core mailing list

On Thu, Apr 20, 2017 at 5:56 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
> On Thu, Apr 20, 2017 at 11:20 AM, Khem Raj <raj.khem@gmail.com> wrote:
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>>  ...rop-setting-mcpu-to-cortex-a8-on-arm-arch.patch | 108 +++++++++++++++++++++
>>  meta/recipes-devtools/valgrind/valgrind_3.12.0.bb  |   3 +-
>>  2 files changed, 110 insertions(+), 1 deletion(-)
>>  create mode 100644 meta/recipes-devtools/valgrind/valgrind/0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch
>>
>> diff --git a/meta/recipes-devtools/valgrind/valgrind/0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch b/meta/recipes-devtools/valgrind/valgrind/0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch
>> new file mode 100644
>> index 00000000000..9f1da7bac68
>> --- /dev/null
>> +++ b/meta/recipes-devtools/valgrind/valgrind/0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch
>> @@ -0,0 +1,108 @@
>> +From 715cf122388f3527afa5649cebf9f1522c240693 Mon Sep 17 00:00:00 2001
>> +From: Khem Raj <raj.khem@gmail.com>
>> +Date: Thu, 20 Apr 2017 10:11:16 -0700
>> +Subject: [PATCH] makefiles: Drop setting -mcpu to cortex-a8 on arm
>> + architecture
>> +
>> +We can not assume that all arches armv7+ are cortex-a8 only
>> +it fails to build for rpi which is armv7ve based (cortex-a8) cpu
>> +implementation.
>> +Fixes
>> +| cc1: warning: switch -mcpu=cortex-a8 conflicts with -march=armv7ve switch
>
> The valgrind tests are built for fixed CPU targets which are known to
> support the instructions being tested (since those instructions may
> not be supported by the target CPU which valgrind itself is being
> built for).
>
> It may be safer to add -march=armv7a to the -mcpu=cortex-a8 tests (and
> ensure that -march=armv7ve doesn't leak through) rather than remove
> -mcpu=cortex-a8.

OE always passes mcpu flags, therefore it wont be an issue unless you
are saying thats not the case. For upstreaming it might be OK, but I
think this will need a different for upstreaming since it should
configure mcpu/march based on some configure input or some such
instead of hardcoding it.

>
> See the comments in:
>
>   http://git.openembedded.org/openembedded-core/commit/?id=3e94af90d90f6db6bab66ae87a47b31f3a0474f6
>
> The change to the toplevel Makefile.all.am looks OK.
>
>> +Upstream-Status: Pending
>> +
>> +Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> +---
>> + Makefile.all.am            |  6 +++---
>> + helgrind/tests/Makefile.am |  6 +++---
>> + none/tests/arm/Makefile.am | 18 +++++++++---------
>> + 3 files changed, 15 insertions(+), 15 deletions(-)
>> +
>> +diff --git a/Makefile.all.am b/Makefile.all.am
>> +index 02059a3..c7c4700 100644
>> +--- a/Makefile.all.am
>> ++++ b/Makefile.all.am
>> +@@ -197,11 +197,11 @@ AM_CCASFLAGS_PPC64LE_LINUX  = @FLAG_M64@ -g
>> +
>> + AM_FLAG_M3264_ARM_LINUX   = @FLAG_M32@
>> + AM_CFLAGS_ARM_LINUX       = @FLAG_M32@ \
>> +-                              $(AM_CFLAGS_BASE) -marm -mcpu=cortex-a8
>> ++                              $(AM_CFLAGS_BASE) -marm
>> + AM_CFLAGS_PSO_ARM_LINUX   = @FLAG_M32@ $(AM_CFLAGS_BASE) \
>> +-                              -marm -mcpu=cortex-a8 $(AM_CFLAGS_PSO_BASE)
>> ++                              -marm $(AM_CFLAGS_PSO_BASE)
>> + AM_CCASFLAGS_ARM_LINUX    = @FLAG_M32@ \
>> +-                              -marm -mcpu=cortex-a8 -g
>> ++                              -marm -g
>> +
>> + AM_FLAG_M3264_ARM64_LINUX = @FLAG_M64@
>> + AM_CFLAGS_ARM64_LINUX     = @FLAG_M64@ $(AM_CFLAGS_BASE)
>> +diff --git a/helgrind/tests/Makefile.am b/helgrind/tests/Makefile.am
>> +index df82169..07eb66a 100644
>> +--- a/helgrind/tests/Makefile.am
>> ++++ b/helgrind/tests/Makefile.am
>> +@@ -189,9 +189,9 @@ if ! VGCONF_PLATFORMS_INCLUDE_X86_DARWIN
>> + endif
>> +
>> + if VGCONF_PLATFORMS_INCLUDE_ARM_LINUX
>> +-annotate_hbefore_CFLAGS = $(AM_CFLAGS) -mcpu=cortex-a8
>> +-tc07_hbl1_CFLAGS        = $(AM_CFLAGS) -mcpu=cortex-a8
>> +-tc08_hbl2_CFLAGS        = $(AM_CFLAGS) -mcpu=cortex-a8
>> ++annotate_hbefore_CFLAGS = $(AM_CFLAGS)
>> ++tc07_hbl1_CFLAGS        = $(AM_CFLAGS)
>> ++tc08_hbl2_CFLAGS        = $(AM_CFLAGS)
>> + else
>> + annotate_hbefore_CFLAGS = $(AM_CFLAGS)
>> + tc07_hbl1_CFLAGS        = $(AM_CFLAGS)
>> +diff --git a/none/tests/arm/Makefile.am b/none/tests/arm/Makefile.am
>> +index 024eb6d..ccecb90 100644
>> +--- a/none/tests/arm/Makefile.am
>> ++++ b/none/tests/arm/Makefile.am
>> +@@ -52,10 +52,10 @@ allexec_CFLAGS             = $(AM_CFLAGS) @FLAG_W_NO_NONNULL@
>> + # need special helping w.r.t -mfpu and -mfloat-abi, though.
>> + # Also force -O0 since -O takes hundreds of MB of memory
>> + # for v6intThumb.c.
>> +-v6intARM_CFLAGS   = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 -marm
>> +-v6intThumb_CFLAGS = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 -mthumb
>> ++v6intARM_CFLAGS   = $(AM_CFLAGS) -g -O0 -marm
>> ++v6intThumb_CFLAGS = $(AM_CFLAGS) -g -O0 -mthumb
>> +
>> +-v6media_CFLAGS    = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 -mthumb
>> ++v6media_CFLAGS    = $(AM_CFLAGS) -g -O0 -mthumb
>> +
>> + v8crypto_a_CFLAGS = $(AM_CFLAGS) -g -O0 -mfpu=crypto-neon-fp-armv8 -marm
>> + v8crypto_t_CFLAGS = $(AM_CFLAGS) -g -O0 -mfpu=crypto-neon-fp-armv8 -mthumb
>> +@@ -65,23 +65,23 @@ v8memory_a_CFLAGS = $(AM_CFLAGS) -g -O0 \
>> + v8memory_t_CFLAGS = $(AM_CFLAGS) -g -O0 \
>> +                       -march=armv8-a -mfpu=crypto-neon-fp-armv8 -mthumb
>> +
>> +-vfp_CFLAGS        = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 \
>> ++vfp_CFLAGS        = $(AM_CFLAGS) -g -O0 \
>> +                       -mfpu=neon \
>> +                       -mthumb
>> +
>> +
>> +-neon128_CFLAGS    = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 \
>> ++neon128_CFLAGS    = $(AM_CFLAGS) -g -O0 \
>> +                       -mfpu=neon \
>> +                       -mthumb
>> +
>> +-neon64_CFLAGS     = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 \
>> ++neon64_CFLAGS     = $(AM_CFLAGS) -g -O0 \
>> +                       -mfpu=neon \
>> +                       -mthumb
>> +
>> + intdiv_CFLAGS   = $(AM_CFLAGS) -g -march=armv7ve -mcpu=cortex-a15 -mthumb
>> +-ldrt_CFLAGS     = $(AM_CFLAGS) -g -mcpu=cortex-a8 -mthumb
>> +-ldrt_arm_CFLAGS         = $(AM_CFLAGS) -g -mcpu=cortex-a8 -marm
>> ++ldrt_CFLAGS     = $(AM_CFLAGS) -g -mthumb
>> ++ldrt_arm_CFLAGS         = $(AM_CFLAGS) -g -marm
>> +
>> +-vcvt_fixed_float_VFP_CFLAGS = $(AM_CFLAGS) -g -mcpu=cortex-a8 -mfpu=vfpv3
>> ++vcvt_fixed_float_VFP_CFLAGS = $(AM_CFLAGS) -g -mfpu=vfpv3
>> +
>> + vfpv4_fma_CFLAGS  = $(AM_CFLAGS) -g -O0 -march=armv7ve -mcpu=cortex-a15 -mfpu=vfpv4 -marm
>> +--
>> +2.12.2
>> +
>> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb
>> index 62a96354cd0..a07c8767ce3 100644
>> --- a/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb
>> +++ b/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb
>> @@ -23,7 +23,8 @@ SRC_URI = "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
>>             file://use-appropriate-march-mcpu-mfpu-for-ARM-test-apps.patch \
>>             file://avoid-neon-for-targets-which-don-t-support-it.patch \
>>             file://valgrind-make-ld-XXX.so-strlen-intercept-optional.patch \
>> -"
>> +           file://0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch \
>> +           "
>>  SRC_URI_append_libc-musl = "\
>>             file://0001-fix-build-for-musl-targets.patch \
>>  "
>> --
>> 2.12.2
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/5] valgrind: Fix arm build with gcc7
  2017-04-21  1:06     ` Khem Raj
@ 2017-04-21  1:29       ` Andre McCurdy
  2017-04-21 16:32         ` Khem Raj
  0 siblings, 1 reply; 12+ messages in thread
From: Andre McCurdy @ 2017-04-21  1:29 UTC (permalink / raw)
  To: Khem Raj; +Cc: OE Core mailing list

On Thu, Apr 20, 2017 at 6:06 PM, Khem Raj <raj.khem@gmail.com> wrote:
> On Thu, Apr 20, 2017 at 5:56 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
>> On Thu, Apr 20, 2017 at 11:20 AM, Khem Raj <raj.khem@gmail.com> wrote:
>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>> ---
>>>  ...rop-setting-mcpu-to-cortex-a8-on-arm-arch.patch | 108 +++++++++++++++++++++
>>>  meta/recipes-devtools/valgrind/valgrind_3.12.0.bb  |   3 +-
>>>  2 files changed, 110 insertions(+), 1 deletion(-)
>>>  create mode 100644 meta/recipes-devtools/valgrind/valgrind/0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch
>>>
>>> diff --git a/meta/recipes-devtools/valgrind/valgrind/0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch b/meta/recipes-devtools/valgrind/valgrind/0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch
>>> new file mode 100644
>>> index 00000000000..9f1da7bac68
>>> --- /dev/null
>>> +++ b/meta/recipes-devtools/valgrind/valgrind/0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch
>>> @@ -0,0 +1,108 @@
>>> +From 715cf122388f3527afa5649cebf9f1522c240693 Mon Sep 17 00:00:00 2001
>>> +From: Khem Raj <raj.khem@gmail.com>
>>> +Date: Thu, 20 Apr 2017 10:11:16 -0700
>>> +Subject: [PATCH] makefiles: Drop setting -mcpu to cortex-a8 on arm
>>> + architecture
>>> +
>>> +We can not assume that all arches armv7+ are cortex-a8 only
>>> +it fails to build for rpi which is armv7ve based (cortex-a8) cpu
>>> +implementation.
>>> +Fixes
>>> +| cc1: warning: switch -mcpu=cortex-a8 conflicts with -march=armv7ve switch
>>
>> The valgrind tests are built for fixed CPU targets which are known to
>> support the instructions being tested (since those instructions may
>> not be supported by the target CPU which valgrind itself is being
>> built for).
>>
>> It may be safer to add -march=armv7a to the -mcpu=cortex-a8 tests (and
>> ensure that -march=armv7ve doesn't leak through) rather than remove
>> -mcpu=cortex-a8.
>
> OE always passes mcpu flags, therefore it wont be an issue unless you
> are saying thats not the case.

OE won't pass an -mcpu flag for generic DEFAULTTUNE values such as "armv7athf".

> For upstreaming it might be OK, but I
> think this will need a different for upstreaming since it should
> configure mcpu/march based on some configure input or some such
> instead of hardcoding it.

For the ../tests/... Makefiles, the mcpu/march flags should absolutely
be hardcoded. e.g. the test for "idiv" should always be built in
exactly the same way, regardless of whether or not the target arch you
configure and build valgrind itself for is armv7ve.

>>
>> See the comments in:
>>
>>   http://git.openembedded.org/openembedded-core/commit/?id=3e94af90d90f6db6bab66ae87a47b31f3a0474f6
>>
>> The change to the toplevel Makefile.all.am looks OK.
>>
>>> +Upstream-Status: Pending
>>> +
>>> +Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>> +---
>>> + Makefile.all.am            |  6 +++---
>>> + helgrind/tests/Makefile.am |  6 +++---
>>> + none/tests/arm/Makefile.am | 18 +++++++++---------
>>> + 3 files changed, 15 insertions(+), 15 deletions(-)
>>> +
>>> +diff --git a/Makefile.all.am b/Makefile.all.am
>>> +index 02059a3..c7c4700 100644
>>> +--- a/Makefile.all.am
>>> ++++ b/Makefile.all.am
>>> +@@ -197,11 +197,11 @@ AM_CCASFLAGS_PPC64LE_LINUX  = @FLAG_M64@ -g
>>> +
>>> + AM_FLAG_M3264_ARM_LINUX   = @FLAG_M32@
>>> + AM_CFLAGS_ARM_LINUX       = @FLAG_M32@ \
>>> +-                              $(AM_CFLAGS_BASE) -marm -mcpu=cortex-a8
>>> ++                              $(AM_CFLAGS_BASE) -marm
>>> + AM_CFLAGS_PSO_ARM_LINUX   = @FLAG_M32@ $(AM_CFLAGS_BASE) \
>>> +-                              -marm -mcpu=cortex-a8 $(AM_CFLAGS_PSO_BASE)
>>> ++                              -marm $(AM_CFLAGS_PSO_BASE)
>>> + AM_CCASFLAGS_ARM_LINUX    = @FLAG_M32@ \
>>> +-                              -marm -mcpu=cortex-a8 -g
>>> ++                              -marm -g
>>> +
>>> + AM_FLAG_M3264_ARM64_LINUX = @FLAG_M64@
>>> + AM_CFLAGS_ARM64_LINUX     = @FLAG_M64@ $(AM_CFLAGS_BASE)
>>> +diff --git a/helgrind/tests/Makefile.am b/helgrind/tests/Makefile.am
>>> +index df82169..07eb66a 100644
>>> +--- a/helgrind/tests/Makefile.am
>>> ++++ b/helgrind/tests/Makefile.am
>>> +@@ -189,9 +189,9 @@ if ! VGCONF_PLATFORMS_INCLUDE_X86_DARWIN
>>> + endif
>>> +
>>> + if VGCONF_PLATFORMS_INCLUDE_ARM_LINUX
>>> +-annotate_hbefore_CFLAGS = $(AM_CFLAGS) -mcpu=cortex-a8
>>> +-tc07_hbl1_CFLAGS        = $(AM_CFLAGS) -mcpu=cortex-a8
>>> +-tc08_hbl2_CFLAGS        = $(AM_CFLAGS) -mcpu=cortex-a8
>>> ++annotate_hbefore_CFLAGS = $(AM_CFLAGS)
>>> ++tc07_hbl1_CFLAGS        = $(AM_CFLAGS)
>>> ++tc08_hbl2_CFLAGS        = $(AM_CFLAGS)
>>> + else
>>> + annotate_hbefore_CFLAGS = $(AM_CFLAGS)
>>> + tc07_hbl1_CFLAGS        = $(AM_CFLAGS)
>>> +diff --git a/none/tests/arm/Makefile.am b/none/tests/arm/Makefile.am
>>> +index 024eb6d..ccecb90 100644
>>> +--- a/none/tests/arm/Makefile.am
>>> ++++ b/none/tests/arm/Makefile.am
>>> +@@ -52,10 +52,10 @@ allexec_CFLAGS             = $(AM_CFLAGS) @FLAG_W_NO_NONNULL@
>>> + # need special helping w.r.t -mfpu and -mfloat-abi, though.
>>> + # Also force -O0 since -O takes hundreds of MB of memory
>>> + # for v6intThumb.c.
>>> +-v6intARM_CFLAGS   = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 -marm
>>> +-v6intThumb_CFLAGS = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 -mthumb
>>> ++v6intARM_CFLAGS   = $(AM_CFLAGS) -g -O0 -marm
>>> ++v6intThumb_CFLAGS = $(AM_CFLAGS) -g -O0 -mthumb
>>> +
>>> +-v6media_CFLAGS    = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 -mthumb
>>> ++v6media_CFLAGS    = $(AM_CFLAGS) -g -O0 -mthumb
>>> +
>>> + v8crypto_a_CFLAGS = $(AM_CFLAGS) -g -O0 -mfpu=crypto-neon-fp-armv8 -marm
>>> + v8crypto_t_CFLAGS = $(AM_CFLAGS) -g -O0 -mfpu=crypto-neon-fp-armv8 -mthumb
>>> +@@ -65,23 +65,23 @@ v8memory_a_CFLAGS = $(AM_CFLAGS) -g -O0 \
>>> + v8memory_t_CFLAGS = $(AM_CFLAGS) -g -O0 \
>>> +                       -march=armv8-a -mfpu=crypto-neon-fp-armv8 -mthumb
>>> +
>>> +-vfp_CFLAGS        = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 \
>>> ++vfp_CFLAGS        = $(AM_CFLAGS) -g -O0 \
>>> +                       -mfpu=neon \
>>> +                       -mthumb
>>> +
>>> +
>>> +-neon128_CFLAGS    = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 \
>>> ++neon128_CFLAGS    = $(AM_CFLAGS) -g -O0 \
>>> +                       -mfpu=neon \
>>> +                       -mthumb
>>> +
>>> +-neon64_CFLAGS     = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 \
>>> ++neon64_CFLAGS     = $(AM_CFLAGS) -g -O0 \
>>> +                       -mfpu=neon \
>>> +                       -mthumb
>>> +
>>> + intdiv_CFLAGS   = $(AM_CFLAGS) -g -march=armv7ve -mcpu=cortex-a15 -mthumb
>>> +-ldrt_CFLAGS     = $(AM_CFLAGS) -g -mcpu=cortex-a8 -mthumb
>>> +-ldrt_arm_CFLAGS         = $(AM_CFLAGS) -g -mcpu=cortex-a8 -marm
>>> ++ldrt_CFLAGS     = $(AM_CFLAGS) -g -mthumb
>>> ++ldrt_arm_CFLAGS         = $(AM_CFLAGS) -g -marm
>>> +
>>> +-vcvt_fixed_float_VFP_CFLAGS = $(AM_CFLAGS) -g -mcpu=cortex-a8 -mfpu=vfpv3
>>> ++vcvt_fixed_float_VFP_CFLAGS = $(AM_CFLAGS) -g -mfpu=vfpv3
>>> +
>>> + vfpv4_fma_CFLAGS  = $(AM_CFLAGS) -g -O0 -march=armv7ve -mcpu=cortex-a15 -mfpu=vfpv4 -marm
>>> +--
>>> +2.12.2
>>> +
>>> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb
>>> index 62a96354cd0..a07c8767ce3 100644
>>> --- a/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb
>>> +++ b/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb
>>> @@ -23,7 +23,8 @@ SRC_URI = "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
>>>             file://use-appropriate-march-mcpu-mfpu-for-ARM-test-apps.patch \
>>>             file://avoid-neon-for-targets-which-don-t-support-it.patch \
>>>             file://valgrind-make-ld-XXX.so-strlen-intercept-optional.patch \
>>> -"
>>> +           file://0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch \
>>> +           "
>>>  SRC_URI_append_libc-musl = "\
>>>             file://0001-fix-build-for-musl-targets.patch \
>>>  "
>>> --
>>> 2.12.2
>>>
>>> --
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/5] valgrind: Fix arm build with gcc7
  2017-04-21  1:29       ` Andre McCurdy
@ 2017-04-21 16:32         ` Khem Raj
  2017-04-21 18:11           ` Andre McCurdy
  0 siblings, 1 reply; 12+ messages in thread
From: Khem Raj @ 2017-04-21 16:32 UTC (permalink / raw)
  To: Andre McCurdy; +Cc: OE Core mailing list

On Thu, Apr 20, 2017 at 6:29 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
> On Thu, Apr 20, 2017 at 6:06 PM, Khem Raj <raj.khem@gmail.com> wrote:
>> On Thu, Apr 20, 2017 at 5:56 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
>>> On Thu, Apr 20, 2017 at 11:20 AM, Khem Raj <raj.khem@gmail.com> wrote:
>>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>>> ---
>>>>  ...rop-setting-mcpu-to-cortex-a8-on-arm-arch.patch | 108 +++++++++++++++++++++
>>>>  meta/recipes-devtools/valgrind/valgrind_3.12.0.bb  |   3 +-
>>>>  2 files changed, 110 insertions(+), 1 deletion(-)
>>>>  create mode 100644 meta/recipes-devtools/valgrind/valgrind/0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch
>>>>
>>>> diff --git a/meta/recipes-devtools/valgrind/valgrind/0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch b/meta/recipes-devtools/valgrind/valgrind/0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch
>>>> new file mode 100644
>>>> index 00000000000..9f1da7bac68
>>>> --- /dev/null
>>>> +++ b/meta/recipes-devtools/valgrind/valgrind/0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch
>>>> @@ -0,0 +1,108 @@
>>>> +From 715cf122388f3527afa5649cebf9f1522c240693 Mon Sep 17 00:00:00 2001
>>>> +From: Khem Raj <raj.khem@gmail.com>
>>>> +Date: Thu, 20 Apr 2017 10:11:16 -0700
>>>> +Subject: [PATCH] makefiles: Drop setting -mcpu to cortex-a8 on arm
>>>> + architecture
>>>> +
>>>> +We can not assume that all arches armv7+ are cortex-a8 only
>>>> +it fails to build for rpi which is armv7ve based (cortex-a8) cpu
>>>> +implementation.
>>>> +Fixes
>>>> +| cc1: warning: switch -mcpu=cortex-a8 conflicts with -march=armv7ve switch
>>>
>>> The valgrind tests are built for fixed CPU targets which are known to
>>> support the instructions being tested (since those instructions may
>>> not be supported by the target CPU which valgrind itself is being
>>> built for).
>>>
>>> It may be safer to add -march=armv7a to the -mcpu=cortex-a8 tests (and
>>> ensure that -march=armv7ve doesn't leak through) rather than remove
>>> -mcpu=cortex-a8.
>>
>> OE always passes mcpu flags, therefore it wont be an issue unless you
>> are saying thats not the case.
>
> OE won't pass an -mcpu flag for generic DEFAULTTUNE values such as "armv7athf".
>
>> For upstreaming it might be OK, but I
>> think this will need a different for upstreaming since it should
>> configure mcpu/march based on some configure input or some such
>> instead of hardcoding it.
>
> For the ../tests/... Makefiles, the mcpu/march flags should absolutely
> be hardcoded. e.g. the test for "idiv" should always be built in
> exactly the same way, regardless of whether or not the target arch you
> configure and build valgrind itself for is armv7ve.
>

what is the purpose of compiling such a test case for a machine
where it will cause SIGILL ?

>>>
>>> See the comments in:
>>>
>>>   http://git.openembedded.org/openembedded-core/commit/?id=3e94af90d90f6db6bab66ae87a47b31f3a0474f6
>>>
>>> The change to the toplevel Makefile.all.am looks OK.
>>>
>>>> +Upstream-Status: Pending
>>>> +
>>>> +Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>>> +---
>>>> + Makefile.all.am            |  6 +++---
>>>> + helgrind/tests/Makefile.am |  6 +++---
>>>> + none/tests/arm/Makefile.am | 18 +++++++++---------
>>>> + 3 files changed, 15 insertions(+), 15 deletions(-)
>>>> +
>>>> +diff --git a/Makefile.all.am b/Makefile.all.am
>>>> +index 02059a3..c7c4700 100644
>>>> +--- a/Makefile.all.am
>>>> ++++ b/Makefile.all.am
>>>> +@@ -197,11 +197,11 @@ AM_CCASFLAGS_PPC64LE_LINUX  = @FLAG_M64@ -g
>>>> +
>>>> + AM_FLAG_M3264_ARM_LINUX   = @FLAG_M32@
>>>> + AM_CFLAGS_ARM_LINUX       = @FLAG_M32@ \
>>>> +-                              $(AM_CFLAGS_BASE) -marm -mcpu=cortex-a8
>>>> ++                              $(AM_CFLAGS_BASE) -marm
>>>> + AM_CFLAGS_PSO_ARM_LINUX   = @FLAG_M32@ $(AM_CFLAGS_BASE) \
>>>> +-                              -marm -mcpu=cortex-a8 $(AM_CFLAGS_PSO_BASE)
>>>> ++                              -marm $(AM_CFLAGS_PSO_BASE)
>>>> + AM_CCASFLAGS_ARM_LINUX    = @FLAG_M32@ \
>>>> +-                              -marm -mcpu=cortex-a8 -g
>>>> ++                              -marm -g
>>>> +
>>>> + AM_FLAG_M3264_ARM64_LINUX = @FLAG_M64@
>>>> + AM_CFLAGS_ARM64_LINUX     = @FLAG_M64@ $(AM_CFLAGS_BASE)
>>>> +diff --git a/helgrind/tests/Makefile.am b/helgrind/tests/Makefile.am
>>>> +index df82169..07eb66a 100644
>>>> +--- a/helgrind/tests/Makefile.am
>>>> ++++ b/helgrind/tests/Makefile.am
>>>> +@@ -189,9 +189,9 @@ if ! VGCONF_PLATFORMS_INCLUDE_X86_DARWIN
>>>> + endif
>>>> +
>>>> + if VGCONF_PLATFORMS_INCLUDE_ARM_LINUX
>>>> +-annotate_hbefore_CFLAGS = $(AM_CFLAGS) -mcpu=cortex-a8
>>>> +-tc07_hbl1_CFLAGS        = $(AM_CFLAGS) -mcpu=cortex-a8
>>>> +-tc08_hbl2_CFLAGS        = $(AM_CFLAGS) -mcpu=cortex-a8
>>>> ++annotate_hbefore_CFLAGS = $(AM_CFLAGS)
>>>> ++tc07_hbl1_CFLAGS        = $(AM_CFLAGS)
>>>> ++tc08_hbl2_CFLAGS        = $(AM_CFLAGS)
>>>> + else
>>>> + annotate_hbefore_CFLAGS = $(AM_CFLAGS)
>>>> + tc07_hbl1_CFLAGS        = $(AM_CFLAGS)
>>>> +diff --git a/none/tests/arm/Makefile.am b/none/tests/arm/Makefile.am
>>>> +index 024eb6d..ccecb90 100644
>>>> +--- a/none/tests/arm/Makefile.am
>>>> ++++ b/none/tests/arm/Makefile.am
>>>> +@@ -52,10 +52,10 @@ allexec_CFLAGS             = $(AM_CFLAGS) @FLAG_W_NO_NONNULL@
>>>> + # need special helping w.r.t -mfpu and -mfloat-abi, though.
>>>> + # Also force -O0 since -O takes hundreds of MB of memory
>>>> + # for v6intThumb.c.
>>>> +-v6intARM_CFLAGS   = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 -marm
>>>> +-v6intThumb_CFLAGS = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 -mthumb
>>>> ++v6intARM_CFLAGS   = $(AM_CFLAGS) -g -O0 -marm
>>>> ++v6intThumb_CFLAGS = $(AM_CFLAGS) -g -O0 -mthumb
>>>> +
>>>> +-v6media_CFLAGS    = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 -mthumb
>>>> ++v6media_CFLAGS    = $(AM_CFLAGS) -g -O0 -mthumb
>>>> +
>>>> + v8crypto_a_CFLAGS = $(AM_CFLAGS) -g -O0 -mfpu=crypto-neon-fp-armv8 -marm
>>>> + v8crypto_t_CFLAGS = $(AM_CFLAGS) -g -O0 -mfpu=crypto-neon-fp-armv8 -mthumb
>>>> +@@ -65,23 +65,23 @@ v8memory_a_CFLAGS = $(AM_CFLAGS) -g -O0 \
>>>> + v8memory_t_CFLAGS = $(AM_CFLAGS) -g -O0 \
>>>> +                       -march=armv8-a -mfpu=crypto-neon-fp-armv8 -mthumb
>>>> +
>>>> +-vfp_CFLAGS        = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 \
>>>> ++vfp_CFLAGS        = $(AM_CFLAGS) -g -O0 \
>>>> +                       -mfpu=neon \
>>>> +                       -mthumb
>>>> +
>>>> +
>>>> +-neon128_CFLAGS    = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 \
>>>> ++neon128_CFLAGS    = $(AM_CFLAGS) -g -O0 \
>>>> +                       -mfpu=neon \
>>>> +                       -mthumb
>>>> +
>>>> +-neon64_CFLAGS     = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 \
>>>> ++neon64_CFLAGS     = $(AM_CFLAGS) -g -O0 \
>>>> +                       -mfpu=neon \
>>>> +                       -mthumb
>>>> +
>>>> + intdiv_CFLAGS   = $(AM_CFLAGS) -g -march=armv7ve -mcpu=cortex-a15 -mthumb
>>>> +-ldrt_CFLAGS     = $(AM_CFLAGS) -g -mcpu=cortex-a8 -mthumb
>>>> +-ldrt_arm_CFLAGS         = $(AM_CFLAGS) -g -mcpu=cortex-a8 -marm
>>>> ++ldrt_CFLAGS     = $(AM_CFLAGS) -g -mthumb
>>>> ++ldrt_arm_CFLAGS         = $(AM_CFLAGS) -g -marm
>>>> +
>>>> +-vcvt_fixed_float_VFP_CFLAGS = $(AM_CFLAGS) -g -mcpu=cortex-a8 -mfpu=vfpv3
>>>> ++vcvt_fixed_float_VFP_CFLAGS = $(AM_CFLAGS) -g -mfpu=vfpv3
>>>> +
>>>> + vfpv4_fma_CFLAGS  = $(AM_CFLAGS) -g -O0 -march=armv7ve -mcpu=cortex-a15 -mfpu=vfpv4 -marm
>>>> +--
>>>> +2.12.2
>>>> +
>>>> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb
>>>> index 62a96354cd0..a07c8767ce3 100644
>>>> --- a/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb
>>>> +++ b/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb
>>>> @@ -23,7 +23,8 @@ SRC_URI = "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
>>>>             file://use-appropriate-march-mcpu-mfpu-for-ARM-test-apps.patch \
>>>>             file://avoid-neon-for-targets-which-don-t-support-it.patch \
>>>>             file://valgrind-make-ld-XXX.so-strlen-intercept-optional.patch \
>>>> -"
>>>> +           file://0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch \
>>>> +           "
>>>>  SRC_URI_append_libc-musl = "\
>>>>             file://0001-fix-build-for-musl-targets.patch \
>>>>  "
>>>> --
>>>> 2.12.2
>>>>
>>>> --
>>>> _______________________________________________
>>>> Openembedded-core mailing list
>>>> Openembedded-core@lists.openembedded.org
>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/5] valgrind: Fix arm build with gcc7
  2017-04-21 16:32         ` Khem Raj
@ 2017-04-21 18:11           ` Andre McCurdy
  0 siblings, 0 replies; 12+ messages in thread
From: Andre McCurdy @ 2017-04-21 18:11 UTC (permalink / raw)
  To: Khem Raj; +Cc: OE Core mailing list

On Fri, Apr 21, 2017 at 9:32 AM, Khem Raj <raj.khem@gmail.com> wrote:
> On Thu, Apr 20, 2017 at 6:29 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
>> On Thu, Apr 20, 2017 at 6:06 PM, Khem Raj <raj.khem@gmail.com> wrote:
>>> On Thu, Apr 20, 2017 at 5:56 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
>>>> On Thu, Apr 20, 2017 at 11:20 AM, Khem Raj <raj.khem@gmail.com> wrote:
>>>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>>>> ---
>>>>>  ...rop-setting-mcpu-to-cortex-a8-on-arm-arch.patch | 108 +++++++++++++++++++++
>>>>>  meta/recipes-devtools/valgrind/valgrind_3.12.0.bb  |   3 +-
>>>>>  2 files changed, 110 insertions(+), 1 deletion(-)
>>>>>  create mode 100644 meta/recipes-devtools/valgrind/valgrind/0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch
>>>>>
>>>>> diff --git a/meta/recipes-devtools/valgrind/valgrind/0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch b/meta/recipes-devtools/valgrind/valgrind/0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch
>>>>> new file mode 100644
>>>>> index 00000000000..9f1da7bac68
>>>>> --- /dev/null
>>>>> +++ b/meta/recipes-devtools/valgrind/valgrind/0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch
>>>>> @@ -0,0 +1,108 @@
>>>>> +From 715cf122388f3527afa5649cebf9f1522c240693 Mon Sep 17 00:00:00 2001
>>>>> +From: Khem Raj <raj.khem@gmail.com>
>>>>> +Date: Thu, 20 Apr 2017 10:11:16 -0700
>>>>> +Subject: [PATCH] makefiles: Drop setting -mcpu to cortex-a8 on arm
>>>>> + architecture
>>>>> +
>>>>> +We can not assume that all arches armv7+ are cortex-a8 only
>>>>> +it fails to build for rpi which is armv7ve based (cortex-a8) cpu
>>>>> +implementation.
>>>>> +Fixes
>>>>> +| cc1: warning: switch -mcpu=cortex-a8 conflicts with -march=armv7ve switch
>>>>
>>>> The valgrind tests are built for fixed CPU targets which are known to
>>>> support the instructions being tested (since those instructions may
>>>> not be supported by the target CPU which valgrind itself is being
>>>> built for).
>>>>
>>>> It may be safer to add -march=armv7a to the -mcpu=cortex-a8 tests (and
>>>> ensure that -march=armv7ve doesn't leak through) rather than remove
>>>> -mcpu=cortex-a8.
>>>
>>> OE always passes mcpu flags, therefore it wont be an issue unless you
>>> are saying thats not the case.
>>
>> OE won't pass an -mcpu flag for generic DEFAULTTUNE values such as "armv7athf".
>>
>>> For upstreaming it might be OK, but I
>>> think this will need a different for upstreaming since it should
>>> configure mcpu/march based on some configure input or some such
>>> instead of hardcoding it.
>>
>> For the ../tests/... Makefiles, the mcpu/march flags should absolutely
>> be hardcoded. e.g. the test for "idiv" should always be built in
>> exactly the same way, regardless of whether or not the target arch you
>> configure and build valgrind itself for is armv7ve.
>>
>
> what is the purpose of compiling such a test case for a machine
> where it will cause SIGILL ?

I don't think it will when executed via valgrind, since valgrind acts
as an interpreter for the binaries it runs.

In the past I've used valgrind to run an x86 binary which used cmov on
a VIA C3 CPU which didn't support that instruction. I guess a similar
approach would work for ARM - ie you could use valgrind to run an
armv7ve binary on an armv7a CPU.

>>>>
>>>> See the comments in:
>>>>
>>>>   http://git.openembedded.org/openembedded-core/commit/?id=3e94af90d90f6db6bab66ae87a47b31f3a0474f6
>>>>
>>>> The change to the toplevel Makefile.all.am looks OK.
>>>>
>>>>> +Upstream-Status: Pending
>>>>> +
>>>>> +Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>>>> +---
>>>>> + Makefile.all.am            |  6 +++---
>>>>> + helgrind/tests/Makefile.am |  6 +++---
>>>>> + none/tests/arm/Makefile.am | 18 +++++++++---------
>>>>> + 3 files changed, 15 insertions(+), 15 deletions(-)
>>>>> +
>>>>> +diff --git a/Makefile.all.am b/Makefile.all.am
>>>>> +index 02059a3..c7c4700 100644
>>>>> +--- a/Makefile.all.am
>>>>> ++++ b/Makefile.all.am
>>>>> +@@ -197,11 +197,11 @@ AM_CCASFLAGS_PPC64LE_LINUX  = @FLAG_M64@ -g
>>>>> +
>>>>> + AM_FLAG_M3264_ARM_LINUX   = @FLAG_M32@
>>>>> + AM_CFLAGS_ARM_LINUX       = @FLAG_M32@ \
>>>>> +-                              $(AM_CFLAGS_BASE) -marm -mcpu=cortex-a8
>>>>> ++                              $(AM_CFLAGS_BASE) -marm
>>>>> + AM_CFLAGS_PSO_ARM_LINUX   = @FLAG_M32@ $(AM_CFLAGS_BASE) \
>>>>> +-                              -marm -mcpu=cortex-a8 $(AM_CFLAGS_PSO_BASE)
>>>>> ++                              -marm $(AM_CFLAGS_PSO_BASE)
>>>>> + AM_CCASFLAGS_ARM_LINUX    = @FLAG_M32@ \
>>>>> +-                              -marm -mcpu=cortex-a8 -g
>>>>> ++                              -marm -g
>>>>> +
>>>>> + AM_FLAG_M3264_ARM64_LINUX = @FLAG_M64@
>>>>> + AM_CFLAGS_ARM64_LINUX     = @FLAG_M64@ $(AM_CFLAGS_BASE)
>>>>> +diff --git a/helgrind/tests/Makefile.am b/helgrind/tests/Makefile.am
>>>>> +index df82169..07eb66a 100644
>>>>> +--- a/helgrind/tests/Makefile.am
>>>>> ++++ b/helgrind/tests/Makefile.am
>>>>> +@@ -189,9 +189,9 @@ if ! VGCONF_PLATFORMS_INCLUDE_X86_DARWIN
>>>>> + endif
>>>>> +
>>>>> + if VGCONF_PLATFORMS_INCLUDE_ARM_LINUX
>>>>> +-annotate_hbefore_CFLAGS = $(AM_CFLAGS) -mcpu=cortex-a8
>>>>> +-tc07_hbl1_CFLAGS        = $(AM_CFLAGS) -mcpu=cortex-a8
>>>>> +-tc08_hbl2_CFLAGS        = $(AM_CFLAGS) -mcpu=cortex-a8
>>>>> ++annotate_hbefore_CFLAGS = $(AM_CFLAGS)
>>>>> ++tc07_hbl1_CFLAGS        = $(AM_CFLAGS)
>>>>> ++tc08_hbl2_CFLAGS        = $(AM_CFLAGS)
>>>>> + else
>>>>> + annotate_hbefore_CFLAGS = $(AM_CFLAGS)
>>>>> + tc07_hbl1_CFLAGS        = $(AM_CFLAGS)
>>>>> +diff --git a/none/tests/arm/Makefile.am b/none/tests/arm/Makefile.am
>>>>> +index 024eb6d..ccecb90 100644
>>>>> +--- a/none/tests/arm/Makefile.am
>>>>> ++++ b/none/tests/arm/Makefile.am
>>>>> +@@ -52,10 +52,10 @@ allexec_CFLAGS             = $(AM_CFLAGS) @FLAG_W_NO_NONNULL@
>>>>> + # need special helping w.r.t -mfpu and -mfloat-abi, though.
>>>>> + # Also force -O0 since -O takes hundreds of MB of memory
>>>>> + # for v6intThumb.c.
>>>>> +-v6intARM_CFLAGS   = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 -marm
>>>>> +-v6intThumb_CFLAGS = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 -mthumb
>>>>> ++v6intARM_CFLAGS   = $(AM_CFLAGS) -g -O0 -marm
>>>>> ++v6intThumb_CFLAGS = $(AM_CFLAGS) -g -O0 -mthumb
>>>>> +
>>>>> +-v6media_CFLAGS    = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 -mthumb
>>>>> ++v6media_CFLAGS    = $(AM_CFLAGS) -g -O0 -mthumb
>>>>> +
>>>>> + v8crypto_a_CFLAGS = $(AM_CFLAGS) -g -O0 -mfpu=crypto-neon-fp-armv8 -marm
>>>>> + v8crypto_t_CFLAGS = $(AM_CFLAGS) -g -O0 -mfpu=crypto-neon-fp-armv8 -mthumb
>>>>> +@@ -65,23 +65,23 @@ v8memory_a_CFLAGS = $(AM_CFLAGS) -g -O0 \
>>>>> + v8memory_t_CFLAGS = $(AM_CFLAGS) -g -O0 \
>>>>> +                       -march=armv8-a -mfpu=crypto-neon-fp-armv8 -mthumb
>>>>> +
>>>>> +-vfp_CFLAGS        = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 \
>>>>> ++vfp_CFLAGS        = $(AM_CFLAGS) -g -O0 \
>>>>> +                       -mfpu=neon \
>>>>> +                       -mthumb
>>>>> +
>>>>> +
>>>>> +-neon128_CFLAGS    = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 \
>>>>> ++neon128_CFLAGS    = $(AM_CFLAGS) -g -O0 \
>>>>> +                       -mfpu=neon \
>>>>> +                       -mthumb
>>>>> +
>>>>> +-neon64_CFLAGS     = $(AM_CFLAGS) -g -O0 -mcpu=cortex-a8 \
>>>>> ++neon64_CFLAGS     = $(AM_CFLAGS) -g -O0 \
>>>>> +                       -mfpu=neon \
>>>>> +                       -mthumb
>>>>> +
>>>>> + intdiv_CFLAGS   = $(AM_CFLAGS) -g -march=armv7ve -mcpu=cortex-a15 -mthumb
>>>>> +-ldrt_CFLAGS     = $(AM_CFLAGS) -g -mcpu=cortex-a8 -mthumb
>>>>> +-ldrt_arm_CFLAGS         = $(AM_CFLAGS) -g -mcpu=cortex-a8 -marm
>>>>> ++ldrt_CFLAGS     = $(AM_CFLAGS) -g -mthumb
>>>>> ++ldrt_arm_CFLAGS         = $(AM_CFLAGS) -g -marm
>>>>> +
>>>>> +-vcvt_fixed_float_VFP_CFLAGS = $(AM_CFLAGS) -g -mcpu=cortex-a8 -mfpu=vfpv3
>>>>> ++vcvt_fixed_float_VFP_CFLAGS = $(AM_CFLAGS) -g -mfpu=vfpv3
>>>>> +
>>>>> + vfpv4_fma_CFLAGS  = $(AM_CFLAGS) -g -O0 -march=armv7ve -mcpu=cortex-a15 -mfpu=vfpv4 -marm
>>>>> +--
>>>>> +2.12.2
>>>>> +
>>>>> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb
>>>>> index 62a96354cd0..a07c8767ce3 100644
>>>>> --- a/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb
>>>>> +++ b/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb
>>>>> @@ -23,7 +23,8 @@ SRC_URI = "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
>>>>>             file://use-appropriate-march-mcpu-mfpu-for-ARM-test-apps.patch \
>>>>>             file://avoid-neon-for-targets-which-don-t-support-it.patch \
>>>>>             file://valgrind-make-ld-XXX.so-strlen-intercept-optional.patch \
>>>>> -"
>>>>> +           file://0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch \
>>>>> +           "
>>>>>  SRC_URI_append_libc-musl = "\
>>>>>             file://0001-fix-build-for-musl-targets.patch \
>>>>>  "
>>>>> --
>>>>> 2.12.2
>>>>>
>>>>> --
>>>>> _______________________________________________
>>>>> Openembedded-core mailing list
>>>>> Openembedded-core@lists.openembedded.org
>>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2017-04-21 18:11 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-20 18:20 [PATCH 1/5] boost: Upgrade to 1.64.0 Khem Raj
2017-04-20 18:20 ` [PATCH 2/5] valgrind: Fix arm build with gcc7 Khem Raj
2017-04-21  0:56   ` Andre McCurdy
2017-04-21  1:06     ` Khem Raj
2017-04-21  1:29       ` Andre McCurdy
2017-04-21 16:32         ` Khem Raj
2017-04-21 18:11           ` Andre McCurdy
2017-04-20 18:20 ` [PATCH 3/5] bitbake.conf: Add pr to list of hosttools Khem Raj
2017-04-20 21:30   ` Burton, Ross
2017-04-20 21:32     ` Khem Raj
2017-04-20 18:20 ` [PATCH 4/5] gstreamer1.0-libav: Fix build with gcc7 Khem Raj
2017-04-20 18:20 ` [PATCH 5/5] gnu-efi: " Khem Raj

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.