All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] gpio: move tca9554 from pcf857x to pca953x
@ 2017-04-21 12:46 ` Anders Darander
  0 siblings, 0 replies; 7+ messages in thread
From: Anders Darander @ 2017-04-21 12:46 UTC (permalink / raw)
  To: linus.walleij-QSEj5FYQhm4dnm+yROfE0A,
	gnurou-Re5JQEeQqe8AvxtiuMwx3w, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
	linux-gpio-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, mark.rutland-5wv7dgnIgG8
  Cc: Anders Darander

The TCA9554 doesn't work with the pcf857x driver, trying to change the direction
gives a NAK bailout error.

TCA9554 is similar to the PCA9554, thus change the driver.

Signed-off-by: Anders Darander <anders-7UjN0b3lYz2SbKU13Z4Etw@public.gmane.org>
---
 drivers/gpio/Kconfig        | 2 +-
 drivers/gpio/gpio-pca953x.c | 1 +
 drivers/gpio/gpio-pcf857x.c | 2 --
 3 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 05043071fc98..684f887173e9 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -753,7 +753,7 @@ config GPIO_PCA953X
 	  4 bits:	pca9536, pca9537
 
 	  8 bits:	max7310, max7315, pca6107, pca9534, pca9538, pca9554,
-			pca9556, pca9557, pca9574, tca6408, xra1202
+			pca9556, pca9557, pca9574, tca6408, tca9554, xra1202
 
 	  16 bits:	max7312, max7313, pca9535, pca9539, pca9555, pca9575,
 			tca6416
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index d44232aadb6c..13d895264fc8 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -81,6 +81,7 @@ static const struct i2c_device_id pca953x_id[] = {
 	{ "tca6416", 16 | PCA953X_TYPE | PCA_INT, },
 	{ "tca6424", 24 | PCA953X_TYPE | PCA_INT, },
 	{ "tca9539", 16 | PCA953X_TYPE | PCA_INT, },
+	{ "tca9554", 8  | PCA953X_TYPE | PCA_INT, },
 	{ "xra1202", 8  | PCA953X_TYPE },
 	{ }
 };
diff --git a/drivers/gpio/gpio-pcf857x.c b/drivers/gpio/gpio-pcf857x.c
index 895af42a4513..8ddf9302ce3b 100644
--- a/drivers/gpio/gpio-pcf857x.c
+++ b/drivers/gpio/gpio-pcf857x.c
@@ -46,7 +46,6 @@ static const struct i2c_device_id pcf857x_id[] = {
 	{ "pca9675", 16 },
 	{ "max7328", 8 },
 	{ "max7329", 8 },
-	{ "tca9554", 8 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, pcf857x_id);
@@ -66,7 +65,6 @@ static const struct of_device_id pcf857x_of_table[] = {
 	{ .compatible = "nxp,pca9675" },
 	{ .compatible = "maxim,max7328" },
 	{ .compatible = "maxim,max7329" },
-	{ .compatible = "ti,tca9554" },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, pcf857x_of_table);
-- 
2.11.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH 1/2] gpio: move tca9554 from pcf857x to pca953x
@ 2017-04-21 12:46 ` Anders Darander
  0 siblings, 0 replies; 7+ messages in thread
From: Anders Darander @ 2017-04-21 12:46 UTC (permalink / raw)
  To: linus.walleij, gnurou, robh+dt, linux-gpio, devicetree,
	linux-kernel, mark.rutland
  Cc: Anders Darander

The TCA9554 doesn't work with the pcf857x driver, trying to change the direction
gives a NAK bailout error.

TCA9554 is similar to the PCA9554, thus change the driver.

Signed-off-by: Anders Darander <anders@chargestorm.se>
---
 drivers/gpio/Kconfig        | 2 +-
 drivers/gpio/gpio-pca953x.c | 1 +
 drivers/gpio/gpio-pcf857x.c | 2 --
 3 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 05043071fc98..684f887173e9 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -753,7 +753,7 @@ config GPIO_PCA953X
 	  4 bits:	pca9536, pca9537
 
 	  8 bits:	max7310, max7315, pca6107, pca9534, pca9538, pca9554,
-			pca9556, pca9557, pca9574, tca6408, xra1202
+			pca9556, pca9557, pca9574, tca6408, tca9554, xra1202
 
 	  16 bits:	max7312, max7313, pca9535, pca9539, pca9555, pca9575,
 			tca6416
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index d44232aadb6c..13d895264fc8 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -81,6 +81,7 @@ static const struct i2c_device_id pca953x_id[] = {
 	{ "tca6416", 16 | PCA953X_TYPE | PCA_INT, },
 	{ "tca6424", 24 | PCA953X_TYPE | PCA_INT, },
 	{ "tca9539", 16 | PCA953X_TYPE | PCA_INT, },
+	{ "tca9554", 8  | PCA953X_TYPE | PCA_INT, },
 	{ "xra1202", 8  | PCA953X_TYPE },
 	{ }
 };
diff --git a/drivers/gpio/gpio-pcf857x.c b/drivers/gpio/gpio-pcf857x.c
index 895af42a4513..8ddf9302ce3b 100644
--- a/drivers/gpio/gpio-pcf857x.c
+++ b/drivers/gpio/gpio-pcf857x.c
@@ -46,7 +46,6 @@ static const struct i2c_device_id pcf857x_id[] = {
 	{ "pca9675", 16 },
 	{ "max7328", 8 },
 	{ "max7329", 8 },
-	{ "tca9554", 8 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, pcf857x_id);
@@ -66,7 +65,6 @@ static const struct of_device_id pcf857x_of_table[] = {
 	{ .compatible = "nxp,pca9675" },
 	{ .compatible = "maxim,max7328" },
 	{ .compatible = "maxim,max7329" },
-	{ .compatible = "ti,tca9554" },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, pcf857x_of_table);
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH 2/2] gpio: DT bindings, move tca9554 from pcf857x to pca953x
  2017-04-21 12:46 ` Anders Darander
  (?)
@ 2017-04-21 12:46 ` Anders Darander
  2017-04-24 16:31   ` Linus Walleij
  2017-04-26  7:56   ` Geert Uytterhoeven
  -1 siblings, 2 replies; 7+ messages in thread
From: Anders Darander @ 2017-04-21 12:46 UTC (permalink / raw)
  To: linus.walleij, gnurou, robh+dt, linux-gpio, devicetree,
	linux-kernel, mark.rutland
  Cc: Anders Darander

The TCA9554 is similar to the PCA9554. Update the DT binding docs.

Signed-off-by: Anders Darander <anders@chargestorm.se>
---
 Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 1 +
 Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt b/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
index e63935710011..7f57271df2bc 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
+++ b/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
@@ -26,6 +26,7 @@ Required properties:
 	ti,tca6416
 	ti,tca6424
 	ti,tca9539
+	ti,tca9554
 	onsemi,pca9654
 	exar,xra1202
 
diff --git a/Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt b/Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt
index ada4e2973323..7d3bd631d011 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt
+++ b/Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt
@@ -25,7 +25,6 @@ Required Properties:
     - "nxp,pcf8574": For the NXP PCF8574
     - "nxp,pcf8574a": For the NXP PCF8574A
     - "nxp,pcf8575": For the NXP PCF8575
-    - "ti,tca9554": For the TI TCA9554
 
   - reg: I2C slave address.
 
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] gpio: move tca9554 from pcf857x to pca953x
  2017-04-21 12:46 ` Anders Darander
@ 2017-04-24 16:28     ` Linus Walleij
  -1 siblings, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2017-04-24 16:28 UTC (permalink / raw)
  To: Anders Darander
  Cc: Alexandre Courbot, Rob Herring,
	linux-gpio-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, Mark Rutland

On Fri, Apr 21, 2017 at 2:46 PM, Anders Darander <anders-7UjN0b3lYz2SbKU13Z4Etw@public.gmane.org> wrote:

> The TCA9554 doesn't work with the pcf857x driver, trying to change the direction
> gives a NAK bailout error.
>
> TCA9554 is similar to the PCA9554, thus change the driver.
>
> Signed-off-by: Anders Darander <anders-7UjN0b3lYz2SbKU13Z4Etw@public.gmane.org>

Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] gpio: move tca9554 from pcf857x to pca953x
@ 2017-04-24 16:28     ` Linus Walleij
  0 siblings, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2017-04-24 16:28 UTC (permalink / raw)
  To: Anders Darander
  Cc: Alexandre Courbot, Rob Herring, linux-gpio, devicetree,
	linux-kernel, Mark Rutland

On Fri, Apr 21, 2017 at 2:46 PM, Anders Darander <anders@chargestorm.se> wrote:

> The TCA9554 doesn't work with the pcf857x driver, trying to change the direction
> gives a NAK bailout error.
>
> TCA9554 is similar to the PCA9554, thus change the driver.
>
> Signed-off-by: Anders Darander <anders@chargestorm.se>

Patch applied.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] gpio: DT bindings, move tca9554 from pcf857x to pca953x
  2017-04-21 12:46 ` [PATCH 2/2] gpio: DT bindings, " Anders Darander
@ 2017-04-24 16:31   ` Linus Walleij
  2017-04-26  7:56   ` Geert Uytterhoeven
  1 sibling, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2017-04-24 16:31 UTC (permalink / raw)
  To: Anders Darander
  Cc: Alexandre Courbot, Rob Herring, linux-gpio, devicetree,
	linux-kernel, Mark Rutland

On Fri, Apr 21, 2017 at 2:46 PM, Anders Darander <anders@chargestorm.se> wrote:

> The TCA9554 is similar to the PCA9554. Update the DT binding docs.
>
> Signed-off-by: Anders Darander <anders@chargestorm.se>

Patch applied. Seems like this component was misqualified at some point,
let's repair it.

yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] gpio: DT bindings, move tca9554 from pcf857x to pca953x
  2017-04-21 12:46 ` [PATCH 2/2] gpio: DT bindings, " Anders Darander
  2017-04-24 16:31   ` Linus Walleij
@ 2017-04-26  7:56   ` Geert Uytterhoeven
  1 sibling, 0 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2017-04-26  7:56 UTC (permalink / raw)
  To: Anders Darander
  Cc: Linus Walleij, Alexandre Courbot, Rob Herring, linux-gpio,
	devicetree, linux-kernel, Mark Rutland

On Fri, Apr 21, 2017 at 2:46 PM, Anders Darander <anders@chargestorm.se> wrote:
> The TCA9554 is similar to the PCA9554. Update the DT binding docs.
>
> Signed-off-by: Anders Darander <anders@chargestorm.se>
> ---
>  Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 1 +
>  Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt | 1 -
>  2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt b/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
> index e63935710011..7f57271df2bc 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
> @@ -26,6 +26,7 @@ Required properties:
>         ti,tca6416
>         ti,tca6424
>         ti,tca9539
> +       ti,tca9554
>         onsemi,pca9654
>         exar,xra1202
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt b/Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt
> index ada4e2973323..7d3bd631d011 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt
> @@ -25,7 +25,6 @@ Required Properties:
>      - "nxp,pcf8574": For the NXP PCF8574
>      - "nxp,pcf8574a": For the NXP PCF8574A
>      - "nxp,pcf8575": For the NXP PCF8575
> -    - "ti,tca9554": For the TI TCA9554
>
>    - reg: I2C slave address.

BTW, gpio-pca953x.txt seems to lack lots of gpio-controller-related properties.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-04-26  7:56 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-21 12:46 [PATCH 1/2] gpio: move tca9554 from pcf857x to pca953x Anders Darander
2017-04-21 12:46 ` Anders Darander
2017-04-21 12:46 ` [PATCH 2/2] gpio: DT bindings, " Anders Darander
2017-04-24 16:31   ` Linus Walleij
2017-04-26  7:56   ` Geert Uytterhoeven
     [not found] ` <20170421124631.19269-1-anders-7UjN0b3lYz2SbKU13Z4Etw@public.gmane.org>
2017-04-24 16:28   ` [PATCH 1/2] gpio: " Linus Walleij
2017-04-24 16:28     ` Linus Walleij

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.