tools/testing/selftests/bpf/Makefile

tools/testing/selftests/bpf/Makefile

[David Miller]

Alexei, that unconditional -D__x86_64__ isn't going to work.  It in
fact makes the build break on sparc because the types.h asm headers
explicitly check for things like __sparc__ && __arch64__ etc.

There are other places that want stuff like this, so let's do it
right.

In every

	arch/${ARCH}/Makefile

extract out the "-DXXX" stuff from CHECKFLAGS into a new Makefile
variable, expand that into CHECKFLAGS and use the new variable in
places like

	tools/testing/selftests/bpf/Makefile

and

	tools/testing/selftests/ipc/Makefile

Thanks.

Re: tools/testing/selftests/bpf/Makefile

[Alexei Starovoitov]

On Sat, Apr 22, 2017 at 03:45:01PM -0400, David Miller wrote:
> 
> Alexei, that unconditional -D__x86_64__ isn't going to work.  It in
> fact makes the build break on sparc because the types.h asm headers
> explicitly check for things like __sparc__ && __arch64__ etc.

yeah. it was a quick workaround for the following error:
In file included from net-next/tools/testing/selftests/bpf/test_xdp.c:8:
In file included from /usr/include/string.h:25:
In file included from /usr/include/features.h:399:
/usr/include/gnu/stubs.h:7:11: fatal error: 'gnu/stubs-32.h' file not found

the bpf progs don't do any x86 specific things.

> In every
> 	arch/${ARCH}/Makefile
> extract out the "-DXXX" stuff from CHECKFLAGS into a new Makefile

that should work. Probably there is even simpler way.