* [PATCH -next] input: touchscreen: mxs-lradc: Make symbol mxs_lradc_ts_irq_names static
@ 2017-04-25 6:27 Wei Yongjun
2017-04-25 17:05 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2017-04-25 6:27 UTC (permalink / raw)
To: Dmitry Torokhov, Marek Vasut, Lee Jones, Ksenija Stanojevic
Cc: Wei Yongjun, linux-input
From: Wei Yongjun <weiyongjun1@huawei.com>
Fixes the following sparse warning:
drivers/input/touchscreen/mxs-lradc-ts.c:33:12: warning:
symbol 'mxs_lradc_ts_irq_names' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/input/touchscreen/mxs-lradc-ts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/mxs-lradc-ts.c b/drivers/input/touchscreen/mxs-lradc-ts.c
index 4b4aebf..603ac5a 100644
--- a/drivers/input/touchscreen/mxs-lradc-ts.c
+++ b/drivers/input/touchscreen/mxs-lradc-ts.c
@@ -30,7 +30,7 @@
#include <linux/of_irq.h>
#include <linux/platform_device.h>
-const char *mxs_lradc_ts_irq_names[] = {
+static const char *mxs_lradc_ts_irq_names[] = {
"mxs-lradc-touchscreen",
"mxs-lradc-channel6",
"mxs-lradc-channel7",
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] input: touchscreen: mxs-lradc: Make symbol mxs_lradc_ts_irq_names static
2017-04-25 6:27 [PATCH -next] input: touchscreen: mxs-lradc: Make symbol mxs_lradc_ts_irq_names static Wei Yongjun
@ 2017-04-25 17:05 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2017-04-25 17:05 UTC (permalink / raw)
To: Wei Yongjun
Cc: Marek Vasut, Lee Jones, Ksenija Stanojevic, Wei Yongjun, linux-input
On Tue, Apr 25, 2017 at 06:27:04AM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warning:
>
> drivers/input/touchscreen/mxs-lradc-ts.c:33:12: warning:
> symbol 'mxs_lradc_ts_irq_names' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/input/touchscreen/mxs-lradc-ts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/mxs-lradc-ts.c b/drivers/input/touchscreen/mxs-lradc-ts.c
> index 4b4aebf..603ac5a 100644
> --- a/drivers/input/touchscreen/mxs-lradc-ts.c
> +++ b/drivers/input/touchscreen/mxs-lradc-ts.c
> @@ -30,7 +30,7 @@
> #include <linux/of_irq.h>
> #include <linux/platform_device.h>
>
> -const char *mxs_lradc_ts_irq_names[] = {
> +static const char *mxs_lradc_ts_irq_names[] = {
FWIW checkpatch recommends "static const char * const".
> "mxs-lradc-touchscreen",
> "mxs-lradc-channel6",
> "mxs-lradc-channel7",
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-25 17:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-25 6:27 [PATCH -next] input: touchscreen: mxs-lradc: Make symbol mxs_lradc_ts_irq_names static Wei Yongjun
2017-04-25 17:05 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.