[BUG] multipath-tools: missing internal values (multipath -t)

[BUG] multipath-tools: missing internal values (multipath -t)

[Xose Vazquez Perez]

Hi,

These values:
no_path_retry
dev_loss_tmo
reservation_key
partition_delimite
delay_watch_checks
delay_wait_checks
are missing from the "defaults section" of multipath -t output.

Re: [BUG] multipath-tools: missing internal values (multipath -t)

[Benjamin Marzinski]

On Tue, Apr 25, 2017 at 04:26:06PM +0200, Xose Vazquez Perez wrote:
> Hi,
> 
> These values:

What do you think of these?
> no_path_retry

The default if no_path_retry is set is to use the features line to
determine what to do when there are no paths. we could have it
print something like

no_path_retry <undef>

> dev_loss_tmo

The default here is to keep whatever the sysfs value currently is. We
could print

dev_loss_tmo <undef>

or

dev_loss_tmo <sysfs>

or something else. I'm open to ideas.

> reservation_key

The default here is nothing

reservation_key <undef>

probably makes the most sense

> partition_delimite

The default here is an empty string

partition_delm ""

is probably the right answer.

> delay_watch_checks
> delay_wait_checks

These clearly have well defined default values and should be set.


-Ben

> are missing from the "defaults section" of multipath -t output.
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel

Re: [BUG] multipath-tools: missing internal values (multipath -t)

[Christophe Varoqui]

[-- Attachment #1.1: Type: text/plain, Size: 1550 bytes --]

Hi,

The config outputed should be usable, so a comment could be printed for the
keywords you suggest printing <undef> as the default for.

Example:

# no_path_retry <comment explaining the contextual default behaviour>

or simply

# no_path_retry <contextual, see man page>

On Tue, Apr 25, 2017 at 8:42 PM, Benjamin Marzinski <bmarzins@redhat.com>
wrote:

> On Tue, Apr 25, 2017 at 04:26:06PM +0200, Xose Vazquez Perez wrote:
> > Hi,
> >
> > These values:
>
> What do you think of these?
> > no_path_retry
>
> The default if no_path_retry is set is to use the features line to
> determine what to do when there are no paths. we could have it
> print something like
>
> no_path_retry <undef>
>
> > dev_loss_tmo
>
> The default here is to keep whatever the sysfs value currently is. We
> could print
>
> dev_loss_tmo <undef>
>
> or
>
> dev_loss_tmo <sysfs>
>
> or something else. I'm open to ideas.
>
> > reservation_key
>
> The default here is nothing
>
> reservation_key <undef>
>
> probably makes the most sense
>
> > partition_delimite
>
> The default here is an empty string
>
> partition_delm ""
>
> is probably the right answer.
>
> > delay_watch_checks
> > delay_wait_checks
>
> These clearly have well defined default values and should be set.
>
>
> -Ben
>
> > are missing from the "defaults section" of multipath -t output.
> > --
> > dm-devel mailing list
> > dm-devel@redhat.com
> > https://www.redhat.com/mailman/listinfo/dm-devel
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
>

[-- Attachment #1.2: Type: text/html, Size: 2799 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [BUG] multipath-tools: missing internal values (multipath -t)

[Benjamin Marzinski]

On Thu, Apr 27, 2017 at 09:10:09AM +0200, Christophe Varoqui wrote:
>    Hi,
>    The config outputed should be usable, so a comment could be printed for
>    the keywords you suggest printing <undef> as the default for.
>    Example:
>    # no_path_retry <comment explaining the contextual default behaviour>
>    or simply
>    # no_path_retry <contextual, see man page>

Makes sense.

Thanks
-Ben

>    On Tue, Apr 25, 2017 at 8:42 PM, Benjamin Marzinski
>    <[1]bmarzins@redhat.com> wrote:
> 
>      On Tue, Apr 25, 2017 at 04:26:06PM +0200, Xose Vazquez Perez wrote:
>      > Hi,
>      >
>      > These values:
> 
>      What do you think of these?
>      > no_path_retry
> 
>      The default if no_path_retry is set is to use the features line to
>      determine what to do when there are no paths. we could have it
>      print something like
> 
>      no_path_retry <undef>
> 
>      > dev_loss_tmo
> 
>      The default here is to keep whatever the sysfs value currently is. We
>      could print
> 
>      dev_loss_tmo <undef>
> 
>      or
> 
>      dev_loss_tmo <sysfs>
> 
>      or something else. I'm open to ideas.
> 
>      > reservation_key
> 
>      The default here is nothing
> 
>      reservation_key <undef>
> 
>      probably makes the most sense
> 
>      > partition_delimite
> 
>      The default here is an empty string
> 
>      partition_delm ""
> 
>      is probably the right answer.
> 
>      > delay_watch_checks
>      > delay_wait_checks
> 
>      These clearly have well defined default values and should be set.
> 
>      -Ben
>      > are missing from the "defaults section" of multipath -t output.
>      > --
>      > dm-devel mailing list
>      > [2]dm-devel@redhat.com
>      > [3]https://www.redhat.com/mailman/listinfo/dm-devel
> 
>      --
>      dm-devel mailing list
>      [4]dm-devel@redhat.com
>      [5]https://www.redhat.com/mailman/listinfo/dm-devel
> 
> References
> 
>    Visible links
>    1. mailto:bmarzins@redhat.com
>    2. mailto:dm-devel@redhat.com
>    3. https://www.redhat.com/mailman/listinfo/dm-devel
>    4. mailto:dm-devel@redhat.com
>    5. https://www.redhat.com/mailman/listinfo/dm-devel

Re: [BUG] multipath-tools: missing internal values (multipath -t)

[Xose Vazquez Perez]

On 04/27/2017 09:10 AM, Christophe Varoqui wrote:

> The config outputed should be usable, so a comment could be printed for the keywords you suggest printing <undef> as the default for.
> 
> Example:
> 
> # no_path_retry <comment explaining the contextual default behaviour>
> 
> or simply
> 
> # no_path_retry <contextual, see man page>

Undefined values should be replaced by "", but this is not the case for 'no_path_retry'.

Re: [BUG] multipath-tools: missing internal values (multipath -t)

[Xose Vazquez Perez]

On 04/25/2017 04:26 PM, Xose Vazquez Perez wrote:

> These values:
> no_path_retry
> dev_loss_tmo
> reservation_key
> partition_delimite
> delay_watch_checks
> delay_wait_checks
> are missing from the "defaults section" of multipath -t output.

It still happens in 0.7.3