* [PATCH] usb: musb: don't mark of_dev_auxdata as initdata
@ 2017-04-25 20:04 Arnd Bergmann
2017-04-26 9:30 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-04-25 20:04 UTC (permalink / raw)
To: Bin Liu, Greg Kroah-Hartman
Cc: Arnd Bergmann, Alexandre Bailon, David Lechner, Wolfram Sang,
Petr Kulhavy, linux-usb, linux-kernel
The probe function is not __init since it can be called for deferred
probing or when unbinding/rebinding the device, and therefore it must
not reference objects in __initdata, as pointed out by this link
time warning:
WARNING: drivers/usb/musb/da8xx.o(.text+0x9d4): Section mismatch in reference from the function da8xx_probe() to the (unknown reference) .init.data:(unknown)
This removes the annotation.
Reported-by: Olof's autobuilder <olof@lixom.net>
Fixes: d6299b6efbf6 ("usb: musb: Add support of CPPI 4.1 DMA controller to DA8xx")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/usb/musb/da8xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c
index 5a8a031485ea..df88123274ca 100644
--- a/drivers/usb/musb/da8xx.c
+++ b/drivers/usb/musb/da8xx.c
@@ -513,7 +513,7 @@ static const struct musb_hdrc_config da8xx_config = {
.multipoint = 1,
};
-static struct of_dev_auxdata da8xx_auxdata_lookup[] __initdata = {
+static struct of_dev_auxdata da8xx_auxdata_lookup[] = {
OF_DEV_AUXDATA("ti,da830-cppi41", 0x01e01000, "cppi41-dmaengine",
NULL),
{}
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: musb: don't mark of_dev_auxdata as initdata
2017-04-25 20:04 [PATCH] usb: musb: don't mark of_dev_auxdata as initdata Arnd Bergmann
@ 2017-04-26 9:30 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2017-04-26 9:30 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Bin Liu, Alexandre Bailon, David Lechner, Wolfram Sang,
Petr Kulhavy, linux-usb, linux-kernel
On Tue, Apr 25, 2017 at 10:04:53PM +0200, Arnd Bergmann wrote:
> The probe function is not __init since it can be called for deferred
> probing or when unbinding/rebinding the device, and therefore it must
> not reference objects in __initdata, as pointed out by this link
> time warning:
>
> WARNING: drivers/usb/musb/da8xx.o(.text+0x9d4): Section mismatch in reference from the function da8xx_probe() to the (unknown reference) .init.data:(unknown)
>
> This removes the annotation.
>
> Reported-by: Olof's autobuilder <olof@lixom.net>
> Fixes: d6299b6efbf6 ("usb: musb: Add support of CPPI 4.1 DMA controller to DA8xx")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Now applied as I think Bin is offline for a bit.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-26 9:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-25 20:04 [PATCH] usb: musb: don't mark of_dev_auxdata as initdata Arnd Bergmann
2017-04-26 9:30 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.