* [U-Boot] [PATCH] power: twl4030: Add CONFIG_CMD_POWEROFF support @ 2017-04-24 18:34 ` Adam Ford 2017-04-25 20:10 ` Tom Rini ` (2 more replies) 0 siblings, 3 replies; 6+ messages in thread From: Adam Ford @ 2017-04-24 18:34 UTC (permalink / raw) To: u-boot With the addition of twl4030_power_off(), let's allow the 'poweroff' command to run this function when CONFIG_CMD_POWEROFF is enabled. Tested on a DM3730 with twl4030 PMIC. Signed-off-by: Adam Ford <aford173@gmail.com> diff --git a/drivers/power/twl4030.c b/drivers/power/twl4030.c index 8866bf1..ab98d68 100644 --- a/drivers/power/twl4030.c +++ b/drivers/power/twl4030.c @@ -171,3 +171,12 @@ void twl4030_power_mmc_init(int dev_index) mdelay(100); /* ramp-up delay from Linux code */ } } + +#ifdef CONFIG_CMD_POWEROFF +int do_poweroff(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) +{ + twl4030_power_off(); + + return 0; +} +#endif -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] power: twl4030: Add CONFIG_CMD_POWEROFF support 2017-04-24 18:34 ` [U-Boot] [PATCH] power: twl4030: Add CONFIG_CMD_POWEROFF support Adam Ford @ 2017-04-25 20:10 ` Tom Rini 2017-04-26 0:51 ` Adam Ford 2017-04-27 4:14 ` Jaehoon Chung 2017-05-10 17:53 ` [U-Boot] " Tom Rini 2 siblings, 1 reply; 6+ messages in thread From: Tom Rini @ 2017-04-25 20:10 UTC (permalink / raw) To: u-boot On Mon, Apr 24, 2017 at 01:34:43PM -0500, Adam Ford wrote: > With the addition of twl4030_power_off(), let's allow the 'poweroff' command > to run this function when CONFIG_CMD_POWEROFF is enabled. > > Tested on a DM3730 with twl4030 PMIC. > > Signed-off-by: Adam Ford <aford173@gmail.com> > > diff --git a/drivers/power/twl4030.c b/drivers/power/twl4030.c > index 8866bf1..ab98d68 100644 Reviewed-by: Tom Rini <trini@konsulko.com> ... any chance you've got moving TWL4030 stuff to Kconfig on your TODO list? :) -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170425/afd02882/attachment.sig> ^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] power: twl4030: Add CONFIG_CMD_POWEROFF support 2017-04-25 20:10 ` Tom Rini @ 2017-04-26 0:51 ` Adam Ford 2017-04-26 18:43 ` Adam Ford 0 siblings, 1 reply; 6+ messages in thread From: Adam Ford @ 2017-04-26 0:51 UTC (permalink / raw) To: u-boot On Tue, Apr 25, 2017 at 3:10 PM, Tom Rini <trini@konsulko.com> wrote: > On Mon, Apr 24, 2017 at 01:34:43PM -0500, Adam Ford wrote: > >> With the addition of twl4030_power_off(), let's allow the 'poweroff' command >> to run this function when CONFIG_CMD_POWEROFF is enabled. >> >> Tested on a DM3730 with twl4030 PMIC. >> >> Signed-off-by: Adam Ford <aford173@gmail.com> >> >> diff --git a/drivers/power/twl4030.c b/drivers/power/twl4030.c >> index 8866bf1..ab98d68 100644 > > Reviewed-by: Tom Rini <trini@konsulko.com> > > ... any chance you've got moving TWL4030 stuff to Kconfig on your TODO > list? :) > I will try to work something in in the next few days adam > -- > Tom ^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] power: twl4030: Add CONFIG_CMD_POWEROFF support 2017-04-26 0:51 ` Adam Ford @ 2017-04-26 18:43 ` Adam Ford 0 siblings, 0 replies; 6+ messages in thread From: Adam Ford @ 2017-04-26 18:43 UTC (permalink / raw) To: u-boot On Tue, Apr 25, 2017 at 7:51 PM, Adam Ford <aford173@gmail.com> wrote: > On Tue, Apr 25, 2017 at 3:10 PM, Tom Rini <trini@konsulko.com> wrote: >> On Mon, Apr 24, 2017 at 01:34:43PM -0500, Adam Ford wrote: >> >>> With the addition of twl4030_power_off(), let's allow the 'poweroff' command >>> to run this function when CONFIG_CMD_POWEROFF is enabled. >>> >>> Tested on a DM3730 with twl4030 PMIC. >>> >>> Signed-off-by: Adam Ford <aford173@gmail.com> >>> >>> diff --git a/drivers/power/twl4030.c b/drivers/power/twl4030.c >>> index 8866bf1..ab98d68 100644 >> >> Reviewed-by: Tom Rini <trini@konsulko.com> >> >> ... any chance you've got moving TWL4030 stuff to Kconfig on your TODO >> list? :) >> > > I will try to work something in in the next few days I just posted a new 2-patch thread for the CONFIG_TWL4030_POWER. > > adam >> -- >> Tom ^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] power: twl4030: Add CONFIG_CMD_POWEROFF support 2017-04-24 18:34 ` [U-Boot] [PATCH] power: twl4030: Add CONFIG_CMD_POWEROFF support Adam Ford 2017-04-25 20:10 ` Tom Rini @ 2017-04-27 4:14 ` Jaehoon Chung 2017-05-10 17:53 ` [U-Boot] " Tom Rini 2 siblings, 0 replies; 6+ messages in thread From: Jaehoon Chung @ 2017-04-27 4:14 UTC (permalink / raw) To: u-boot Hi Adam On 04/25/2017 03:34 AM, Adam Ford wrote: > With the addition of twl4030_power_off(), let's allow the 'poweroff' command > to run this function when CONFIG_CMD_POWEROFF is enabled. > > Tested on a DM3730 with twl4030 PMIC. > > Signed-off-by: Adam Ford <aford173@gmail.com> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> > > diff --git a/drivers/power/twl4030.c b/drivers/power/twl4030.c > index 8866bf1..ab98d68 100644 > --- a/drivers/power/twl4030.c > +++ b/drivers/power/twl4030.c > @@ -171,3 +171,12 @@ void twl4030_power_mmc_init(int dev_index) > mdelay(100); /* ramp-up delay from Linux code */ > } > } > + > +#ifdef CONFIG_CMD_POWEROFF > +int do_poweroff(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) > +{ > + twl4030_power_off(); > + > + return 0; > +} > +#endif > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] power: twl4030: Add CONFIG_CMD_POWEROFF support 2017-04-24 18:34 ` [U-Boot] [PATCH] power: twl4030: Add CONFIG_CMD_POWEROFF support Adam Ford 2017-04-25 20:10 ` Tom Rini 2017-04-27 4:14 ` Jaehoon Chung @ 2017-05-10 17:53 ` Tom Rini 2 siblings, 0 replies; 6+ messages in thread From: Tom Rini @ 2017-05-10 17:53 UTC (permalink / raw) To: u-boot On Mon, Apr 24, 2017 at 01:34:43PM -0500, Adam Ford wrote: > With the addition of twl4030_power_off(), let's allow the 'poweroff' command > to run this function when CONFIG_CMD_POWEROFF is enabled. > > Tested on a DM3730 with twl4030 PMIC. > > Signed-off-by: Adam Ford <aford173@gmail.com> > Reviewed-by: Tom Rini <trini@konsulko.com> > Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> > > diff --git a/drivers/power/twl4030.c b/drivers/power/twl4030.c > index 8866bf1..ab98d68 100644 Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170510/05a5379c/attachment.sig> ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-05-10 17:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170424183452epcas2p2f44649cbfb461f0b4b77b1ef1d4658c1@epcas2p2.samsung.com>
2017-04-24 18:34 ` [U-Boot] [PATCH] power: twl4030: Add CONFIG_CMD_POWEROFF support Adam Ford
2017-04-25 20:10 ` Tom Rini
2017-04-26 0:51 ` Adam Ford
2017-04-26 18:43 ` Adam Ford
2017-04-27 4:14 ` Jaehoon Chung
2017-05-10 17:53 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.