[Qemu-devel] [PATCH] block: Remove NULL check in bdrv_co_flush

[Qemu-devel] [PATCH] block: Remove NULL check in bdrv_co_flush

[Fam Zheng]

Reported by Coverity. We already use bs in bdrv_inc_in_flight before
checking for NULL. It is unnecessary as all callers pass non-NULL bs, so
drop it.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 block/io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/io.c b/block/io.c
index a7142e0..a039966 100644
--- a/block/io.c
+++ b/block/io.c
@@ -2308,7 +2308,7 @@ int coroutine_fn bdrv_co_flush(BlockDriverState *bs)
 
     bdrv_inc_in_flight(bs);
 
-    if (!bs || !bdrv_is_inserted(bs) || bdrv_is_read_only(bs) ||
+    if (!bdrv_is_inserted(bs) || bdrv_is_read_only(bs) ||
         bdrv_is_sg(bs)) {
         goto early_exit;
     }
-- 
2.9.3

Re: [Qemu-devel] [PATCH] block: Remove NULL check in bdrv_co_flush

[Max Reitz]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

On 26.04.2017 04:03, Fam Zheng wrote:
> Reported by Coverity. We already use bs in bdrv_inc_in_flight before
> checking for NULL. It is unnecessary as all callers pass non-NULL bs, so
> drop it.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  block/io.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

Re: [Qemu-devel] [PATCH] block: Remove NULL check in bdrv_co_flush

[Kevin Wolf]

Am 26.04.2017 um 04:03 hat Fam Zheng geschrieben:
> Reported by Coverity. We already use bs in bdrv_inc_in_flight before
> checking for NULL. It is unnecessary as all callers pass non-NULL bs, so
> drop it.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>

Thanks, applied to block-next.

Kevin