All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Jon Derrick <jonathan.derrick@intel.com>
Cc: axboe@fb.com, hch@infradead.org, sagi@grimberg.me,
	linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org,
	keith.busch@intel.com
Subject: Re: [PATCH] nvme-scsi: Use correct byte ordering for eui64 in Dev ID VPD
Date: Wed, 26 Apr 2017 00:22:48 -0700	[thread overview]
Message-ID: <20170426072248.GA8552@infradead.org> (raw)
In-Reply-To: <20170425201809.1683-1-jonathan.derrick@intel.com>

On Tue, Apr 25, 2017 at 02:18:09PM -0600, Jon Derrick wrote:
> NVME specifies an EUI64/NGUID in little-endian format, while SCSI
> specifies that the Device Identification VPD use big-endian for EUI
> formats. The current code copies this bytestream directly from the
> Identification Namespace page, meaning we just need to reverse the
> bytestream when passing it on to the VPD.

This will break existing setups that rely on VPD 0x83 for device
identification (which I think includes older SuSE distros).

And once you change the setup anyway please stop using this buggy
SCSI emulation.

WARNING: multiple messages have this Message-ID (diff)
From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH] nvme-scsi: Use correct byte ordering for eui64 in Dev ID VPD
Date: Wed, 26 Apr 2017 00:22:48 -0700	[thread overview]
Message-ID: <20170426072248.GA8552@infradead.org> (raw)
In-Reply-To: <20170425201809.1683-1-jonathan.derrick@intel.com>

On Tue, Apr 25, 2017@02:18:09PM -0600, Jon Derrick wrote:
> NVME specifies an EUI64/NGUID in little-endian format, while SCSI
> specifies that the Device Identification VPD use big-endian for EUI
> formats. The current code copies this bytestream directly from the
> Identification Namespace page, meaning we just need to reverse the
> bytestream when passing it on to the VPD.

This will break existing setups that rely on VPD 0x83 for device
identification (which I think includes older SuSE distros).

And once you change the setup anyway please stop using this buggy
SCSI emulation.

  parent reply	other threads:[~2017-04-26  7:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-25 20:18 [PATCH] nvme-scsi: Use correct byte ordering for eui64 in Dev ID VPD Jon Derrick
2017-04-25 20:18 ` Jon Derrick
2017-04-25 20:55 ` Jon Derrick
2017-04-25 20:55   ` Jon Derrick
2017-04-26  7:22 ` Christoph Hellwig [this message]
2017-04-26  7:22   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170426072248.GA8552@infradead.org \
    --to=hch@infradead.org \
    --cc=axboe@fb.com \
    --cc=jonathan.derrick@intel.com \
    --cc=keith.busch@intel.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.