From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> To: Peter Maydell <peter.maydell@linaro.org> Cc: "prasun.kapoor" <Prasun.Kapoor@cavium.com>, kvm-devel <kvm@vger.kernel.org>, Juan Quintela <quintela@redhat.com>, Marc Zyngier <marc.zyngier@arm.com>, Andre Przywara <andre.przywara@arm.com>, Vijaya Kumar K <vijayak@caviumnetworks.com>, "Kumar, Vijaya" <Vijaya.Kumar@cavium.com>, Paolo Bonzini <pbonzini@redhat.com>, "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>, arm-mail-list <linux-arm-kernel@lists.infradead.org>, eric.auger.pro@gmail.com Subject: Re: [PATCH v5 02/22] KVM: arm/arm64: Add GICV3 pending table save API documentation Date: Wed, 26 Apr 2017 09:48:31 +0100 [thread overview] Message-ID: <20170426084830.GB2098@work-vm> (raw) In-Reply-To: <CAFEAcA-u-sH+v-Pnr_3gRC3iSJP0ZK68+GqkDzmi3xe1-B2WAQ@mail.gmail.com> * Peter Maydell (peter.maydell@linaro.org) wrote: > On 26 April 2017 at 09:26, Auger Eric <eric.auger@redhat.com> wrote: > > On 25/04/2017 12:43, Peter Maydell wrote: > >> When does the -EFAULT return happen? (if the guest points GITS_BASER<n> > >> etc at invalid memory, presumably?) > > > > Yes that's correct, when GICR_PENDBASER contains a bad GPA. > > > >> How does the QEMU migration code > >> handle this case? Failing migration because the guest has done something > >> silly doesn't seem too palatable, but trying to avoid that could be > >> more effort than an obscure corner case really merits. > > > > The kvm_device_access will cause an abort() as for other errors returned > > by kvm_device_ioctl(). > > That's pretty nasty. Guests shouldn't be able to provoke QEMU > into abort()ing, ideally. We don't necessarily have to produce > a successful migration, but we should at least fail it cleanly. Yes, no abort()'s during migration due to guest behaviour. They always end up coming back around to being filed as migration bugs and people worry why they've got cores. Ideally log a message into stderr to say that the guest state is inconsistent so that when someone comes to debug it then they can see it's obvious. Dave > thanks > -- PMM -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
WARNING: multiple messages have this Message-ID (diff)
From: dgilbert@redhat.com (Dr. David Alan Gilbert) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 02/22] KVM: arm/arm64: Add GICV3 pending table save API documentation Date: Wed, 26 Apr 2017 09:48:31 +0100 [thread overview] Message-ID: <20170426084830.GB2098@work-vm> (raw) In-Reply-To: <CAFEAcA-u-sH+v-Pnr_3gRC3iSJP0ZK68+GqkDzmi3xe1-B2WAQ@mail.gmail.com> * Peter Maydell (peter.maydell at linaro.org) wrote: > On 26 April 2017 at 09:26, Auger Eric <eric.auger@redhat.com> wrote: > > On 25/04/2017 12:43, Peter Maydell wrote: > >> When does the -EFAULT return happen? (if the guest points GITS_BASER<n> > >> etc at invalid memory, presumably?) > > > > Yes that's correct, when GICR_PENDBASER contains a bad GPA. > > > >> How does the QEMU migration code > >> handle this case? Failing migration because the guest has done something > >> silly doesn't seem too palatable, but trying to avoid that could be > >> more effort than an obscure corner case really merits. > > > > The kvm_device_access will cause an abort() as for other errors returned > > by kvm_device_ioctl(). > > That's pretty nasty. Guests shouldn't be able to provoke QEMU > into abort()ing, ideally. We don't necessarily have to produce > a successful migration, but we should at least fail it cleanly. Yes, no abort()'s during migration due to guest behaviour. They always end up coming back around to being filed as migration bugs and people worry why they've got cores. Ideally log a message into stderr to say that the guest state is inconsistent so that when someone comes to debug it then they can see it's obvious. Dave > thanks > -- PMM -- Dr. David Alan Gilbert / dgilbert at redhat.com / Manchester, UK
next prev parent reply other threads:[~2017-04-26 8:48 UTC|newest] Thread overview: 264+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-14 10:15 [PATCH v5 00/22] vITS save/restore Eric Auger 2017-04-14 10:15 ` Eric Auger 2017-04-14 10:15 ` [PATCH v5 01/22] KVM: arm/arm64: Add ITS save/restore API documentation Eric Auger 2017-04-14 10:15 ` Eric Auger 2017-04-25 10:38 ` Peter Maydell 2017-04-25 10:38 ` Peter Maydell 2017-04-26 12:31 ` Christoffer Dall 2017-04-26 12:31 ` Christoffer Dall 2017-04-26 15:48 ` Auger Eric 2017-04-26 15:48 ` Auger Eric 2017-04-27 8:57 ` Christoffer Dall 2017-04-27 8:57 ` Christoffer Dall 2017-04-27 9:33 ` Auger Eric 2017-04-27 9:33 ` Auger Eric 2017-04-27 11:02 ` Christoffer Dall 2017-04-27 11:02 ` Christoffer Dall 2017-04-27 12:51 ` Auger Eric 2017-04-27 12:51 ` Auger Eric 2017-04-27 14:45 ` Christoffer Dall 2017-04-27 14:45 ` Christoffer Dall 2017-04-27 15:29 ` Auger Eric 2017-04-27 15:29 ` Auger Eric 2017-04-27 16:23 ` Marc Zyngier 2017-04-27 16:23 ` Marc Zyngier 2017-04-27 17:14 ` Auger Eric 2017-04-27 17:14 ` Auger Eric 2017-04-27 17:27 ` Christoffer Dall 2017-04-27 17:27 ` Christoffer Dall 2017-04-27 16:38 ` Christoffer Dall 2017-04-27 16:38 ` Christoffer Dall 2017-04-27 17:27 ` Auger Eric 2017-04-27 17:27 ` Auger Eric 2017-04-27 17:54 ` Christoffer Dall 2017-04-27 17:54 ` Christoffer Dall 2017-04-27 19:27 ` Auger Eric 2017-04-27 19:27 ` Auger Eric 2017-05-04 7:00 ` Auger Eric 2017-05-04 7:00 ` Auger Eric 2017-05-04 7:40 ` Marc Zyngier 2017-05-04 7:40 ` Marc Zyngier 2017-05-04 7:54 ` Auger Eric 2017-05-04 7:54 ` Auger Eric 2017-05-04 7:46 ` Christoffer Dall 2017-05-04 7:46 ` Christoffer Dall 2017-04-14 10:15 ` [PATCH v5 02/22] KVM: arm/arm64: Add GICV3 pending table save " Eric Auger 2017-04-14 10:15 ` Eric Auger 2017-04-25 10:43 ` Peter Maydell 2017-04-25 10:43 ` Peter Maydell 2017-04-26 8:26 ` Auger Eric 2017-04-26 8:26 ` Auger Eric 2017-04-26 8:44 ` Peter Maydell 2017-04-26 8:44 ` Peter Maydell 2017-04-26 8:48 ` Dr. David Alan Gilbert [this message] 2017-04-26 8:48 ` Dr. David Alan Gilbert 2017-04-26 9:57 ` Auger Eric 2017-04-26 9:57 ` Auger Eric 2017-04-26 13:00 ` Christoffer Dall 2017-04-26 13:00 ` Christoffer Dall 2017-04-26 13:01 ` Peter Maydell 2017-04-26 13:01 ` Peter Maydell 2017-04-26 13:14 ` Christoffer Dall 2017-04-26 13:14 ` Christoffer Dall 2017-04-26 13:26 ` Peter Maydell 2017-04-26 13:26 ` Peter Maydell 2017-04-26 14:47 ` Auger Eric 2017-04-26 14:47 ` Auger Eric 2017-04-14 10:15 ` [PATCH v5 03/22] KVM: arm/arm64: vgic-its: rename itte into ite Eric Auger 2017-04-14 10:15 ` Eric Auger 2017-04-26 11:21 ` Prakash B 2017-04-26 11:21 ` Prakash B 2017-04-27 9:05 ` Christoffer Dall 2017-04-27 9:05 ` Christoffer Dall 2017-04-27 9:20 ` Andre Przywara 2017-04-27 9:20 ` Andre Przywara 2017-04-27 9:40 ` Auger Eric 2017-04-27 9:40 ` Auger Eric 2017-04-27 11:09 ` Christoffer Dall 2017-04-27 11:09 ` Christoffer Dall 2017-04-14 10:15 ` [PATCH v5 04/22] arm/arm64: vgic: turn vgic_find_mmio_region into public Eric Auger 2017-04-14 10:15 ` Eric Auger 2017-04-26 11:22 ` Prakash B 2017-04-26 11:22 ` Prakash B 2017-04-27 9:07 ` Christoffer Dall 2017-04-27 9:07 ` Christoffer Dall 2017-04-14 10:15 ` [PATCH v5 05/22] KVM: arm64: vgic-its: KVM_DEV_ARM_VGIC_GRP_ITS_REGS group Eric Auger 2017-04-14 10:15 ` Eric Auger 2017-04-26 11:23 ` Prakash B 2017-04-26 11:23 ` Prakash B 2017-04-27 9:12 ` Christoffer Dall 2017-04-27 9:12 ` Christoffer Dall 2017-04-14 10:15 ` [PATCH v5 06/22] KVM: arm/arm64: vgic: expose (un)lock_all_vcpus Eric Auger 2017-04-14 10:15 ` Eric Auger 2017-04-26 11:23 ` Prakash B 2017-04-26 11:23 ` Prakash B 2017-04-27 9:18 ` Christoffer Dall 2017-04-27 9:18 ` Christoffer Dall 2017-04-14 10:15 ` [PATCH v5 07/22] KVM: arm64: vgic-its: Implement vgic_its_has_attr_regs and attr_regs_access Eric Auger 2017-04-14 10:15 ` Eric Auger 2017-04-26 11:24 ` Prakash B 2017-04-26 11:24 ` Prakash B 2017-04-27 11:00 ` Christoffer Dall 2017-04-27 11:00 ` Christoffer Dall 2017-04-27 12:22 ` Auger Eric 2017-04-27 12:22 ` Auger Eric 2017-04-14 10:15 ` [PATCH v5 08/22] KVM: arm64: vgic-its: Implement vgic_mmio_uaccess_write_its_creadr Eric Auger 2017-04-14 10:15 ` Eric Auger 2017-04-26 11:24 ` Prakash B 2017-04-26 11:24 ` Prakash B 2017-04-27 11:27 ` Christoffer Dall 2017-04-27 11:27 ` Christoffer Dall 2017-04-27 12:53 ` Auger Eric 2017-04-27 12:53 ` Auger Eric 2017-04-14 10:15 ` [PATCH v5 09/22] KVM: arm64: vgic-its: Introduce migration ABI infrastructure Eric Auger 2017-04-14 10:15 ` Eric Auger 2017-04-26 11:27 ` Prakash B 2017-04-26 11:27 ` Prakash B 2017-04-27 13:14 ` Christoffer Dall 2017-04-27 13:14 ` Christoffer Dall 2017-04-14 10:15 ` [PATCH v5 10/22] KVM: arm64: vgic-its: Implement vgic_mmio_uaccess_write_its_iidr Eric Auger 2017-04-14 10:15 ` Eric Auger 2017-04-26 11:27 ` Prakash B 2017-04-26 11:27 ` Prakash B 2017-04-27 14:57 ` Christoffer Dall 2017-04-27 14:57 ` Christoffer Dall 2017-04-14 10:15 ` [PATCH v5 11/22] KVM: arm64: vgic-its: Interpret MAPD Size field and check related errors Eric Auger 2017-04-14 10:15 ` Eric Auger 2017-04-26 11:28 ` Prakash B 2017-04-26 11:28 ` Prakash B 2017-04-27 16:25 ` Christoffer Dall 2017-04-27 16:25 ` Christoffer Dall 2017-04-27 17:15 ` Auger Eric 2017-04-27 17:15 ` Auger Eric 2017-04-27 17:28 ` Christoffer Dall 2017-04-27 17:28 ` Christoffer Dall 2017-04-14 10:15 ` [PATCH v5 12/22] KVM: arm64: vgic-its: Interpret MAPD ITT_addr field Eric Auger 2017-04-14 10:15 ` Eric Auger 2017-04-26 11:29 ` Prakash B 2017-04-26 11:29 ` Prakash B 2017-04-27 16:43 ` Christoffer Dall 2017-04-27 16:43 ` Christoffer Dall 2017-04-27 17:44 ` Auger Eric 2017-04-27 17:44 ` Auger Eric 2017-04-27 18:09 ` Christoffer Dall 2017-04-27 18:09 ` Christoffer Dall 2017-04-27 19:18 ` Auger Eric 2017-04-27 19:18 ` Auger Eric 2017-04-14 10:15 ` [PATCH v5 13/22] KVM: arm64: vgic-its: Check the device id matches TYPER DEVBITS range Eric Auger 2017-04-14 10:15 ` Eric Auger 2017-04-26 11:29 ` Prakash B 2017-04-26 11:29 ` Prakash B 2017-04-27 16:48 ` Christoffer Dall 2017-04-27 16:48 ` Christoffer Dall 2017-04-27 17:24 ` Auger Eric 2017-04-27 17:24 ` Auger Eric 2017-04-14 10:15 ` [PATCH v5 14/22] KVM: arm64: vgic-its: KVM_DEV_ARM_ITS_SAVE/RESTORE_TABLES Eric Auger 2017-04-14 10:15 ` Eric Auger 2017-04-26 11:31 ` Prakash B 2017-04-26 11:31 ` Prakash B 2017-04-27 17:24 ` Christoffer Dall 2017-04-27 17:24 ` Christoffer Dall 2017-04-14 10:15 ` [PATCH v5 15/22] KVM: arm64: vgic-its: vgic_its_alloc_ite/device Eric Auger 2017-04-14 10:15 ` Eric Auger 2017-04-26 11:31 ` Prakash B 2017-04-26 11:31 ` Prakash B 2017-04-27 17:31 ` Christoffer Dall 2017-04-27 17:31 ` Christoffer Dall 2017-04-14 10:15 ` [PATCH v5 16/22] KVM: arm64: vgic-its: Add infrastructure for table lookup Eric Auger 2017-04-14 10:15 ` Eric Auger 2017-04-26 11:32 ` Prakash B 2017-04-26 11:32 ` Prakash B 2017-04-27 18:06 ` Christoffer Dall 2017-04-27 18:06 ` Christoffer Dall 2017-04-27 19:24 ` Auger Eric 2017-04-27 19:24 ` Auger Eric 2017-04-28 9:47 ` Christoffer Dall 2017-04-28 9:47 ` Christoffer Dall 2017-04-30 19:33 ` Christoffer Dall 2017-04-30 19:33 ` Christoffer Dall 2017-05-03 13:40 ` Auger Eric 2017-05-03 13:40 ` Auger Eric 2017-05-03 14:38 ` Christoffer Dall 2017-05-03 14:38 ` Christoffer Dall 2017-04-30 19:35 ` Christoffer Dall 2017-04-30 19:35 ` Christoffer Dall 2017-05-03 6:53 ` Auger Eric 2017-05-03 6:53 ` Auger Eric 2017-05-03 8:01 ` Christoffer Dall 2017-05-03 8:01 ` Christoffer Dall 2017-05-03 10:22 ` Auger Eric 2017-05-03 10:22 ` Auger Eric 2017-04-30 20:13 ` Christoffer Dall 2017-04-30 20:13 ` Christoffer Dall 2017-04-14 10:15 ` [PATCH v5 17/22] KVM: arm64: vgic-its: Collection table save/restore Eric Auger 2017-04-14 10:15 ` Eric Auger 2017-04-26 11:33 ` Prakash B 2017-04-26 11:33 ` Prakash B 2017-04-28 10:44 ` Christoffer Dall 2017-04-28 10:44 ` Christoffer Dall 2017-04-28 11:05 ` Auger Eric 2017-04-28 11:05 ` Auger Eric 2017-04-28 17:42 ` Christoffer Dall 2017-04-28 17:42 ` Christoffer Dall 2017-04-14 10:15 ` [PATCH v5 18/22] KVM: arm64: vgic-its: vgic_its_check_id returns the entry's GPA Eric Auger 2017-04-14 10:15 ` Eric Auger 2017-04-26 11:33 ` Prakash B 2017-04-26 11:33 ` Prakash B 2017-05-02 8:29 ` Christoffer Dall 2017-05-02 8:29 ` Christoffer Dall 2017-04-14 10:15 ` [PATCH v5 19/22] KVM: arm64: vgic-its: ITT save and restore Eric Auger 2017-04-14 10:15 ` Eric Auger 2017-04-26 11:34 ` Prakash B 2017-04-26 11:34 ` Prakash B 2017-04-30 20:14 ` Christoffer Dall 2017-04-30 20:14 ` Christoffer Dall 2017-05-03 16:08 ` Auger Eric 2017-05-03 16:08 ` Auger Eric 2017-05-03 16:37 ` Christoffer Dall 2017-05-03 16:37 ` Christoffer Dall 2017-05-03 21:55 ` Auger Eric 2017-05-03 21:55 ` Auger Eric 2017-05-04 7:31 ` Christoffer Dall 2017-05-04 7:31 ` Christoffer Dall 2017-05-04 7:40 ` Auger Eric 2017-05-04 7:40 ` Auger Eric 2017-05-04 8:23 ` Christoffer Dall 2017-05-04 8:23 ` Christoffer Dall 2017-05-04 8:44 ` Auger Eric 2017-05-04 8:44 ` Auger Eric 2017-04-14 10:15 ` [PATCH v5 20/22] KVM: arm64: vgic-its: Device table save/restore Eric Auger 2017-04-14 10:15 ` Eric Auger 2017-04-26 11:34 ` Prakash B 2017-04-26 11:34 ` Prakash B 2017-04-30 20:55 ` Christoffer Dall 2017-04-30 20:55 ` Christoffer Dall 2017-05-03 14:07 ` Auger Eric 2017-05-03 14:07 ` Auger Eric 2017-05-03 15:29 ` Christoffer Dall 2017-05-03 15:29 ` Christoffer Dall 2017-05-03 21:38 ` Auger Eric 2017-05-03 21:38 ` Auger Eric 2017-04-14 10:15 ` [PATCH v5 21/22] KVM: arm64: vgic-its: Fix pending table sync Eric Auger 2017-04-14 10:15 ` Eric Auger 2017-04-26 11:35 ` Prakash B 2017-04-26 11:35 ` Prakash B 2017-04-30 21:10 ` Christoffer Dall 2017-04-30 21:10 ` Christoffer Dall 2017-05-03 22:20 ` Auger Eric 2017-05-03 22:20 ` Auger Eric 2017-05-04 7:32 ` Christoffer Dall 2017-05-04 7:32 ` Christoffer Dall 2017-04-14 10:15 ` [PATCH v5 22/22] KVM: arm64: vgic-v3: KVM_DEV_ARM_VGIC_SAVE_PENDING_TABLES Eric Auger 2017-04-14 10:15 ` Eric Auger 2017-04-26 11:35 ` Prakash B 2017-04-26 11:35 ` Prakash B 2017-04-30 21:32 ` Christoffer Dall 2017-04-30 21:32 ` Christoffer Dall 2017-05-03 22:22 ` Auger Eric 2017-05-03 22:22 ` Auger Eric 2017-04-26 11:38 ` [PATCH v5 00/22] vITS save/restore Prakash B 2017-04-26 11:38 ` Prakash B 2017-04-26 13:02 ` Christoffer Dall 2017-04-26 13:02 ` Christoffer Dall 2017-04-27 6:55 ` Auger Eric 2017-04-27 6:55 ` Auger Eric
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170426084830.GB2098@work-vm \ --to=dgilbert@redhat.com \ --cc=Prasun.Kapoor@cavium.com \ --cc=Vijaya.Kumar@cavium.com \ --cc=andre.przywara@arm.com \ --cc=eric.auger.pro@gmail.com \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=marc.zyngier@arm.com \ --cc=pbonzini@redhat.com \ --cc=peter.maydell@linaro.org \ --cc=quintela@redhat.com \ --cc=vijayak@caviumnetworks.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.