All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: Ilia Sergachev <ilia.sergachev@unibas.ch>,
	devel@driverdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Staging: ks7010: style fix
Date: Wed, 26 Apr 2017 13:45:55 +0300	[thread overview]
Message-ID: <20170426104555.6k5st7izvhapqxhg@mwanda> (raw)
In-Reply-To: <20170426103756.GF18468@eros>

On Wed, Apr 26, 2017 at 08:37:56PM +1000, Tobin C. Harding wrote:
> On Wed, Apr 26, 2017 at 10:38:54AM +0200, Ilia Sergachev wrote:
> > Fix the style of block comments.
> > Move trailing */ to a separate line.
> > Checkpatch was showing:
> > WARNING: Block comments use a trailing */ on a separate line.
> 
> You are doing well Ilia. A few nitpicks
> 
> - Your first subject was better (excluding the filname) :) it was more
>   descriptive.

Yeah.   This subject is bad.

> 
> - staging has a small 's'. You can verify with;
>   $ git log --pretty=oneline drivers/staging/ks7010/ks_wlan_net.c 

Nah..  It can go either way.  No one cares.

regards,
dan carpenter

  reply	other threads:[~2017-04-26 10:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-25 20:59 [PATCH] staging: ks7010: fix block comment style in ks_wlan_net.c Ilia Sergachev
2017-04-26  3:12 ` Tobin C. Harding
2017-04-26  8:18 ` [PATCH v2] Staging: ks7010: style fix Ilia Sergachev
2017-04-26  8:28   ` Greg Kroah-Hartman
2017-04-26  8:38 ` Ilia Sergachev
2017-04-26 10:37   ` Tobin C. Harding
2017-04-26 10:45     ` Dan Carpenter [this message]
2017-04-26 11:00 ` [PATCH v3] staging: ks7010: fix block comment style Ilia Sergachev
2017-04-26 22:50   ` Tobin C. Harding
2017-04-28  9:45   ` Greg Kroah-Hartman
2017-04-28 10:35 ` [PATCH v4] " Ilia Sergachev
2017-04-28 12:20   ` Greg Kroah-Hartman
2017-04-28 13:01     ` Ilia Sergachev
2017-04-30  9:11       ` Tobin C. Harding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170426104555.6k5st7izvhapqxhg@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=ilia.sergachev@unibas.ch \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@tobin.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.