From: "Tobin C. Harding" <me@tobin.cc>
To: Ilia Sergachev <ilia.sergachev@unibas.ch>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] staging: ks7010: fix block comment style
Date: Sun, 30 Apr 2017 19:11:48 +1000 [thread overview]
Message-ID: <20170430091148.GD14735@eros> (raw)
In-Reply-To: <20170428150132.0082f449@zero1>
On Fri, Apr 28, 2017 at 03:01:32PM +0200, Ilia Sergachev wrote:
> On Fri, 28 Apr 2017 14:20:21 +0200
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>
> >
> > Nope, the whole thing still doesn't apply:
> >
> > checking file drivers/staging/ks7010/ks_wlan_net.c
> > Hunk #1 FAILED at 230.
> > Hunk #2 FAILED at 343.
> > Hunk #3 FAILED at 1137.
> > Hunk #4 FAILED at 1189.
> > Hunk #5 FAILED at 1225.
> > Hunk #6 FAILED at 1497.
> > Hunk #7 FAILED at 1569.
> > Hunk #8 FAILED at 1596.
> > Hunk #9 FAILED at 1970.
> > Hunk #10 FAILED at 2105.
> > Hunk #11 FAILED at 3351.
> > 11 out of 11 hunks FAILED
> >
> > What tree/branch are you making this patch against?
> >
> > thanks,
> >
> > greg k-h
>
> Ok, I was using torvalds/linux instead of next/linux-next.
> In fact, the style fixes on this file were already done in 'next'.
> So, thank you all for your patience, and sorry about lost time,
> these were the necessary lessons for me - I'll find now something else
> to fix :)
If you are attempting fixes to staging drivers you may like to base
your patches off Greg's staging tree
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
The branch you want is either staging-next or staging-testing.
Hope this helps,
Tobin.
prev parent reply other threads:[~2017-04-30 9:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 20:59 [PATCH] staging: ks7010: fix block comment style in ks_wlan_net.c Ilia Sergachev
2017-04-26 3:12 ` Tobin C. Harding
2017-04-26 8:18 ` [PATCH v2] Staging: ks7010: style fix Ilia Sergachev
2017-04-26 8:28 ` Greg Kroah-Hartman
2017-04-26 8:38 ` Ilia Sergachev
2017-04-26 10:37 ` Tobin C. Harding
2017-04-26 10:45 ` Dan Carpenter
2017-04-26 11:00 ` [PATCH v3] staging: ks7010: fix block comment style Ilia Sergachev
2017-04-26 22:50 ` Tobin C. Harding
2017-04-28 9:45 ` Greg Kroah-Hartman
2017-04-28 10:35 ` [PATCH v4] " Ilia Sergachev
2017-04-28 12:20 ` Greg Kroah-Hartman
2017-04-28 13:01 ` Ilia Sergachev
2017-04-30 9:11 ` Tobin C. Harding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170430091148.GD14735@eros \
--to=me@tobin.cc \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilia.sergachev@unibas.ch \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.