All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chandra Annamaneni <chandra627@gmail.com>
Cc: christian.gromm@microchip.com, andrey.shvetsov@k2l.de,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] Staging: most: use __func__ instead of the function name
Date: Wed, 26 Apr 2017 17:08:56 +0300	[thread overview]
Message-ID: <20170426140856.6ncu47o7klwxllj5@mwanda> (raw)
In-Reply-To: <alpine.DEB.2.20.1704260559320.27185@turtle>

On Wed, Apr 26, 2017 at 06:02:29AM -0700, Chandra Annamaneni wrote:
> 
> Change video.c to use %s, __func__ instead of function names.
> Warnings flagged by checkpatch.pl
> 
> Signed-off-by: Chandra Annamaneni <chandra627@gmail.com>
> 
> diff --git a/drivers/staging/most/aim-v4l2/video.c b/drivers/staging/most/aim-v4l2/video.c
> index 59e861e..e074841 100644
> --- a/drivers/staging/most/aim-v4l2/video.c
> +++ b/drivers/staging/most/aim-v4l2/video.c
> @@ -79,7 +79,7 @@ static int aim_vdev_open(struct file *filp)
>  	struct most_video_dev *mdev = video_drvdata(filp);
>  	struct aim_fh *fh;
> 
> -	v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
> +	v4l2_info(&mdev->v4l2_dev, "aim_vdev_open()\n");

You sent the reversed patch.

regards,
dan carpenter

  reply	other threads:[~2017-04-26 14:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-26 13:02 [PATCH v4] Staging: most: use __func__ instead of the function name Chandra Annamaneni
2017-04-26 14:08 ` Dan Carpenter [this message]
2017-04-26 21:24   ` Chandra Annamaneni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170426140856.6ncu47o7klwxllj5@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=andrey.shvetsov@k2l.de \
    --cc=chandra627@gmail.com \
    --cc=christian.gromm@microchip.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.