* [PATCH] gpio: f7188x: Add a missing break
@ 2017-04-26 19:08 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2017-04-26 19:08 UTC (permalink / raw)
To: Linus Walleij, Marty Plummer
Cc: Alexandre Courbot, linux-gpio, kernel-janitors
A break statement was obviously intended here.
Fixes: d69843e416d3 ("gpio: f7188x: Add F71889A GPIO support.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpio/gpio-f7188x.c b/drivers/gpio/gpio-f7188x.c
index c013ff5deb70..13350c9d7f5e 100644
--- a/drivers/gpio/gpio-f7188x.c
+++ b/drivers/gpio/gpio-f7188x.c
@@ -398,6 +398,7 @@ static int f7188x_gpio_probe(struct platform_device *pdev)
case f71889a:
data->nr_bank = ARRAY_SIZE(f71889a_gpio_bank);
data->bank = f71889a_gpio_bank;
+ break;
case f71889f:
data->nr_bank = ARRAY_SIZE(f71889_gpio_bank);
data->bank = f71889_gpio_bank;
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] gpio: f7188x: Add a missing break
@ 2017-04-26 19:08 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2017-04-26 19:08 UTC (permalink / raw)
To: Linus Walleij, Marty Plummer
Cc: Alexandre Courbot, linux-gpio, kernel-janitors
A break statement was obviously intended here.
Fixes: d69843e416d3 ("gpio: f7188x: Add F71889A GPIO support.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpio/gpio-f7188x.c b/drivers/gpio/gpio-f7188x.c
index c013ff5deb70..13350c9d7f5e 100644
--- a/drivers/gpio/gpio-f7188x.c
+++ b/drivers/gpio/gpio-f7188x.c
@@ -398,6 +398,7 @@ static int f7188x_gpio_probe(struct platform_device *pdev)
case f71889a:
data->nr_bank = ARRAY_SIZE(f71889a_gpio_bank);
data->bank = f71889a_gpio_bank;
+ break;
case f71889f:
data->nr_bank = ARRAY_SIZE(f71889_gpio_bank);
data->bank = f71889_gpio_bank;
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] gpio: f7188x: Add a missing break
2017-04-26 19:08 ` Dan Carpenter
@ 2017-04-28 8:09 ` Linus Walleij
-1 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2017-04-28 8:09 UTC (permalink / raw)
To: Dan Carpenter
Cc: Marty Plummer, Alexandre Courbot, linux-gpio, kernel-janitors
On Wed, Apr 26, 2017 at 9:08 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> A break statement was obviously intended here.
>
> Fixes: d69843e416d3 ("gpio: f7188x: Add F71889A GPIO support.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gpio: f7188x: Add a missing break
@ 2017-04-28 8:09 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2017-04-28 8:09 UTC (permalink / raw)
To: Dan Carpenter
Cc: Marty Plummer, Alexandre Courbot, linux-gpio, kernel-janitors
On Wed, Apr 26, 2017 at 9:08 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> A break statement was obviously intended here.
>
> Fixes: d69843e416d3 ("gpio: f7188x: Add F71889A GPIO support.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gpio: f7188x: Add a missing break
2017-04-28 8:09 ` Linus Walleij
@ 2017-04-30 23:45 ` Marty Plummer
-1 siblings, 0 replies; 6+ messages in thread
From: Marty Plummer @ 2017-04-30 23:45 UTC (permalink / raw)
To: Linus Walleij
Cc: Dan Carpenter, Alexandre Courbot, linux-gpio, kernel-janitors
On Fri, Apr 28, 2017 at 10:09:39AM +0200, Linus Walleij wrote:
> On Wed, Apr 26, 2017 at 9:08 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> > A break statement was obviously intended here.
> >
> > Fixes: d69843e416d3 ("gpio: f7188x: Add F71889A GPIO support.")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Patch applied.
>
> Yours,
> Linus Walleij
How embarrassing, I completely missed that. Good catch.
Marty.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gpio: f7188x: Add a missing break
@ 2017-04-30 23:45 ` Marty Plummer
0 siblings, 0 replies; 6+ messages in thread
From: Marty Plummer @ 2017-04-30 23:45 UTC (permalink / raw)
To: Linus Walleij
Cc: Dan Carpenter, Alexandre Courbot, linux-gpio, kernel-janitors
On Fri, Apr 28, 2017 at 10:09:39AM +0200, Linus Walleij wrote:
> On Wed, Apr 26, 2017 at 9:08 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> > A break statement was obviously intended here.
> >
> > Fixes: d69843e416d3 ("gpio: f7188x: Add F71889A GPIO support.")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Patch applied.
>
> Yours,
> Linus Walleij
How embarrassing, I completely missed that. Good catch.
Marty.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-04-30 23:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-26 19:08 [PATCH] gpio: f7188x: Add a missing break Dan Carpenter
2017-04-26 19:08 ` Dan Carpenter
2017-04-28 8:09 ` Linus Walleij
2017-04-28 8:09 ` Linus Walleij
2017-04-30 23:45 ` Marty Plummer
2017-04-30 23:45 ` Marty Plummer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.