From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> To: Davide Caratti <dcaratti@redhat.com> Cc: Tom Herbert <tom@herbertland.com>, Alexander Duyck <alexander.duyck@gmail.com>, David Laight <David.Laight@aculab.com>, "David S . Miller" <davem@davemloft.net>, netdev@vger.kernel.org, linux-sctp@vger.kernel.org Subject: Re: [PATCH RFC net-next v4 0/7] net: improve support for SCTP checksums Date: Thu, 27 Apr 2017 09:41:38 -0300 [thread overview] Message-ID: <20170427124138.GB3216@localhost.localdomain> (raw) In-Reply-To: <cover.1492692976.git.dcaratti@redhat.com> On Thu, Apr 20, 2017 at 03:38:06PM +0200, Davide Caratti wrote: > hello Tom, > > On Fri, 2017-04-07 at 11:11 -0700, Tom Herbert wrote: > > maybe just call it csum_not_ip then. Then just do "if > > (unlikely(skb->csum_not_ip)) ..." > > Ok, done. V4 uses this bit for SCTP only and leaves unmodified behavior > when offloaded FCoE frames are processed. Further work is still possible > to extend this fix for FCoE, if needed, either by using additional sk_buff > bits, or using skb->csum_not_ip and use other data (e.g. skb->csum_offset) > to distinguish SCTP from FCoE. > > > the only case where this new bit is relevant is when > > CHECKSUM_PARTIAL for a CRC is being done. When it's set for offloading > > sctp crc it must be set. When CRC is resolved, in the helper for > > instance, it must be cleared. > > in V4 the bit is set when SCTP packets with offloaded checksum are > generated; the bit is cleared when CRC32c is resolved for such packets > (i.e. skb->ip_summed transitions from CHECKSUM_PARTIAL to CHECKSUM_NONE). > > Any feedbacks are appreciated! > thank you in advance, > -- > davide > > > Davide Caratti (7): > skbuff: add stub to help computing crc32c on SCTP packets > net: introduce skb_crc32c_csum_help > sk_buff: remove support for csum_bad in sk_buff > net: use skb->csum_not_inet to identify packets needing crc32c > net: more accurate checksumming in validate_xmit_skb() > openvswitch: more accurate checksumming in queue_userspace_packet() > sk_buff.h: improve description of CHECKSUM_{COMPLETE,UNNECESSARY} Other than the comments I did on patch 2, this series LGTM. > > Documentation/networking/checksum-offloads.txt | 11 +++-- > drivers/net/ethernet/aquantia/atlantic/aq_ring.c | 2 +- > include/linux/netdevice.h | 8 +-- > include/linux/skbuff.h | 58 +++++++++------------- > net/bridge/netfilter/nft_reject_bridge.c | 5 +- > net/core/dev.c | 63 +++++++++++++++++++++--- > net/core/skbuff.c | 24 +++++++++ > net/ipv4/netfilter/nf_reject_ipv4.c | 2 +- > net/ipv6/netfilter/nf_reject_ipv6.c | 3 -- > net/openvswitch/datapath.c | 2 +- > net/sched/act_csum.c | 1 + > net/sctp/offload.c | 8 +++ > net/sctp/output.c | 1 + > 13 files changed, 128 insertions(+), 60 deletions(-) > > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sctp" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> To: Davide Caratti <dcaratti@redhat.com> Cc: Tom Herbert <tom@herbertland.com>, Alexander Duyck <alexander.duyck@gmail.com>, David Laight <David.Laight@aculab.com>, "David S . Miller" <davem@davemloft.net>, netdev@vger.kernel.org, linux-sctp@vger.kernel.org Subject: Re: [PATCH RFC net-next v4 0/7] net: improve support for SCTP checksums Date: Thu, 27 Apr 2017 12:41:38 +0000 [thread overview] Message-ID: <20170427124138.GB3216@localhost.localdomain> (raw) In-Reply-To: <cover.1492692976.git.dcaratti@redhat.com> On Thu, Apr 20, 2017 at 03:38:06PM +0200, Davide Caratti wrote: > hello Tom, > > On Fri, 2017-04-07 at 11:11 -0700, Tom Herbert wrote: > > maybe just call it csum_not_ip then. Then just do "if > > (unlikely(skb->csum_not_ip)) ..." > > Ok, done. V4 uses this bit for SCTP only and leaves unmodified behavior > when offloaded FCoE frames are processed. Further work is still possible > to extend this fix for FCoE, if needed, either by using additional sk_buff > bits, or using skb->csum_not_ip and use other data (e.g. skb->csum_offset) > to distinguish SCTP from FCoE. > > > the only case where this new bit is relevant is when > > CHECKSUM_PARTIAL for a CRC is being done. When it's set for offloading > > sctp crc it must be set. When CRC is resolved, in the helper for > > instance, it must be cleared. > > in V4 the bit is set when SCTP packets with offloaded checksum are > generated; the bit is cleared when CRC32c is resolved for such packets > (i.e. skb->ip_summed transitions from CHECKSUM_PARTIAL to CHECKSUM_NONE). > > Any feedbacks are appreciated! > thank you in advance, > -- > davide > > > Davide Caratti (7): > skbuff: add stub to help computing crc32c on SCTP packets > net: introduce skb_crc32c_csum_help > sk_buff: remove support for csum_bad in sk_buff > net: use skb->csum_not_inet to identify packets needing crc32c > net: more accurate checksumming in validate_xmit_skb() > openvswitch: more accurate checksumming in queue_userspace_packet() > sk_buff.h: improve description of CHECKSUM_{COMPLETE,UNNECESSARY} Other than the comments I did on patch 2, this series LGTM. > > Documentation/networking/checksum-offloads.txt | 11 +++-- > drivers/net/ethernet/aquantia/atlantic/aq_ring.c | 2 +- > include/linux/netdevice.h | 8 +-- > include/linux/skbuff.h | 58 +++++++++------------- > net/bridge/netfilter/nft_reject_bridge.c | 5 +- > net/core/dev.c | 63 +++++++++++++++++++++--- > net/core/skbuff.c | 24 +++++++++ > net/ipv4/netfilter/nf_reject_ipv4.c | 2 +- > net/ipv6/netfilter/nf_reject_ipv6.c | 3 -- > net/openvswitch/datapath.c | 2 +- > net/sched/act_csum.c | 1 + > net/sctp/offload.c | 8 +++ > net/sctp/output.c | 1 + > 13 files changed, 128 insertions(+), 60 deletions(-) > > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sctp" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
next prev parent reply other threads:[~2017-04-27 12:41 UTC|newest] Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-23 16:52 [RFC PATCH net-next 0/5] net: improve support for SCTP checksums Davide Caratti 2017-01-23 16:52 ` Davide Caratti 2017-01-23 16:52 ` [RFC PATCH net-next 1/5] skbuff: add stub to help computing crc32c on SCTP packets Davide Caratti 2017-01-23 16:52 ` Davide Caratti 2017-01-23 16:52 ` [RFC PATCH net-next 2/5] net: split skb_checksum_help Davide Caratti 2017-01-23 16:52 ` Davide Caratti 2017-01-23 20:59 ` Tom Herbert 2017-01-23 20:59 ` Tom Herbert 2017-01-24 16:35 ` David Laight 2017-01-24 16:35 ` David Laight 2017-02-02 15:07 ` Davide Caratti 2017-02-02 15:07 ` Davide Caratti 2017-02-02 16:55 ` David Laight 2017-02-02 16:55 ` David Laight 2017-02-02 18:08 ` Tom Herbert 2017-02-02 18:08 ` Tom Herbert 2017-02-27 13:39 ` Davide Caratti 2017-02-27 13:39 ` Davide Caratti 2017-02-27 15:11 ` Tom Herbert 2017-02-27 15:11 ` Tom Herbert 2017-02-28 10:31 ` Davide Caratti 2017-02-28 10:31 ` Davide Caratti 2017-02-28 10:32 ` [PATCH RFC net-next v2 1/4] skbuff: add stub to help computing crc32c on SCTP packets Davide Caratti 2017-02-28 10:32 ` Davide Caratti 2017-02-28 10:32 ` [PATCH RFC net-next v2 2/4] net: introduce skb_sctp_csum_help Davide Caratti 2017-02-28 10:32 ` Davide Caratti 2017-02-28 10:32 ` [PATCH RFC net-next v2 3/4] net: more accurate checksumming in validate_xmit_skb Davide Caratti 2017-02-28 10:32 ` Davide Caratti 2017-02-28 19:50 ` Tom Herbert 2017-02-28 19:50 ` Tom Herbert 2017-02-28 10:32 ` [PATCH RFC net-next v2 4/4] Documentation: update notes on checksum offloading Davide Caratti 2017-02-28 10:32 ` Davide Caratti 2017-02-28 22:46 ` [PATCH RFC net-next v2 1/4] skbuff: add stub to help computing crc32c on SCTP packets Alexander Duyck 2017-02-28 22:46 ` Alexander Duyck 2017-03-01 3:17 ` Tom Herbert 2017-03-01 3:17 ` Tom Herbert 2017-03-01 10:53 ` David Laight 2017-03-01 10:53 ` David Laight 2017-03-06 21:51 ` Davide Caratti 2017-03-06 21:51 ` Davide Caratti 2017-03-07 18:06 ` Alexander Duyck 2017-03-07 18:06 ` Alexander Duyck 2017-03-18 13:17 ` Davide Caratti 2017-03-18 13:17 ` Davide Caratti 2017-03-18 22:35 ` Tom Herbert 2017-03-18 22:35 ` Tom Herbert 2017-04-07 14:16 ` [PATCH RFC net-next v3 0/7] improve CRC32c in the forwarding path Davide Caratti 2017-04-07 14:16 ` Davide Caratti 2017-04-07 14:16 ` [PATCH RFC net-next v3 1/7] skbuff: add stub to help computing crc32c on SCTP packets Davide Caratti 2017-04-07 14:16 ` Davide Caratti 2017-04-07 14:16 ` [PATCH RFC net-next v3 2/7] net: introduce skb_crc32c_csum_help Davide Caratti 2017-04-07 14:16 ` Davide Caratti 2017-04-07 14:16 ` [PATCH RFC net-next v3 3/7] sk_buff: remove support for csum_bad in sk_buff Davide Caratti 2017-04-07 14:16 ` Davide Caratti 2017-04-07 14:16 ` [PATCH RFC net-next v3 4/7] net: use skb->csum_algo to identify packets needing crc32c Davide Caratti 2017-04-07 14:16 ` Davide Caratti 2017-04-07 15:43 ` Tom Herbert 2017-04-07 15:43 ` Tom Herbert 2017-04-07 17:29 ` Davide Caratti 2017-04-07 17:29 ` Davide Caratti 2017-04-07 18:11 ` Tom Herbert 2017-04-07 18:11 ` Tom Herbert 2017-04-13 10:36 ` Davide Caratti 2017-04-13 10:36 ` Davide Caratti 2017-04-20 13:38 ` [PATCH RFC net-next v4 0/7] net: improve support for SCTP checksums Davide Caratti 2017-04-20 13:38 ` Davide Caratti 2017-04-20 13:38 ` [PATCH RFC net-next v4 1/7] skbuff: add stub to help computing crc32c on SCTP packets Davide Caratti 2017-04-20 13:38 ` Davide Caratti 2017-04-20 13:38 ` [PATCH RFC net-next v4 2/7] net: introduce skb_crc32c_csum_help Davide Caratti 2017-04-20 13:38 ` Davide Caratti 2017-04-27 12:29 ` Marcelo Ricardo Leitner 2017-04-27 12:29 ` Marcelo Ricardo Leitner 2017-04-20 13:38 ` [PATCH RFC net-next v4 3/7] sk_buff: remove support for csum_bad in sk_buff Davide Caratti 2017-04-20 13:38 ` Davide Caratti 2017-04-27 1:34 ` [sk_buff] 95510aef27: BUG:Bad_page_state_in_process kernel test robot 2017-04-27 1:34 ` kernel test robot 2017-04-29 20:21 ` [PATCH RFC net-next v4 3/7] sk_buff: remove support for csum_bad in sk_buff Tom Herbert 2017-04-29 20:21 ` Tom Herbert 2017-04-20 13:38 ` [PATCH RFC net-next v4 4/7] net: use skb->csum_not_inet to identify packets needing crc32c Davide Caratti 2017-04-20 13:38 ` Davide Caratti 2017-04-29 20:18 ` Tom Herbert 2017-04-29 20:18 ` Tom Herbert 2017-04-20 13:38 ` [PATCH RFC net-next v4 5/7] net: more accurate checksumming in validate_xmit_skb() Davide Caratti 2017-04-20 13:38 ` Davide Caratti 2017-04-20 13:38 ` [PATCH RFC net-next v4 6/7] openvswitch: more accurate checksumming in queue_userspace_packet() Davide Caratti 2017-04-20 13:38 ` Davide Caratti 2017-04-20 13:38 ` [PATCH RFC net-next v4 7/7] sk_buff.h: improve description of CHECKSUM_{COMPLETE,UNNECESSARY} Davide Caratti 2017-04-20 13:38 ` Davide Caratti 2017-04-29 20:20 ` Tom Herbert 2017-04-29 20:20 ` Tom Herbert 2017-04-27 12:41 ` Marcelo Ricardo Leitner [this message] 2017-04-27 12:41 ` [PATCH RFC net-next v4 0/7] net: improve support for SCTP checksums Marcelo Ricardo Leitner 2017-04-07 14:16 ` [PATCH RFC net-next v3 5/7] net: more accurate checksumming in validate_xmit_skb() Davide Caratti 2017-04-07 14:16 ` Davide Caratti 2017-04-07 14:16 ` [PATCH RFC net-next v3 6/7] openvswitch: more accurate checksumming in queue_userspace_packet() Davide Caratti 2017-04-07 14:16 ` Davide Caratti 2017-04-07 14:16 ` [PATCH RFC net-next v3 7/7] sk_buff.h: improve description of CHECKSUM_{COMPLETE,UNNECESSARY} Davide Caratti 2017-04-07 14:16 ` Davide Caratti 2017-01-23 16:52 ` [RFC PATCH net-next 3/5] net: introduce skb_sctp_csum_help Davide Caratti 2017-01-23 16:52 ` Davide Caratti 2017-01-23 16:52 ` [RFC PATCH net-next 4/5] net: more accurate checksumming in validate_xmit_skb Davide Caratti 2017-01-23 16:52 ` Davide Caratti 2017-01-23 16:52 ` [RFC PATCH net-next 5/5] Documentation: add description of skb_sctp_csum_help Davide Caratti 2017-01-23 16:52 ` Davide Caratti
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170427124138.GB3216@localhost.localdomain \ --to=marcelo.leitner@gmail.com \ --cc=David.Laight@aculab.com \ --cc=alexander.duyck@gmail.com \ --cc=davem@davemloft.net \ --cc=dcaratti@redhat.com \ --cc=linux-sctp@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=tom@herbertland.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.