* [Buildroot] [PATCH 1/1] libcsv: new package
@ 2017-05-01 17:37 Matt Weber
2017-05-01 19:27 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Matt Weber @ 2017-05-01 17:37 UTC (permalink / raw)
To: buildroot
From: David Graziano <david.graziano@rockwellcollins.com>
libcsv is a small, simple and fast CSV library written in pure
ANSI C89 that can read and write CSV data.
Signed-off-by: David Graziano <david.graziano@rockwellcollins.com>
Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
---
package/Config.in | 1 +
package/libcsv/Config.in | 10 ++++++++++
package/libcsv/libcsv.hash | 2 ++
package/libcsv/libcsv.mk | 15 +++++++++++++++
4 files changed, 28 insertions(+)
create mode 100644 package/libcsv/Config.in
create mode 100644 package/libcsv/libcsv.hash
create mode 100644 package/libcsv/libcsv.mk
diff --git a/package/Config.in b/package/Config.in
index bfcfb73..e3b6682 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1367,6 +1367,7 @@ menu "Other"
source "package/libcofi/Config.in"
source "package/libcroco/Config.in"
source "package/libcrossguid/Config.in"
+ source "package/libcsv/Config.in"
source "package/libdaemon/Config.in"
source "package/libee/Config.in"
source "package/libev/Config.in"
diff --git a/package/libcsv/Config.in b/package/libcsv/Config.in
new file mode 100644
index 0000000..eaa6115
--- /dev/null
+++ b/package/libcsv/Config.in
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_LIBCSV
+ bool "libcsv"
+ help
+ libcsv is a small, simple and fast CSV library written in pure
+ ANSI C89 that can read and write CSV data. It provides a
+ straight-forward interface using callback functions to handle
+ parsed fields and rows and can parse improperly formatted CSV
+ files.
+
+ https://sourceforge.net/projects/libcsv/
diff --git a/package/libcsv/libcsv.hash b/package/libcsv/libcsv.hash
new file mode 100644
index 0000000..e35c44f
--- /dev/null
+++ b/package/libcsv/libcsv.hash
@@ -0,0 +1,2 @@
+#locally computed
+sha256 d9c0431cb803ceb9896ce74f683e6e5a0954e96ae1d9e4028d6e0f967bebd7e4 libcsv-3.0.3.tar.gz
diff --git a/package/libcsv/libcsv.mk b/package/libcsv/libcsv.mk
new file mode 100644
index 0000000..cfb4088
--- /dev/null
+++ b/package/libcsv/libcsv.mk
@@ -0,0 +1,15 @@
+################################################################################
+#
+# libcsv
+#
+################################################################################
+
+LIBCSV_VERSION = 3.0.3
+LIBCSV_SITE = http://sourceforge.net/projects/libcsv/files
+LIBCSV_SOURCE = libcsv-$(LIBCSV_VERSION).tar.gz
+LIBCSV_LICENSE = LGPLv2.1+
+LIBCSV_LICENSE_FILES = COPYING.LESSER
+LIBCSV_INSTALL_STAGING = YES
+
+$(eval $(host-autotools-package))
+$(eval $(autotools-package))
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] libcsv: new package
2017-05-01 17:37 [Buildroot] [PATCH 1/1] libcsv: new package Matt Weber
@ 2017-05-01 19:27 ` Thomas Petazzoni
2017-05-01 19:29 ` Matthew Weber
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2017-05-01 19:27 UTC (permalink / raw)
To: buildroot
Hello,
Thanks for this contribution, see some comments below.
On Mon, 1 May 2017 12:37:20 -0500, Matt Weber wrote:
> package/Config.in | 1 +
> package/libcsv/Config.in | 10 ++++++++++
> package/libcsv/libcsv.hash | 2 ++
> package/libcsv/libcsv.mk | 15 +++++++++++++++
Please add an entry to the DEVELOPERS file.
> +LIBCSV_VERSION = 3.0.3
> +LIBCSV_SITE = http://sourceforge.net/projects/libcsv/files
> +LIBCSV_SOURCE = libcsv-$(LIBCSV_VERSION).tar.gz
Not needed, this is the default value.
> +LIBCSV_LICENSE = LGPLv2.1+
Please use the SPDX license code: LGPL-2.1+
> +LIBCSV_LICENSE_FILES = COPYING.LESSER
> +LIBCSV_INSTALL_STAGING = YES
> +
> +$(eval $(host-autotools-package))
Why are you adding a host package ? If you don't intend to use it as a
dependency for another package or don't have a good reason to have a
host package, please don't add a host variant.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] libcsv: new package
2017-05-01 19:27 ` Thomas Petazzoni
@ 2017-05-01 19:29 ` Matthew Weber
0 siblings, 0 replies; 3+ messages in thread
From: Matthew Weber @ 2017-05-01 19:29 UTC (permalink / raw)
To: buildroot
Thomas,
On Mon, May 1, 2017 at 2:27 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> Thanks for this contribution, see some comments below.
>
> On Mon, 1 May 2017 12:37:20 -0500, Matt Weber wrote:
>
>> package/Config.in | 1 +
>> package/libcsv/Config.in | 10 ++++++++++
>> package/libcsv/libcsv.hash | 2 ++
>> package/libcsv/libcsv.mk | 15 +++++++++++++++
>
> Please add an entry to the DEVELOPERS file.
>
Will do.
>> +LIBCSV_VERSION = 3.0.3
>> +LIBCSV_SITE = http://sourceforge.net/projects/libcsv/files
>> +LIBCSV_SOURCE = libcsv-$(LIBCSV_VERSION).tar.gz
>
> Not needed, this is the default value.
Ah shoot, will update.
>
>> +LIBCSV_LICENSE = LGPLv2.1+
>
> Please use the SPDX license code: LGPL-2.1+
>
Will do.
>> +LIBCSV_LICENSE_FILES = COPYING.LESSER
>> +LIBCSV_INSTALL_STAGING = YES
>> +
>> +$(eval $(host-autotools-package))
>
> Why are you adding a host package ? If you don't intend to use it as a
> dependency for another package or don't have a good reason to have a
> host package, please don't add a host variant.
It's currently being used for a host side internal tool. We can
remove the host build and carry that internally as there isn't a
upstream reason to have it.
(Dave, care to update your MR and I'll resubmit?)
- Matt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-01 19:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-01 17:37 [Buildroot] [PATCH 1/1] libcsv: new package Matt Weber
2017-05-01 19:27 ` Thomas Petazzoni
2017-05-01 19:29 ` Matthew Weber
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.