* [PATCH 0/4] Pull Request
@ 2017-04-27 3:29 J William Piggott
2017-04-27 3:33 ` [PATCH 1/4] hwclock: extra messages for debug only J William Piggott
` (4 more replies)
0 siblings, 5 replies; 19+ messages in thread
From: J William Piggott @ 2017-04-27 3:29 UTC (permalink / raw)
To: Karel Zak; +Cc: util-linux, junk
sys-utils/hwclock.c | 27 +++++++++++++--------------
1 file changed, 13 insertions(+), 14 deletions(-)
The following changes since commit 85bfb519afcbccccb63849b1a348dde76ff6bb83:
switch_root: unlink files without _DIRENT_HAVE_D_TYPE (2017-04-26 11:23:50 +0200)
are available in the git repository at:
git@github.com:jwpi/util-linux.git 170419
for you to fetch changes up to 57415653a667cf2442d019f62287534931ab3da4:
hwclock: use a consistent name for --predict (2017-04-26 23:19:56 -0400)
----------------------------------------------------------------
J William Piggott (4):
hwclock: extra messages for debug only
hwclock: make clock test mode message consistent
hwclock: remove unneeded braces
hwclock: use a consistent name for --predict
sys-utils/hwclock.c | 27 +++++++++++++--------------
1 file changed, 13 insertions(+), 14 deletions(-)
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 1/4] hwclock: extra messages for debug only
2017-04-27 3:29 [PATCH 0/4] Pull Request J William Piggott
@ 2017-04-27 3:33 ` J William Piggott
2017-04-27 3:36 ` [PATCH 2/4] hwclock: make clock test mode message consistent J William Piggott
` (3 subsequent siblings)
4 siblings, 0 replies; 19+ messages in thread
From: J William Piggott @ 2017-04-27 3:33 UTC (permalink / raw)
To: Karel Zak; +Cc: util-linux, junk
Only print extra save_adjtime() messages in debug mode. This makes
the --test mode output consistent accross functions.
Signed-off-by: J William Piggott <elseifthen@gmx.com>
---
sys-utils/hwclock.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sys-utils/hwclock.c b/sys-utils/hwclock.c
index a98f4e3..31ee8fe 100644
--- a/sys-utils/hwclock.c
+++ b/sys-utils/hwclock.c
@@ -919,10 +919,10 @@ static void save_adjtime(const struct hwclock_control *ctl,
(adjtime->local_utc == LOCAL) ? "LOCAL" : "UTC");
if (ctl->testing) {
- printf(_
- ("Not updating adjtime file because of testing mode.\n"));
- printf(_("Would have written the following to %s:\n%s"),
- ctl->adj_file_name, content);
+ if (ctl->debug){
+ printf(_("Test mode: %s was not updated with:\n%s"),
+ ctl->adj_file_name, content);
+ }
free(content);
return;
}
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 2/4] hwclock: make clock test mode message consistent
2017-04-27 3:29 [PATCH 0/4] Pull Request J William Piggott
2017-04-27 3:33 ` [PATCH 1/4] hwclock: extra messages for debug only J William Piggott
@ 2017-04-27 3:36 ` J William Piggott
2017-04-27 3:39 ` [PATCH 3/4] hwclock: remove unneeded braces J William Piggott
` (2 subsequent siblings)
4 siblings, 0 replies; 19+ messages in thread
From: J William Piggott @ 2017-04-27 3:36 UTC (permalink / raw)
To: Karel Zak; +Cc: util-linux
Signed-off-by: J William Piggott <elseifthen@gmx.com>
---
sys-utils/hwclock.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sys-utils/hwclock.c b/sys-utils/hwclock.c
index 31ee8fe..4a187c5 100644
--- a/sys-utils/hwclock.c
+++ b/sys-utils/hwclock.c
@@ -391,7 +391,7 @@ set_hardware_clock(const struct hwclock_control *ctl, const time_t newtime)
new_broken_time.tm_sec, (long)newtime);
if (ctl->testing)
- printf(_("Clock not changed - testing only.\n"));
+ printf(_("Test mode: clock was not changed\n"));
else {
ur->set_hardware_clock(ctl, &new_broken_time);
}
@@ -636,7 +636,7 @@ set_system_clock(const struct hwclock_control *ctl, const bool hclock_valid,
}
if (ctl->testing) {
printf(_
- ("Not setting system clock because running in test mode.\n"));
+ ("Test mode: clock was not changed\n"));
retcode = 0;
} else {
const struct timezone tz = { minuteswest, 0 };
@@ -724,7 +724,7 @@ static int set_system_clock_timezone(const struct hwclock_control *ctl)
}
if (ctl->testing) {
printf(_
- ("Not setting system clock because running in test mode.\n"));
+ ("Test mode: clock was not changed\n"));
retcode = 0;
} else {
const struct timezone tz_utc = { 0, 0 };
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 3/4] hwclock: remove unneeded braces
2017-04-27 3:29 [PATCH 0/4] Pull Request J William Piggott
2017-04-27 3:33 ` [PATCH 1/4] hwclock: extra messages for debug only J William Piggott
2017-04-27 3:36 ` [PATCH 2/4] hwclock: make clock test mode message consistent J William Piggott
@ 2017-04-27 3:39 ` J William Piggott
2017-04-27 3:42 ` [PATCH 4/4] hwclock: use a consistent name for --predict J William Piggott
2017-05-02 9:13 ` [PATCH 0/4] Pull Request Karel Zak
4 siblings, 0 replies; 19+ messages in thread
From: J William Piggott @ 2017-04-27 3:39 UTC (permalink / raw)
To: Karel Zak; +Cc: util-linux
Signed-off-by: J William Piggott <elseifthen@gmx.com>
---
sys-utils/hwclock.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sys-utils/hwclock.c b/sys-utils/hwclock.c
index 4a187c5..e66acd2 100644
--- a/sys-utils/hwclock.c
+++ b/sys-utils/hwclock.c
@@ -392,9 +392,8 @@ set_hardware_clock(const struct hwclock_control *ctl, const time_t newtime)
if (ctl->testing)
printf(_("Test mode: clock was not changed\n"));
- else {
+ else
ur->set_hardware_clock(ctl, &new_broken_time);
- }
}
/*
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 4/4] hwclock: use a consistent name for --predict
2017-04-27 3:29 [PATCH 0/4] Pull Request J William Piggott
` (2 preceding siblings ...)
2017-04-27 3:39 ` [PATCH 3/4] hwclock: remove unneeded braces J William Piggott
@ 2017-04-27 3:42 ` J William Piggott
2017-05-02 9:13 ` [PATCH 0/4] Pull Request Karel Zak
4 siblings, 0 replies; 19+ messages in thread
From: J William Piggott @ 2017-04-27 3:42 UTC (permalink / raw)
To: Karel Zak; +Cc: util-linux
The predict function name is documented as '--predict', but the
code uses '--predict-hc'. This works okay, except that the
'mutually exclusive' error message prints the undocumented name.
* sys-utils/hwclock.c: rename 'predict-hc' to 'predict' so that
it matches the man-page. This should not be a problem because
'predict-hc' was never documented.
Signed-off-by: J William Piggott <elseifthen@gmx.com>
---
sys-utils/hwclock.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/sys-utils/hwclock.c b/sys-utils/hwclock.c
index e66acd2..e890cb8 100644
--- a/sys-utils/hwclock.c
+++ b/sys-utils/hwclock.c
@@ -1304,7 +1304,7 @@ int main(int argc, char **argv)
OPT_GETEPOCH,
OPT_LOCALTIME,
OPT_NOADJFILE,
- OPT_PREDICT_HC,
+ OPT_PREDICT,
OPT_SET,
OPT_SETEPOCH,
OPT_SYSTZ,
@@ -1337,7 +1337,7 @@ int main(int argc, char **argv)
#endif
{ "adjfile", required_argument, NULL, OPT_ADJFILE },
{ "systz", no_argument, NULL, OPT_SYSTZ },
- { "predict-hc", no_argument, NULL, OPT_PREDICT_HC },
+ { "predict", no_argument, NULL, OPT_PREDICT },
{ "get", no_argument, NULL, OPT_GET },
{ "update-drift", no_argument, NULL, OPT_UPDATE },
{ NULL, 0, NULL, 0 }
@@ -1345,7 +1345,7 @@ int main(int argc, char **argv)
static const ul_excl_t excl[] = { /* rows and cols in ASCII order */
{ 'a','r','s','w',
- OPT_GET, OPT_GETEPOCH, OPT_PREDICT_HC,
+ OPT_GET, OPT_GETEPOCH, OPT_PREDICT,
OPT_SET, OPT_SETEPOCH, OPT_SYSTZ },
{ 'u', OPT_LOCALTIME},
{ OPT_ADJFILE, OPT_NOADJFILE },
@@ -1454,8 +1454,8 @@ int main(int argc, char **argv)
ctl.systz = 1; /* --systz */
ctl.show = 0;
break;
- case OPT_PREDICT_HC:
- ctl.predict = 1; /* --predict-hc */
+ case OPT_PREDICT:
+ ctl.predict = 1; /* --predict */
ctl.show = 0;
break;
case OPT_GET:
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH 0/4] Pull Request
2017-04-27 3:29 [PATCH 0/4] Pull Request J William Piggott
` (3 preceding siblings ...)
2017-04-27 3:42 ` [PATCH 4/4] hwclock: use a consistent name for --predict J William Piggott
@ 2017-05-02 9:13 ` Karel Zak
4 siblings, 0 replies; 19+ messages in thread
From: Karel Zak @ 2017-05-02 9:13 UTC (permalink / raw)
To: J William Piggott; +Cc: util-linux, junk
On Wed, Apr 26, 2017 at 11:29:40PM -0400, J William Piggott wrote:
> hwclock: extra messages for debug only
> hwclock: make clock test mode message consistent
> hwclock: remove unneeded braces
> hwclock: use a consistent name for --predict
Applied, thanks.
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 0/4] Pull Request
2017-12-10 15:47 J William Piggott
@ 2017-12-11 14:53 ` Karel Zak
0 siblings, 0 replies; 19+ messages in thread
From: Karel Zak @ 2017-12-11 14:53 UTC (permalink / raw)
To: J William Piggott; +Cc: util-linux
On Sun, Dec 10, 2017 at 10:47:04AM -0500, J William Piggott wrote:
> J William Piggott (4):
> lib/timeutils.c: bug fix Segmentation fault
> lib/timeutils.c:strxxx_iso: test conversion errors
> lib/timeutils.c:strxxx_iso: do not wrap tm_year
> lib/timeutils.c: warn format_iso_time() overflow
Merged, thanks!
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 0/4] Pull Request
@ 2017-12-10 15:47 J William Piggott
2017-12-11 14:53 ` Karel Zak
0 siblings, 1 reply; 19+ messages in thread
From: J William Piggott @ 2017-12-10 15:47 UTC (permalink / raw)
To: Karel Zak; +Cc: util-linux
The following changes since commit 44d753407d6b751f022ef234c85785ccd99c5590:
tests: unlocks on failed ts_scsi_debug_init (2017-12-07 15:08:29 +0100)
are available in the git repository at:
git@github.com:jwpi/util-linux.git 171121
for you to fetch changes up to 6cdc7b9c02b251120eb014c4dbc2387d47e7fb46:
lib/timeutils.c: warn format_iso_time() overflow (2017-12-09 18:43:29 -0500)
----------------------------------------------------------------
J William Piggott (4):
lib/timeutils.c: bug fix Segmentation fault
lib/timeutils.c:strxxx_iso: test conversion errors
lib/timeutils.c:strxxx_iso: do not wrap tm_year
lib/timeutils.c: warn format_iso_time() overflow
lib/timeutils.c | 46 +++++++++++++++++++++++++++++++---------------
sys-utils/hwclock.c | 5 ++---
2 files changed, 33 insertions(+), 18 deletions(-)
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 0/4] Pull Request
@ 2017-10-23 0:37 J William Piggott
0 siblings, 0 replies; 19+ messages in thread
From: J William Piggott @ 2017-10-23 0:37 UTC (permalink / raw)
To: Karel Zak; +Cc: util-linux
This patch set address four bugs. Three are related to ISO 8601 formats
and the fourth is a tangentially related bug in hwclock.
Patch 0002 increases the ISO 8601 buffer macro from 32 to 42 which should
work for the first three, and may be usable in the last four files:
login-utils/last.c:1039 buffer size 32
misc-utils/uuidparse.c:231 uses ISO_8601_BUFSIZ + 4
login-utils/utmpdump.c:94 buffer size 40
login-utils/lslogins.c:316 buffer size 64
sys-utils/lsipc.c:1328 buffer size 64
sys-utils/dmesg.c:887 buffer size 256
term-utils/script.c:351 uses BUFSIZ (8K on my system)
I haven't tested it on them.
The the final patch adds some common ISO timestamp format masks.
The following changes since commit b41bac08abadbea9bac7a093c995ca53d86c76f1:
build-sys: move rfkill to /usr/sbin (2017-10-20 14:59:16 +0200)
are available in the git repository at:
git@github.com:jwpi/util-linux.git 170925
for you to fetch changes up to a9f92c6d1f25f4111f1334bdb2dd96f8b4ccb9ba:
lib/timeutils: add common ISO timestamp masks (2017-10-21 20:55:01 -0400)
----------------------------------------------------------------
J William Piggott (4):
hwclock: add iso-8601 overflow check
lib/timeutils: ISO_8601_BUFSIZ too small
lib/timeutils: add get_gmtoff()
lib/timeutils: add common ISO timestamp masks
include/timeutils.h | 23 ++++++++++++-----
lib/timeutils.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++---
login-utils/last.c | 2 +-
login-utils/lslogins.c | 3 +--
login-utils/utmpdump.c | 4 +--
misc-utils/uuidparse.c | 10 ++------
sys-utils/dmesg.c | 4 +--
sys-utils/hwclock.c | 23 +++++++----------
sys-utils/lsipc.c | 2 +-
sys-utils/rfkill.c | 8 ++----
term-utils/script.c | 8 ++----
11 files changed, 103 insertions(+), 54 deletions(-)
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 0/4] Pull Request
2017-07-16 17:46 J William Piggott
@ 2017-07-17 10:03 ` Karel Zak
0 siblings, 0 replies; 19+ messages in thread
From: Karel Zak @ 2017-07-17 10:03 UTC (permalink / raw)
To: J William Piggott; +Cc: util-linux
On Sun, Jul 16, 2017 at 01:46:38PM -0400, J William Piggott wrote:
> sys-utils/hwclock-rtc.c | 56 +++++++++++++++++++------------------------------
> sys-utils/hwclock.8.in | 3 +++
> sys-utils/hwclock.c | 24 +++++++--------------
> sys-utils/hwclock.h | 2 +-
> 4 files changed, 32 insertions(+), 53 deletions(-)
Applied, thanks.
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 0/4] Pull Request
@ 2017-07-16 17:46 J William Piggott
2017-07-17 10:03 ` Karel Zak
0 siblings, 1 reply; 19+ messages in thread
From: J William Piggott @ 2017-07-16 17:46 UTC (permalink / raw)
To: Karel Zak; +Cc: util-linux
The following changes since commit 8ffa3b651d7e74acba8f1d831b7f68fdb3c66aae:
libfdisk: make fdisk compliant to UEFI/GPT specification on PMBR (2017-07-14 12:48:18 +0200)
are available in the git repository at:
git@github.com:jwpi/util-linux.git 170711
for you to fetch changes up to c26ddc568f3fb26b45a22cbf89d3294113e70377:
hwclock: improve RTC epoch messages (2017-07-16 08:41:54 -0400)
----------------------------------------------------------------
J William Piggott (4):
hwclock: --epoch presence test fails
hwclock: remove dead ioctl check
hwclock: improve RTC epoch messages
hwclock: improve RTC epoch messages
sys-utils/hwclock-rtc.c | 56 +++++++++++++++++++------------------------------
sys-utils/hwclock.8.in | 3 +++
sys-utils/hwclock.c | 24 +++++++--------------
sys-utils/hwclock.h | 2 +-
4 files changed, 32 insertions(+), 53 deletions(-)
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 0/4] pull request
2017-06-26 13:47 ` J William Piggott
@ 2017-06-26 14:25 ` Karel Zak
0 siblings, 0 replies; 19+ messages in thread
From: Karel Zak @ 2017-06-26 14:25 UTC (permalink / raw)
To: J William Piggott; +Cc: util-linux
On Mon, Jun 26, 2017 at 09:47:42AM -0400, J William Piggott wrote:
>
>
> On 06/26/2017 04:27 AM, Karel Zak wrote:
> > On Sun, Jun 25, 2017 at 05:45:56PM -0400, J William Piggott wrote:
> >>
> >> * Rudi didn't like cluttering boilerplate.c with seldom used USAGE_*
> >> constants and I don't disagree with that point. I do think they should
> >> be in the file for new contributor discovery purposes. As a compromise
> >> I added the missing ones as a comment.
> >>
> >> * the newly added USAGE_COLUMNS could be used in disk-utils/fdisk-list.c:432
> >> if Karel wants to drop the ' (for -o)'. I did not change it.
> >
> > I think USAGE_COLUMNS should be good enough everywhere and the
> > additional notes (like ' (for -o)') are unnecessary.
> >
> > Maybe we can change the text to "Available output columns:" to make it
> > more specific for readers.
>
> Since we cannot guarantee that the 'output' option name will always be
> available.
I have already pushed "Available output columns:" :-)
The "output" does not mean any option in this case.
> It might be better to stay generic with the header and
> instead create the reference in the option description like:
>
> -o, --output <list> columns to display (see Columns:)
>
> Columns:
> SOURCE source device
> ...
Anyway, I like this "see Columns:" idea. Go ahead and send patch.
> On a somewhat related note; in recent discussion I've been trying to
> promote the idea of using consistent language. For example, with all of
> the synonyms: output, show, to stdout, display, print, etc. I think it
> would be helpful to both users and translators to choose one to be used
> consistently. Especially for technical writing it is important to use
> consistent terms.
>
> An idea from the Linux man-pages project is that man-pages.7 has a list
> of preferred terms/spellings; perhaps util-linux could have a list of
> preferred terms to be used in documentation and message strings?
Sounds good. (but I hope we will have no endless "bike-shed
color" discussion about the terms)
> We also might want to consider replacing Documentation/howto-man-page.txt
> with a link to, or a copy of, man-pages.7. Michael and company have
> added a lot to it in recent times.
Documentation/howto-man-page.txt is a template, if you want to write new
tool than it should be good enough to cp(1) this template and use it.
I'd like to keep it there.
We can rename the file to Documentation/boilerplate.1 and rewrite
Documentation/howto-man-page.txt to the real how-to with link to the
Michal's man-pages.7.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 0/4] pull request
2017-06-26 8:27 ` Karel Zak
2017-06-26 12:11 ` Karel Zak
@ 2017-06-26 13:47 ` J William Piggott
2017-06-26 14:25 ` Karel Zak
1 sibling, 1 reply; 19+ messages in thread
From: J William Piggott @ 2017-06-26 13:47 UTC (permalink / raw)
To: Karel Zak; +Cc: util-linux
On 06/26/2017 04:27 AM, Karel Zak wrote:
> On Sun, Jun 25, 2017 at 05:45:56PM -0400, J William Piggott wrote:
>>
>> * Rudi didn't like cluttering boilerplate.c with seldom used USAGE_*
>> constants and I don't disagree with that point. I do think they should
>> be in the file for new contributor discovery purposes. As a compromise
>> I added the missing ones as a comment.
>>
>> * the newly added USAGE_COLUMNS could be used in disk-utils/fdisk-list.c:432
>> if Karel wants to drop the ' (for -o)'. I did not change it.
>
> I think USAGE_COLUMNS should be good enough everywhere and the
> additional notes (like ' (for -o)') are unnecessary.
>
> Maybe we can change the text to "Available output columns:" to make it
> more specific for readers.
Since we cannot guarantee that the 'output' option name will always be
available. It might be better to stay generic with the header and
instead create the reference in the option description like:
-o, --output <list> columns to display (see Columns:)
Columns:
SOURCE source device
...
This would also keep the Columns header format consistent with the others.
On a somewhat related note; in recent discussion I've been trying to
promote the idea of using consistent language. For example, with all of
the synonyms: output, show, to stdout, display, print, etc. I think it
would be helpful to both users and translators to choose one to be used
consistently. Especially for technical writing it is important to use
consistent terms.
An idea from the Linux man-pages project is that man-pages.7 has a list
of preferred terms/spellings; perhaps util-linux could have a list of
preferred terms to be used in documentation and message strings?
We also might want to consider replacing Documentation/howto-man-page.txt
with a link to, or a copy of, man-pages.7. Michael and company have
added a lot to it in recent times.
>
> Karel
>
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 0/4] pull request
2017-06-26 8:27 ` Karel Zak
@ 2017-06-26 12:11 ` Karel Zak
2017-06-26 13:47 ` J William Piggott
1 sibling, 0 replies; 19+ messages in thread
From: Karel Zak @ 2017-06-26 12:11 UTC (permalink / raw)
To: J William Piggott; +Cc: util-linux
On Mon, Jun 26, 2017 at 10:27:44AM +0200, Karel Zak wrote:
> On Sun, Jun 25, 2017 at 05:45:56PM -0400, J William Piggott wrote:
> >
> > * Rudi didn't like cluttering boilerplate.c with seldom used USAGE_*
> > constants and I don't disagree with that point. I do think they should
> > be in the file for new contributor discovery purposes. As a compromise
> > I added the missing ones as a comment.
> >
> > * the newly added USAGE_COLUMNS could be used in disk-utils/fdisk-list.c:432
> > if Karel wants to drop the ' (for -o)'. I did not change it.
>
> I think USAGE_COLUMNS should be good enough everywhere and the
> additional notes (like ' (for -o)') are unnecessary.
>
> Maybe we can change the text to "Available output columns:" to make it
> more specific for readers.
Implemented & pull request merged. Thanks.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 0/4] pull request
2017-06-25 21:45 [PATCH 0/4] pull request J William Piggott
@ 2017-06-26 8:27 ` Karel Zak
2017-06-26 12:11 ` Karel Zak
2017-06-26 13:47 ` J William Piggott
0 siblings, 2 replies; 19+ messages in thread
From: Karel Zak @ 2017-06-26 8:27 UTC (permalink / raw)
To: J William Piggott; +Cc: util-linux
On Sun, Jun 25, 2017 at 05:45:56PM -0400, J William Piggott wrote:
>
> * Rudi didn't like cluttering boilerplate.c with seldom used USAGE_*
> constants and I don't disagree with that point. I do think they should
> be in the file for new contributor discovery purposes. As a compromise
> I added the missing ones as a comment.
>
> * the newly added USAGE_COLUMNS could be used in disk-utils/fdisk-list.c:432
> if Karel wants to drop the ' (for -o)'. I did not change it.
I think USAGE_COLUMNS should be good enough everywhere and the
additional notes (like ' (for -o)') are unnecessary.
Maybe we can change the text to "Available output columns:" to make it
more specific for readers.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 0/4] pull request
@ 2017-06-25 21:45 J William Piggott
2017-06-26 8:27 ` Karel Zak
0 siblings, 1 reply; 19+ messages in thread
From: J William Piggott @ 2017-06-25 21:45 UTC (permalink / raw)
To: Karel Zak; +Cc: util-linux
* Rudi didn't like cluttering boilerplate.c with seldom used USAGE_*
constants and I don't disagree with that point. I do think they should
be in the file for new contributor discovery purposes. As a compromise
I added the missing ones as a comment.
* the newly added USAGE_COLUMNS could be used in disk-utils/fdisk-list.c:432
if Karel wants to drop the ' (for -o)'. I did not change it.
* I couldn't test the blkzone change to USAGE_COMMANDS, but I expect it to
be okay.
configure: WARNING: linux/blkzoned.h header not found; not building blkzone
The following changes since commit 2a14beb4e9c6cdf4466993741d86e45dd57ddef3:
agetty: fix login name DEL/CTRL^U issue (2017-06-23 14:26:47 +0200)
are available in the git repository at:
git@github.com:jwpi/util-linux.git 170622
for you to fetch changes up to 7948117da5654311dba59b256d9a017d56877592:
Docs: move option naming to howto-contribute.txt (2017-06-24 15:22:49 -0400)
----------------------------------------------------------------
J William Piggott (4):
include/c.h: add USAGE_COMMANDS and USAGE_COLUMNS
Docs: add a comment for constants to boilerplate.c
Docs: update howto-usage-function.txt
Docs: move option naming to howto-contribute.txt
Documentation/boilerplate.c | 8 +--
Documentation/howto-contribute.txt | 25 +++++++++
Documentation/howto-usage-function.txt | 97 +++++++++++++---------------------
disk-utils/sfdisk.c | 2 +-
include/c.h | 4 +-
login-utils/lslogins.c | 6 +--
misc-utils/findmnt.c | 3 +-
sys-utils/blkzone.c | 2 +-
sys-utils/lscpu.c | 3 +-
sys-utils/lsmem.c | 5 +-
sys-utils/wdctl.c | 3 +-
11 files changed, 78 insertions(+), 80 deletions(-)
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 0/4] pull request
2017-05-31 18:45 J William Piggott
@ 2017-06-01 8:54 ` Karel Zak
0 siblings, 0 replies; 19+ messages in thread
From: Karel Zak @ 2017-06-01 8:54 UTC (permalink / raw)
To: J William Piggott; +Cc: util-linux
On Wed, May 31, 2017 at 02:45:23PM -0400, J William Piggott wrote:
> git@github.com:jwpi/util-linux.git 170529
Applied, thanks.
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 0/4] pull request
@ 2017-05-31 18:45 J William Piggott
2017-06-01 8:54 ` Karel Zak
0 siblings, 1 reply; 19+ messages in thread
From: J William Piggott @ 2017-05-31 18:45 UTC (permalink / raw)
To: Karel Zak; +Cc: util-linux
docs: various changes; see patches for details.
The following changes since commit 3947ca4ca9737d830f54658ef353f5626c0d0282:
build-sys: ncurses headers cleanup (2017-05-31 11:01:46 +0200)
are available in the git repository at:
git@github.com:jwpi/util-linux.git 170529
for you to fetch changes up to 80008bcae9a1aed3d38507a319155a69c4414509:
docs: move source-code-management.txt to README (2017-05-31 11:36:47 -0400)
----------------------------------------------------------------
J William Piggott (4):
docs: update v2.30-ReleaseNotes
docs: update howto-contribute.txt
docs: update howto-contribute.txt
docs: move source-code-management.txt to README
Documentation/howto-contribute.txt | 201 +++++++++++++++---------------
Documentation/release-schedule.txt | 2 +-
Documentation/releases/v2.30-ReleaseNotes | 38 +++---
Documentation/source-code-management.txt | 38 ------
README | 121 +++++++++++++-----
5 files changed, 215 insertions(+), 185 deletions(-)
delete mode 100644 Documentation/source-code-management.txt
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 0/4] Pull request
@ 2011-04-18 8:00 Martin Jansa
0 siblings, 0 replies; 19+ messages in thread
From: Martin Jansa @ 2011-04-18 8:00 UTC (permalink / raw)
To: openembedded-core
First two patches are taken from previous pull request
(without rejected distutils-common-base.bbclass: Prepend STAGING_LIBDIR to linker library search path.)
Other two allows distro layer to be a bit smaller.
Pull URL: git://git.openembedded.org/openembedded-core-contrib
Branch: jansa/pull
Browse: http://git.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=jansa/pull
Thanks,
Martin Jansa <Martin.Jansa@gmail.com>
---
Martin Jansa (4):
gconf-dbus: add SRCREV to recipe
xf86-video-omapfb: add SRCREV to recipe
task-base: allow distribution to define apm provider
python-dir.bbclass: define default PYTHON_BASEVERSION
meta/classes/python-dir.bbclass | 1 +
meta/recipes-core/tasks/task-base.bb | 5 ++++-
meta/recipes-gnome/gnome/gconf-dbus_svn.bb | 1 +
.../xorg-driver/xf86-video-omapfb_git.bb | 1 +
4 files changed, 7 insertions(+), 1 deletions(-)
--
1.7.5.rc1
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2017-12-11 14:53 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-27 3:29 [PATCH 0/4] Pull Request J William Piggott
2017-04-27 3:33 ` [PATCH 1/4] hwclock: extra messages for debug only J William Piggott
2017-04-27 3:36 ` [PATCH 2/4] hwclock: make clock test mode message consistent J William Piggott
2017-04-27 3:39 ` [PATCH 3/4] hwclock: remove unneeded braces J William Piggott
2017-04-27 3:42 ` [PATCH 4/4] hwclock: use a consistent name for --predict J William Piggott
2017-05-02 9:13 ` [PATCH 0/4] Pull Request Karel Zak
-- strict thread matches above, loose matches on Subject: below --
2017-12-10 15:47 J William Piggott
2017-12-11 14:53 ` Karel Zak
2017-10-23 0:37 J William Piggott
2017-07-16 17:46 J William Piggott
2017-07-17 10:03 ` Karel Zak
2017-06-25 21:45 [PATCH 0/4] pull request J William Piggott
2017-06-26 8:27 ` Karel Zak
2017-06-26 12:11 ` Karel Zak
2017-06-26 13:47 ` J William Piggott
2017-06-26 14:25 ` Karel Zak
2017-05-31 18:45 J William Piggott
2017-06-01 8:54 ` Karel Zak
2011-04-18 8:00 [PATCH 0/4] Pull request Martin Jansa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.