All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package: protobuf: fix build on gcc < 4.5.0
@ 2017-05-03  0:14 Mario J. Rugiero
  2017-05-03  4:02 ` Baruch Siach
  0 siblings, 1 reply; 5+ messages in thread
From: Mario J. Rugiero @ 2017-05-03  0:14 UTC (permalink / raw)
  To: buildroot

Add upstream patch working around a gcc bug which got fixed in version 4.5.0.

Fixes:
http://autobuild.buildroot.org/results/77d/77dbb6bbbc0ea9e9bcdd22b10011ef9728c20d54/
http://autobuild.buildroot.org/results/21f/21f5e1ea4f37e1d174604d6da78c0e916c89f1e3/
http://autobuild.buildroot.org/results/24e/24e880086c87d40b5d79a90d805acc75b33d484c/

Signed-off-by: Mario J. Rugiero <mrugiero@gmail.com>
---
 package/protobuf/protobuf.hash | 1 +
 package/protobuf/protobuf.mk   | 1 +
 2 files changed, 2 insertions(+)

diff --git a/package/protobuf/protobuf.hash b/package/protobuf/protobuf.hash
index 8c2ade37e..9b8e1e86d 100644
--- a/package/protobuf/protobuf.hash
+++ b/package/protobuf/protobuf.hash
@@ -1,3 +1,4 @@
 # Locally calculated
 sha256 51d773e4297238b282eaa4c1dd317099675b12eef2b414732b851c00459225c6 protobuf-cpp-3.2.0.tar.gz
 sha256 da80c39838515913633f4cbd875fdd4ad711be95c83a50ff5096b9f1254033b3 416f90939d4de58fe1a4e2489120010313183291.patch
+sha256 309c8fd476863ddf9726a9700023d6349f7305e05bec071a06f4ccf7e90a7053 a83ac8663fb8042a881bc60b12a8bd3a0c03a3ff.patch
diff --git a/package/protobuf/protobuf.mk b/package/protobuf/protobuf.mk
index 610da8c04..92b6fe344 100644
--- a/package/protobuf/protobuf.mk
+++ b/package/protobuf/protobuf.mk
@@ -20,6 +20,7 @@ PROTOBUF_CONF_OPTS = --with-protoc=$(HOST_DIR)/usr/bin/protoc
 PROTOBUF_INSTALL_STAGING = YES
 
 PROTOBUF_PATCH = https://github.com/google/protobuf/commit/416f90939d4de58fe1a4e2489120010313183291.patch
+PROTOBUF_PATCH += https://github.com/google/protobuf/commit/a83ac8663fb8042a881bc60b12a8bd3a0c03a3ff.patch
 
 ifeq ($(BR2_PACKAGE_ZLIB),y)
 PROTOBUF_DEPENDENCIES += zlib
-- 
2.12.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package: protobuf: fix build on gcc < 4.5.0
  2017-05-03  0:14 [Buildroot] [PATCH] package: protobuf: fix build on gcc < 4.5.0 Mario J. Rugiero
@ 2017-05-03  4:02 ` Baruch Siach
  2017-05-03  5:07   ` Mario Rugiero
  0 siblings, 1 reply; 5+ messages in thread
From: Baruch Siach @ 2017-05-03  4:02 UTC (permalink / raw)
  To: buildroot

Hi Mario,

On Tue, May 02, 2017 at 09:14:24PM -0300, Mario J. Rugiero wrote:
> Add upstream patch working around a gcc bug which got fixed in version 4.5.0.

Is there a reason not to bump version to 3.3.0 that includes this fix?

baruch

> Fixes:
> http://autobuild.buildroot.org/results/77d/77dbb6bbbc0ea9e9bcdd22b10011ef9728c20d54/
> http://autobuild.buildroot.org/results/21f/21f5e1ea4f37e1d174604d6da78c0e916c89f1e3/
> http://autobuild.buildroot.org/results/24e/24e880086c87d40b5d79a90d805acc75b33d484c/
> 
> Signed-off-by: Mario J. Rugiero <mrugiero@gmail.com>
> ---
>  package/protobuf/protobuf.hash | 1 +
>  package/protobuf/protobuf.mk   | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/package/protobuf/protobuf.hash b/package/protobuf/protobuf.hash
> index 8c2ade37e..9b8e1e86d 100644
> --- a/package/protobuf/protobuf.hash
> +++ b/package/protobuf/protobuf.hash
> @@ -1,3 +1,4 @@
>  # Locally calculated
>  sha256 51d773e4297238b282eaa4c1dd317099675b12eef2b414732b851c00459225c6 protobuf-cpp-3.2.0.tar.gz
>  sha256 da80c39838515913633f4cbd875fdd4ad711be95c83a50ff5096b9f1254033b3 416f90939d4de58fe1a4e2489120010313183291.patch
> +sha256 309c8fd476863ddf9726a9700023d6349f7305e05bec071a06f4ccf7e90a7053 a83ac8663fb8042a881bc60b12a8bd3a0c03a3ff.patch
> diff --git a/package/protobuf/protobuf.mk b/package/protobuf/protobuf.mk
> index 610da8c04..92b6fe344 100644
> --- a/package/protobuf/protobuf.mk
> +++ b/package/protobuf/protobuf.mk
> @@ -20,6 +20,7 @@ PROTOBUF_CONF_OPTS = --with-protoc=$(HOST_DIR)/usr/bin/protoc
>  PROTOBUF_INSTALL_STAGING = YES
>  
>  PROTOBUF_PATCH = https://github.com/google/protobuf/commit/416f90939d4de58fe1a4e2489120010313183291.patch
> +PROTOBUF_PATCH += https://github.com/google/protobuf/commit/a83ac8663fb8042a881bc60b12a8bd3a0c03a3ff.patch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package: protobuf: fix build on gcc < 4.5.0
  2017-05-03  4:02 ` Baruch Siach
@ 2017-05-03  5:07   ` Mario Rugiero
  0 siblings, 0 replies; 5+ messages in thread
From: Mario Rugiero @ 2017-05-03  5:07 UTC (permalink / raw)
  To: buildroot

2017-05-03 1:02 GMT-03:00 Baruch Siach <baruch@tkos.co.il>:
> Hi Mario,
>
> On Tue, May 02, 2017 at 09:14:24PM -0300, Mario J. Rugiero wrote:
>> Add upstream patch working around a gcc bug which got fixed in version 4.5.0.
>
> Is there a reason not to bump version to 3.3.0 that includes this fix?
>
> baruch
>
>> Fixes:
>> http://autobuild.buildroot.org/results/77d/77dbb6bbbc0ea9e9bcdd22b10011ef9728c20d54/
>> http://autobuild.buildroot.org/results/21f/21f5e1ea4f37e1d174604d6da78c0e916c89f1e3/
>> http://autobuild.buildroot.org/results/24e/24e880086c87d40b5d79a90d805acc75b33d484c/
>>
>> Signed-off-by: Mario J. Rugiero <mrugiero@gmail.com>
>> ---
>>  package/protobuf/protobuf.hash | 1 +
>>  package/protobuf/protobuf.mk   | 1 +
>>  2 files changed, 2 insertions(+)
>>
>> diff --git a/package/protobuf/protobuf.hash b/package/protobuf/protobuf.hash
>> index 8c2ade37e..9b8e1e86d 100644
>> --- a/package/protobuf/protobuf.hash
>> +++ b/package/protobuf/protobuf.hash
>> @@ -1,3 +1,4 @@
>>  # Locally calculated
>>  sha256 51d773e4297238b282eaa4c1dd317099675b12eef2b414732b851c00459225c6 protobuf-cpp-3.2.0.tar.gz
>>  sha256 da80c39838515913633f4cbd875fdd4ad711be95c83a50ff5096b9f1254033b3 416f90939d4de58fe1a4e2489120010313183291.patch
>> +sha256 309c8fd476863ddf9726a9700023d6349f7305e05bec071a06f4ccf7e90a7053 a83ac8663fb8042a881bc60b12a8bd3a0c03a3ff.patch
>> diff --git a/package/protobuf/protobuf.mk b/package/protobuf/protobuf.mk
>> index 610da8c04..92b6fe344 100644
>> --- a/package/protobuf/protobuf.mk
>> +++ b/package/protobuf/protobuf.mk
>> @@ -20,6 +20,7 @@ PROTOBUF_CONF_OPTS = --with-protoc=$(HOST_DIR)/usr/bin/protoc
>>  PROTOBUF_INSTALL_STAGING = YES
>>
>>  PROTOBUF_PATCH = https://github.com/google/protobuf/commit/416f90939d4de58fe1a4e2489120010313183291.patch
>> +PROTOBUF_PATCH += https://github.com/google/protobuf/commit/a83ac8663fb8042a881bc60b12a8bd3a0c03a3ff.patch
>
> --
>      http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>    - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
None. I missed the announcement. Will make a new patch as soon as I
got my work box working again. I accidentally killed it.

Regards,
Mario.

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package: protobuf: fix build on gcc < 4.5.0
  2017-05-03 19:16 Mario J. Rugiero
@ 2017-05-03 19:21 ` Mario Rugiero
  0 siblings, 0 replies; 5+ messages in thread
From: Mario Rugiero @ 2017-05-03 19:21 UTC (permalink / raw)
  To: buildroot

2017-05-03 16:16 GMT-03:00 Mario J. Rugiero <mrugiero@gmail.com>:
> Add upstream patch working around a gcc bug which got fixed in version 4.5.0.
>
> Fixes:
> http://autobuild.buildroot.org/results/77d/77dbb6bbbc0ea9e9bcdd22b10011ef9728c20d54/
> http://autobuild.buildroot.org/results/21f/21f5e1ea4f37e1d174604d6da78c0e916c89f1e3/
> http://autobuild.buildroot.org/results/24e/24e880086c87d40b5d79a90d805acc75b33d484c/
>
> Tested with:
> qemu_aarch64_virt_defconfig
>
> Signed-off-by: Mario J. Rugiero <mrugiero@gmail.com>
> ---
>  package/protobuf/protobuf.hash | 1 +
>  package/protobuf/protobuf.mk   | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/package/protobuf/protobuf.hash b/package/protobuf/protobuf.hash
> index 8c2ade37e..9b8e1e86d 100644
> --- a/package/protobuf/protobuf.hash
> +++ b/package/protobuf/protobuf.hash
> @@ -1,3 +1,4 @@
>  # Locally calculated
>  sha256 51d773e4297238b282eaa4c1dd317099675b12eef2b414732b851c00459225c6 protobuf-cpp-3.2.0.tar.gz
>  sha256 da80c39838515913633f4cbd875fdd4ad711be95c83a50ff5096b9f1254033b3 416f90939d4de58fe1a4e2489120010313183291.patch
> +sha256 309c8fd476863ddf9726a9700023d6349f7305e05bec071a06f4ccf7e90a7053 a83ac8663fb8042a881bc60b12a8bd3a0c03a3ff.patch
> diff --git a/package/protobuf/protobuf.mk b/package/protobuf/protobuf.mk
> index 610da8c04..92b6fe344 100644
> --- a/package/protobuf/protobuf.mk
> +++ b/package/protobuf/protobuf.mk
> @@ -20,6 +20,7 @@ PROTOBUF_CONF_OPTS = --with-protoc=$(HOST_DIR)/usr/bin/protoc
>  PROTOBUF_INSTALL_STAGING = YES
>
>  PROTOBUF_PATCH = https://github.com/google/protobuf/commit/416f90939d4de58fe1a4e2489120010313183291.patch
> +PROTOBUF_PATCH += https://github.com/google/protobuf/commit/a83ac8663fb8042a881bc60b12a8bd3a0c03a3ff.patch
>
>  ifeq ($(BR2_PACKAGE_ZLIB),y)
>  PROTOBUF_DEPENDENCIES += zlib
> --
> 2.12.2
>
Nevermind this, I thought I had bumped the version already.

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package: protobuf: fix build on gcc < 4.5.0
@ 2017-05-03 19:16 Mario J. Rugiero
  2017-05-03 19:21 ` Mario Rugiero
  0 siblings, 1 reply; 5+ messages in thread
From: Mario J. Rugiero @ 2017-05-03 19:16 UTC (permalink / raw)
  To: buildroot

Add upstream patch working around a gcc bug which got fixed in version 4.5.0.

Fixes:
http://autobuild.buildroot.org/results/77d/77dbb6bbbc0ea9e9bcdd22b10011ef9728c20d54/
http://autobuild.buildroot.org/results/21f/21f5e1ea4f37e1d174604d6da78c0e916c89f1e3/
http://autobuild.buildroot.org/results/24e/24e880086c87d40b5d79a90d805acc75b33d484c/

Tested with:
qemu_aarch64_virt_defconfig

Signed-off-by: Mario J. Rugiero <mrugiero@gmail.com>
---
 package/protobuf/protobuf.hash | 1 +
 package/protobuf/protobuf.mk   | 1 +
 2 files changed, 2 insertions(+)

diff --git a/package/protobuf/protobuf.hash b/package/protobuf/protobuf.hash
index 8c2ade37e..9b8e1e86d 100644
--- a/package/protobuf/protobuf.hash
+++ b/package/protobuf/protobuf.hash
@@ -1,3 +1,4 @@
 # Locally calculated
 sha256 51d773e4297238b282eaa4c1dd317099675b12eef2b414732b851c00459225c6 protobuf-cpp-3.2.0.tar.gz
 sha256 da80c39838515913633f4cbd875fdd4ad711be95c83a50ff5096b9f1254033b3 416f90939d4de58fe1a4e2489120010313183291.patch
+sha256 309c8fd476863ddf9726a9700023d6349f7305e05bec071a06f4ccf7e90a7053 a83ac8663fb8042a881bc60b12a8bd3a0c03a3ff.patch
diff --git a/package/protobuf/protobuf.mk b/package/protobuf/protobuf.mk
index 610da8c04..92b6fe344 100644
--- a/package/protobuf/protobuf.mk
+++ b/package/protobuf/protobuf.mk
@@ -20,6 +20,7 @@ PROTOBUF_CONF_OPTS = --with-protoc=$(HOST_DIR)/usr/bin/protoc
 PROTOBUF_INSTALL_STAGING = YES
 
 PROTOBUF_PATCH = https://github.com/google/protobuf/commit/416f90939d4de58fe1a4e2489120010313183291.patch
+PROTOBUF_PATCH += https://github.com/google/protobuf/commit/a83ac8663fb8042a881bc60b12a8bd3a0c03a3ff.patch
 
 ifeq ($(BR2_PACKAGE_ZLIB),y)
 PROTOBUF_DEPENDENCIES += zlib
-- 
2.12.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-05-03 19:21 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-03  0:14 [Buildroot] [PATCH] package: protobuf: fix build on gcc < 4.5.0 Mario J. Rugiero
2017-05-03  4:02 ` Baruch Siach
2017-05-03  5:07   ` Mario Rugiero
2017-05-03 19:16 Mario J. Rugiero
2017-05-03 19:21 ` Mario Rugiero

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.