From: Peter Ujfalusi <peter.ujfalusi@ti.com> To: <b-liu@ti.com>, <tony@atomide.com>, <gregkh@linuxfoundation.org> Cc: <linux-usb@vger.kernel.org>, <linux-omap@vger.kernel.org>, <balbi@kernel.org>, <linux-kernel@vger.kernel.org> Subject: [PATCH 0/4] usb: musb: tusb6010_omap: Convert to DMAengine Date: Wed, 3 May 2017 13:54:02 +0300 [thread overview] Message-ID: <20170503105406.25125-1-peter.ujfalusi@ti.com> (raw) Hi, With port_window support implemented in DMAengine and the sDMA DMAengine driver, the tusb6010_omap driver can be converted away from the custom legacy omap-dma API to generic DMAengine. The first two patch is to prepare the tusb6010_omap driver for the conversion. The third one adds the needed entries for the dma_slave_map so we can request the DMA channels. This can be reverted when the stack is converted to DT. The last patch does the main work to move the driver to DMAengine API. I have tested the set on top of next-20170503 on Nokia n810 with nfsroot using CDC Ethernet (g_cdc) and copying files with scp to/form my host. To force that the DMA is actually used I have: diff --git a/drivers/usb/musb/tusb6010_omap.c b/drivers/usb/musb/tusb6010_omap.c index 05aefcad40b5..a5fc2a6bdad3 100644 --- a/drivers/usb/musb/tusb6010_omap.c +++ b/drivers/usb/musb/tusb6010_omap.c @@ -216,8 +216,8 @@ static int tusb_omap_dma_program(struct dma_channel *channel, u16 packet_sz, * use a timer for the callback, but it is unsafe as the XFR_SIZE * register is corrupt, and we won't know if the DMA worked. */ - if (dma_addr & 0x2) - return false; +// if (dma_addr & 0x2) +// return false; /* * Because of HW issue #10, it seems like mixing sync DMA and async Since this condition will almost all the time was true - effectively disabling the DMA use. Regards. Peter --- Peter Ujfalusi (4): usb: musb: tusb6010_omap: Create new struct for DMA data/parameters usb: musb: tusb6010_omap: Allocate DMA channels upfront ARM: OMAP2+: DMA: Add slave map entries for 24xx external request lines usb: musb: tusb6010_omap: Convert to dmaengine WIP arch/arm/mach-omap2/dma.c | 24 +++ drivers/usb/musb/tusb6010_omap.c | 342 ++++++++++++++++++--------------------- 2 files changed, 177 insertions(+), 189 deletions(-) -- 2.12.2
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com> To: b-liu@ti.com, tony@atomide.com, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, balbi@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/4] usb: musb: tusb6010_omap: Convert to DMAengine Date: Wed, 3 May 2017 13:54:02 +0300 [thread overview] Message-ID: <20170503105406.25125-1-peter.ujfalusi@ti.com> (raw) Hi, With port_window support implemented in DMAengine and the sDMA DMAengine driver, the tusb6010_omap driver can be converted away from the custom legacy omap-dma API to generic DMAengine. The first two patch is to prepare the tusb6010_omap driver for the conversion. The third one adds the needed entries for the dma_slave_map so we can request the DMA channels. This can be reverted when the stack is converted to DT. The last patch does the main work to move the driver to DMAengine API. I have tested the set on top of next-20170503 on Nokia n810 with nfsroot using CDC Ethernet (g_cdc) and copying files with scp to/form my host. To force that the DMA is actually used I have: diff --git a/drivers/usb/musb/tusb6010_omap.c b/drivers/usb/musb/tusb6010_omap.c index 05aefcad40b5..a5fc2a6bdad3 100644 --- a/drivers/usb/musb/tusb6010_omap.c +++ b/drivers/usb/musb/tusb6010_omap.c @@ -216,8 +216,8 @@ static int tusb_omap_dma_program(struct dma_channel *channel, u16 packet_sz, * use a timer for the callback, but it is unsafe as the XFR_SIZE * register is corrupt, and we won't know if the DMA worked. */ - if (dma_addr & 0x2) - return false; +// if (dma_addr & 0x2) +// return false; /* * Because of HW issue #10, it seems like mixing sync DMA and async Since this condition will almost all the time was true - effectively disabling the DMA use. Regards. Peter --- Peter Ujfalusi (4): usb: musb: tusb6010_omap: Create new struct for DMA data/parameters usb: musb: tusb6010_omap: Allocate DMA channels upfront ARM: OMAP2+: DMA: Add slave map entries for 24xx external request lines usb: musb: tusb6010_omap: Convert to dmaengine WIP arch/arm/mach-omap2/dma.c | 24 +++ drivers/usb/musb/tusb6010_omap.c | 342 ++++++++++++++++++--------------------- 2 files changed, 177 insertions(+), 189 deletions(-) -- 2.12.2
next reply other threads:[~2017-05-03 10:55 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-03 10:54 Peter Ujfalusi [this message] 2017-05-03 10:54 ` [PATCH 0/4] usb: musb: tusb6010_omap: Convert to DMAengine Peter Ujfalusi 2017-05-03 10:57 ` Peter Ujfalusi 2017-05-03 10:57 ` Peter Ujfalusi 2017-05-03 10:56 Peter Ujfalusi 2017-05-03 10:56 ` Peter Ujfalusi 2017-05-04 14:31 ` Tony Lindgren 2017-05-05 7:28 ` Peter Ujfalusi 2017-05-05 7:28 ` Peter Ujfalusi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170503105406.25125-1-peter.ujfalusi@ti.com \ --to=peter.ujfalusi@ti.com \ --cc=b-liu@ti.com \ --cc=balbi@kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.