All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-filesystems][PATCH 1/2] xfsdump: 3.1.4 -> 3.1.6
@ 2017-05-04  9:32 Chen Qi
  2017-05-04  9:32 ` [meta-filesystems][PATCH 2/2] xfsdump: fix do_configure failure and remove from blacklist Chen Qi
  2017-05-04  9:55 ` [meta-filesystems][PATCH 1/2] xfsdump: 3.1.4 -> 3.1.6 Martin Jansa
  0 siblings, 2 replies; 4+ messages in thread
From: Chen Qi @ 2017-05-04  9:32 UTC (permalink / raw)
  To: openembedded-devel

From: Robert Yang <liezhi.yang@windriver.com>

The 3.1.4 doesn't work with xfsprogs 4.7:
| inv_files.o: In function `inv_dirpath':
|xfsdump-3.1.4/invutil/inv_files.c:53: undefined reference to `ASSERT'
| inv_files.o: In function `inv_fstab':
|xfsdump-3.1.4/invutil/inv_files.c:60: undefined reference to `ASSERT'
| inv_files.o: In function `inv_lockfile':
|xfsdump-3.1.4/invutil/inv_files.c:67: undefined reference to `ASSERT'
| inv_files.o: In function `inv_basepath':
|xfsdump-3.1.4/invutil/inv_files.c:74: undefined reference to `ASSERT'
| collect2: error: ld returned 1 exit status
| make[2]: *** [../include/buildrules:33: xfsinvutil] Error 1

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 .../recipes-utils/xfsdump/xfsdump_3.1.6.bb         | 38 ++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 meta-filesystems/recipes-utils/xfsdump/xfsdump_3.1.6.bb

diff --git a/meta-filesystems/recipes-utils/xfsdump/xfsdump_3.1.6.bb b/meta-filesystems/recipes-utils/xfsdump/xfsdump_3.1.6.bb
new file mode 100644
index 000000000..8f942ba7c
--- /dev/null
+++ b/meta-filesystems/recipes-utils/xfsdump/xfsdump_3.1.6.bb
@@ -0,0 +1,38 @@
+SUMMARY = "XFS Filesystem Dump Utility"
+DESCRIPTION = "The xfsdump package contains xfsdump, xfsrestore and a \
+               number of other utilities for administering XFS filesystems.\
+               xfsdump examines files in a filesystem, determines which \
+               need to be backed up, and copies those files to a \
+               specified disk, tape or other storage medium."
+HOMEPAGE = "http://oss.sgi.com/projects/xfs"
+SECTION = "base"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://doc/COPYING;md5=15c832894d10ddd00dfcf57bee490ecc"
+DEPENDS = "xfsprogs attr"
+
+SRC_URI = "ftp://oss.sgi.com/projects/xfs/cmd_tars/${BPN}-${PV}.tar.gz \
+    file://remove-install-as-user.patch \
+"
+SRC_URI[md5sum] = "50353cd4f4b435685955363e6044f4d1"
+SRC_URI[sha256sum] = "7f78c11ca527477d90e5e62b0778f3ad96f2b71c19173044e9aca9515fff42d0"
+
+inherit autotools-brokensep
+
+PARALLEL_MAKE = ""
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[gettext] = "--enable-gettext=yes,--enable-gettext=no,gettext"
+
+EXTRA_OEMAKE += "'LIBTOOL=${HOST_SYS}-libtool' V=1"
+
+do_configure () {
+    export DEBUG="-DNDEBUG"
+    oe_runconf
+}
+
+do_install () {
+    export DIST_ROOT=${D}
+    oe_runmake install
+    oe_runmake install-dev
+}
+
+PNBLACKLIST[xfsdump] ?= "Depends on broken xfsprogs - the recipe will be removed on 2017-09-01 unless the issue is fixed"
-- 
2.11.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [meta-filesystems][PATCH 2/2] xfsdump: fix do_configure failure and remove from blacklist
  2017-05-04  9:32 [meta-filesystems][PATCH 1/2] xfsdump: 3.1.4 -> 3.1.6 Chen Qi
@ 2017-05-04  9:32 ` Chen Qi
  2017-05-04  9:55 ` [meta-filesystems][PATCH 1/2] xfsdump: 3.1.4 -> 3.1.6 Martin Jansa
  1 sibling, 0 replies; 4+ messages in thread
From: Chen Qi @ 2017-05-04  9:32 UTC (permalink / raw)
  To: openembedded-devel

Add '-D_FILE_OFFSET_BITS=64' to CFLAGS to fix the following do_configure
error.

  FATAL ERROR: cannot find a valid <xfs/xfs.h> header file.

Although -D_FILE_OFFSET_BITS=64 has already been defined in
include/builddefs.in, it only affects the compile process, leaving configure
process unaware of this value.

Remove from blacklist as the configure failure has been fixed by this patch.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 meta-filesystems/recipes-utils/xfsdump/xfsdump_3.1.6.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-filesystems/recipes-utils/xfsdump/xfsdump_3.1.6.bb b/meta-filesystems/recipes-utils/xfsdump/xfsdump_3.1.6.bb
index 8f942ba7c..ecc746829 100644
--- a/meta-filesystems/recipes-utils/xfsdump/xfsdump_3.1.6.bb
+++ b/meta-filesystems/recipes-utils/xfsdump/xfsdump_3.1.6.bb
@@ -22,6 +22,8 @@ PARALLEL_MAKE = ""
 PACKAGECONFIG ??= ""
 PACKAGECONFIG[gettext] = "--enable-gettext=yes,--enable-gettext=no,gettext"
 
+CFLAGS += "-D_FILE_OFFSET_BITS=64"
+
 EXTRA_OEMAKE += "'LIBTOOL=${HOST_SYS}-libtool' V=1"
 
 do_configure () {
@@ -34,5 +36,3 @@ do_install () {
     oe_runmake install
     oe_runmake install-dev
 }
-
-PNBLACKLIST[xfsdump] ?= "Depends on broken xfsprogs - the recipe will be removed on 2017-09-01 unless the issue is fixed"
-- 
2.11.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [meta-filesystems][PATCH 1/2] xfsdump: 3.1.4 -> 3.1.6
  2017-05-04  9:32 [meta-filesystems][PATCH 1/2] xfsdump: 3.1.4 -> 3.1.6 Chen Qi
  2017-05-04  9:32 ` [meta-filesystems][PATCH 2/2] xfsdump: fix do_configure failure and remove from blacklist Chen Qi
@ 2017-05-04  9:55 ` Martin Jansa
  2017-05-04 10:02   ` ChenQi
  1 sibling, 1 reply; 4+ messages in thread
From: Martin Jansa @ 2017-05-04  9:55 UTC (permalink / raw)
  To: Chen Qi; +Cc: openembedded-devel

Have you kept the old version intentionally?

On Thu, May 4, 2017 at 11:32 AM, Chen Qi <Qi.Chen@windriver.com> wrote:

> From: Robert Yang <liezhi.yang@windriver.com>
>
> The 3.1.4 doesn't work with xfsprogs 4.7:
> | inv_files.o: In function `inv_dirpath':
> |xfsdump-3.1.4/invutil/inv_files.c:53: undefined reference to `ASSERT'
> | inv_files.o: In function `inv_fstab':
> |xfsdump-3.1.4/invutil/inv_files.c:60: undefined reference to `ASSERT'
> | inv_files.o: In function `inv_lockfile':
> |xfsdump-3.1.4/invutil/inv_files.c:67: undefined reference to `ASSERT'
> | inv_files.o: In function `inv_basepath':
> |xfsdump-3.1.4/invutil/inv_files.c:74: undefined reference to `ASSERT'
> | collect2: error: ld returned 1 exit status
> | make[2]: *** [../include/buildrules:33: xfsinvutil] Error 1
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  .../recipes-utils/xfsdump/xfsdump_3.1.6.bb         | 38
> ++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 meta-filesystems/recipes-utils/xfsdump/
> xfsdump_3.1.6.bb
>
> diff --git a/meta-filesystems/recipes-utils/xfsdump/xfsdump_3.1.6.bb
> b/meta-filesystems/recipes-utils/xfsdump/xfsdump_3.1.6.bb
> new file mode 100644
> index 000000000..8f942ba7c
> --- /dev/null
> +++ b/meta-filesystems/recipes-utils/xfsdump/xfsdump_3.1.6.bb
> @@ -0,0 +1,38 @@
> +SUMMARY = "XFS Filesystem Dump Utility"
> +DESCRIPTION = "The xfsdump package contains xfsdump, xfsrestore and a \
> +               number of other utilities for administering XFS
> filesystems.\
> +               xfsdump examines files in a filesystem, determines which \
> +               need to be backed up, and copies those files to a \
> +               specified disk, tape or other storage medium."
> +HOMEPAGE = "http://oss.sgi.com/projects/xfs"
> +SECTION = "base"
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://doc/COPYING;md5=15c832894d10ddd00dfcf57bee490e
> cc"
> +DEPENDS = "xfsprogs attr"
> +
> +SRC_URI = "ftp://oss.sgi.com/projects/xfs/cmd_tars/${BPN}-${PV}.tar.gz \
> +    file://remove-install-as-user.patch \
> +"
> +SRC_URI[md5sum] = "50353cd4f4b435685955363e6044f4d1"
> +SRC_URI[sha256sum] = "7f78c11ca527477d90e5e62b0778f3
> ad96f2b71c19173044e9aca9515fff42d0"
> +
> +inherit autotools-brokensep
> +
> +PARALLEL_MAKE = ""
> +PACKAGECONFIG ??= ""
> +PACKAGECONFIG[gettext] = "--enable-gettext=yes,--
> enable-gettext=no,gettext"
> +
> +EXTRA_OEMAKE += "'LIBTOOL=${HOST_SYS}-libtool' V=1"
> +
> +do_configure () {
> +    export DEBUG="-DNDEBUG"
> +    oe_runconf
> +}
> +
> +do_install () {
> +    export DIST_ROOT=${D}
> +    oe_runmake install
> +    oe_runmake install-dev
> +}
> +
> +PNBLACKLIST[xfsdump] ?= "Depends on broken xfsprogs - the recipe will be
> removed on 2017-09-01 unless the issue is fixed"
> --
> 2.11.0
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [meta-filesystems][PATCH 1/2] xfsdump: 3.1.4 -> 3.1.6
  2017-05-04  9:55 ` [meta-filesystems][PATCH 1/2] xfsdump: 3.1.4 -> 3.1.6 Martin Jansa
@ 2017-05-04 10:02   ` ChenQi
  0 siblings, 0 replies; 4+ messages in thread
From: ChenQi @ 2017-05-04 10:02 UTC (permalink / raw)
  To: Martin Jansa; +Cc: openembedded-devel

On 05/04/2017 05:55 PM, Martin Jansa wrote:
> Have you kept the old version intentionally?
>

NO. That's a mistake when using 'git format-patch', I'll send out V2.
Thanks for reminding me about this.

Best Regards,
Chen Qi

> On Thu, May 4, 2017 at 11:32 AM, Chen Qi <Qi.Chen@windriver.com 
> <mailto:Qi.Chen@windriver.com>> wrote:
>
>     From: Robert Yang <liezhi.yang@windriver.com
>     <mailto:liezhi.yang@windriver.com>>
>
>     The 3.1.4 doesn't work with xfsprogs 4.7:
>     | inv_files.o: In function `inv_dirpath':
>     |xfsdump-3.1.4/invutil/inv_files.c:53: undefined reference to `ASSERT'
>     | inv_files.o: In function `inv_fstab':
>     |xfsdump-3.1.4/invutil/inv_files.c:60: undefined reference to `ASSERT'
>     | inv_files.o: In function `inv_lockfile':
>     |xfsdump-3.1.4/invutil/inv_files.c:67: undefined reference to `ASSERT'
>     | inv_files.o: In function `inv_basepath':
>     |xfsdump-3.1.4/invutil/inv_files.c:74: undefined reference to `ASSERT'
>     | collect2: error: ld returned 1 exit status
>     | make[2]: *** [../include/buildrules:33: xfsinvutil] Error 1
>
>     Signed-off-by: Robert Yang <liezhi.yang@windriver.com
>     <mailto:liezhi.yang@windriver.com>>
>     ---
>      .../recipes-utils/xfsdump/xfsdump_3.1.6.bb
>     <http://xfsdump_3.1.6.bb>         | 38 ++++++++++++++++++++++
>      1 file changed, 38 insertions(+)
>      create mode 100644
>     meta-filesystems/recipes-utils/xfsdump/xfsdump_3.1.6.bb
>     <http://xfsdump_3.1.6.bb>
>
>     diff --git
>     a/meta-filesystems/recipes-utils/xfsdump/xfsdump_3.1.6.bb
>     <http://xfsdump_3.1.6.bb>
>     b/meta-filesystems/recipes-utils/xfsdump/xfsdump_3.1.6.bb
>     <http://xfsdump_3.1.6.bb>
>     new file mode 100644
>     index 000000000..8f942ba7c
>     --- /dev/null
>     +++ b/meta-filesystems/recipes-utils/xfsdump/xfsdump_3.1.6.bb
>     <http://xfsdump_3.1.6.bb>
>     @@ -0,0 +1,38 @@
>     +SUMMARY = "XFS Filesystem Dump Utility"
>     +DESCRIPTION = "The xfsdump package contains xfsdump, xfsrestore
>     and a \
>     +               number of other utilities for administering XFS
>     filesystems.\
>     +               xfsdump examines files in a filesystem, determines
>     which \
>     +               need to be backed up, and copies those files to a \
>     +               specified disk, tape or other storage medium."
>     +HOMEPAGE = "http://oss.sgi.com/projects/xfs
>     <http://oss.sgi.com/projects/xfs>"
>     +SECTION = "base"
>     +LICENSE = "GPLv2"
>     +LIC_FILES_CHKSUM =
>     "file://doc/COPYING;md5=15c832894d10ddd00dfcf57bee490ecc"
>     +DEPENDS = "xfsprogs attr"
>     +
>     +SRC_URI =
>     "ftp://oss.sgi.com/projects/xfs/cmd_tars/${BPN}-${PV}.tar.gz
>     <ftp://oss.sgi.com/projects/xfs/cmd_tars/$%7BBPN%7D-$%7BPV%7D.tar.gz>
>     \
>     +    file://remove-install-as-user.patch \
>     +"
>     +SRC_URI[md5sum] = "50353cd4f4b435685955363e6044f4d1"
>     +SRC_URI[sha256sum] =
>     "7f78c11ca527477d90e5e62b0778f3ad96f2b71c19173044e9aca9515fff42d0"
>     +
>     +inherit autotools-brokensep
>     +
>     +PARALLEL_MAKE = ""
>     +PACKAGECONFIG ??= ""
>     +PACKAGECONFIG[gettext] =
>     "--enable-gettext=yes,--enable-gettext=no,gettext"
>     +
>     +EXTRA_OEMAKE += "'LIBTOOL=${HOST_SYS}-libtool' V=1"
>     +
>     +do_configure () {
>     +    export DEBUG="-DNDEBUG"
>     +    oe_runconf
>     +}
>     +
>     +do_install () {
>     +    export DIST_ROOT=${D}
>     +    oe_runmake install
>     +    oe_runmake install-dev
>     +}
>     +
>     +PNBLACKLIST[xfsdump] ?= "Depends on broken xfsprogs - the recipe
>     will be removed on 2017-09-01 unless the issue is fixed"
>     --
>     2.11.0
>
>     --
>     _______________________________________________
>     Openembedded-devel mailing list
>     Openembedded-devel@lists.openembedded.org
>     <mailto:Openembedded-devel@lists.openembedded.org>
>     http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>     <http://lists.openembedded.org/mailman/listinfo/openembedded-devel>
>
>



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-05-04 10:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-04  9:32 [meta-filesystems][PATCH 1/2] xfsdump: 3.1.4 -> 3.1.6 Chen Qi
2017-05-04  9:32 ` [meta-filesystems][PATCH 2/2] xfsdump: fix do_configure failure and remove from blacklist Chen Qi
2017-05-04  9:55 ` [meta-filesystems][PATCH 1/2] xfsdump: 3.1.4 -> 3.1.6 Martin Jansa
2017-05-04 10:02   ` ChenQi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.