* [PATCH] x86/intel_idle: add GLK support
@ 2017-04-23 6:06 David E. Box
2017-04-26 22:36 ` Rafael J. Wysocki
2017-04-29 3:56 ` Len Brown
0 siblings, 2 replies; 4+ messages in thread
From: David E. Box @ 2017-04-23 6:06 UTC (permalink / raw)
To: lenb, jacob.jun.pan; +Cc: linux-kernel, linux-pm
From: "Box, David E" <david.e.box@intel.com>
Gemini Lake uses the same C-states as Broxton and also uses the
IRTL MSR's to determine maximum C-state latency.
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
---
drivers/idle/intel_idle.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
index e045a5c..778af71 100644
--- a/drivers/idle/intel_idle.c
+++ b/drivers/idle/intel_idle.c
@@ -1097,6 +1097,7 @@ static const struct x86_cpu_id intel_idle_ids[] __initconst = {
ICPU(INTEL_FAM6_XEON_PHI_KNL, idle_cpu_knl),
ICPU(INTEL_FAM6_XEON_PHI_KNM, idle_cpu_knl),
ICPU(INTEL_FAM6_ATOM_GOLDMONT, idle_cpu_bxt),
+ ICPU(INTEL_FAM6_ATOM_GEMINI_LAKE, idle_cpu_bxt),
ICPU(INTEL_FAM6_ATOM_DENVERTON, idle_cpu_dnv),
{}
};
@@ -1309,6 +1310,7 @@ static void intel_idle_state_table_update(void)
ivt_idle_state_table_update();
break;
case INTEL_FAM6_ATOM_GOLDMONT:
+ case INTEL_FAM6_ATOM_GEMINI_LAKE:
bxt_idle_state_table_update();
break;
case INTEL_FAM6_SKYLAKE_DESKTOP:
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] x86/intel_idle: add GLK support
2017-04-23 6:06 [PATCH] x86/intel_idle: add GLK support David E. Box
@ 2017-04-26 22:36 ` Rafael J. Wysocki
2017-05-04 23:35 ` Jacob Pan
2017-04-29 3:56 ` Len Brown
1 sibling, 1 reply; 4+ messages in thread
From: Rafael J. Wysocki @ 2017-04-26 22:36 UTC (permalink / raw)
To: David E. Box, jacob.jun.pan; +Cc: lenb, linux-kernel, linux-pm
On Saturday, April 22, 2017 11:06:25 PM David E. Box wrote:
> From: "Box, David E" <david.e.box@intel.com>
>
> Gemini Lake uses the same C-states as Broxton and also uses the
> IRTL MSR's to determine maximum C-state latency.
>
> Signed-off-by: David E. Box <david.e.box@linux.intel.com>
You could use the code names consistently in your subjects (but I can fix this up).
Jacob, any concerns?
> ---
> drivers/idle/intel_idle.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
> index e045a5c..778af71 100644
> --- a/drivers/idle/intel_idle.c
> +++ b/drivers/idle/intel_idle.c
> @@ -1097,6 +1097,7 @@ static const struct x86_cpu_id intel_idle_ids[] __initconst = {
> ICPU(INTEL_FAM6_XEON_PHI_KNL, idle_cpu_knl),
> ICPU(INTEL_FAM6_XEON_PHI_KNM, idle_cpu_knl),
> ICPU(INTEL_FAM6_ATOM_GOLDMONT, idle_cpu_bxt),
> + ICPU(INTEL_FAM6_ATOM_GEMINI_LAKE, idle_cpu_bxt),
> ICPU(INTEL_FAM6_ATOM_DENVERTON, idle_cpu_dnv),
> {}
> };
> @@ -1309,6 +1310,7 @@ static void intel_idle_state_table_update(void)
> ivt_idle_state_table_update();
> break;
> case INTEL_FAM6_ATOM_GOLDMONT:
> + case INTEL_FAM6_ATOM_GEMINI_LAKE:
> bxt_idle_state_table_update();
> break;
> case INTEL_FAM6_SKYLAKE_DESKTOP:
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] x86/intel_idle: add GLK support
2017-04-26 22:36 ` Rafael J. Wysocki
@ 2017-05-04 23:35 ` Jacob Pan
0 siblings, 0 replies; 4+ messages in thread
From: Jacob Pan @ 2017-05-04 23:35 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: David E. Box, lenb, linux-kernel, linux-pm, jacob.jun.pan
On Thu, 27 Apr 2017 00:36:42 +0200
"Rafael J. Wysocki" <rjw@rjwysocki.net> wrote:
> > From: "Box, David E" <david.e.box@intel.com>
> >
> > Gemini Lake uses the same C-states as Broxton and also uses the
> > IRTL MSR's to determine maximum C-state latency.
> >
> > Signed-off-by: David E. Box <david.e.box@linux.intel.com>
>
> You could use the code names consistently in your subjects (but I can
> fix this up).
>
> Jacob, any concerns?
No. Sorry for the delay.
Acked-by: Pan, Jacob jun <jacob.jun.pan@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/intel_idle: add GLK support
2017-04-23 6:06 [PATCH] x86/intel_idle: add GLK support David E. Box
2017-04-26 22:36 ` Rafael J. Wysocki
@ 2017-04-29 3:56 ` Len Brown
1 sibling, 0 replies; 4+ messages in thread
From: Len Brown @ 2017-04-29 3:56 UTC (permalink / raw)
To: David E. Box; +Cc: Jacob Pan, linux-kernel, Linux PM list
Acked-by: Len Brown <len.brown@intel.com>
On Sun, Apr 23, 2017 at 2:06 AM, David E. Box
<david.e.box@linux.intel.com> wrote:
> From: "Box, David E" <david.e.box@intel.com>
>
> Gemini Lake uses the same C-states as Broxton and also uses the
> IRTL MSR's to determine maximum C-state latency.
>
> Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> ---
> drivers/idle/intel_idle.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
> index e045a5c..778af71 100644
> --- a/drivers/idle/intel_idle.c
> +++ b/drivers/idle/intel_idle.c
> @@ -1097,6 +1097,7 @@ static const struct x86_cpu_id intel_idle_ids[] __initconst = {
> ICPU(INTEL_FAM6_XEON_PHI_KNL, idle_cpu_knl),
> ICPU(INTEL_FAM6_XEON_PHI_KNM, idle_cpu_knl),
> ICPU(INTEL_FAM6_ATOM_GOLDMONT, idle_cpu_bxt),
> + ICPU(INTEL_FAM6_ATOM_GEMINI_LAKE, idle_cpu_bxt),
> ICPU(INTEL_FAM6_ATOM_DENVERTON, idle_cpu_dnv),
> {}
> };
> @@ -1309,6 +1310,7 @@ static void intel_idle_state_table_update(void)
> ivt_idle_state_table_update();
> break;
> case INTEL_FAM6_ATOM_GOLDMONT:
> + case INTEL_FAM6_ATOM_GEMINI_LAKE:
> bxt_idle_state_table_update();
> break;
> case INTEL_FAM6_SKYLAKE_DESKTOP:
> --
> 2.9.3
>
--
Len Brown, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-04 23:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-23 6:06 [PATCH] x86/intel_idle: add GLK support David E. Box
2017-04-26 22:36 ` Rafael J. Wysocki
2017-05-04 23:35 ` Jacob Pan
2017-04-29 3:56 ` Len Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.