All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/1] mark clk81 as critical on Meson8b
@ 2017-05-04 18:32 ` Martin Blumenstingl
  0 siblings, 0 replies; 9+ messages in thread
From: Martin Blumenstingl @ 2017-05-04 18:32 UTC (permalink / raw)
  To: linux-amlogic, jbrunet, narmstrong, linux-clk
  Cc: khilman, carlo, sboyd, mturquette, linux-arm-kernel, Martin Blumenstingl

The GX (gxbb.c) clock controller driver already marks the clk81 clock
as criticial. However, the Meson8b clock controller driver does not do
this yet.
This can lead to a freeze of the whole system when clk81 is disabled
by the common clock framework (for example after the last child clock
is disabled by a driver which used that child clock).

Martin Blumenstingl (1):
  clk: meson: meson8b: mark clk81 as critical

 drivers/clk/meson/meson8b.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.12.2

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH 0/1] mark clk81 as critical on Meson8b
@ 2017-05-04 18:32 ` Martin Blumenstingl
  0 siblings, 0 replies; 9+ messages in thread
From: Martin Blumenstingl @ 2017-05-04 18:32 UTC (permalink / raw)
  To: linux-arm-kernel

The GX (gxbb.c) clock controller driver already marks the clk81 clock
as criticial. However, the Meson8b clock controller driver does not do
this yet.
This can lead to a freeze of the whole system when clk81 is disabled
by the common clock framework (for example after the last child clock
is disabled by a driver which used that child clock).

Martin Blumenstingl (1):
  clk: meson: meson8b: mark clk81 as critical

 drivers/clk/meson/meson8b.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.12.2

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH 0/1] mark clk81 as critical on Meson8b
@ 2017-05-04 18:32 ` Martin Blumenstingl
  0 siblings, 0 replies; 9+ messages in thread
From: Martin Blumenstingl @ 2017-05-04 18:32 UTC (permalink / raw)
  To: linus-amlogic

The GX (gxbb.c) clock controller driver already marks the clk81 clock
as criticial. However, the Meson8b clock controller driver does not do
this yet.
This can lead to a freeze of the whole system when clk81 is disabled
by the common clock framework (for example after the last child clock
is disabled by a driver which used that child clock).

Martin Blumenstingl (1):
  clk: meson: meson8b: mark clk81 as critical

 drivers/clk/meson/meson8b.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.12.2

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH 1/1] clk: meson: meson8b: mark clk81 as critical
  2017-05-04 18:32 ` Martin Blumenstingl
  (?)
@ 2017-05-04 18:32   ` Martin Blumenstingl
  -1 siblings, 0 replies; 9+ messages in thread
From: Martin Blumenstingl @ 2017-05-04 18:32 UTC (permalink / raw)
  To: linux-amlogic, jbrunet, narmstrong, linux-clk
  Cc: khilman, carlo, sboyd, mturquette, linux-arm-kernel, Martin Blumenstingl

Disabling clk81 results in an immediate freeze of the whole system. This
can happen "accidentally" when the last child-clock of clk81 is disabled
(in this case the common clock framework also disables clk81, even if it
was only enabled indirectly before).

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
 drivers/clk/meson/meson8b.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/meson/meson8b.c b/drivers/clk/meson/meson8b.c
index e9985503165c..bfd1690724de 100644
--- a/drivers/clk/meson/meson8b.c
+++ b/drivers/clk/meson/meson8b.c
@@ -399,7 +399,7 @@ struct clk_gate meson8b_clk81 = {
 		.ops = &clk_gate_ops,
 		.parent_names = (const char *[]){ "mpeg_clk_div" },
 		.num_parents = 1,
-		.flags = (CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED),
+		.flags = (CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED | CLK_IS_CRITICAL),
 	},
 };
 
-- 
2.12.2

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH 1/1] clk: meson: meson8b: mark clk81 as critical
@ 2017-05-04 18:32   ` Martin Blumenstingl
  0 siblings, 0 replies; 9+ messages in thread
From: Martin Blumenstingl @ 2017-05-04 18:32 UTC (permalink / raw)
  To: linux-arm-kernel

Disabling clk81 results in an immediate freeze of the whole system. This
can happen "accidentally" when the last child-clock of clk81 is disabled
(in this case the common clock framework also disables clk81, even if it
was only enabled indirectly before).

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
 drivers/clk/meson/meson8b.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/meson/meson8b.c b/drivers/clk/meson/meson8b.c
index e9985503165c..bfd1690724de 100644
--- a/drivers/clk/meson/meson8b.c
+++ b/drivers/clk/meson/meson8b.c
@@ -399,7 +399,7 @@ struct clk_gate meson8b_clk81 = {
 		.ops = &clk_gate_ops,
 		.parent_names = (const char *[]){ "mpeg_clk_div" },
 		.num_parents = 1,
-		.flags = (CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED),
+		.flags = (CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED | CLK_IS_CRITICAL),
 	},
 };
 
-- 
2.12.2

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH 1/1] clk: meson: meson8b: mark clk81 as critical
@ 2017-05-04 18:32   ` Martin Blumenstingl
  0 siblings, 0 replies; 9+ messages in thread
From: Martin Blumenstingl @ 2017-05-04 18:32 UTC (permalink / raw)
  To: linus-amlogic

Disabling clk81 results in an immediate freeze of the whole system. This
can happen "accidentally" when the last child-clock of clk81 is disabled
(in this case the common clock framework also disables clk81, even if it
was only enabled indirectly before).

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
 drivers/clk/meson/meson8b.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/meson/meson8b.c b/drivers/clk/meson/meson8b.c
index e9985503165c..bfd1690724de 100644
--- a/drivers/clk/meson/meson8b.c
+++ b/drivers/clk/meson/meson8b.c
@@ -399,7 +399,7 @@ struct clk_gate meson8b_clk81 = {
 		.ops = &clk_gate_ops,
 		.parent_names = (const char *[]){ "mpeg_clk_div" },
 		.num_parents = 1,
-		.flags = (CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED),
+		.flags = (CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED | CLK_IS_CRITICAL),
 	},
 };
 
-- 
2.12.2

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] clk: meson: meson8b: mark clk81 as critical
  2017-05-04 18:32   ` Martin Blumenstingl
  (?)
@ 2017-05-29  7:57     ` Neil Armstrong
  -1 siblings, 0 replies; 9+ messages in thread
From: Neil Armstrong @ 2017-05-29  7:57 UTC (permalink / raw)
  To: Martin Blumenstingl, linux-amlogic, jbrunet, linux-clk
  Cc: khilman, carlo, sboyd, mturquette, linux-arm-kernel

On 05/04/2017 08:32 PM, Martin Blumenstingl wrote:
> Disabling clk81 results in an immediate freeze of the whole system. This
> can happen "accidentally" when the last child-clock of clk81 is disabled
> (in this case the common clock framework also disables clk81, even if it
> was only enabled indirectly before).
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
>  drivers/clk/meson/meson8b.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/meson/meson8b.c b/drivers/clk/meson/meson8b.c
> index e9985503165c..bfd1690724de 100644
> --- a/drivers/clk/meson/meson8b.c
> +++ b/drivers/clk/meson/meson8b.c
> @@ -399,7 +399,7 @@ struct clk_gate meson8b_clk81 = {
>  		.ops = &clk_gate_ops,
>  		.parent_names = (const char *[]){ "mpeg_clk_div" },
>  		.num_parents = 1,
> -		.flags = (CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED),
> +		.flags = (CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED | CLK_IS_CRITICAL),
>  	},
>  };
>  
> 

Hi Martin,

I applied the patch resent by Jerome,

Thanks,
Neil

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH 1/1] clk: meson: meson8b: mark clk81 as critical
@ 2017-05-29  7:57     ` Neil Armstrong
  0 siblings, 0 replies; 9+ messages in thread
From: Neil Armstrong @ 2017-05-29  7:57 UTC (permalink / raw)
  To: linux-arm-kernel

On 05/04/2017 08:32 PM, Martin Blumenstingl wrote:
> Disabling clk81 results in an immediate freeze of the whole system. This
> can happen "accidentally" when the last child-clock of clk81 is disabled
> (in this case the common clock framework also disables clk81, even if it
> was only enabled indirectly before).
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
>  drivers/clk/meson/meson8b.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/meson/meson8b.c b/drivers/clk/meson/meson8b.c
> index e9985503165c..bfd1690724de 100644
> --- a/drivers/clk/meson/meson8b.c
> +++ b/drivers/clk/meson/meson8b.c
> @@ -399,7 +399,7 @@ struct clk_gate meson8b_clk81 = {
>  		.ops = &clk_gate_ops,
>  		.parent_names = (const char *[]){ "mpeg_clk_div" },
>  		.num_parents = 1,
> -		.flags = (CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED),
> +		.flags = (CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED | CLK_IS_CRITICAL),
>  	},
>  };
>  
> 

Hi Martin,

I applied the patch resent by Jerome,

Thanks,
Neil

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH 1/1] clk: meson: meson8b: mark clk81 as critical
@ 2017-05-29  7:57     ` Neil Armstrong
  0 siblings, 0 replies; 9+ messages in thread
From: Neil Armstrong @ 2017-05-29  7:57 UTC (permalink / raw)
  To: linus-amlogic

On 05/04/2017 08:32 PM, Martin Blumenstingl wrote:
> Disabling clk81 results in an immediate freeze of the whole system. This
> can happen "accidentally" when the last child-clock of clk81 is disabled
> (in this case the common clock framework also disables clk81, even if it
> was only enabled indirectly before).
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
>  drivers/clk/meson/meson8b.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/meson/meson8b.c b/drivers/clk/meson/meson8b.c
> index e9985503165c..bfd1690724de 100644
> --- a/drivers/clk/meson/meson8b.c
> +++ b/drivers/clk/meson/meson8b.c
> @@ -399,7 +399,7 @@ struct clk_gate meson8b_clk81 = {
>  		.ops = &clk_gate_ops,
>  		.parent_names = (const char *[]){ "mpeg_clk_div" },
>  		.num_parents = 1,
> -		.flags = (CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED),
> +		.flags = (CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED | CLK_IS_CRITICAL),
>  	},
>  };
>  
> 

Hi Martin,

I applied the patch resent by Jerome,

Thanks,
Neil

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-05-29  7:57 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-04 18:32 [PATCH 0/1] mark clk81 as critical on Meson8b Martin Blumenstingl
2017-05-04 18:32 ` Martin Blumenstingl
2017-05-04 18:32 ` Martin Blumenstingl
2017-05-04 18:32 ` [PATCH 1/1] clk: meson: meson8b: mark clk81 as critical Martin Blumenstingl
2017-05-04 18:32   ` Martin Blumenstingl
2017-05-04 18:32   ` Martin Blumenstingl
2017-05-29  7:57   ` Neil Armstrong
2017-05-29  7:57     ` Neil Armstrong
2017-05-29  7:57     ` Neil Armstrong

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.