All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] misplaced EXPORT_SYMBOL_GPL(ping_hash) in net/ipv4/ping.c
@ 2017-05-05 16:17 Vladis Dronov
  2017-05-05 16:44 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Vladis Dronov @ 2017-05-05 16:17 UTC (permalink / raw)
  To: netdev; +Cc: Vladis Dronov

Move misplaced EXPORT_SYMBOL_GPL(ping_hash) to a proper place.

Signed-off-by: Vladis Dronov <vdronov@redhat.com>
---

Actually, this is so small and unimportant (it just hurts my perfectionism),
so does not worth a separate patch. Please, feel free to make it a part of
some patch of yours.

 net/ipv4/ping.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c
index ccfbce1..19f0b7b 100644
--- a/net/ipv4/ping.c
+++ b/net/ipv4/ping.c
@@ -71,7 +71,6 @@ static inline u32 ping_hashfn(const struct net *net, u32 num, u32 mask)
 	pr_debug("hash(%u) = %u\n", num, res);
 	return res;
 }
-EXPORT_SYMBOL_GPL(ping_hash);
 
 static inline struct hlist_nulls_head *ping_hashslot(struct ping_table *table,
 					     struct net *net, unsigned int num)
@@ -152,6 +151,7 @@ int ping_hash(struct sock *sk)
 
 	return 0;
 }
+EXPORT_SYMBOL_GPL(ping_hash);
 
 void ping_unhash(struct sock *sk)
 {
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] misplaced EXPORT_SYMBOL_GPL(ping_hash) in net/ipv4/ping.c
  2017-05-05 16:17 [PATCH] misplaced EXPORT_SYMBOL_GPL(ping_hash) in net/ipv4/ping.c Vladis Dronov
@ 2017-05-05 16:44 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-05-05 16:44 UTC (permalink / raw)
  To: vdronov; +Cc: netdev

From: Vladis Dronov <vdronov@redhat.com>
Date: Fri,  5 May 2017 18:17:16 +0200

> Move misplaced EXPORT_SYMBOL_GPL(ping_hash) to a proper place.
> 
> Signed-off-by: Vladis Dronov <vdronov@redhat.com>

Please use a proper subject line with an appropriate subsystem
prefix.

Also you must indicate the intended target tree (net or net-next)
in the [] brackets.  For example:

	[PATCH net] ipv4: Fix misplaced EXPORT_SYMBOL_GPL ...

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-05-05 16:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-05 16:17 [PATCH] misplaced EXPORT_SYMBOL_GPL(ping_hash) in net/ipv4/ping.c Vladis Dronov
2017-05-05 16:44 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.