* [RFC] [PATCH] btrfs: clean up qgroup trace event
@ 2017-05-04 14:04 Anand Jain
2017-05-05 0:31 ` Qu Wenruo
2017-05-05 2:09 ` [PATCH] btrfs: cleanup " Anand Jain
0 siblings, 2 replies; 4+ messages in thread
From: Anand Jain @ 2017-05-04 14:04 UTC (permalink / raw)
To: linux-btrfs; +Cc: quwenruo
Hi Qu,
The commit 81fb6f77a026 (btrfs: qgroup: Add new trace point for
qgroup data reserve) added the following events which aren't used.
btrfs__qgroup_data_map
btrfs_qgroup_init_data_rsv_map
btrfs_qgroup_free_data_rsv_map
I wonder if it is better to remove or keep it for future use.
Signed-off-by: Anand Jain <anand.jain@oracle.com>
cc: quwenruo@cn.fujitsu.com
---
include/trace/events/btrfs.h | 36 ------------------------------------
1 file changed, 36 deletions(-)
diff --git a/include/trace/events/btrfs.h b/include/trace/events/btrfs.h
index a3c3cab643a9..5471f9b4dc9e 100644
--- a/include/trace/events/btrfs.h
+++ b/include/trace/events/btrfs.h
@@ -1270,42 +1270,6 @@ DEFINE_EVENT(btrfs__workqueue_done, btrfs_workqueue_destroy,
TP_ARGS(wq)
);
-DECLARE_EVENT_CLASS(btrfs__qgroup_data_map,
-
- TP_PROTO(struct inode *inode, u64 free_reserved),
-
- TP_ARGS(inode, free_reserved),
-
- TP_STRUCT__entry_btrfs(
- __field( u64, rootid )
- __field( unsigned long, ino )
- __field( u64, free_reserved )
- ),
-
- TP_fast_assign_btrfs(btrfs_sb(inode->i_sb),
- __entry->rootid = BTRFS_I(inode)->root->objectid;
- __entry->ino = inode->i_ino;
- __entry->free_reserved = free_reserved;
- ),
-
- TP_printk_btrfs("rootid=%llu ino=%lu free_reserved=%llu",
- __entry->rootid, __entry->ino, __entry->free_reserved)
-);
-
-DEFINE_EVENT(btrfs__qgroup_data_map, btrfs_qgroup_init_data_rsv_map,
-
- TP_PROTO(struct inode *inode, u64 free_reserved),
-
- TP_ARGS(inode, free_reserved)
-);
-
-DEFINE_EVENT(btrfs__qgroup_data_map, btrfs_qgroup_free_data_rsv_map,
-
- TP_PROTO(struct inode *inode, u64 free_reserved),
-
- TP_ARGS(inode, free_reserved)
-);
-
#define BTRFS_QGROUP_OPERATIONS \
{ QGROUP_RESERVE, "reserve" }, \
{ QGROUP_RELEASE, "release" }, \
--
2.10.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RFC] [PATCH] btrfs: clean up qgroup trace event
2017-05-04 14:04 [RFC] [PATCH] btrfs: clean up qgroup trace event Anand Jain
@ 2017-05-05 0:31 ` Qu Wenruo
2017-05-05 2:09 ` [PATCH] btrfs: cleanup " Anand Jain
1 sibling, 0 replies; 4+ messages in thread
From: Qu Wenruo @ 2017-05-05 0:31 UTC (permalink / raw)
To: Anand Jain, linux-btrfs
At 05/04/2017 10:04 PM, Anand Jain wrote:
> Hi Qu,
>
> The commit 81fb6f77a026 (btrfs: qgroup: Add new trace point for
> qgroup data reserve) added the following events which aren't used.
> btrfs__qgroup_data_map
> btrfs_qgroup_init_data_rsv_map
> btrfs_qgroup_free_data_rsv_map
> I wonder if it is better to remove or keep it for future use.
Please remove them.
These 2 old tracepoints are never used due to later patch split.
Some of the old caller doesn't ever exist.
Reviewed-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
Thanks for catching this,
Qu
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> cc: quwenruo@cn.fujitsu.com
> ---
> include/trace/events/btrfs.h | 36 ------------------------------------
> 1 file changed, 36 deletions(-)
>
> diff --git a/include/trace/events/btrfs.h b/include/trace/events/btrfs.h
> index a3c3cab643a9..5471f9b4dc9e 100644
> --- a/include/trace/events/btrfs.h
> +++ b/include/trace/events/btrfs.h
> @@ -1270,42 +1270,6 @@ DEFINE_EVENT(btrfs__workqueue_done, btrfs_workqueue_destroy,
> TP_ARGS(wq)
> );
>
> -DECLARE_EVENT_CLASS(btrfs__qgroup_data_map,
> -
> - TP_PROTO(struct inode *inode, u64 free_reserved),
> -
> - TP_ARGS(inode, free_reserved),
> -
> - TP_STRUCT__entry_btrfs(
> - __field( u64, rootid )
> - __field( unsigned long, ino )
> - __field( u64, free_reserved )
> - ),
> -
> - TP_fast_assign_btrfs(btrfs_sb(inode->i_sb),
> - __entry->rootid = BTRFS_I(inode)->root->objectid;
> - __entry->ino = inode->i_ino;
> - __entry->free_reserved = free_reserved;
> - ),
> -
> - TP_printk_btrfs("rootid=%llu ino=%lu free_reserved=%llu",
> - __entry->rootid, __entry->ino, __entry->free_reserved)
> -);
> -
> -DEFINE_EVENT(btrfs__qgroup_data_map, btrfs_qgroup_init_data_rsv_map,
> -
> - TP_PROTO(struct inode *inode, u64 free_reserved),
> -
> - TP_ARGS(inode, free_reserved)
> -);
> -
> -DEFINE_EVENT(btrfs__qgroup_data_map, btrfs_qgroup_free_data_rsv_map,
> -
> - TP_PROTO(struct inode *inode, u64 free_reserved),
> -
> - TP_ARGS(inode, free_reserved)
> -);
> -
> #define BTRFS_QGROUP_OPERATIONS \
> { QGROUP_RESERVE, "reserve" }, \
> { QGROUP_RELEASE, "release" }, \
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] btrfs: cleanup qgroup trace event
2017-05-04 14:04 [RFC] [PATCH] btrfs: clean up qgroup trace event Anand Jain
2017-05-05 0:31 ` Qu Wenruo
@ 2017-05-05 2:09 ` Anand Jain
2017-05-05 16:37 ` David Sterba
1 sibling, 1 reply; 4+ messages in thread
From: Anand Jain @ 2017-05-05 2:09 UTC (permalink / raw)
To: linux-btrfs; +Cc: dsterba, quwenruo
Commit 81fb6f77a026 (btrfs: qgroup: Add new trace point for
qgroup data reserve) added the following events which aren't used.
btrfs__qgroup_data_map
btrfs_qgroup_init_data_rsv_map
btrfs_qgroup_free_data_rsv_map
So remove them.
Signed-off-by: Anand Jain <anand.jain@oracle.com>
cc: quwenruo@cn.fujitsu.com
Reviewed-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
---
include/trace/events/btrfs.h | 36 ------------------------------------
1 file changed, 36 deletions(-)
diff --git a/include/trace/events/btrfs.h b/include/trace/events/btrfs.h
index a3c3cab643a9..5471f9b4dc9e 100644
--- a/include/trace/events/btrfs.h
+++ b/include/trace/events/btrfs.h
@@ -1270,42 +1270,6 @@ DEFINE_EVENT(btrfs__workqueue_done, btrfs_workqueue_destroy,
TP_ARGS(wq)
);
-DECLARE_EVENT_CLASS(btrfs__qgroup_data_map,
-
- TP_PROTO(struct inode *inode, u64 free_reserved),
-
- TP_ARGS(inode, free_reserved),
-
- TP_STRUCT__entry_btrfs(
- __field( u64, rootid )
- __field( unsigned long, ino )
- __field( u64, free_reserved )
- ),
-
- TP_fast_assign_btrfs(btrfs_sb(inode->i_sb),
- __entry->rootid = BTRFS_I(inode)->root->objectid;
- __entry->ino = inode->i_ino;
- __entry->free_reserved = free_reserved;
- ),
-
- TP_printk_btrfs("rootid=%llu ino=%lu free_reserved=%llu",
- __entry->rootid, __entry->ino, __entry->free_reserved)
-);
-
-DEFINE_EVENT(btrfs__qgroup_data_map, btrfs_qgroup_init_data_rsv_map,
-
- TP_PROTO(struct inode *inode, u64 free_reserved),
-
- TP_ARGS(inode, free_reserved)
-);
-
-DEFINE_EVENT(btrfs__qgroup_data_map, btrfs_qgroup_free_data_rsv_map,
-
- TP_PROTO(struct inode *inode, u64 free_reserved),
-
- TP_ARGS(inode, free_reserved)
-);
-
#define BTRFS_QGROUP_OPERATIONS \
{ QGROUP_RESERVE, "reserve" }, \
{ QGROUP_RELEASE, "release" }, \
--
2.10.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] btrfs: cleanup qgroup trace event
2017-05-05 2:09 ` [PATCH] btrfs: cleanup " Anand Jain
@ 2017-05-05 16:37 ` David Sterba
0 siblings, 0 replies; 4+ messages in thread
From: David Sterba @ 2017-05-05 16:37 UTC (permalink / raw)
To: Anand Jain; +Cc: linux-btrfs, dsterba, quwenruo
On Fri, May 05, 2017 at 10:09:36AM +0800, Anand Jain wrote:
> Commit 81fb6f77a026 (btrfs: qgroup: Add new trace point for
> qgroup data reserve) added the following events which aren't used.
> btrfs__qgroup_data_map
> btrfs_qgroup_init_data_rsv_map
> btrfs_qgroup_free_data_rsv_map
> So remove them.
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> cc: quwenruo@cn.fujitsu.com
> Reviewed-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
Patch queued, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-05 16:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-04 14:04 [RFC] [PATCH] btrfs: clean up qgroup trace event Anand Jain
2017-05-05 0:31 ` Qu Wenruo
2017-05-05 2:09 ` [PATCH] btrfs: cleanup " Anand Jain
2017-05-05 16:37 ` David Sterba
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.