All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: andrew@lunn.ch, vivien.didelot@savoirfairelinux.com,
	f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: [PATCH] net: dsa: loop: Check for memory allocation failure
Date: Sat,  6 May 2017 07:29:45 +0200	[thread overview]
Message-ID: <20170506052945.2639-1-christophe.jaillet@wanadoo.fr> (raw)

If 'devm_kzalloc' fails, a NULL pointer will be dereferenced.
Return -ENOMEM instead, as done for some other memory allocation just a
few lines above.

Fixes: 98cd1552ea27 ("net: dsa: Mock-up driver")

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/net/dsa/dsa_loop.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/dsa/dsa_loop.c b/drivers/net/dsa/dsa_loop.c
index f0fc4de4fc9a..a19e1781e9bb 100644
--- a/drivers/net/dsa/dsa_loop.c
+++ b/drivers/net/dsa/dsa_loop.c
@@ -256,6 +256,9 @@ static int dsa_loop_drv_probe(struct mdio_device *mdiodev)
 		return -ENOMEM;
 
 	ps = devm_kzalloc(&mdiodev->dev, sizeof(*ps), GFP_KERNEL);
+	if (!ps)
+		return -ENOMEM;
+
 	ps->netdev = dev_get_by_name(&init_net, pdata->netdev);
 	if (!ps->netdev)
 		return -EPROBE_DEFER;
-- 
2.11.0

WARNING: multiple messages have this Message-ID (diff)
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: andrew@lunn.ch, vivien.didelot@savoirfairelinux.com,
	f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: [PATCH] net: dsa: loop: Check for memory allocation failure
Date: Sat, 06 May 2017 05:29:45 +0000	[thread overview]
Message-ID: <20170506052945.2639-1-christophe.jaillet@wanadoo.fr> (raw)

If 'devm_kzalloc' fails, a NULL pointer will be dereferenced.
Return -ENOMEM instead, as done for some other memory allocation just a
few lines above.

Fixes: 98cd1552ea27 ("net: dsa: Mock-up driver")

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/net/dsa/dsa_loop.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/dsa/dsa_loop.c b/drivers/net/dsa/dsa_loop.c
index f0fc4de4fc9a..a19e1781e9bb 100644
--- a/drivers/net/dsa/dsa_loop.c
+++ b/drivers/net/dsa/dsa_loop.c
@@ -256,6 +256,9 @@ static int dsa_loop_drv_probe(struct mdio_device *mdiodev)
 		return -ENOMEM;
 
 	ps = devm_kzalloc(&mdiodev->dev, sizeof(*ps), GFP_KERNEL);
+	if (!ps)
+		return -ENOMEM;
+
 	ps->netdev = dev_get_by_name(&init_net, pdata->netdev);
 	if (!ps->netdev)
 		return -EPROBE_DEFER;
-- 
2.11.0


             reply	other threads:[~2017-05-06  5:30 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-06  5:29 Christophe JAILLET [this message]
2017-05-06  5:29 ` [PATCH] net: dsa: loop: Check for memory allocation failure Christophe JAILLET
2017-05-06 14:45 ` Andrew Lunn
2017-05-06 14:45   ` Andrew Lunn
2017-05-07 23:22 ` Florian Fainelli
2017-05-07 23:22   ` Florian Fainelli
2017-05-08 12:05 ` David Laight
2017-05-08 12:05   ` David Laight
2017-05-08 12:05   ` David Laight
2017-05-08 12:32   ` Julia Lawall
2017-05-08 12:32     ` Julia Lawall
2017-05-08 12:32     ` Julia Lawall
2017-05-08 17:44     ` Joe Perches
2017-05-08 17:44       ` Joe Perches
2017-05-08 17:44       ` Joe Perches
2017-05-08 23:46       ` Julia Lawall
2017-05-08 23:46         ` Julia Lawall
2017-05-08 23:46         ` Julia Lawall
2017-05-09  0:35         ` Florian Fainelli
2017-05-09  0:35           ` Florian Fainelli
2017-05-09  0:35           ` Florian Fainelli
2017-05-09  0:39           ` Julia Lawall
2017-05-09  0:39             ` Julia Lawall
2017-05-09  0:39             ` Julia Lawall
2017-05-09 15:18           ` Joe Perches
2017-05-09 15:18             ` Joe Perches
2017-05-09 15:18             ` Joe Perches
2017-05-10  4:38             ` Christophe JAILLET
2017-05-10  4:38               ` Christophe JAILLET
2017-05-10  4:46               ` Julia Lawall
2017-05-10  4:46                 ` Julia Lawall
2017-05-10  4:54                 ` Marion & Christophe JAILLET
2017-05-10  4:54                   ` Marion & Christophe JAILLET
2017-05-08 19:01 ` David Miller
2017-05-08 19:01   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170506052945.2639-1-christophe.jaillet@wanadoo.fr \
    --to=christophe.jaillet@wanadoo.fr \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.