* [PATCH rdma-next] IB/netlink: Remove export of ibnl_chk_listeners function
@ 2017-05-08 12:13 Leon Romanovsky
[not found] ` <20170508121343.3213-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Leon Romanovsky @ 2017-05-08 12:13 UTC (permalink / raw)
To: Doug Ledford; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Leon Romanovsky
The ibnl_chk_listeners() function is called in the code
located at the same module, hence no need to be exported.
Remove EXPORT_SYMBOL from it.
Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
drivers/infiniband/core/netlink.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/infiniband/core/netlink.c b/drivers/infiniband/core/netlink.c
index 10469b0088b5..ebd16885cfce 100644
--- a/drivers/infiniband/core/netlink.c
+++ b/drivers/infiniband/core/netlink.c
@@ -55,7 +55,6 @@ int ibnl_chk_listeners(unsigned int group)
return -1;
return 0;
}
-EXPORT_SYMBOL(ibnl_chk_listeners);
int ibnl_add_client(int index, int nops,
const struct ibnl_client_cbs cb_table[])
--
2.12.2
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH rdma-next] IB/netlink: Remove export of ibnl_chk_listeners function
[not found] ` <20170508121343.3213-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
@ 2017-05-09 5:39 ` Yuval Shaia
2017-05-09 6:06 ` Leon Romanovsky
0 siblings, 1 reply; 3+ messages in thread
From: Yuval Shaia @ 2017-05-09 5:39 UTC (permalink / raw)
To: Leon Romanovsky
Cc: Doug Ledford, linux-rdma-u79uwXL29TY76Z2rM5mHXA, Leon Romanovsky
On Mon, May 08, 2017 at 03:13:43PM +0300, Leon Romanovsky wrote:
> The ibnl_chk_listeners() function is called in the code
> located at the same module, hence no need to be exported.
Do you think it's declaration should move from include/rdma/ to local
header file also?
>
> Remove EXPORT_SYMBOL from it.
>
> Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
> drivers/infiniband/core/netlink.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/core/netlink.c b/drivers/infiniband/core/netlink.c
> index 10469b0088b5..ebd16885cfce 100644
> --- a/drivers/infiniband/core/netlink.c
> +++ b/drivers/infiniband/core/netlink.c
> @@ -55,7 +55,6 @@ int ibnl_chk_listeners(unsigned int group)
> return -1;
> return 0;
> }
> -EXPORT_SYMBOL(ibnl_chk_listeners);
>
> int ibnl_add_client(int index, int nops,
> const struct ibnl_client_cbs cb_table[])
> --
> 2.12.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH rdma-next] IB/netlink: Remove export of ibnl_chk_listeners function
2017-05-09 5:39 ` Yuval Shaia
@ 2017-05-09 6:06 ` Leon Romanovsky
0 siblings, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2017-05-09 6:06 UTC (permalink / raw)
To: Yuval Shaia; +Cc: Doug Ledford, linux-rdma-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 1403 bytes --]
On Tue, May 09, 2017 at 08:39:23AM +0300, Yuval Shaia wrote:
> On Mon, May 08, 2017 at 03:13:43PM +0300, Leon Romanovsky wrote:
> > The ibnl_chk_listeners() function is called in the code
> > located at the same module, hence no need to be exported.
>
> Do you think it's declaration should move from include/rdma/ to local
> header file also?
You are right, I'll move it together with ibnl_init(), ibnl_cleanup()
functions and will send v1 shortly.
Thanks
>
> >
> > Remove EXPORT_SYMBOL from it.
> >
> > Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > ---
> > drivers/infiniband/core/netlink.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/infiniband/core/netlink.c b/drivers/infiniband/core/netlink.c
> > index 10469b0088b5..ebd16885cfce 100644
> > --- a/drivers/infiniband/core/netlink.c
> > +++ b/drivers/infiniband/core/netlink.c
> > @@ -55,7 +55,6 @@ int ibnl_chk_listeners(unsigned int group)
> > return -1;
> > return 0;
> > }
> > -EXPORT_SYMBOL(ibnl_chk_listeners);
> >
> > int ibnl_add_client(int index, int nops,
> > const struct ibnl_client_cbs cb_table[])
> > --
> > 2.12.2
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-09 6:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-08 12:13 [PATCH rdma-next] IB/netlink: Remove export of ibnl_chk_listeners function Leon Romanovsky
[not found] ` <20170508121343.3213-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-05-09 5:39 ` Yuval Shaia
2017-05-09 6:06 ` Leon Romanovsky
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.