From: Mark Rutland <mark.rutland@arm.com> To: Sudeep Holla <sudeep.holla@arm.com>, Thomas Gleixner <tglx@linutronix.de>, Daniel Lezcano <daniel.lezcano@linaro.org> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Marc Zyngier <marc.zyngier@arm.com> Subject: Re: [PATCH] clocksource: arm_arch_timer: fix arch_timer_mem_find_best_frame Date: Mon, 8 May 2017 14:27:04 +0100 [thread overview] Message-ID: <20170508132703.GD5480@leverpostej> (raw) In-Reply-To: <1494246747-17267-1-git-send-email-sudeep.holla@arm.com> On Mon, May 08, 2017 at 01:32:27PM +0100, Sudeep Holla wrote: > arch_timer_mem_find_best_frame looks through ARCH_TIMER_MEM_MAX_FRAMES > frames even after finding matches to ensure the best frame is chosen, > which means the variable frame will point to the last valid frame but > not necessarily the best frame. > > On Juno, we get the following error as wrong frame is returned as the > best frame from arch_timer_mem_find_best_frame: > " > arch_timer: Unable to map frame @ 0x0000000000000000 > arch_timer: Frame missing phys irq. > Failed to initialize '/timer@2a810000': -22 > " > > This patch fixes the issue by correctly returning the best frame from > arch_timer_mem_find_best_frame. > > Fixes: c389d701dfb7 ("clocksource: arm_arch_timer: split MMIO timer probing.") > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Marc Zyngier <marc.zyngier@arm.com> Sorry about this; thanks for correcting it. Acked-by: Mark Rutland <mark.rutland@arm.com> Daniel, Thomas, could you please pick this up? Thanks, Mark. > --- > drivers/clocksource/arm_arch_timer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c > index a1fb918b8021..4bed671e490e 100644 > --- a/drivers/clocksource/arm_arch_timer.c > +++ b/drivers/clocksource/arm_arch_timer.c > @@ -1268,7 +1268,7 @@ arch_timer_mem_find_best_frame(struct arch_timer_mem *timer_mem) > pr_err("Unable to find a suitable frame in timer @ %pa\n", > &timer_mem->cntctlbase); > > - return frame; > + return best_frame; > } > > static int __init > -- > 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] clocksource: arm_arch_timer: fix arch_timer_mem_find_best_frame Date: Mon, 8 May 2017 14:27:04 +0100 [thread overview] Message-ID: <20170508132703.GD5480@leverpostej> (raw) In-Reply-To: <1494246747-17267-1-git-send-email-sudeep.holla@arm.com> On Mon, May 08, 2017 at 01:32:27PM +0100, Sudeep Holla wrote: > arch_timer_mem_find_best_frame looks through ARCH_TIMER_MEM_MAX_FRAMES > frames even after finding matches to ensure the best frame is chosen, > which means the variable frame will point to the last valid frame but > not necessarily the best frame. > > On Juno, we get the following error as wrong frame is returned as the > best frame from arch_timer_mem_find_best_frame: > " > arch_timer: Unable to map frame @ 0x0000000000000000 > arch_timer: Frame missing phys irq. > Failed to initialize '/timer at 2a810000': -22 > " > > This patch fixes the issue by correctly returning the best frame from > arch_timer_mem_find_best_frame. > > Fixes: c389d701dfb7 ("clocksource: arm_arch_timer: split MMIO timer probing.") > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Marc Zyngier <marc.zyngier@arm.com> Sorry about this; thanks for correcting it. Acked-by: Mark Rutland <mark.rutland@arm.com> Daniel, Thomas, could you please pick this up? Thanks, Mark. > --- > drivers/clocksource/arm_arch_timer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c > index a1fb918b8021..4bed671e490e 100644 > --- a/drivers/clocksource/arm_arch_timer.c > +++ b/drivers/clocksource/arm_arch_timer.c > @@ -1268,7 +1268,7 @@ arch_timer_mem_find_best_frame(struct arch_timer_mem *timer_mem) > pr_err("Unable to find a suitable frame in timer @ %pa\n", > &timer_mem->cntctlbase); > > - return frame; > + return best_frame; > } > > static int __init > -- > 2.7.4
next prev parent reply other threads:[~2017-05-08 13:27 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-08 12:32 [PATCH] clocksource: arm_arch_timer: fix arch_timer_mem_find_best_frame Sudeep Holla 2017-05-08 12:32 ` Sudeep Holla 2017-05-08 13:27 ` Mark Rutland [this message] 2017-05-08 13:27 ` Mark Rutland 2017-05-09 7:00 ` [tip:timers/urgent] clocksource/arm_arch_timer: Fix arch_timer_mem_find_best_frame() tip-bot for Sudeep Holla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170508132703.GD5480@leverpostej \ --to=mark.rutland@arm.com \ --cc=daniel.lezcano@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=sudeep.holla@arm.com \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.