* [PATCH] Btrfs:Unused comments:"FIXME: check if the IDs really exist" in ioctl.c
@ 2017-05-08 2:10 Daichou
2017-05-09 15:15 ` David Sterba
0 siblings, 1 reply; 3+ messages in thread
From: Daichou @ 2017-05-08 2:10 UTC (permalink / raw)
To: clm, jbacik, dsterba, linux-btrfs; +Cc: Daichou
These comments were already fixed in 2013.
btrfs_add_qgroup_relation, btrfs_ioctl_qgroup_create, btrfs_limit_qgroup
btrfs_add_qgroup_relation, btrfs_del_qgroup_relation have checked qgroupid existed.
Signed-off-by: Daichou <tommy0705c@gmail.com>
---
fs/btrfs/ioctl.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index a29dc3fd7152..6db06f4708f7 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -4900,7 +4900,6 @@ static long btrfs_ioctl_qgroup_assign(struct file *file, void __user *arg)
goto out;
}
- /* FIXME: check if the IDs really exist */
if (sa->assign) {
ret = btrfs_add_qgroup_relation(trans, fs_info,
sa->src, sa->dst);
@@ -4959,7 +4958,6 @@ static long btrfs_ioctl_qgroup_create(struct file *file, void __user *arg)
goto out;
}
- /* FIXME: check if the IDs really exist */
if (sa->create) {
ret = btrfs_create_qgroup(trans, fs_info, sa->qgroupid);
} else {
@@ -5013,7 +5011,6 @@ static long btrfs_ioctl_qgroup_limit(struct file *file, void __user *arg)
qgroupid = root->root_key.objectid;
}
- /* FIXME: check if the IDs really exist */
ret = btrfs_limit_qgroup(trans, fs_info, qgroupid, &sa->lim);
err = btrfs_end_transaction(trans);
--
2.12.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Btrfs:Unused comments:"FIXME: check if the IDs really exist" in ioctl.c
2017-05-08 2:10 [PATCH] Btrfs:Unused comments:"FIXME: check if the IDs really exist" in ioctl.c Daichou
@ 2017-05-09 15:15 ` David Sterba
0 siblings, 0 replies; 3+ messages in thread
From: David Sterba @ 2017-05-09 15:15 UTC (permalink / raw)
To: Daichou; +Cc: clm, jbacik, dsterba, linux-btrfs
On Mon, May 08, 2017 at 10:10:02AM +0800, Daichou wrote:
> These comments were already fixed in 2013.
> btrfs_add_qgroup_relation, btrfs_ioctl_qgroup_create, btrfs_limit_qgroup
> btrfs_add_qgroup_relation, btrfs_del_qgroup_relation have checked qgroupid existed.
Patch is ok, thanks. (I'll just reformat the changelog.)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Btrfs:Unused comments:"FIXME: check if the IDs really exist" in ioctl.c
@ 2017-05-07 17:07 戴周
0 siblings, 0 replies; 3+ messages in thread
From: 戴周 @ 2017-05-07 17:07 UTC (permalink / raw)
To: lbtrfs
[PATCH] Btrfs:Unused comments:"FIXME: check if the IDs really exist"
in ioctl.c
These comments were already fixed in 2013.
btrfs_add_qgroup_relation, btrfs_ioctl_qgroup_create, btrfs_limit_qgroup
btrfs_add_qgroup_relation, btrfs_del_qgroup_relation have checked
qgroupid existed.
Signed-off-by: Daichou <tommy0705c@gmail.com>
---
fs/btrfs/ioctl.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index a29dc3fd7152..6db06f4708f7 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -4900,7 +4900,6 @@ static long btrfs_ioctl_qgroup_assign(struct
file *file, void __user *arg)
goto out;
}
- /* FIXME: check if the IDs really exist */
if (sa->assign) {
ret = btrfs_add_qgroup_relation(trans, fs_info,
sa->src, sa->dst);
@@ -4959,7 +4958,6 @@ static long btrfs_ioctl_qgroup_create(struct
file *file, void __user *arg)
goto out;
}
- /* FIXME: check if the IDs really exist */
if (sa->create) {
ret = btrfs_create_qgroup(trans, fs_info, sa->qgroupid);
} else {
@@ -5013,7 +5011,6 @@ static long btrfs_ioctl_qgroup_limit(struct file
*file, void __user *arg)
qgroupid = root->root_key.objectid;
}
- /* FIXME: check if the IDs really exist */
ret = btrfs_limit_qgroup(trans, fs_info, qgroupid, &sa->lim);
err = btrfs_end_transaction(trans);
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-09 15:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-08 2:10 [PATCH] Btrfs:Unused comments:"FIXME: check if the IDs really exist" in ioctl.c Daichou
2017-05-09 15:15 ` David Sterba
-- strict thread matches above, loose matches on Subject: below --
2017-05-07 17:07 戴周
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.