All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH master] mpir: fix build on MIPS R6 CPUs
@ 2017-05-10 10:55 Vicente Olivert Riera
  2017-05-10 12:00 ` Thomas Petazzoni
  2017-05-10 21:34 ` Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: Vicente Olivert Riera @ 2017-05-10 10:55 UTC (permalink / raw)
  To: buildroot

Commit ef9eebf65f554d9aacfd420600c8ba17787151a8 tried to fix this
problem in a wrong way. It was fixed only for generic R6 CPUs, so the
problem still persist if you choose any other R6 CPU, like I6400 for
instance.

Fix it properly by using the right kconfig options.

Fixes:
  http://autobuild.buildroot.net/results/f33/f33cb1e0b49fe8aee68fb4b66ea4c304b71a6f8f/

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/mpir/mpir.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/mpir/mpir.mk b/package/mpir/mpir.mk
index 697e838..91f704d 100644
--- a/package/mpir/mpir.mk
+++ b/package/mpir/mpir.mk
@@ -27,7 +27,7 @@ MPIR_CONF_ENV += MPN_PATH="generic"
 endif
 
 # Optimized mips32/mips64 code not suitable for mips32r6/mips64r6
-ifeq ($(BR2_mips_32r6)$(BR2_mips_64r6),y)
+ifeq ($(BR2_MIPS_CPU_MIPS32R6)$(BR2_MIPS_CPU_MIPS64R6),y)
 MPIR_CONF_ENV += MPN_PATH="generic"
 endif
 
-- 
2.10.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH master] mpir: fix build on MIPS R6 CPUs
  2017-05-10 10:55 [Buildroot] [PATCH master] mpir: fix build on MIPS R6 CPUs Vicente Olivert Riera
@ 2017-05-10 12:00 ` Thomas Petazzoni
  2017-05-10 21:34 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2017-05-10 12:00 UTC (permalink / raw)
  To: buildroot

Hello,

On Wed, 10 May 2017 11:55:46 +0100, Vicente Olivert Riera wrote:
> Commit ef9eebf65f554d9aacfd420600c8ba17787151a8 tried to fix this
> problem in a wrong way. It was fixed only for generic R6 CPUs, so the
> problem still persist if you choose any other R6 CPU, like I6400 for
> instance.
> 
> Fix it properly by using the right kconfig options.
> 
> Fixes:
>   http://autobuild.buildroot.net/results/f33/f33cb1e0b49fe8aee68fb4b66ea4c304b71a6f8f/
> 
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Thanks!
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH master] mpir: fix build on MIPS R6 CPUs
  2017-05-10 10:55 [Buildroot] [PATCH master] mpir: fix build on MIPS R6 CPUs Vicente Olivert Riera
  2017-05-10 12:00 ` Thomas Petazzoni
@ 2017-05-10 21:34 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2017-05-10 21:34 UTC (permalink / raw)
  To: buildroot

Hello,

On Wed, 10 May 2017 11:55:46 +0100, Vicente Olivert Riera wrote:
> Commit ef9eebf65f554d9aacfd420600c8ba17787151a8 tried to fix this
> problem in a wrong way. It was fixed only for generic R6 CPUs, so the
> problem still persist if you choose any other R6 CPU, like I6400 for
> instance.
> 
> Fix it properly by using the right kconfig options.
> 
> Fixes:
>   http://autobuild.buildroot.net/results/f33/f33cb1e0b49fe8aee68fb4b66ea4c304b71a6f8f/
> 
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
>  package/mpir/mpir.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-05-10 21:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-10 10:55 [Buildroot] [PATCH master] mpir: fix build on MIPS R6 CPUs Vicente Olivert Riera
2017-05-10 12:00 ` Thomas Petazzoni
2017-05-10 21:34 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.