* [PATCH] IB/hfi1: fix array termination by appending NULL to attr array
@ 2017-05-10 15:54 Steven L. Roberts
[not found] ` <1494431652-67941-1-git-send-email-robers97-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Steven L. Roberts @ 2017-05-10 15:54 UTC (permalink / raw)
To: leon-DgEjT+Ai2ygdnm+yROfE0A, linux-rdma-u79uwXL29TY76Z2rM5mHXA
Cc: Steven L. Roberts
From: "Steven L. Roberts" <robers97-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
This fixes a kernel panic when loading the hfi driver as a dynamic module.
Signed-off-by: Steven L Roberts <robers97-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
drivers/infiniband/hw/hfi1/sysfs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/hfi1/sysfs.c b/drivers/infiniband/hw/hfi1/sysfs.c
index 50d140d..2f3bbca 100644
--- a/drivers/infiniband/hw/hfi1/sysfs.c
+++ b/drivers/infiniband/hw/hfi1/sysfs.c
@@ -196,7 +196,8 @@ static ssize_t cc_attr_store(struct kobject *kobj, struct attribute *attr,
};
static struct attribute *port_cc_default_attributes[] = {
- &cc_prescan_attr.attr
+ &cc_prescan_attr.attr,
+ NULL
};
static struct kobj_type port_cc_ktype = {
--
1.8.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] IB/hfi1: fix array termination by appending NULL to attr array
[not found] ` <1494431652-67941-1-git-send-email-robers97-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2017-05-10 16:18 ` Leon Romanovsky
2017-05-10 17:25 ` Dennis Dalessandro
1 sibling, 0 replies; 4+ messages in thread
From: Leon Romanovsky @ 2017-05-10 16:18 UTC (permalink / raw)
To: Steven L. Roberts; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 507 bytes --]
On Wed, May 10, 2017 at 10:54:12AM -0500, Steven L. Roberts wrote:
> From: "Steven L. Roberts" <robers97-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> This fixes a kernel panic when loading the hfi driver as a dynamic module.
>
> Signed-off-by: Steven L Roberts <robers97-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> drivers/infiniband/hw/hfi1/sysfs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Thanks a lot,
Reviewed-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] IB/hfi1: fix array termination by appending NULL to attr array
[not found] ` <1494431652-67941-1-git-send-email-robers97-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-05-10 16:18 ` Leon Romanovsky
@ 2017-05-10 17:25 ` Dennis Dalessandro
[not found] ` <e6273c0a-1dd5-ff53-87ad-e1c4181a01db-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
1 sibling, 1 reply; 4+ messages in thread
From: Dennis Dalessandro @ 2017-05-10 17:25 UTC (permalink / raw)
To: Steven L. Roberts, leon-DgEjT+Ai2ygdnm+yROfE0A,
linux-rdma-u79uwXL29TY76Z2rM5mHXA
On 5/10/2017 11:54 AM, Steven L. Roberts wrote:
> From: "Steven L. Roberts" <robers97-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> This fixes a kernel panic when loading the hfi driver as a dynamic module.
>
> Signed-off-by: Steven L Roberts <robers97-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Acked-by: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] IB/hfi1: fix array termination by appending NULL to attr array
[not found] ` <e6273c0a-1dd5-ff53-87ad-e1c4181a01db-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
@ 2017-06-01 22:05 ` Doug Ledford
0 siblings, 0 replies; 4+ messages in thread
From: Doug Ledford @ 2017-06-01 22:05 UTC (permalink / raw)
To: Dennis Dalessandro, Steven L. Roberts,
leon-DgEjT+Ai2ygdnm+yROfE0A, linux-rdma-u79uwXL29TY76Z2rM5mHXA
On Wed, 2017-05-10 at 13:25 -0400, Dennis Dalessandro wrote:
> On 5/10/2017 11:54 AM, Steven L. Roberts wrote:
> >
> > From: "Steven L. Roberts" <robers97-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >
> > This fixes a kernel panic when loading the hfi driver as a dynamic
> > module.
> >
> > Signed-off-by: Steven L Roberts <robers97-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> Acked-by: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Thanks, applied.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-01 22:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-10 15:54 [PATCH] IB/hfi1: fix array termination by appending NULL to attr array Steven L. Roberts
[not found] ` <1494431652-67941-1-git-send-email-robers97-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-05-10 16:18 ` Leon Romanovsky
2017-05-10 17:25 ` Dennis Dalessandro
[not found] ` <e6273c0a-1dd5-ff53-87ad-e1c4181a01db-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-06-01 22:05 ` Doug Ledford
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.