* [PATCH] input: cros_ec_keyb: remove extraneous 'const'
@ 2017-05-11 11:48 Arnd Bergmann
2017-05-11 17:14 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-05-11 11:48 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Arnd Bergmann, Lee Jones, Enric Balletbo Serra, Douglas Anderson,
Brian Norris, Rajat Jain, Gwendal Grignou, Guenter Roeck,
Vic Yang, linux-input, linux-kernel
gcc-7 warns about 'const SIMPLE_DEV_PM_OPS', as that macro already constains
a 'const' keyword:
drivers/input/keyboard/cros_ec_keyb.c:663:14: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
static const SIMPLE_DEV_PM_OPS(cros_ec_keyb_pm_ops, NULL, cros_ec_keyb_resume);
This removes the extra one.
Fixes: 6af6dc2d2aa6 ("input: Add ChromeOS EC keyboard driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/input/keyboard/cros_ec_keyb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
index c7a8120b13c0..79eb29550c34 100644
--- a/drivers/input/keyboard/cros_ec_keyb.c
+++ b/drivers/input/keyboard/cros_ec_keyb.c
@@ -660,7 +660,7 @@ static const struct of_device_id cros_ec_keyb_of_match[] = {
MODULE_DEVICE_TABLE(of, cros_ec_keyb_of_match);
#endif
-static const SIMPLE_DEV_PM_OPS(cros_ec_keyb_pm_ops, NULL, cros_ec_keyb_resume);
+static SIMPLE_DEV_PM_OPS(cros_ec_keyb_pm_ops, NULL, cros_ec_keyb_resume);
static struct platform_driver cros_ec_keyb_driver = {
.probe = cros_ec_keyb_probe,
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] input: cros_ec_keyb: remove extraneous 'const'
2017-05-11 11:48 [PATCH] input: cros_ec_keyb: remove extraneous 'const' Arnd Bergmann
@ 2017-05-11 17:14 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2017-05-11 17:14 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Lee Jones, Enric Balletbo Serra, Douglas Anderson, Brian Norris,
Rajat Jain, Gwendal Grignou, Guenter Roeck, Vic Yang,
linux-input, linux-kernel
On Thu, May 11, 2017 at 01:48:04PM +0200, Arnd Bergmann wrote:
> gcc-7 warns about 'const SIMPLE_DEV_PM_OPS', as that macro already constains
> a 'const' keyword:
>
> drivers/input/keyboard/cros_ec_keyb.c:663:14: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
> static const SIMPLE_DEV_PM_OPS(cros_ec_keyb_pm_ops, NULL, cros_ec_keyb_resume);
>
> This removes the extra one.
>
> Fixes: 6af6dc2d2aa6 ("input: Add ChromeOS EC keyboard driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thank you.
> ---
> drivers/input/keyboard/cros_ec_keyb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
> index c7a8120b13c0..79eb29550c34 100644
> --- a/drivers/input/keyboard/cros_ec_keyb.c
> +++ b/drivers/input/keyboard/cros_ec_keyb.c
> @@ -660,7 +660,7 @@ static const struct of_device_id cros_ec_keyb_of_match[] = {
> MODULE_DEVICE_TABLE(of, cros_ec_keyb_of_match);
> #endif
>
> -static const SIMPLE_DEV_PM_OPS(cros_ec_keyb_pm_ops, NULL, cros_ec_keyb_resume);
> +static SIMPLE_DEV_PM_OPS(cros_ec_keyb_pm_ops, NULL, cros_ec_keyb_resume);
>
> static struct platform_driver cros_ec_keyb_driver = {
> .probe = cros_ec_keyb_probe,
> --
> 2.9.0
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-11 17:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-11 11:48 [PATCH] input: cros_ec_keyb: remove extraneous 'const' Arnd Bergmann
2017-05-11 17:14 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.