From: Alex Williamson <alex.williamson@redhat.com> To: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, qemu-devel@nongnu.org, cornelia.huck@de.ibm.com, borntraeger@de.ibm.com, agraf@suse.com, eric.auger@redhat.com Subject: Re: [PATCH v7 12/13] vfio/ccw: update sense data if a unit check is pending Date: Thu, 11 May 2017 15:49:15 -0600 [thread overview] Message-ID: <20170511154915.75d7f4b1@w520.home> (raw) In-Reply-To: <20170505020352.8984-13-bjsdjshi@linux.vnet.ibm.com> On Fri, 5 May 2017 04:03:51 +0200 Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> wrote: > Concurrent-sense data is currently not delivered. This patch stores > the concurrent-sense data to the subchannel if a unit check is pending > and the concurrent-sense bit is enabled. Then a TSCH can retreive the > right IRB data back to the guest. > > Signed-off-by: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> > --- Acked-by: Alex Williamson <alex.williamson@redhat.com> > hw/vfio/ccw.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c > index 3c8b518..73f326f 100644 > --- a/hw/vfio/ccw.c > +++ b/hw/vfio/ccw.c > @@ -94,6 +94,7 @@ static void vfio_ccw_io_notifier_handler(void *opaque) > CcwDevice *ccw_dev = CCW_DEVICE(cdev); > SubchDev *sch = ccw_dev->sch; > SCSW *s = &sch->curr_status.scsw; > + PMCW *p = &sch->curr_status.pmcw; > IRB irb; > int size; > > @@ -143,6 +144,12 @@ static void vfio_ccw_io_notifier_handler(void *opaque) > /* Update control block via irb. */ > copy_scsw_to_guest(s, &irb.scsw); > > + /* If a uint check is pending, copy sense data. */ > + if ((s->dstat & SCSW_DSTAT_UNIT_CHECK) && > + (p->chars & PMCW_CHARS_MASK_CSENSE)) { > + memcpy(sch->sense_data, irb.ecw, sizeof(irb.ecw)); > + } > + > read_err: > css_inject_io_interrupt(sch); > }
WARNING: multiple messages have this Message-ID (diff)
From: Alex Williamson <alex.williamson@redhat.com> To: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, qemu-devel@nongnu.org, cornelia.huck@de.ibm.com, borntraeger@de.ibm.com, agraf@suse.com, eric.auger@redhat.com Subject: Re: [Qemu-devel] [PATCH v7 12/13] vfio/ccw: update sense data if a unit check is pending Date: Thu, 11 May 2017 15:49:15 -0600 [thread overview] Message-ID: <20170511154915.75d7f4b1@w520.home> (raw) In-Reply-To: <20170505020352.8984-13-bjsdjshi@linux.vnet.ibm.com> On Fri, 5 May 2017 04:03:51 +0200 Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> wrote: > Concurrent-sense data is currently not delivered. This patch stores > the concurrent-sense data to the subchannel if a unit check is pending > and the concurrent-sense bit is enabled. Then a TSCH can retreive the > right IRB data back to the guest. > > Signed-off-by: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> > --- Acked-by: Alex Williamson <alex.williamson@redhat.com> > hw/vfio/ccw.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c > index 3c8b518..73f326f 100644 > --- a/hw/vfio/ccw.c > +++ b/hw/vfio/ccw.c > @@ -94,6 +94,7 @@ static void vfio_ccw_io_notifier_handler(void *opaque) > CcwDevice *ccw_dev = CCW_DEVICE(cdev); > SubchDev *sch = ccw_dev->sch; > SCSW *s = &sch->curr_status.scsw; > + PMCW *p = &sch->curr_status.pmcw; > IRB irb; > int size; > > @@ -143,6 +144,12 @@ static void vfio_ccw_io_notifier_handler(void *opaque) > /* Update control block via irb. */ > copy_scsw_to_guest(s, &irb.scsw); > > + /* If a uint check is pending, copy sense data. */ > + if ((s->dstat & SCSW_DSTAT_UNIT_CHECK) && > + (p->chars & PMCW_CHARS_MASK_CSENSE)) { > + memcpy(sch->sense_data, irb.ecw, sizeof(irb.ecw)); > + } > + > read_err: > css_inject_io_interrupt(sch); > }
next prev parent reply other threads:[~2017-05-11 21:49 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-05 2:03 [PATCH v7 00/13] basic channel IO passthrough infrastructure based on vfio Dong Jia Shi 2017-05-05 2:03 ` [Qemu-devel] " Dong Jia Shi 2017-05-05 2:03 ` [PATCH v7 01/13] update-linux-headers: update for vfio-ccw Dong Jia Shi 2017-05-05 2:03 ` [Qemu-devel] " Dong Jia Shi 2017-05-05 2:03 ` [PATCH v7 02/13] vfio: linux-headers " Dong Jia Shi 2017-05-05 2:03 ` [Qemu-devel] " Dong Jia Shi 2017-05-05 2:03 ` [PATCH v7 03/13] s390x/css: add s390-squash-mcss machine option Dong Jia Shi 2017-05-05 2:03 ` [Qemu-devel] " Dong Jia Shi 2017-05-05 2:03 ` [PATCH v7 04/13] s390x/css: realize css_sch_build_schib Dong Jia Shi 2017-05-05 2:03 ` [Qemu-devel] " Dong Jia Shi 2017-05-05 12:04 ` Cornelia Huck 2017-05-05 12:04 ` [Qemu-devel] " Cornelia Huck 2017-05-08 3:07 ` Dong Jia Shi 2017-05-05 2:03 ` [PATCH v7 05/13] s390x/css: realize css_create_sch Dong Jia Shi 2017-05-05 2:03 ` [Qemu-devel] " Dong Jia Shi 2017-05-05 12:11 ` Cornelia Huck 2017-05-05 12:11 ` [Qemu-devel] " Cornelia Huck 2017-05-08 5:18 ` Dong Jia Shi 2017-05-08 10:50 ` Cornelia Huck 2017-05-08 10:50 ` [Qemu-devel] " Cornelia Huck 2017-05-09 1:38 ` Dong Jia Shi 2017-05-05 2:03 ` [PATCH v7 06/13] s390x/css: device support for s390-ccw passthrough Dong Jia Shi 2017-05-05 2:03 ` [Qemu-devel] " Dong Jia Shi 2017-05-09 8:18 ` Auger Eric 2017-05-11 21:13 ` Alex Williamson 2017-05-11 21:13 ` [Qemu-devel] " Alex Williamson 2017-05-15 2:22 ` Dong Jia Shi 2017-05-05 2:03 ` [PATCH v7 07/13] vfio/ccw: vfio based subchannel passthrough driver Dong Jia Shi 2017-05-05 2:03 ` [Qemu-devel] " Dong Jia Shi 2017-05-09 8:19 ` Auger Eric 2017-05-09 8:19 ` [Qemu-devel] " Auger Eric 2017-05-11 21:48 ` Alex Williamson 2017-05-11 21:48 ` [Qemu-devel] " Alex Williamson 2017-05-05 2:03 ` [PATCH v7 08/13] vfio/ccw: get io region info Dong Jia Shi 2017-05-05 2:03 ` [Qemu-devel] " Dong Jia Shi 2017-05-09 8:20 ` Auger Eric 2017-05-11 21:48 ` Alex Williamson 2017-05-11 21:48 ` [Qemu-devel] " Alex Williamson 2017-05-05 2:03 ` [PATCH v7 09/13] vfio/ccw: get irqs info and set the eventfd fd Dong Jia Shi 2017-05-05 2:03 ` [Qemu-devel] " Dong Jia Shi 2017-05-09 8:21 ` Auger Eric 2017-05-09 8:21 ` [Qemu-devel] " Auger Eric 2017-05-09 8:35 ` Dong Jia Shi 2017-05-11 21:49 ` Alex Williamson 2017-05-11 21:49 ` [Qemu-devel] " Alex Williamson 2017-05-15 2:31 ` Dong Jia Shi 2017-05-15 2:35 ` Dong Jia Shi 2017-05-05 2:03 ` [PATCH v7 10/13] s390x/css: introduce and realize ccw-request callback Dong Jia Shi 2017-05-05 2:03 ` [Qemu-devel] " Dong Jia Shi 2017-05-11 21:49 ` Alex Williamson 2017-05-11 21:49 ` [Qemu-devel] " Alex Williamson 2017-05-05 2:03 ` [PATCH v7 11/13] s390x/css: ccw translation infrastructure Dong Jia Shi 2017-05-05 2:03 ` [Qemu-devel] " Dong Jia Shi 2017-05-05 2:03 ` [PATCH v7 12/13] vfio/ccw: update sense data if a unit check is pending Dong Jia Shi 2017-05-05 2:03 ` [Qemu-devel] " Dong Jia Shi 2017-05-11 21:49 ` Alex Williamson [this message] 2017-05-11 21:49 ` Alex Williamson 2017-05-05 2:03 ` [PATCH v7 13/13] MAINTAINERS: Add vfio-ccw maintainer Dong Jia Shi 2017-05-05 2:03 ` [Qemu-devel] " Dong Jia Shi 2017-05-05 12:20 ` Cornelia Huck 2017-05-05 12:20 ` [Qemu-devel] " Cornelia Huck 2017-05-08 5:29 ` Dong Jia Shi 2017-05-08 9:09 ` Cornelia Huck 2017-05-08 9:09 ` [Qemu-devel] " Cornelia Huck 2017-05-09 1:41 ` Dong Jia Shi 2017-05-09 7:33 ` Cornelia Huck 2017-05-09 7:33 ` [Qemu-devel] " Cornelia Huck 2017-05-11 21:49 ` Alex Williamson 2017-05-11 21:49 ` [Qemu-devel] " Alex Williamson 2017-05-05 12:22 ` [PATCH v7 00/13] basic channel IO passthrough infrastructure based on vfio Cornelia Huck 2017-05-05 12:22 ` [Qemu-devel] " Cornelia Huck 2017-05-08 5:31 ` Dong Jia Shi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170511154915.75d7f4b1@w520.home \ --to=alex.williamson@redhat.com \ --cc=agraf@suse.com \ --cc=bjsdjshi@linux.vnet.ibm.com \ --cc=borntraeger@de.ibm.com \ --cc=cornelia.huck@de.ibm.com \ --cc=eric.auger@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=qemu-devel@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.