Re: [Qemu-devel] [PATCH v4 5/6] replication: Implement block replication for shared disk case

From: Stefan Hajnoczi <stefanha@gmail.com>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>
Cc: stefanha@redhat.com, qemu-devel@nongnu.org, kwolf@redhat.com,
	xiecl.fnst@cn.fujitsu.com, zhangchen.fnst@cn.fujitsu.com,
	Wen Congyang <wency@cn.fujitsu.com>,
	qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 5/6] replication: Implement block replication for shared disk case
Date: Thu, 11 May 2017 15:15:55 -0400	[thread overview]
Message-ID: <20170511191555.GB24584@stefanha-x1.localdomain> (raw)
In-Reply-To: <1492005921-15664-6-git-send-email-zhang.zhanghailiang@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

On Wed, Apr 12, 2017 at 10:05:20PM +0800, zhanghailiang wrote:
> @@ -612,6 +644,16 @@ static void replication_do_checkpoint(ReplicationState *rs, Error **errp)
>                  error_propagate(errp, local_err);
>                  break;
>              }
> +        } else {
> +            /*
> +             * For shared disk, we need to force SVM to re-read metadata
> +             * that is loaded in memory, or there will be inconsistent.
> +             */
> +            bdrv_invalidate_cache(s->secondary_disk->bs, &local_err);

I'm not sure this call has any effect:

    if (!(bs->open_flags & BDRV_O_INACTIVE)) {
        return;
    }

Is BDRV_O_INACTIVE set?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]