Re: [Qemu-devel] [Qemu-block] [PATCH v4 0/6] COLO block replication supports shared disk case

[Hailiang Zhang <zhang.zhanghailiang@huawei.com>]

On 2017/5/12 3:17, Stefan Hajnoczi wrote:
> On Wed, Apr 12, 2017 at 10:05:15PM +0800, zhanghailiang wrote:
>> COLO block replication doesn't support the shared disk case,
>> Here we try to implement it and this is the 4th version.
>>
>> Please review and any commits are welcomed.
>>
>> Cc: Dr. David Alan Gilbert (git) <dgilbert@redhat.com>
>> Cc: eddie.dong@intel.com
> Sorry for the delay.  Feel free to ping me if I don't review within a
> few days when you post a patch.

That is OK. :) , I was doing other things these days, and it is not quite urgent ... thanks.

>> v4:
>> - Add proper comment for primary_disk in patch 2 (Stefan)
>> - Call bdrv_invalidate_cache() while do checkpoint for shared disk in patch 5
>>
>> v3:
>> - Fix some comments from Stefan and Eric
>>
>> v2:
>> - Drop the patch which add a blk_root() helper
>> - Fix some comments from Changlong
>>
>> zhanghailiang (6):
>>    docs/block-replication: Add description for shared-disk case
>>    replication: add shared-disk and shared-disk-id options
>>    replication: Split out backup_do_checkpoint() from
>>      secondary_do_checkpoint()
>>    replication: fix code logic with the new shared_disk option
>>    replication: Implement block replication for shared disk case
>>    nbd/replication: implement .bdrv_get_info() for nbd and replication
>>      driver
>>
>>   block/nbd.c                |  12 +++
>>   block/replication.c        | 198 ++++++++++++++++++++++++++++++++++-----------
>>   docs/block-replication.txt | 139 ++++++++++++++++++++++++++++++-
>>   qapi/block-core.json       |  10 ++-
>>   4 files changed, 306 insertions(+), 53 deletions(-)
>>
>> -- 
>> 1.8.3.1
>>
>>
>>