All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>,
	linux-gpio@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: imx28: add gpio-ranges for internal gpio controller
Date: Mon, 15 May 2017 10:21:30 +0800	[thread overview]
Message-ID: <20170515022129.GJ8471@dragon> (raw)
In-Reply-To: <20170512080150.uh5qmwu2tctpd6jk@pengutronix.de>

On Fri, May 12, 2017 at 10:01:50AM +0200, Uwe Kleine-König wrote:
> On Fri, May 12, 2017 at 11:05:38AM +0800, Shawn Guo wrote:
> > I went through the code around requesting a pin, and found that we need
> > to call pinctrl_request_gpio() from gpio driver to get the result you
> > want.  In that case, pin_request() will be called with a valid
> > gpio_range as below.
> > 
> >     pinctrl_request_gpio()
> >         pinmux_request_gpio()
> >             pin_request(..., gpio_range)
> > 
> > Right now, pin_request() is being called with a NULL gpio_range from
> > pinmux_enable_setting().  That gets us the mux_owner rather than
> > gpio_owner for the pin.
> 
> But then again I cannot mux a pin to a different function when the gpio
> is requested, right?

You will need to free the GPIO before muxing it to a different function,
I think.

Shawn

WARNING: multiple messages have this Message-ID (diff)
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx28: add gpio-ranges for internal gpio controller
Date: Mon, 15 May 2017 10:21:30 +0800	[thread overview]
Message-ID: <20170515022129.GJ8471@dragon> (raw)
In-Reply-To: <20170512080150.uh5qmwu2tctpd6jk@pengutronix.de>

On Fri, May 12, 2017 at 10:01:50AM +0200, Uwe Kleine-K?nig wrote:
> On Fri, May 12, 2017 at 11:05:38AM +0800, Shawn Guo wrote:
> > I went through the code around requesting a pin, and found that we need
> > to call pinctrl_request_gpio() from gpio driver to get the result you
> > want.  In that case, pin_request() will be called with a valid
> > gpio_range as below.
> > 
> >     pinctrl_request_gpio()
> >         pinmux_request_gpio()
> >             pin_request(..., gpio_range)
> > 
> > Right now, pin_request() is being called with a NULL gpio_range from
> > pinmux_enable_setting().  That gets us the mux_owner rather than
> > gpio_owner for the pin.
> 
> But then again I cannot mux a pin to a different function when the gpio
> is requested, right?

You will need to free the GPIO before muxing it to a different function,
I think.

Shawn

  reply	other threads:[~2017-05-15  2:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-08  8:59 [PATCH] ARM: dts: imx28: add gpio-ranges for internal gpio controller Uwe Kleine-König
2017-05-08  8:59 ` Uwe Kleine-König
2017-05-11  7:51 ` Shawn Guo
2017-05-11  7:51   ` Shawn Guo
2017-05-11  8:09   ` Uwe Kleine-König
2017-05-11  8:09     ` Uwe Kleine-König
2017-05-12  3:05     ` Shawn Guo
2017-05-12  3:05       ` Shawn Guo
2017-05-12  8:01       ` Uwe Kleine-König
2017-05-12  8:01         ` Uwe Kleine-König
2017-05-15  2:21         ` Shawn Guo [this message]
2017-05-15  2:21           ` Shawn Guo
2017-05-15  7:16           ` Uwe Kleine-König
2017-05-15  7:16             ` Uwe Kleine-König
2017-05-22 15:54             ` Linus Walleij
2017-05-22 15:54               ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170515022129.GJ8471@dragon \
    --to=shawnguo@kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.