From: Michal Hocko <mhocko@kernel.org> To: Andrew Morton <akpm@linux-foundation.org> Cc: linux-mm@kvack.org, Mel Gorman <mgorman@suse.de>, Vlastimil Babka <vbabka@suse.cz>, Andrea Arcangeli <aarcange@redhat.com>, Jerome Glisse <jglisse@redhat.com>, Reza Arbab <arbab@linux.vnet.ibm.com>, Yasuaki Ishimatsu <yasu.isimatu@gmail.com>, qiuxishi@huawei.com, Kani Toshimitsu <toshi.kani@hpe.com>, slaoub@gmail.com, Joonsoo Kim <js1304@gmail.com>, Andi Kleen <ak@linux.intel.com>, David Rientjes <rientjes@google.com>, Daniel Kiper <daniel.kiper@oracle.com>, Igor Mammedov <imammedo@redhat.com>, Vitaly Kuznetsov <vkuznets@redhat.com>, LKML <linux-kernel@vger.kernel.org>, Michal Hocko <mhocko@suse.com> Subject: [PATCH 03/14] mm: drop page_initialized check from get_nid_for_pfn Date: Mon, 15 May 2017 10:58:16 +0200 [thread overview] Message-ID: <20170515085827.16474-4-mhocko@kernel.org> (raw) In-Reply-To: <20170515085827.16474-1-mhocko@kernel.org> From: Michal Hocko <mhocko@suse.com> c04fc586c1a4 ("mm: show node to memory section relationship with symlinks in sysfs") has added means to export memblock<->node association into the sysfs. It has also introduced get_nid_for_pfn which is a rather confusing counterpart of pfn_to_nid which checks also whether the pfn page is already initialized (page_initialized). This is done by checking page::lru != NULL which doesn't make any sense at all. Nothing in this path really relies on the lru list being used or initialized. Just remove it because this will become a problem with later patches. Thanks to Reza Arbab for testing which revealed this to be a problem (http://lkml.kernel.org/r/20170403202337.GA12482@dhcp22.suse.cz) Acked-by: Vlastimil Babka <vbabka@suse.cz> Signed-off-by: Michal Hocko <mhocko@suse.com> --- drivers/base/node.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/base/node.c b/drivers/base/node.c index 5548f9686016..06294d69779b 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -368,21 +368,14 @@ int unregister_cpu_under_node(unsigned int cpu, unsigned int nid) } #ifdef CONFIG_MEMORY_HOTPLUG_SPARSE -#define page_initialized(page) (page->lru.next) - static int __ref get_nid_for_pfn(unsigned long pfn) { - struct page *page; - if (!pfn_valid_within(pfn)) return -1; #ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT if (system_state == SYSTEM_BOOTING) return early_pfn_to_nid(pfn); #endif - page = pfn_to_page(pfn); - if (!page_initialized(page)) - return -1; return pfn_to_nid(pfn); } -- 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org> To: Andrew Morton <akpm@linux-foundation.org> Cc: linux-mm@kvack.org, Mel Gorman <mgorman@suse.de>, Vlastimil Babka <vbabka@suse.cz>, Andrea Arcangeli <aarcange@redhat.com>, Jerome Glisse <jglisse@redhat.com>, Reza Arbab <arbab@linux.vnet.ibm.com>, Yasuaki Ishimatsu <yasu.isimatu@gmail.com>, qiuxishi@huawei.com, Kani Toshimitsu <toshi.kani@hpe.com>, slaoub@gmail.com, Joonsoo Kim <js1304@gmail.com>, Andi Kleen <ak@linux.intel.com>, David Rientjes <rientjes@google.com>, Daniel Kiper <daniel.kiper@oracle.com>, Igor Mammedov <imammedo@redhat.com>, Vitaly Kuznetsov <vkuznets@redhat.com>, LKML <linux-kernel@vger.kernel.org>, Michal Hocko <mhocko@suse.com> Subject: [PATCH 03/14] mm: drop page_initialized check from get_nid_for_pfn Date: Mon, 15 May 2017 10:58:16 +0200 [thread overview] Message-ID: <20170515085827.16474-4-mhocko@kernel.org> (raw) In-Reply-To: <20170515085827.16474-1-mhocko@kernel.org> From: Michal Hocko <mhocko@suse.com> c04fc586c1a4 ("mm: show node to memory section relationship with symlinks in sysfs") has added means to export memblock<->node association into the sysfs. It has also introduced get_nid_for_pfn which is a rather confusing counterpart of pfn_to_nid which checks also whether the pfn page is already initialized (page_initialized). This is done by checking page::lru != NULL which doesn't make any sense at all. Nothing in this path really relies on the lru list being used or initialized. Just remove it because this will become a problem with later patches. Thanks to Reza Arbab for testing which revealed this to be a problem (http://lkml.kernel.org/r/20170403202337.GA12482@dhcp22.suse.cz) Acked-by: Vlastimil Babka <vbabka@suse.cz> Signed-off-by: Michal Hocko <mhocko@suse.com> --- drivers/base/node.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/base/node.c b/drivers/base/node.c index 5548f9686016..06294d69779b 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -368,21 +368,14 @@ int unregister_cpu_under_node(unsigned int cpu, unsigned int nid) } #ifdef CONFIG_MEMORY_HOTPLUG_SPARSE -#define page_initialized(page) (page->lru.next) - static int __ref get_nid_for_pfn(unsigned long pfn) { - struct page *page; - if (!pfn_valid_within(pfn)) return -1; #ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT if (system_state == SYSTEM_BOOTING) return early_pfn_to_nid(pfn); #endif - page = pfn_to_page(pfn); - if (!page_initialized(page)) - return -1; return pfn_to_nid(pfn); } -- 2.11.0 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-05-15 8:59 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-15 8:58 [PATCH -v4 0/14] mm: make movable onlining suck less Michal Hocko 2017-05-15 8:58 ` Michal Hocko 2017-05-15 8:58 ` [PATCH 01/14] mm: remove return value from init_currently_empty_zone Michal Hocko 2017-05-15 8:58 ` Michal Hocko 2017-05-15 8:58 ` [PATCH 02/14] mm, memory_hotplug: use node instead of zone in can_online_high_movable Michal Hocko 2017-05-15 8:58 ` Michal Hocko 2017-05-15 8:58 ` Michal Hocko [this message] 2017-05-15 8:58 ` [PATCH 03/14] mm: drop page_initialized check from get_nid_for_pfn Michal Hocko 2017-05-15 8:58 ` [PATCH 04/14] mm, memory_hotplug: get rid of is_zone_device_section Michal Hocko 2017-05-15 8:58 ` Michal Hocko 2017-06-10 9:56 ` Wei Yang 2017-06-10 9:56 ` Wei Yang 2017-06-10 14:58 ` Wei Yang 2017-06-10 14:58 ` Wei Yang 2017-06-12 6:49 ` Michal Hocko 2017-06-12 6:49 ` Michal Hocko 2017-06-14 6:17 ` Wei Yang 2017-06-14 6:12 ` Wei Yang 2017-06-14 6:32 ` Michal Hocko 2017-06-14 6:32 ` Michal Hocko 2017-06-14 9:12 ` Wei Yang 2017-06-14 9:24 ` Michal Hocko 2017-06-14 9:24 ` Michal Hocko 2017-06-15 1:02 ` Wei Yang 2017-05-15 8:58 ` [PATCH 05/14] mm, memory_hotplug: split up register_one_node Michal Hocko 2017-05-15 8:58 ` Michal Hocko 2017-05-15 8:58 ` [PATCH 06/14] mm, memory_hotplug: consider offline memblocks removable Michal Hocko 2017-05-15 8:58 ` Michal Hocko 2017-05-15 8:58 ` [PATCH 07/14] mm: consider zone which is not fully populated to have holes Michal Hocko 2017-05-15 8:58 ` Michal Hocko 2017-05-18 16:14 ` Vlastimil Babka 2017-05-18 16:14 ` Vlastimil Babka 2017-05-18 16:42 ` Michal Hocko 2017-05-18 16:42 ` Michal Hocko 2017-05-19 7:21 ` Vlastimil Babka 2017-05-19 7:21 ` Vlastimil Babka 2017-05-15 8:58 ` [PATCH 08/14] mm, compaction: skip over holes in __reset_isolation_suitable Michal Hocko 2017-05-15 8:58 ` Michal Hocko 2017-05-19 7:23 ` Vlastimil Babka 2017-05-19 7:23 ` Vlastimil Babka 2017-05-15 8:58 ` [PATCH 09/14] mm: __first_valid_page skip over offline pages Michal Hocko 2017-05-15 8:58 ` Michal Hocko 2017-05-19 8:05 ` Vlastimil Babka 2017-05-19 8:05 ` Vlastimil Babka 2017-05-15 8:58 ` [PATCH 10/14] mm, vmstat: skip reporting offline pages in pagetypeinfo Michal Hocko 2017-05-15 8:58 ` Michal Hocko 2017-05-19 8:17 ` Vlastimil Babka 2017-05-19 8:17 ` Vlastimil Babka 2017-05-15 8:58 ` [PATCH 11/14] mm, memory_hotplug: do not associate hotadded memory to zones until online Michal Hocko 2017-05-15 8:58 ` Michal Hocko 2017-05-19 8:56 ` Vlastimil Babka 2017-05-19 8:56 ` Vlastimil Babka 2017-06-16 4:20 ` Wei Yang 2017-06-16 8:05 ` Michal Hocko 2017-06-16 8:05 ` Michal Hocko 2017-06-16 8:11 ` Wei Yang 2017-06-16 8:45 ` Michal Hocko 2017-06-16 8:45 ` Michal Hocko 2017-06-16 9:11 ` Wei Yang 2017-06-25 0:14 ` Wei Yang 2017-06-26 5:38 ` Michal Hocko 2017-06-26 5:38 ` Michal Hocko 2017-05-15 8:58 ` [PATCH 12/14] mm, memory_hotplug: replace for_device by want_memblock in arch_add_memory Michal Hocko 2017-05-15 8:58 ` Michal Hocko 2017-05-15 8:58 ` [PATCH 13/14] mm, memory_hotplug: fix the section mismatch warning Michal Hocko 2017-05-15 8:58 ` Michal Hocko 2017-05-15 8:58 ` [PATCH 14/14] mm, memory_hotplug: remove unused cruft after memory hotplug rework Michal Hocko 2017-05-15 8:58 ` Michal Hocko 2017-06-09 9:51 ` [PATCH -v4 0/14] mm: make movable onlining suck less Wei Yang 2017-06-09 9:51 ` Wei Yang 2017-06-09 10:49 ` Michal Hocko 2017-06-09 10:49 ` Michal Hocko 2017-06-10 2:20 ` Wei Yang 2017-06-10 2:20 ` Wei Yang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170515085827.16474-4-mhocko@kernel.org \ --to=mhocko@kernel.org \ --cc=aarcange@redhat.com \ --cc=ak@linux.intel.com \ --cc=akpm@linux-foundation.org \ --cc=arbab@linux.vnet.ibm.com \ --cc=daniel.kiper@oracle.com \ --cc=imammedo@redhat.com \ --cc=jglisse@redhat.com \ --cc=js1304@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=mhocko@suse.com \ --cc=qiuxishi@huawei.com \ --cc=rientjes@google.com \ --cc=slaoub@gmail.com \ --cc=toshi.kani@hpe.com \ --cc=vbabka@suse.cz \ --cc=vkuznets@redhat.com \ --cc=yasu.isimatu@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.